D7953: Use QQuickStyle to set the QQC2 style

arojas added a comment. In https://phabricator.kde.org/D7953#148962, @fvogt wrote: > This is not as clear as it could be. What about just not setting QT_QUICK_CONTROLS_1_STYLE in the first place? > QT_QUICK_CONTROLS_1_STYLE is only necessary because of QT_QUICK_CONTROLS_STYLE.

D7953: Use QQuickStyle to set the QQC2 style

fvogt added a comment. This is not as clear as it could be. What about just not setting QT_QUICK_CONTROLS_1_STYLE in the first place? QT_QUICK_CONTROLS_1_STYLE is only necessary because of QT_QUICK_CONTROLS_STYLE. REPOSITORY R135 Integration for Qt applications in Plasma REVISION

D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE

This revision was automatically updated to reflect the committed changes. Closed by commit R108:a264c2b5cf14: Change default argument of grabXKeyboard to XCB_WINDOW_NONE (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7857?vs=19600=19916#toc REPOSITORY R108

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

arojas abandoned this revision. arojas added a comment. Superseded by https://phabricator.kde.org/D7953 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff,

D7953: Use QQuickStyle to set the QQC2 style

This revision was automatically updated to reflect the committed changes. Closed by commit R135:059369d6b6a9: Use QQuickStyle to set the QQC2 style (authored by arojas). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

Re: KDE Slimbook and its Synaptics-less Touchpad

Thanks, We have provided infomration to the bug. *Alejandro López The SLIMBOOK Team* /*"el ultrabook potente y asequible"*/ i...@slimbook.es www.slimbook.es

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

asturmlechner edited the summary of this revision. REPOSITORY R572 releaseme REVISION DETAIL https://phabricator.kde.org/D7981 To: asturmlechner, #plasma, sitter, O2 releaseme Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

asturmlechner updated this revision to Diff 19901. asturmlechner added a comment. Owners added a reviewer: O2: releaseme. Re-added search for KF5DocTools REPOSITORY R572 releaseme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7981?vs=19893=19901 BRANCH master REVISION DETAIL

Robust way to to read default applications

Hello all, I'm working on some code that needs to get the default file manager application. I'm currently using KSharedConfig::openConfig to read mimeapps.list, which works as long as mimeapps.list exists. But I'm noticing that on a fresh install, mimeapps.list doesn't exist--it seems to get

Re: KDE Slimbook and its Synaptics-less Touchpad

Hello, The ugly thing people tell us is that in KDE NEON preferences, it does not appear as a touchopad and can not change anything. Many people tell us why it does not appear as a touchpad. The touchpad can work with evdev or with libinput.

D6591: XdgV6 - Kwin side

This revision was automatically updated to reflect the committed changes. Closed by commit R108:e492f9e2980a: XdgV6 - Kwin side (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6591?vs=19895=19899 REVISION DETAIL

D6591: XdgV6 - Kwin side

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. And sorry, sorry, sorry that the review took so long. REPOSITORY R108 KWin BRANCH xdgv6 REVISION DETAIL https://phabricator.kde.org/D6591 To: davidedmundson, #plasma,

Re: Re: KDE Slimbook and its Synaptics-less Touchpad

FWIW, the bug tracking this is https://bugs.kde.org/show_bug.cgi?id=383379 Nate On Mon, 25 Sep 2017 07:20:20 -0700 SLIMBOOK TEAM - Alejandro López alejandrolo...@slimbook.es wrote Hello, The ugly thing people tell us is that in KDE NEON preferences, it does not appear as a

Re: KDE Slimbook and its Synaptics-less Touchpad

Hello, The ugly thing people tell us is that in KDE NEON preferences, it does not appear as a touchopad and can not change anything. Many people tell us why it does not appear as a touchpad. The touchpad can work with evdev or with libinput. - To get touchpad hardware id:     hwinfo --mouse  

D7965: Drop the ObscurringWindow functionality on desktop switching

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH drop-obscuring-windows REVISION DETAIL https://phabricator.kde.org/D7965 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7853: Add a dedicated X11EventFilter for forwarding property events to the effect system

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH window-property-x11-filter REVISION DETAIL https://phabricator.kde.org/D7853 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7924: Support starting kwin_wayland without XWayland support

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH wayland-no-xwayland REVISION DETAIL https://phabricator.kde.org/D7924 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7897: Move X11 specific Workspace initialization code into dedicated method

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH workspace-init-x11 REVISION DETAIL https://phabricator.kde.org/D7897 To: graesslin, #kwin, #plasma, broulik Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH grab-x-keyboard-none-window REVISION DETAIL https://phabricator.kde.org/D7857 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

Re: KDE Slimbook and its Synaptics-less Touchpad

Alejandro López The SLIMBOOK Team "el ultrabook potente y asequible" i...@slimbook.es www.slimbook.es

Re: KDE Slimbook and its Synaptics-less Touchpad

Hello, The ugly thing people tell us is that in KDE NEON preferences, it does not appear as a touchopad and can not change anything. Many people tell us why it does not appear as a touchpad. The touchpad can work with evdev or with libinput.

D6591: XdgV6 - Kwin side

davidedmundson updated this revision to Diff 19895. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Update tests to cover XDGv6 - write a ping test - fix crash in ping with socket mode connections REPOSITORY R108 KWin CHANGES SINCE

D6591: XdgV6 - Kwin side

davidedmundson commandeered this revision. davidedmundson edited reviewers, added: mart; removed: davidedmundson. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6591 To: davidedmundson, #plasma,

D6591: XdgV6 - Kwin side

davidedmundson added a comment. > It's really not difficult Ha. Extending those tests was not dificult, and if you look you'll see that was committed in the XDG branch mid last week. But we also have ping mixed in here (something I now regret), and that proved much more

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

asturmlechner added a comment. In https://phabricator.kde.org/D7981#148820, @sitter wrote: > This breaks repos which have no find_package call already. Fine, I can re-add that without REQUIRED keyword. Out of curiousity, do you know of an example? REPOSITORY R572 releaseme

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

sitter added a comment. This breaks repos which have no find_package call already. REPOSITORY R572 releaseme REVISION DETAIL https://phabricator.kde.org/D7981 To: asturmlechner, #plasma, sitter Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

asturmlechner created this revision. asturmlechner added reviewers: Plasma, sitter. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Many packages have KF5DocTools optional, but as soon as a release is made that

D7917: [TasksModel] Use std::acumulate on the QHash directly

This revision was automatically updated to reflect the committed changes. Closed by commit R120:602e93dfdb10: [TasksModel] Use std::acumulate on the QHash directly (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D7919: [PowerDevil Runner] Obliterate traces of power profiles

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4174ceb76219: [PowerDevil Runner] Obliterate traces of power profiles (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7919?vs=19749=19890#toc REPOSITORY R120 Plasma

Minutes Monday Plasma Hangout

Meeting minutes! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 25-09-2017 Present: jensreut, Sho_, kbroulik, fvogt, Riddell, d_ed, bshah, sebas jensreut: * VDG management Sho: * Did emergency v1.0.3 release of Simple Menu to fix favorites on Plasma v5.11 * On vacation last

D7917: [TasksModel] Use std::acumulate on the QHash directly

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7917 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7940: plugin loaded by kirigami to use KColorScheme and KIconLoader

davidedmundson added inline comments. INLINE COMMENTS > plasmadesktoptheme.cpp:34 > +PlasmaDesktopTheme::PlasmaDesktopTheme(QObject *parent) > +: PlatformTheme(parent) > +{ I can't find Kirigami::PlatformTheme? Is the review published? > plasmadesktoptheme.h:73 > +private: > +//legacy

D7919: [PowerDevil Runner] Obliterate traces of power profiles

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7919 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7941: use Kirigami Theme for colors

davidedmundson added a comment. This is set to be a framework. We can't have a framework that imports something from workspace. INLINE COMMENTS > Label.qml:32 > > -height: Math.round(Math.max(paintedHeight, > StylePrivate.TextSingleton.height * 1.6)) > +height:

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

jgrulich added inline comments. INLINE COMMENTS > openconnectauth.cpp:162 > > +if (!dataMap[NM_OPENCONNECT_KEY_PIN].isEmpty()){ > + d->isPinProvided = true; Coding style. Missing space before "{". > openconnectauth.cpp:165 > +} > +if

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

jgrulich requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D7795 To: thorstenb, #plasma, jgrulich Cc: jgrulich, plasma-devel, ZrenBot, progwolff, lesliezhai,

D7980: Don't auto scale outputs where we don't know the physical size

This revision was automatically updated to reflect the committed changes. Closed by commit R104:2b869e687d77: Dont auto scale outputs where we dont know the physical size (authored by davidedmundson). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D7980: Don't auto scale outputs where we don't know the physical size

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Works, scale is back to 1 here. REPOSITORY R104 KScreen BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D7980 To: davidedmundson, #plasma, fvogt Cc: plasma-devel,

D7953: Use QQuickStyle to set the QQC2 style

davidedmundson added a comment. We should definitely be strict about adding addititional dependencies after the freeze, but I think in this case it's safe and worth it. I shall send an email to kde-distro-packagers to make sure everyone knows. REPOSITORY R135 Integration for Qt

D7953: Use QQuickStyle to set the QQC2 style

arojas added a comment. so is this OK for 5.11? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7953 To: arojas, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D7953: Use QQuickStyle to set the QQC2 style

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Soo much cleaner. Thanks for taking care of this REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7953 To:

D7980: Don't auto scale outputs where we don't know the physical size

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We don't have enough data to calculate the DPI properly and the current code effectively