thorstenb added a comment.
The openconnect-plugin is not used for parsing this variable. Maybe it was in
the past.
I add my pin in "nm-servie-defines.h" near NM_OPENCONNECT_KEY_USERCERT. It
was not used.
I try to add this code in openconnect plugin in first place, but it was not
working
xuetianweng created this revision.
xuetianweng added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Gtk3 supports theme variant feature, which allows application to specify
a variant theme to use.
TEST PLAN
Test with gtk3-demo ->
cfeck added a comment.
Is there a consensus if this is still needed?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7481
To: davidedmundson, #plasma
Cc: cfeck, broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed,
cfeck added a comment.
Please commit accepted changes.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7769
To: subdiff, #plasma, davidedmundson, hein
Cc: cfeck, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg,
davidedmundson added a comment.
I do hold a personal vendetta against this line, so I wish I could approve it.
But, unlike the QQC2 change, PlasmaComponents.Label is pre-existing and used
/everywhere/ . Not just within Plasma, but in literally every applet in the KDE
store.
I don't
nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
nicolasfella added a project: Plasma.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Same as https://phabricator.kde.org/D8129 but
broulik added a comment.
Despite just having built p-f from git I still get
> Error loading QML file:
file:///usr/share/plasma/plasmoids/org.kde.plasma.fuzzyclock/contents/ui/main.qml:51:34:
Type PlasmaCalendar.MonthView unavailable
>
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This fixes the following problem:
1. Have two windows maximized
2. Click minimize button
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Documentation is still missing, Unstable suffix is still in two many API
calls.
INLINE COMMENTS
> registry.h:527-528
> +
> +zxdg_exporter_v2
Hi,
> You can run it nested; so you have a wayland session in a window. Like
> Xephyr.
>
> But if you want to play with it, just choose it at the login manager, you
> don't need to uninstall X11.
Neither is really what I want, or can (my login manager doesn't know about
wayland). I do have a
You can run it nested; so you have a wayland session in a window. Like
Xephyr.
But if you want to play with it, just choose it at the login manager, you
don't need to uninstall X11.
David
Hi,
Is it possible somehow to use KWin's wayland compositor when it's acting as the
window server of an X11 session? I understand that the opposite is possible. I
have little idea about the technical feasibility of what I'm asking but that
aside it for anyone like me who feels wayland isn't
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R124 System Settings
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8143
To: davidedmundson, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
davidedmundson created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Ran gallery
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8144
AFFECTED FILES
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Opened it.
REPOSITORY
R124 System Settings
BRANCH
master
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e3586f1bba10: Silence warning. (authored by hein).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8136?vs=20333=20339
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:f375e212db9e: Silence warnings (authored by hein).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8137?vs=20334=20340
REVISION DETAIL
jgrulich added a comment.
I discussed this witn Openconnect maintainer and I was told basically the
same I told you first. NM_OPENCONNECT_KEY_PIN is something what
NetworkManager-openconnect plugin doesn't support. Do you have your own patched
nm-openconnect plugin or something like that?
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8000391d85f2: Dont try to override label heights
(authored by davidedmundson).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8129
To: davidedmundson, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
mart accepted this revision.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8136
To: hein, mart, davidedmundson
Cc: plasma-devel, apol, davidedmundson, mart, hein
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8137
To: hein, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
cfeck added a comment.
No problem, can you please abandon this diff then?
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D7795
To: thorstenb, #plasma, jgrulich
Cc: cfeck, jgrulich, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8131
To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8138
To: davidedmundson, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
davidedmundson created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Deprecated in favour of QtQuickControls2.Label which is identical in behaviour
TEST PLAN
Ran gallery
REPOSITORY
R169 Kirigami
davidedmundson updated this revision to Diff 20335.
davidedmundson added a comment.
add warning
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8131?vs=20322=20335
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8131
AFFECTED FILES
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8136
To: hein, mart, davidedmundson
Cc: plasma-devel, apol, davidedmundson, mart, hein
hein created this revision.
hein added a reviewer: mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8137
AFFECTED
hein created this revision.
hein added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8136
AFFECTED FILES
mart added a comment.
In https://phabricator.kde.org/D8131#152181, @davidedmundson wrote:
> Can do.
> Will be a bit noisy as if it's used in a delegate it'll be spewing out
constantly.
i'm ok with the noise... helps people actually wanting to do the port ;)
REPOSITORY
R169
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8135
To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
frame->fooHeight is the same as frame->fooFixedHeight if the border is
enabled, we
davidedmundson added a comment.
Can do.
Will be a bit noisy as if it's used in a delegate it'll be spewing out
constantly.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8131
To: davidedmundson, #plasma
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai,
mart added inline comments.
INLINE COMMENTS
> Label.qml:38
> */
> -T2.Label {
> -id: root
> -
> -height: Math.round(Math.max(paintedHeight, Units.gridUnit * 1.6))
> -verticalAlignment: lineCount > 1 ? Text.AlignTop : Text.AlignVCenter
> -
> -activeFocusOnTab: false
> -
thorstenb marked 8 inline comments as done.
thorstenb added a comment.
Hi,
i've done a arc redo because of "arc patch" not working and web "diff update"
also not working.
https://phabricator.kde.org/D8134 is the updated patch with the requested
coding style.
Sorry for not using arc in
thorstenb edited the summary of this revision.
thorstenb added reviewers: Plasma, jgrulich.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D8134
To: thorstenb, #plasma, jgrulich
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
37 matches
Mail list logo
