D8090: Move WindowRules from Client to AbstractClient

2017-10-06 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:0372fdaf9275: Move WindowRules from Client to AbstractClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8090?vs=20204=20416 REVISION

D8145: Update pointer position whenever a window gets (un)minimized

2017-10-06 Thread Martin Flöser
graesslin added a comment. yep, I actually checked whether we can use the stacking order changed for that, but it's clearly documented as only when the actual layering changes. And I fear it would cause problems in other areas where code reacts on stacking order changes and gets confused if

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

2017-10-06 Thread Martin Flöser
graesslin added a comment. Just the DBus protocol is in https://phabricator.kde.org/D8166 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8163 To: graesslin, #kwin, #plasma, mart Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D8166: Add DBus protocol to virtual keyboard

2017-10-06 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change adds a DBus API to query whether the virtual keyboard is currently enabled and

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

2017-10-06 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D8163#152777, @davidedmundson wrote: > Immediately going for a workaround is.. (and I don't want to use this term as you've clearly made a huge patch) lazy. Hey, I discussed this with Marco yesterday afternoon ;-) If

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

2017-10-06 Thread David Edmundson
davidedmundson added a comment. Immediately going for a workaround is.. (and I don't want to use this term as you've clearly made a huge patch) lazy. Especially as the current code path in your trace shows we're doing something very stupid: - we go through KStatusNotifierItem -

D8159: Add API for setting server decoration palettes

2017-10-06 Thread David Edmundson
davidedmundson added a comment. If it does go into wayland-protocols I imagine it would get renamed? And even if it did get upstreamed and adopted, Steam (for example) would want to set the palette. INLINE COMMENTS > graesslin wrote in server_decoration_interface.h:147 > Nothing better

D7957: Turn on frames around dock widgets by default

2017-10-06 Thread Nathaniel Graham
ngraham planned changes to this revision. ngraham added a comment. I'll see if I can re-work the patch to add separators when frames are off, rather than turning on all frames by default. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

2017-10-06 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma, mart. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY During startup the StatusNotifierItem can cause a freeze as it might do a blocking DBus

D7941: use Kirigami Theme for colors

2017-10-06 Thread Ben Cooksley
bcooksley reopened this revision. bcooksley added a comment. This revision is now accepted and ready to land. This code introduces a new dependency which has yet to be declared in the kde-build-metadata repository. As this has been several days now, i'll be reverting this commit and any

D8159: Add API for setting server decoration palettes

2017-10-06 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > broulik wrote in server_decoration_interface.h:147 > I think we support both (doing a KService lookup if no complete path given), > imho "name" would also be consistent with what KConfig uses Nothing better than looking into the source:

D8159: Add API for setting server decoration palettes

2017-10-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > graesslin wrote in server_decoration_interface.h:147 > is it a paletteName or palettePath? IIRC we set complete paths? I think we support both (doing a KService lookup if no complete path given), imho "name" would also be consistent with what

D8159: Add API for setting server decoration palettes

2017-10-06 Thread Martin Flöser
graesslin added a comment. I'm fine with the change, but when I thought about it, I was wondering whether it would be better to have a dedicated interface. There is at least one other Wayland compositor out there which implements the protocol and I got several requests about upstreaming it.

D8160: be less aggressive when to disable borders

2017-10-06 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Shit it, thanks ! In fact I remember making the same fix some time back in breeze. Must have forgotten to backport it to oxygen. REPOSITORY R113 Oxygen Theme BRANCH

D8160: be less aggressive when to disable borders

2017-10-06 Thread Marco Martin
mart added a comment. F4968746: Spectacle.a23412.png REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8160 To: mart, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8160: be less aggressive when to disable borders

2017-10-06 Thread Marco Martin
mart retitled this revision from "ibe less aggressive when to disable borders" to "be less aggressive when to disable borders". mart added reviewers: Plasma, hpereiradacosta. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8160 To: mart, #plasma, hpereiradacosta

D8160: ibe less aggressive when to disable borders

2017-10-06 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY if the control height is 2*Metrics::LineEdit_FrameWidth + option->fontMetrics.height() it means that "it just fits", therefore still draw the

D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo

2017-10-06 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R106:cbaaf5f4ff54: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo (authored by fvogt). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo

2017-10-06 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R106 KSysguard BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D8153 To: fvogt, #plasma, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8159: Add API for setting server decoration palettes

2017-10-06 Thread David Edmundson
davidedmundson added a comment. In https://phabricator.kde.org/D8159#152648, @broulik wrote: > > This is getting deprecated > > yay... > > global menu also uses it That's next. Will make a new protocol for that, it doesn't fit here. REPOSITORY R127 KWayland REVISION

D8159: Add API for setting server decoration palettes

2017-10-06 Thread Kai Uwe Broulik
broulik added a comment. > This is getting deprecated yay... global menu also uses it REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8159 To: davidedmundson, #plasma Cc: broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,

D8159: Add API for setting server decoration palettes

2017-10-06 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This is currently handled by the QtExtended surface which is

Latte Dock in review phase

2017-10-06 Thread Michail Vourlakos
Hello, Latte Dock entered the review phase in order to be part of extragear in the future. After some requests I am forwarding you the message sent at kde-core-devel mailing list in case there are plasma devs that want to participate in the review... --- Hello everyone, we decided

Re: Latte Dock in review phase

2017-10-06 Thread Michail Vourlakos
ok, I will forward it there also 2017-10-06 10:19 GMT+03:00 Jonathan Riddell : > plasma-devel subscribers may be interested in reviewing this > > > -- Forwarded message -- > From: Michail Vourlakos > Date: 4 October 2017 at 22:00 >

Fwd: Latte Dock in review phase

2017-10-06 Thread Jonathan Riddell
plasma-devel subscribers may be interested in reviewing this -- Forwarded message -- From: Michail Vourlakos Date: 4 October 2017 at 22:00 Subject: Latte Dock in review phase To: kde-core-de...@kde.org Hello everyone, we decided to make Latte an active