Re: Notes from QtCS that will affect Plasma.

On 10 Oct 2017 10:23 p.m., "Kai Uwe Broulik" wrote: >- we (KDE) would use that private API in client code if we implement a custom popup... > - [I'm not particularly happy with that at all, but it's at least slightly better than the current state] This means even

Re: Notes from QtCS that will affect Plasma.

>    - we (KDE) would use that private API in client code if we implement a custom popup...>   - [I'm not particularly happy with that at all, but it's at least slightly better than the current state]

Notes from QtCS that will affect Plasma.

Most notes are about boring internal things and I quietly stayed at the back. For the wayland session I had a lot of questions/comments and was a general nuisance. Wayland: xdg_positioner: We need to pass data to the window from from QComboBox etc, but also from client code i.e a

Plasma 5.12 goal: let's get Wayland ready!

Hi all, I want to put out a development goal for the Plasma team for the upcoming 5.12 cycle: let's get Wayland ready! The last two weeks I saw two blog posts by two different Plasma members showing screenshots running X. That disappointed me. I hoped that we all are running Wayland already

Re: [RFC] Fixing the QT_QPA_PLATFORM dilemma

Am 2017-10-10 20:07, schrieb David Edmundson: On the "fix Qt" side. Discussed in QtCS yesterday (I have more notes to type up): QtWayland client will be moving into QtBase. When this happens, neat and tidy autodection is do-able. Also those bundled apps would have wayland. Realistically we're

Re: [RFC] Fixing the QT_QPA_PLATFORM dilemma

On the "fix Qt" side. Discussed in QtCS yesterday (I have more notes to type up): QtWayland client will be moving into QtBase. When this happens, neat and tidy autodection is do-able. Also those bundled apps would have wayland. Realistically we're talking Qt5.11. Maybe we could do a hack in

D7369: Wayland foreign protocol

graesslin added a comment. In https://phabricator.kde.org/D7369#153978, @mart wrote: > In https://phabricator.kde.org/D7369#152358, @graesslin wrote: > > > Documentation is still missing, Unstable suffix is still in two many API calls. > > > i think the

D7521: Make use of foreign protocol

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH mart/foreign REVISION DETAIL https://phabricator.kde.org/D7521 To: mart, #plasma, graesslin Cc: luebking, graesslin, davidedmundson, plasma-devel, kwin, #kwin, ZrenBot,

[RFC] Fixing the QT_QPA_PLATFORM dilemma

Hi Plasmates, on Wayland we use QT_QPA_PLATFORM=wayland to force all Qt applications to use the Wayland QPA instead of the XCB QPA. This has a huge problem: Qt does not ship Wayland in their installers. So any application which bundles Qt itself is not going to start on a Plasma/Wayland

D8178: Fix editing items in SimpleFavoritesModel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:06f01ed291ca: Fix editing items in SimpleFavoritesModel (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8178?vs=20437=20579 REVISION

D8239: Use correct .desktop file name when setting KMail as default

dvratil added a comment. In https://phabricator.kde.org/D8239#154122, @davidedmundson wrote: > is a kconf_update needed? Added kconf_update script to KMail repo REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8239 To: dvratil, #plasma,

D8239: Use correct .desktop file name when setting KMail as default

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ca72cd44ebc0: Use correct .desktop file name when setting KMail as default (authored by dvratil). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8239: Use correct .desktop file name when setting KMail as default

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. is a kconf_update needed? REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8239 To: dvratil, #plasma, davidedmundson

D8239: Use correct .desktop file name when setting KMail as default

dvratil added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8239 To: dvratil, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8239: Use correct .desktop file name when setting KMail as default

dvratil created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Since Applications 17.08 KMail's desktop file is called org.kde.kmail2.desktop in order to match its DBus name. This breaks setting KMail as

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. One of our CI jobs is no longer happy: 13:02:41 -- The following REQUIRED packages have not been found: 13:02:41 13:02:41 * Wayland (required version >= 1.13) , C library implementation of the Wayland protocol: a protocol for a compositor to talk to

D8039: Support software QtQuickRendering in Aurorae

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in aurorae.cpp:354 > Changing the rendering doesn't block making calls to any of the openGL calls > in QtBase. > The only changes are purely inside QtQuick > > So: > creating a context still works fine > creating an FBO

D8039: Support software QtQuickRendering in Aurorae

graesslin added a comment. Ah sorry, I had my comment here for weeks, just unsubmitted :-( REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8039 To: davidedmundson, #plasma Cc: graesslin, apol, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8182: Support initial minimize rule in ShellClient

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH shell-client-initial-minimize-rule REVISION DETAIL https://phabricator.kde.org/D8182 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot,

D8232: Add option to center shadow

rpelorosso updated this revision to Diff 20566. rpelorosso edited the summary of this revision. rpelorosso added a comment. Aligned the "Center Shadow" checkbox to the left F5381122: image.png CHANGES SINCE LAST UPDATE

5.12 kickoff

Many people are at Qt WS this week and there's a Blue Systems sprint next week so probably any 5.12 kickoff meeting should wait until after oct 22nd. The schedule is already agreed with release 5.12.0 LTS Release Thu 2018-01-25 Tue 2018-01-30 https://community.kde.org/Schedules/Plasma_5 so maybe

D8039: Support software QtQuickRendering in Aurorae

davidedmundson updated this revision to Diff 20565. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Check Qt version REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8039?vs=20050=20565 BRANCH master

D8236: Remove duplicate code

davidedmundson abandoned this revision. davidedmundson added a comment. Edit. Marco pushed this on Friday. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8236 To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8143: Use QQC2.Label over Kirigami.Label

This revision was automatically updated to reflect the committed changes. Closed by commit R124:59f70b3afe18: Use QQC2.Label over Kirigami.Label (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8143?vs=20350=20564 REVISION

D8131: Deprecate Kirigami.Label

This revision was automatically updated to reflect the committed changes. Closed by commit R169:72c01208fe79: Deprecate Kirigami.Label (authored by davidedmundson). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8131?vs=20335=20563 REVISION DETAIL

D8144: Port gallery example use of Labels to be consistently QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R169:cdace49d7077: Port gallery example use of Labels to be consistently QQC2 (authored by davidedmundson). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D8138: Port Kirigami.Controls uses of Kirigami.Label

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d72248793f5b: Port Kirigami.Controls uses of Kirigami.Label (authored by davidedmundson). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8138?vs=20336=20561

D8050: Expose wl_display_set_global_filter as a virtual method

This revision was automatically updated to reflect the committed changes. Closed by commit R127:a1aad4e86cba: Expose wl_display_set_global_filter as a virtual method (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D8236: Remove duplicate code

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. davidedmundson added a project: Plasma. REVISION SUMMARY Height is set by anchors. Setting both is wrong. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D8236

D8234: Fix system settings binding loop

davidedmundson abandoned this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8234 To: davidedmundson, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8232: Add option to center shadow

davidedmundson added a comment. Rule of thumb: If you tag VDG in a review, you need screenshots. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8178: Fix editing items in SimpleFavoritesModel

fvogt added a comment. re. the comments: I did not write any of that, it simply got added by the tools.js sync. If this is supposed to be removed, please tell Ivan. I did test this patch for all types of favorites, but not in relation to activities as I'm not too familiar with them.

D8178: Fix editing items in SimpleFavoritesModel

hein added a comment. Please make sure the spam is gone (console.log), etc. The "this crashes Qt" comment": That was written by Ivan originally. Please make sure and test that this patch works with both kinds of favorites. I'm travelling and am indisposed currently. REPOSITORY

D8115: Port KAccess away from kdelibs4support

apol updated this revision to Diff 20557. apol added a comment. Remove comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8115?vs=20258=20557 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8115 AFFECTED FILES

D7885: Don't crash if a client (legally) uses deleted global contrast manager

davidedmundson added a comment. Found a better approach that we can use globally (pun not intended) If we track REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7885 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot,

D8234: Fix system settings binding loop

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in CategoriesPage.qml:35 > There's even an `anchors.fill: parent` below oh you're right :/ I'll check if I can just kill this line. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8234 To:

D8234: Fix system settings binding loop

broulik added inline comments. INLINE COMMENTS > CategoriesPage.qml:35 > id: searchLayout > -height: menuButton.height > +implicitHeight: menuButton.implicitHeight > spacing: Kirigami.Units.smallSpacing There's even an `anchors.fill: parent`

D8234: Fix system settings binding loop

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Setting a parent's height to a child's height in a layout never makes sense as layouts will

D8178: Fix editing items in SimpleFavoritesModel

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > tools.js:32 > actionList.unshift(separator); > +// actionList = actions.concat(actionList); // this crashes Qt > O.o >

Plasma 5.11.0

Plasma 5.11.0 is now released https://www.kde.org/announcements/plasma-5.11.0.php Please made bugfixes to Plasma/5.11 branch and new features to master branches

D8115: Port KAccess away from kdelibs4support

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.cpp:91 > > -app.setXkbOpcode(xkb_opcode); > -app.disableSessionManagement(); > +// app.setXkbOpcode(xkb_opcode); > return

D8214: Fix warning

apol abandoned this revision. apol added a comment. It was only happening because of Zanshin, waiting for their feedback. https://bugs.kde.org/show_bug.cgi?id=385548 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8214 To: apol, #plasma, davidedmundson

D7521: Make use of foreign protocol

mart updated this revision to Diff 20554. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. - adapt to api changes REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7521?vs=18964=20554 BRANCH mart/foreign REVISION

D8214: Fix warning

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This Attribute would make sense to set in kquickaddons with my QtQuick settings code. The image texture cache in k-d needs updating to test this flag and not do

D7369: Wayland foreign protocol

mart updated this revision to Diff 20553. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - add api docs, getridof some unstable, calls with unstable follow the other interfaces REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D7369: Wayland foreign protocol

mart added a comment. In https://phabricator.kde.org/D7369#152358, @graesslin wrote: > Documentation is still missing, Unstable suffix is still in two many API calls. i think the importerUnstableV2Announced exporterUnstableV2Announced should remain with unstable and versioned?

D8160: be less aggressive when to disable borders

This revision was automatically updated to reflect the committed changes. Closed by commit R113:94ea668fa279: be less aggressive when to disable borders (authored by mart). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8160?vs=20390=20550 REVISION

D7941: use Kirigami Theme for colors

mart closed this revision. mart added a comment. dependencies are up to date now in metadata REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D7941 To: mart, #plasma, #kirigami, hein Cc: bcooksley, davidedmundson, plasma-devel, ZrenBot,

D8232: Add option to center shadow

mart added a comment. i would love that REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

mart added a reviewer: VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[kio-extras] [Bug 369850] Can't browse samba workgroups

https://bugs.kde.org/show_bug.cgi?id=369850 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org