D8178: Fix editing items in SimpleFavoritesModel

fvogt added inline comments. INLINE COMMENTS > ivan wrote in tools.js:185 > I don't like this change. Would rather have this stated explicitly than rely > on the implementation in the favmodel. Can you make this part also aware of > which model is behind the favoriteModel variable? With yet

D8178: Fix editing items in SimpleFavoritesModel

ivan added a comment. Somehow I didn't submit the comment when I wrote it. See above. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8178 To: fvogt, #plasma, davidedmundson Cc: ivan, hein, davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff,

D8178: Fix editing items in SimpleFavoritesModel

ivan added inline comments. INLINE COMMENTS > tools.js:185 > console.log("Removing from all activities"); > -favoriteModel.removeFavoriteFrom(favoriteId, ":any"); > - > +favoriteModel.removeFavorite(favoriteId); > } else if (actionId == "_kicker_favorite_add") { I

Wayland showstoppers wiki page

Hi all, I just created a wiki page to track the showstoppers: https://community.kde.org/Plasma/Wayland_Showstoppers I decided for wiki instead of bugzilla as I want to track issues all over the stack and not just those in our software. Please add as you find issues which you think are a

D7369: Wayland foreign protocol

graesslin added a comment. There is still quite some documentation missing. Especially the server side is not yet documented enough that I would know how to use the new API and what it does. It's totally fine to copy and adapt the documentation from the Wayland xml protocol. INLINE

D8252: Make calendar pin persistent across sessions

graesslin added a comment. I agree on the consistent part. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8252 To: davidedmundson, #plasma Cc: graesslin, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8251: Fix DRM EGL crash regression

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. whoops. Thanks for fixing. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D8251 To: davidedmundson, #plasma, graesslin Cc: graesslin,

D8252: Make calendar pin persistent across sessions

broulik added a comment. Should we do the same for System Tray? I don't think anybody would do this but it should be consistent INLINE COMMENTS > main.xml:69 > + > + > + false Whether to keep the calendar popup opened when it loses focus REPOSITORY R120 Plasma Workspace

D8252: Make calendar pin persistent across sessions

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A user can "pin" the calendar so that it won't get closed on focus change, but only when the

D8251: Fix DRM EGL crash regression

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY In https://phabricator.kde.org/R108:47343fb8f75909f6491c0534004df56ee1e53737 we made

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

ngraham added a comment. What's the status of this patch? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5928 To: subdiff, #kwin Cc: ngraham, leezu, behrmann, cfeck, graesslin, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, alexeymin, progwolff, lesliezhai,

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. In https://phabricator.kde.org/D8050#154356, @davidedmundson wrote: > I'm not resubmitting something just for the purpose of you two winding each other up. Eh, it was not meant like that. I just wanted to point out that this does not need any changes

Re: Notes from QtCS that will affect Plasma.

Am 2017-10-10 22:18, schrieb David Edmundson: Most notes are about boring internal things and I quietly stayed at the back. For the wayland session I had a lot of questions/comments and was a general nuisance. Wayland: xdg_positioner: We need to pass data to the window from from QComboBox

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson added a comment. I'm not resubmitting something just for the purpose of you two winding each other up. We're in no rush for this. I'll check what suse has and go from there. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To:

D8250: [client] Drop the checks for platformName being "wayland"

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Flatpak. Restricted Application added a subscriber: plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY There are also QPA's which are "wayland" but have a different

Re: Plasma 5.12 goal: let's get Wayland ready!

Am 2017-10-11 11:53, schrieb Marco Martin: On martedì 10 ottobre 2017 21:40:14 CEST Martin Flöser wrote: Hi all, I want to put out a development goal for the Plasma team for the upcoming 5.12 cycle: let's get Wayland ready! The last two weeks I saw two blog posts by two different Plasma

Re: Plasma 5.12 goal: let's get Wayland ready!

Am 2017-10-11 12:30, schrieb David Edmundson: I want to put out a development goal for the Plasma team for the upcoming 5.12 cycle: let's get Wayland ready! Sure, but being an LTS, the "do LTS stuff" goal also needs to remain in full effect. I think that goes hand in hand and is actually why

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin accepted this revision. graesslin added a comment. I'm accepting this revision again. The CI system needs to have the PPA activated again as the old CI system had. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma,

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. In https://phabricator.kde.org/D8050#154207, @bcooksley wrote: > Please remedy the Wayland dependency incompatibility. > > In the event the relevant package is not available in the distribution in question, you'll need to contact it's packagers and make the

Re: [RFC] Fixing the QT_QPA_PLATFORM dilemma

Am 2017-10-11 11:23, schrieb David Edmundson: On Wed, Oct 11, 2017 at 11:01 AM, Marco Martin wrote: On martedì 10 ottobre 2017 19:35:43 CEST Martin Flöser wrote: Based on that we can detect whether we are on Wayland and could pick the Wayland platform (and should check

Re: Plasma 5.12 goal: let's get Wayland ready!

On Wed, Oct 11, 2017 at 12:30 PM, David Edmundson < da...@davidedmundson.co.uk> wrote: > > I want to put out a development goal for the Plasma team for the > upcoming 5.12 cycle: let's get Wayland ready! > > Sure, but being an LTS, the "do LTS stuff" goal also needs to remain in > full effect. >

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson added a comment. This was reverted since yesterday when we noticed CI failed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma, graesslin, bcooksley Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot,

Re: Plasma 5.12 goal: let's get Wayland ready!

> I want to put out a development goal for the Plasma team for the upcoming 5.12 cycle: let's get Wayland ready! Sure, but being an LTS, the "do LTS stuff" goal also needs to remain in full effect. On Tue, Oct 10, 2017 at 9:40 PM, Martin Flöser wrote: > Hi all, > > I want

Re: Plasma 5.12 goal: let's get Wayland ready!

On martedì 10 ottobre 2017 21:40:14 CEST Martin Flöser wrote: > Hi all, > > I want to put out a development goal for the Plasma team for the > upcoming 5.12 cycle: let's get Wayland ready! > > The last two weeks I saw two blog posts by two different Plasma members > showing screenshots running

D8050: Expose wl_display_set_global_filter as a virtual method

bcooksley requested changes to this revision. bcooksley added a comment. This revision now requires changes to proceed. Please remedy the Wayland dependency incompatibility. In the event the relevant package is not available in the distribution in question, you'll need to contact it's

D8050: Expose wl_display_set_global_filter as a virtual method

bcooksley reopened this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Re: [RFC] Fixing the QT_QPA_PLATFORM dilemma

On Wed, Oct 11, 2017 at 11:01 AM, Marco Martin wrote: > On martedì 10 ottobre 2017 19:35:43 CEST Martin Flöser wrote: > > Based on that we can detect whether we are on Wayland and could pick the > > Wayland platform (and should check whether the QPA plugin is installed). > > >

D7369: Wayland foreign protocol

mart added a comment. In https://phabricator.kde.org/D7369#154153, @graesslin wrote: > In https://phabricator.kde.org/D7369#153978, @mart wrote: > > > In https://phabricator.kde.org/D7369#152358, @graesslin wrote: > > > > > Documentation is still missing, Unstable suffix is still

D7369: Wayland foreign protocol

mart updated this revision to Diff 20584. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - update to the upstream xml protocol REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=20553=20584

Re: [RFC] Fixing the QT_QPA_PLATFORM dilemma

On martedì 10 ottobre 2017 19:35:43 CEST Martin Flöser wrote: > Based on that we can detect whether we are on Wayland and could pick the > Wayland platform (and should check whether the QPA plugin is installed). > > The only problem is how to do it: > * our platform theme plugin is too late :-(