lueck added inline comments.
INLINE COMMENTS
> index.docbook:17-18
>
> 2016-09-20
> Plasma 5.8
>
Please bump date + releasinfo
> index.docbook:18-19
>
> 2016-09-21
> Plasma 5.8
>
Please bump date + releasinfo
> index.docbook:17-18
>
> 2017-04-01
> Plasma 5.9
>
Please bump
ngraham updated this revision to Diff 22015.
ngraham edited the test plan for this revision.
ngraham added a comment.
Better text for inactive selection checkbox
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8684?vs=22009=22015
BRANCH
ngraham edited the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D8684
REVISION DETAIL
https://phabricator.kde.org/D8684
To: ngraham, abetts, #vdg, #plasma, #documentation, apol
Cc: apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed,
abetts added a comment.
Just on the first image
"Inactive selection changes color"
to
"Change colors for inactive selection"
Just to make sure that the checkbox starts with a verb.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D8684
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:dd3722248e20: Screenlocker KCM text improvements
(authored by ngraham).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8686?vs=22011=22012
REVISION DETAIL
abetts accepted this revision.
abetts added a comment.
This revision is now accepted and ready to land.
I would agree, keyboard shortcut seems better. It just felt like the label
didn't have context for the shortcut button next to it.
REPOSITORY
R133 KScreenLocker
BRANCH
master
ngraham marked an inline comment as done.
REPOSITORY
R133 KScreenLocker
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8686
To: ngraham, abetts, #vdg, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
ngraham updated this revision to Diff 22011.
ngraham added a comment.
Make this string shorter
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8686?vs=22001=22011
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8686
AFFECTED FILES
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Looks good!
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D8684
REVISION DETAIL
https://phabricator.kde.org/D8684
To: ngraham, abetts, #vdg, #plasma, #documentation, apol
Cc: apol,
apol added inline comments.
INLINE COMMENTS
> kcm.ui:131
>
> -Lock screen:
> +Lock screen with keyboard shortcut:
>
Maybe leave it at `keyboard shortcut`? `Lock screen` is a bit redundant as
we're already at the screen locking page and the text
jpalecek added a comment.
In https://phabricator.kde.org/D8673#164830, @davidedmundson wrote:
> Do the sockets need closing in the destructor?
Good point. I assumed the `KSMServer` instance is practically a singleton
(being assigned to global `the_server` etc.) which is created
ngraham edited the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8684
To: ngraham, abetts, #vdg, #plasma, #documentation
Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, sebas, apol, mart
ngraham retitled this revision from "text improvements for Style, Colors, and
Workspace KCMs" to "text improvements for Colors, Icons, Style, and Workspace
KCMs".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
ngraham updated this revision to Diff 22009.
ngraham added a comment.
Also address 386567; better text for the "enable icon animation" checkbox
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8684?vs=22007=22009
BRANCH
arcpatch-D8684
REVISION
ngraham edited the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8684
To: ngraham, abetts, #vdg, #plasma, #documentation
Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, sebas, apol, mart
ngraham updated this revision to Diff 22007.
ngraham added a comment.
hover -> mouse hover
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8684?vs=22006=22007
BRANCH
arcpatch-D8684
REVISION DETAIL
https://phabricator.kde.org/D8684
AFFECTED
ngraham updated this revision to Diff 22006.
ngraham added a comment.
Also update Workspace KCM strings
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8684?vs=21999=22006
BRANCH
arcpatch-D8684
REVISION DETAIL
https://phabricator.kde.org/D8684
ngraham retitled this revision from "Style and Colors KCM text improvements" to
"text improvements for Style, Colors, and Workspace KCMs".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
ngraham edited the test plan for this revision.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D8686
To: ngraham, abetts, #vdg, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham created this revision.
ngraham added reviewers: abetts, VDG, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 386573
TEST PLAN
Tested in KDE Neon:
REPOSITORY
R133 KScreenLocker
BRANCH
master
ngraham updated this revision to Diff 21999.
ngraham added a comment.
Fix unnecessary whitespace change
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8684?vs=21998=21999
BRANCH
colors_386565
REVISION DETAIL
https://phabricator.kde.org/D8684
ngraham retitled this revision from "Style KCM text improvements" to "Style and
Colors KCM text improvements".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8684
To:
ngraham updated this revision to Diff 21998.
ngraham added a comment.
Colors KCM text improvements
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8684?vs=21993=21998
BRANCH
colors_386565
REVISION DETAIL
https://phabricator.kde.org/D8684
lueck added a reviewer: Documentation.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8684
To: ngraham, abetts, #vdg, #plasma, #documentation
Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, sebas, apol, mart
ngraham edited the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8684
To: ngraham, abetts, #vdg, #plasma
Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, sebas, apol, mart
ngraham created this revision.
ngraham added reviewers: abetts, VDG, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 386570
Implement @abetts' proposals in https://bugs.kde.org/show_bug.cgi?id=386570
mart updated this revision to Diff 21991.
mart added a comment.
- add gallery page
- make FormLayout a template
- use Headings for all the titles
- remove some redundant code
- support for dynamic elements
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
I am not :(
drmSetClientCap fails
Is there much I can do?
Am 2017-11-06 18:25, schrieb David Edmundson:
For all rotations (including upside down) I'm getting the primary
buffer displaying pre-rotated contents; for 90 and 270 the contents
are frozen.
Could you please verify that you run atomic mode settings? The
description matches my experiences
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
inhibit-idle
REVISION DETAIL
https://phabricator.kde.org/D8383
To: graesslin, #frameworks, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, leezu, ZrenBot,
For all rotations (including upside down) I'm getting the primary buffer
displaying pre-rotated contents; for 90 and 270 the contents are frozen.
For flipped the cursor plane flipped correctly and updates fine.
This on master, I don't have your supportRotations patches in.
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
drm-mode-to-output
REVISION DETAIL
https://phabricator.kde.org/D8578
To: graesslin, #kwin, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, kwin, ZrenBot,
graesslin marked an inline comment as done.
REPOSITORY
R108 KWin
BRANCH
drm-cursor-to-output
REVISION DETAIL
https://phabricator.kde.org/D8664
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:c9c26019a186: [platforms/drm] Move cursor dumb buffers to
Output (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8664?vs=21973=21976#toc
REPOSITORY
R108 KWin
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:4bfeeb3084a5: [platforms/drm] Fix cursor hotspot for
inverted landscape rotation (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:04dac01c2a32: Very slightly increase text contrast for the
default Breeze color scheme (authored by ngraham).
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> davidedmundson wrote in drm_output.cpp:960
> this needs a showCursor() too to be useful
you added the showCursor above, but not here.
REPOSITORY
graesslin updated this revision to Diff 21973.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Incorporated suggested changes. As I didn't like the index manipulation in the
old code base I tried to take the advantages from my failed attempt and
graesslin marked 4 inline comments as done.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8664
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Ref https://phabricator.kde.org/T7174, https://phabricator.kde.org/T7175
Changelog -
1. Added Dbus
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:78f638adc6cc: Added Dbus, Autocomplete, Updated Look and
Feel (authored by Aiix).
REPOSITORY
R846 Mycroft Plasma integration
CHANGES SINCE LAST UPDATE
ngraham added a comment.
Oops, I did link to the wrong recision in my last comment. This is the
correct one: https://phabricator.kde.org/D8592 (it's also linked to in the
Stack)
The diff _here_ is up to date, and these are accurate before-and-after
screenshots:
Before:
F5456910:
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3ebdd64e6bbd: Optimize SortFilterModel role names
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8639?vs=21832=21966
Hola,
The minutes and the log.
Enjoy!
--
sebas
http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 6-11-2017
Present: notmart, Ridell, Sho, kbroulik, d_ed
notmart:
* kirigami: support for colored icons in some more places: possibility to color
the main action buttons, needed by
subdiff added a comment.
The diff you linked was wrong probably. Are the screenshots updated to the
last change? It looks very strong there.
REPOSITORY
R31 Breeze
BRANCH
arcpatch-D7424
REVISION DETAIL
https://phabricator.kde.org/D7424
To: ngraham, hpereiradacosta, jensreuterberg,
davidedmundson added a comment.
Makes sense.
Do the sockets need closing in the destructor?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8673
To: jpalecek, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
46 matches
Mail list logo
