hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Nice.
I think we have the same problem in Kicker and Application Dashboard, which
also use append trickery.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
hein added a comment.
So if I understand correctly, the Mnemonic stuff currently doesn't seem to
have the same aims as KAcceleratorManager does ...
KAcceleratorManager acts on a hierarchy of widgets, traverses it, assigns
weights to actionable things and possible mnemonics and overall
ngraham edited the summary of this revision.
REPOSITORY
R128 User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8793
To: ngraham, apol, #plasma, mlaurent, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas,
ngraham updated this revision to Diff 22306.
ngraham added a comment.
Found a way to safely remove the temp file and keep everything working
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8793?vs=22272=22306
BRANCH
master
REVISION DETAIL
apol edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8809
To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
davidedmundson added a comment.
you can close https://bugs.kde.org/show_bug.cgi?id=382233
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8809
To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We were reporting that the margins were changing whenever anything changed
in a FrameSvg,
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
There's a bunch of code referring to this setting but not such a setting,
so the qml engine is confused and
ngraham added a comment.
Actually, deleting the file in /tmp breaks it all over again in the same way,
which is probably why this was broken when it was using a moveJob. Looks like
we may have to live with having a file in /tmp, or else embark on a bigger
change.
REPOSITORY
R128 User
ngraham added a comment.
Yes, it looks like in that case, we leak /tmp/systemsettings.[number] since
it's copied, not moved. I'll have to explicitly handle that case.
REPOSITORY
R128 User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8793
To: ngraham, apol,
davidedmundson added a comment.
> Does KScreen allow to disable all screens?
The user gets a prompt "are you sure you want to disable all outputs?"
If they press the "I'm an idiot" button, then it will.
> and if yes: how does KWin behave in this case?
Very badly.
> How
ngraham added a comment.
What's the status of this patch?
FWIW, @ivan I think the UI change goes quite nicely with the new default.
It's nice and streamlined now.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8449
To: cryptodude, ivan, #plasma
Cc:
cfeck added inline comments.
INLINE COMMENTS
> cfeck wrote in mountdialog.cpp:33
> Is the leasing space intended?
"leading" :)
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8787
To: cryptodude, #plasma, ivan
Cc: cfeck, plasma-devel, ZrenBot, progwolff,
cfeck added a comment.
Please clarify. If https://phabricator.kde.org/D8791 gets accepted, which
issues remain that would justify a custom dialog?
INLINE COMMENTS
> mountdialog.cpp:33
> +m_ui.errorLabelStatic->setVisible(false);
> +m_ui.vaultName->setText(QString("
luebking added a comment.
Ignore the request as "probably temporary" and just freeze rendering?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8796
To: davidedmundson, #plasma
Cc: luebking, broulik, graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot,
progwolff,
broulik added a comment.
Given how well Qt handled the no screen case in the past I'd advise against
being able to disable all of them.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8796
To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, kwin, #kwin,
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8794
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening,
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:c601e875cfa7: [platforms/drm] At safety checks for the
properties (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8752?vs=22208=22293
graesslin added a comment.
Does KScreen allow to disable all screens? And if yes: how does KWin behave
in this case? I had been thinking about this for some time and are not sure how
KWin should handle this situation. I can see reasons to say "user asked for it,
so all screens should go
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:55a8d72e9786: Use heuristic weighted length algorithm to
calculate the query term length. (authored by xuetianweng).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8771
To: xuetianweng, hein, broulik
Cc: cfeck, ihipop, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
xuetianweng updated this revision to Diff 22289.
xuetianweng marked an inline comment as done.
xuetianweng added a comment.
Use the new kcoreaddons function to cal the length.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8771?vs=22234=22289
xuetianweng added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
xuetianweng created this revision.
xuetianweng added a reviewer: ngraham.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Added libinput support to X11 backend. It also adds an new option to backend
which is only available to libinput device currently.
TEST PLAN
Manually
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
We need to keep the DrmOutput object to still have the
WaylandOutputDevice.
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
This is a tiny refactor so that DrmOutput can have WaylandOutput dynamically
On Monday November 13 2017 17:20:56 Martin Flöser wrote:
Hi,
Is it possible that many if not most of the users who might report this kind of
issue use (very) fast disks combined with lots of RAM (and possible tiny
amounts of swap space) nowadays? (Meaning they never notice anything out of the
mart updated this revision to Diff 22277.
mart added a comment.
- text 100% wide
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8641?vs=22274=22277
BRANCH
mart/formlayout
REVISION DETAIL
https://phabricator.kde.org/D8641
AFFECTED FILES
mart updated this revision to Diff 22274.
mart added a comment.
- event compress relayouts
- resize items that are separator
- new way to switch from wide to compact
- remove debug
- introduce a mnemonics mechanism
- split mnemonics in a new attached
REPOSITORY
R169 Kirigami
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
misclicked, wanted to accept it.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8779
To: davidedmundson, #plasma, graesslin
Cc: bshah,
bshah added a comment.
@graesslin, you requested changes here but what change? There is no comment
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8779
To: davidedmundson, #plasma, graesslin
Cc: bshah, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in input.cpp:960
> if we're always going to do:
>
> if (actionResult.first) {
> return actionResult.second;
>
> why return two bools and not just "and" them here?
if actionResult.first is true we should not
graesslin requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8779
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
Am 2017-11-13 10:23, schrieb René J.V. Bertin:
Hi,
This is something I also noticed with KWin4 but which seems to be
worse with KWin5 (v5.11.1, FW 5.38.0, Qt 5.8.0 and the Breeze
windowtheme):
After a big compile job (like building QtWebKit) performed in the
background (output redirected to
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Please check we're not now leaking a file in /tmp when the user uses the
pixmap region selector with a custom image.
REPOSITORY
R128 User Manager
BRANCH
master
ngraham retitled this revision from "Fix using avatars from the gallery" to
"Fix using avatars from the gallery and from local files".
ngraham edited the test plan for this revision.
ngraham added reviewers: apol, Plasma, mlaurent, davidedmundson.
REPOSITORY
R128 User Manager
REVISION DETAIL
ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 385151
Use a KIO::copy job throughout to ensure that ~/.face gets created correctly
TEST PLAN
Tested in KDE Neon. With this
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:ef782d629eac: Replace the library name in the source
(authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8792?vs=22270=22271
REVISION DETAIL
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8792
To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We use this field to infer the library name from the CI/CD.
REPOSITORY
R169 Kirigami
BRANCH
master
ngraham added a comment.
Have you had any time to produce some more of the individual patches for
this? It would be really great to get a libinput-compatible version of the
input KCM for 5.12.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8168
To:
cryptodude added a comment.
Hmm, api.kde.org certainly fooled me. Seems there are two classes with
the same name in different packages!
Either way, one has a bug, not sure which was linked in.
Still, it apart from the incorrect commit message, I stand by the patch as it
makes
cfeck added a comment.
KPasswordDialog does not come from KDELibs4Support, but from KWidgetsAddons.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8787
To: cryptodude, #plasma, ivan
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
Hi,
notes and full log attached!
Cheers,
Eike
Plasma Team meeting, 13-11-2017
Present: notmart, fvogt, bshah, d_ed, sebas, Sho_
notmart:
* FormLayout:
** automatic wide/compact layout switch
** automatic text mnemonics/shortcuts
* small command line tool to switch look and feel (maybe useful
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b40c0de099fc: When used by QML, only populate after
component is complete (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
hein added a comment.
Looking at the KActivities API more, perhaps not exposing this directly was
deliberate of Ivan as otherwise Consumer would probably have all of the Cache
signals. Ivan, can you opine on this?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:fdf7468d9844: Install related ref instead attempting to
upgrade it (authored by jgrulich).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8784?vs=22256=22263#toc
REPOSITORY
R134 Discover
hein added a comment.
I inquired upstream about a signal/API a few times and wasn't told about this
signal. I will look into it, unless Ivan wants to.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8524
To: hein, #plasma, davidedmundson
Cc:
apol added a comment.
Just cherry-pick the commit into the right branch and `git push` it.
REPOSITORY
R134 Discover Software Store
BRANCH
install-related-refs
REVISION DETAIL
https://phabricator.kde.org/D8784
To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
hein added a comment.
I've found this problem in many KDE UIs, and I'd like to have a generic
solution. How do you feel about adding something like a logicalStringLength()
to KCoreAddons or KCodecs? Then we can use it in KRunner, KMail, Amarok, ...
REPOSITORY
R120 Plasma Workspace
davidedmundson abandoned this revision.
davidedmundson added a comment.
See thread on https://phabricator.kde.org/D7732, it's not reliable to do this.
REPOSITORY
R123 SDDM Configuration Panel (KCM)
REVISION DETAIL
https://phabricator.kde.org/D7716
To: davidedmundson, #plasma
Cc: apol,
jgrulich added a comment.
In https://phabricator.kde.org/D8784#167078, @apol wrote:
> Thanks! Please submit to 5.11 if it doesn't bump the dependency.
It doesn't, I'm just not sure how to land this into Plasma/5.11 branch as I
created local branch based on master and when running
apol added inline comments.
INLINE COMMENTS
> FlatpakTransactionJob.cpp:76
> +g_autoptr(GError) installedRefError = nullptr;
> +FlatpakInstalledRef *installedRef = nullptr;
> +installedRef =
> flatpak_installation_get_installed_ref(m_app->installation(),
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Thanks! Please submit to 5.11 if it doesn't bump the dependency.
REPOSITORY
R134 Discover Software Store
BRANCH
install-related-refs
REVISION DETAIL
https://phabricator.kde.org/D8784
cryptodude created this revision.
cryptodude added reviewers: Plasma, ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Replace kde4support dep with specialized pwd diag
BUG:385985
BUG:385445
Drop usage of
jgrulich abandoned this revision.
jgrulich added a comment.
Installing qqc2-desktop-style solved my problem.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D8786
To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
ActivitiesCache has a perfectly good nameChanged signal which is exactly what
we want.
I know it's not currently public API, but we should be fixing things
jgrulich created this revision.
jgrulich added a reviewer: apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Currently when using dark theme I cannot see most of the labels. This should
use text color
from system
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:cc0d3da26276: Update scrollbar assets (authored by
LordTermor, committed by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6688?vs=15977=22260#toc
REPOSITORY
R98 Breeze for
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6e1ae0539c4e: Fix crash in KAStatsFavouritesModel
(authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8608?vs=22111=22257#toc
REPOSITORY
R119 Plasma Desktop
jgrulich updated this revision to Diff 22256.
jgrulich added a comment.
Print error when we fail to find out whether related ref is installed
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8784?vs=22255=22256
BRANCH
install-related-refs
jgrulich created this revision.
jgrulich added a reviewer: apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When upgrading an app, we attempt to also upgrade related refs, but we
fail if some of the listed refs is
Hi,
This is something I also noticed with KWin4 but which seems to be worse with
KWin5 (v5.11.1, FW 5.38.0, Qt 5.8.0 and the Breeze windowtheme):
After a big compile job (like building QtWebKit) performed in the background
(output redirected to file) with Google Chrome and Kontact running (in
63 matches
Mail list logo
