D8910: Add Plasma Mobile session

2017-11-19 Thread Bhushan Shah
bshah created this revision. bshah added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY And also, autoload Plasma Mobile shell if session is plasma-mobile TEST PLAN loaded Plasma Mobile session

D8909: Fix uninitialized warning on valgrind

2017-11-19 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D8909 AFFECTED FILES s

D8896: Add recently added file to .qrc

2017-11-19 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8896 To: janmulder, mart, davidedmundson Cc: plasma-devel, apol, davidedmundson, mart, hein

D8896: Add recently added file to .qrc

2017-11-19 Thread Jan Mulder
janmulder created this revision. janmulder added a reviewer: mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Commit https://phabricator.kde.org/R169:f8ee631aac787b6096b44236a2da7ca81200cf2f added a file but addin

D8887: Fix leaking of FDs requested from logind

2017-11-19 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R108:96af5965eeef: Fix leaking of FDs requested from logind (authored by fvogt). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8887?vs=22592&id=22594 REVISION DETAIL ht

D8887: Fix leaking of FDs requested from logind

2017-11-19 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8887 To: fvogt, #plasma, graesslin Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute

D8888: Fix race condition with libinput events on startup

2017-11-19 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R108:d7d78e2b5937: Fix race condition with libinput events on startup (authored by fvogt). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D?vs=22581&id=22593 REVISION D

D8887: Fix leaking of FDs requested from logind

2017-11-19 Thread Fabian Vogt
fvogt updated this revision to Diff 22592. fvogt added a comment. Restricted Application edited projects, added Plasma; removed KWin. Remove non-linux codepath REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8887?vs=22580&id=22592 BRANCH Plasma/5.11 REVISIO

D8888: Fix race condition with libinput events on startup

2017-11-19 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D#169518, @fvogt wrote: > Should this go into Plasma/5.11 as well? Yes, please. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D To: fvogt, #plasma, graesslin, davidedmundson Cc: anthonyfiero

D8887: Fix leaking of FDs requested from logind

2017-11-19 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D8887#169520, @fvogt wrote: > Should this go into Plasma/5.11 (probably even 5.8) as well? 5.11 yes! Wayland support is not covered by LTS, so I don't see a need to fix in 5.8. INLINE COMMENTS > fvogt wrote in logind.cpp:

D8887: Fix leaking of FDs requested from logind

2017-11-19 Thread Fabian Vogt
fvogt added a comment. Should this go into Plasma/5.11 (probably even 5.8) as well? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8887 To: fvogt, #plasma, graesslin Cc: kwin, plasma-devel, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreut

D8888: Fix race condition with libinput events on startup

2017-11-19 Thread Fabian Vogt
fvogt added a comment. Should this go into Plasma/5.11 as well? INLINE COMMENTS > anthonyfieroni wrote in input.cpp:1734-1738 > Doesn't it to be in setup? > > void Connection::setup(QObject *to) > { > connect(this, &LibInput::Connection::eventsRead, to, [this]() { > processEvents(

D8887: Fix leaking of FDs requested from logind

2017-11-19 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > graesslin wrote in logind.cpp:387 > Which systems wouldn't have it? FD_DUPFD_CLOEXEC is Linux specific. I don't know whether this code path could get used on BSDs. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8887 To: fv

D8888: Fix race condition with libinput events on startup

2017-11-19 Thread Martin Flöser
graesslin accepted this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D To: fvogt, #plasma, graesslin, davidedmundson Cc: anthonyfieroni, ngraham, kwin, #kwin, plasma-devel, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abett

D8887: Fix leaking of FDs requested from logind

2017-11-19 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > logind.cpp:387 > +#else > +// F_DUPFD_CLOEXEC not available, do it non-atomically > +int fd = > dup(reply.arguments().first().value().fileDescriptor()); Which systems wouldn't have it? REPOSITORY R108 KWin REVISION DETAI