Re: how to activate debug output ?

2017-11-27 Thread Stéphane Ancelot
ok solved, thanks Le 28/11/2017 à 08:51, Sebastian Kügler a écrit : On dinsdag 28 november 2017 08:17:53 CET Stéphane Ancelot wrote: Thanks , but I would like to add some debug messages eg in systemsettings cpp program. I have seen qDebug, kDebug in other files, but it fails when I compile

Re: how to activate debug output ?

2017-11-27 Thread Sebastian Kügler
On dinsdag 28 november 2017 08:17:53 CET Stéphane Ancelot wrote: > Thanks , but I would like to add some debug messages eg in > systemsettings cpp program. > I have seen qDebug, kDebug in other files, but it fails when I compile kDebug isn't used in Plasma 5 anymore, use qCDebug or qDebug.

D8922: Avoid jumping of items toward right/botton when dropping

2017-11-27 Thread Andras Mantia
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c0f8856742a4: Avoid jumping of items toward right/botton when dropping (authored by amantia). Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.

D8915: Update the proxy to source and source to proxy mapping correctly

2017-11-27 Thread Andras Mantia
This revision was automatically updated to reflect the committed changes. Closed by commit R119:98d56d9135b1: Update the proxy to source and source to proxy mapping correctly (authored by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8850: Support drag and drop between shared folder view containments

2017-11-27 Thread Andras Mantia
This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc9c3d32a381: Support drag and drop between shared folder view containments (authored by mwolff, committed by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8850: Support drag and drop between shared folder view containments

2017-11-27 Thread Andras Mantia
amantia updated this revision to Diff 23065. amantia added a comment. Rebased REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22868=23065 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFFECTED FILES

D8598: FolderView: position files at drop event target position

2017-11-27 Thread Andras Mantia
This revision was automatically updated to reflect the committed changes. Closed by commit R119:e94888701c32: FolderView: position files at drop event target position (authored by mwolff, committed by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8493: Make Folder View screen aware

2017-11-27 Thread Andras Mantia
This revision was automatically updated to reflect the committed changes. Closed by commit R119:88718b162ada: Make Folder View screen aware (authored by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22795=23063 REVISION DETAIL

D8493: Make Folder View screen aware

2017-11-27 Thread Andras Mantia
amantia removed a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, apol, mwolff Cc: anthonyfieroni,

Re: how to activate debug output ?

2017-11-27 Thread Stéphane Ancelot
Thanks , but I would like to add some debug messages eg in systemsettings cpp program. I have seen qDebug, kDebug in other files, but it fails when I compile Le 27/11/2017 à 18:00, David Edmundson a écrit : run: QT_LOGGING_RULES=debug.area.id.debug=true   processName i.e

D8754: Baloo KCM text improvements

2017-11-27 Thread Nathaniel Graham
ngraham abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8754 To: ngraham, #vdg, #plasma, abetts Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D9026: Sort list of installed apps alphabetically

2017-11-27 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9026 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9026: Sort list of installed apps alphabetically

2017-11-27 Thread Nathaniel Graham
ngraham edited the test plan for this revision. ngraham added a reviewer: Discover Software Store. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9026 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D9026: Sort list of installed apps alphabetically

2017-11-27 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sort list of installed apps alphrbetically, because sorting by rating count doesn't make much sense when

D6764: Add font size setting to the digital clock plasmoid

2017-11-27 Thread Nathaniel Graham
ngraham added a comment. It also might be worth stepping back and asking why people want a size adjustment setting in the first place. I'm willing to bet that most of the time, it's because they think the default size is too big (because it is really big--way bigger than any of the other

D6764: Add font size setting to the digital clock plasmoid

2017-11-27 Thread Diego Gangl
januz added a comment. Thanks for the replies guys. @davidedmundson Good point! I'll keep a close eye on the current code while I work on this. REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-devel,

D9021: determine QQC2 version at build time

2017-11-27 Thread Aleix Pol Gonzalez
apol added a comment. Note this breaks integration in the IDE. Is it maybe something to discuss with upstream? REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH mart/autoversion REVISION DETAIL https://phabricator.kde.org/D9021 To: mart, #plasma, rizzitello,

D9019: [Calendar] Adjust the calendar toolbar anchors

2017-11-27 Thread David Edmundson
davidedmundson added a comment. > but I did not contribute for a long time Good to have you back! REPOSITORY R242 Plasma Framework (Library) BRANCH upstreaming REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma, broulik Cc: davidedmundson, broulik,

D9019: [Calendar] Adjust the calendar toolbar anchors

2017-11-27 Thread Alexandr Akulich
akulichalexandr added a comment. In https://phabricator.kde.org/D9019#172612, @broulik wrote: > Thanks! It's the little things that make it feel polished :) > > Do you have commit access? Yes, I have the access, but I did not contribute for a long time and still have to get

D9021: determine QQC2 version at build time

2017-11-27 Thread Chris Rizzitello
rizzitello accepted this revision. rizzitello added a comment. This revision is now accepted and ready to land. This removes the runtime problem referanced in the bug above. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH mart/autoversion REVISION DETAIL

D9021: determine QQC2 version at build time

2017-11-27 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH mart/autoversion REVISION DETAIL https://phabricator.kde.org/D9021 To: mart, #plasma, rizzitello, davidedmundson Cc: rizzitello, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Re: how to activate debug output ?

2017-11-27 Thread David Edmundson
run: QT_LOGGING_RULES=debug.area.id.debug=true processName i.e ​QT_LOGGING_RULES=kwin_core.debug=true kwin_x11

D9019: [Calendar] Adjust the calendar toolbar anchors

2017-11-27 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! It's the little things that make it feel polished :) Do you have commit access? REPOSITORY R242 Plasma Framework (Library) BRANCH upstreaming REVISION DETAIL

D8858: Fix testWaylandFullscreenShell.

2017-11-27 Thread Christophe Giboudeaux
This revision was automatically updated to reflect the committed changes. Closed by commit R127:7cd465a3bad3: Fix testWaylandFullscreenShell. (authored by cgiboudeaux). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8858?vs=22546=23037#toc REPOSITORY R127 KWayland CHANGES SINCE LAST

D9021: determine QQC2 version at build time

2017-11-27 Thread Marco Martin
mart updated this revision to Diff 23036. mart added a comment. - support editable for comboboxes REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9021?vs=23035=23036 BRANCH mart/autoversion REVISION DETAIL

how to activate debug output ?

2017-11-27 Thread Stéphane Ancelot
Hi, I tried kDebug, but it fails at build, are there some headers to add ? Regards S.Ancelot

D8858: Fix testWaylandFullscreenShell.

2017-11-27 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8858 To: cgiboudeaux, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai,

D8641: FormLayout

2017-11-27 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > hein wrote in FormLayout.qml:66 > Doesn't Kirigami have wideMode logic somewhere else too? yes, they are in some controls, independent from each other > hein wrote in FormLayout.qml:114 > Isn't this going to cause tons of ReferenceErrors without "x

D9019: [Calendar] Adjust the calendar toolbar anchors

2017-11-27 Thread Alexandr Akulich
akulichalexandr edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9019: [Calendar] Adjust the calendar toolbar anchors

2017-11-27 Thread Alexandr Akulich
akulichalexandr retitled this revision from "Plasma: Adjust the calendar toolbar layout" to "[Calendar] Adjust the calendar toolbar anchors". akulichalexandr edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019

D8641: FormLayout

2017-11-27 Thread Marco Martin
mart marked 6 inline comments as done. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein, davidedmundson Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ngiannip, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9019: [Calendar] Adjust the calendar toolbar anchors

2017-11-27 Thread Alexandr Akulich
akulichalexandr edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9021: determine QQC2 version at build time

2017-11-27 Thread Marco Martin
mart updated this revision to Diff 23035. mart added a comment. - remove useless output REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9021?vs=23034=23035 BRANCH mart/autoversion REVISION DETAIL

D9019: Plasma: Adjust the calendar toolbar layout

2017-11-27 Thread Alexandr Akulich
akulichalexandr updated this revision to Diff 23032. akulichalexandr added a comment. Updating https://phabricator.kde.org/D9019: Plasma: Adjust the calendar toolbar layout The new diff is created via Arcanist REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D9021: determine QQC2 version at build time

2017-11-27 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY the qqc2 theme style needs to import the same qqc2 version than the latest one available in the installed Qt,

Re: compiling a specific branch with kdebuidl-src failed

2017-11-27 Thread Stéphane Ancelot
Le 27/11/2017 à 15:48, Stéphane Ancelot a écrit : Hi,. I tried to setup a build for branch KDE/5.8 I added next line in ~/.kdesrc-buildrc branch KDE/5.8 branch Plasma/5.8 seems being better . It fails with following message for cmdline "kdesrc-build systemsettings ": cloning

D9019: Plasma: Adjust the calendar toolbar layout

2017-11-27 Thread Alexandr Akulich
akulichalexandr added a task: T7499: Fix plasma calendar applet layout. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9019: Plasma: Adjust the calendar toolbar layout

2017-11-27 Thread Alexandr Akulich
akulichalexandr created this revision. akulichalexandr added a reviewer: Plasma. akulichalexandr added a project: Plasma. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION

compiling a specific branch with kdebuidl-src failed

2017-11-27 Thread Stéphane Ancelot
Hi,. I tried to setup a build for branch KDE/5.8 I added next line in ~/.kdesrc-buildrc branch KDE/5.8 It fails with following message for cmdline "kdesrc-build systemsettings ": cloning kde-build-metadata     Falling back to clone of kde-build-metadata  * Downloading projects.kde.org

D8444: Define default Action when we plug unknown monitor

2017-11-27 Thread Laurent Montel
mlaurent added a comment. @sebas: What do you want as widget design ? Is it ok to add plasma dependancy in kscreen ? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham,

D8827: experimental support for auto mnemonics

2017-11-27 Thread Eike Hein
hein added a comment. How heavy will be all these Shortcut instances? Is that a lot of QObjects? Otherwise it looks pretty good. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8827 To: mart, #plasma Cc: hein, broulik, plasma-devel,

D8444: Define default Action when we plug unknown monitor

2017-11-27 Thread Laurent Montel
mlaurent added a comment. (I was in vacation.) Ok so I need to create an osd plasma for it. I can trash this current patch. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham,

Re: enhancing system settings and dashboard

2017-11-27 Thread Jonathan Riddell
On Mon, Nov 27, 2017 at 03:00:19PM +0100, Stéphane Ancelot wrote: > Hi, > > There are few modifications I would like to try . > > Where is the source code for system settings panel and dashboard menu? In KDE Git https://community.kde.org/Infrastructure/Git

D8641: FormLayout

2017-11-27 Thread Eike Hein
hein added a comment. In general it looks quite good to me. INLINE COMMENTS > FormLayout.qml:66 > + */ > +property bool wideMode: width >= lay.wideImplicitWidth > + Doesn't Kirigami have wideMode logic somewhere else too? > FormLayout.qml:114 > +//NOTE: this is

enhancing system settings and dashboard

2017-11-27 Thread Stéphane Ancelot
Hi, There are few modifications I would like to try . Where is the source code for system settings panel and dashboard menu? Regards, S.Ancelot

Minutes Monday Plasma Hangout

2017-11-27 Thread Sebastian Kügler
The minutes and log, as usual -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 31-7-2017 Present: kbroulik, Sho_, d_ed, bshah, notmart, eang, andris, sebas kbroulik: * I just merged Kate jump list actions support, you should now get kate sessions (if you use them) show

D8939: Offset the scrollbar by the header size

2017-11-27 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R169:6d5e1dc22070: Offset the scrollbar by the header size (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8939?vs=23004=23005 REVISION DETAIL

D8641: FormLayout

2017-11-27 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R169:adf62671e39e: adress small issues (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8641?vs=22997=23006#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D8641: FormLayout

2017-11-27 Thread Marco Martin
mart updated this revision to Diff 23008. mart added a comment. - an early prototype of a FormLayout - Form->FormData - add gallery page - make FormLayout a template - use Headings for all the titles - remove some redundant code - support for dynamic elements - add heuristic to

D8641: FormLayout

2017-11-27 Thread Marco Martin
mart reopened this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein, davidedmundson Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ngiannip, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8939: Offset the scrollbar by the header size

2017-11-27 Thread Marco Martin
mart accepted this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D8939 To: apol, #kirigami, mart, ngraham, abetts Cc: colomar, plasma-devel, ngiannip, apol, davidedmundson, mart, hein

D8939: Offset the scrollbar by the header size

2017-11-27 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 23004. apol added a comment. correct the bottom margin REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8939?vs=22727=23004 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8939 AFFECTED FILES

D8641: FormLayout

2017-11-27 Thread Marco Martin
mart updated this revision to Diff 22997. mart marked 14 inline comments as done. mart added a comment. - an early prototype of a FormLayout - Form->FormData - add gallery page - make FormLayout a template - use Headings for all the titles - remove some redundant code - support for

D8493: Make Folder View screen aware

2017-11-27 Thread Andras Mantia
amantia added a comment. @davidedmundson Any comments? If not, I will push this tomorrow. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni,

D8982: Qml controls for kcm creation

2017-11-27 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in SimpleKCM.qml:23 > > but i think the scrolling should be handed by the qml part. > > Why? 3 reasons: 1. because the long term goal is to get rid of the qwidget version, so even if it's long down the road things should be

D8982: Qml controls for kcm creation

2017-11-27 Thread Marco Martin
mart marked 10 inline comments as done. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8982 To: mart, #plasma, hein, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D8982: Qml controls for kcm creation

2017-11-27 Thread Marco Martin
mart updated this revision to Diff 22996. mart added a comment. - documentation REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8982?vs=22897=22996 BRANCH arcpatch-D8982 REVISION DETAIL https://phabricator.kde.org/D8982 AFFECTED FILES

D8858: Fix testWaylandFullscreenShell.

2017-11-27 Thread Christophe Giboudeaux
cgiboudeaux added a comment. ping ! REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8858 To: cgiboudeaux, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart,

D8982: Qml controls for kcm creation

2017-11-27 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > mart wrote in SimpleKCM.qml:23 > yeah, it does that.. > it keeps the qquickwidget small enough so the qwidget scrollbar won't be > there. > which isn't optimal, but i think the scrolling should be handed by the qml > part. > but i think

Kwin build failure

2017-11-27 Thread Rik Mills
This morning on stable 5.11 branch in both Neon and Kubuntu CI Thank you https://build.neon.kde.org/job/xenial_stable_plasma_kwin_bin_amd64/241/console 08:06:59 /workspace/build/autotests/integration/decoration_input_test.cpp: In member function ‘void

D8982: Qml controls for kcm creation

2017-11-27 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D8982#171694, @davidedmundson wrote: > I like the GridView > > Note that we'll want to use that from the WallpaperDialog in Plasma, which isn't a KCM. I don't think it will be a problem though ? yes, those components should

D8987: reparent the font dialog

2017-11-27 Thread Marco Martin
mart abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8987 To: mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8641: FormLayout

2017-11-27 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Still has comments from my original review not replied to. Maybe using the "done" feature in phab, will make it eaiser to track things? Also this needs API

D8986: an early prototype of a FormLayout

2017-11-27 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D8986#171699, @davidedmundson wrote: > What's with this and https://phabricator.kde.org/D8641? uuh, this commit should be in the branch which is feeding https://phabricator.kde.org/D8641? REPOSITORY R169 Kirigami REVISION