This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a8448a9f6959: Also enable shell runner for kicker
(authored by fvogt).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9093?vs=23235&id=23242
REVISION DETAIL
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9093
To: fvogt, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, seb
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:b82e40fb2fc1: [KWindowEffectsPrivateX11] Add reserve()
call (authored by broulik).
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9086?vs=23213&id=23236
REVI
fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Kickoff has the shell runner enabled as part of "extraRunners" as well.
TEST PLAN
Typed in ls, can run ls now.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVI
apol updated this revision to Diff 23233.
apol added a comment.
Fix david's comment
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8917?vs=23202&id=23233
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8917
AFFECTED FILE
graesslin accepted this revision.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9092
To: apol, #frameworks, #plasma, davidedmundson, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mar
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9092
To: apol, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Calling KGlobalAccel::setDefaultShortcut would do few blocking calls one after
the other. T
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D9086
To: broulik, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abet
This revision was automatically updated to reflect the committed changes.
Closed by commit R97:85351d220d83: bluedevil-sendfile: Set option descriptions
for command line help (authored by marten).
REPOSITORY
R97 Bluedevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9079?vs=23201&i
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f1ab8b7ccb91: Don't block all the ksmserver process
when calling kded.loadSecondPhase (authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9090?vs=23224&id=23225#toc
REPOSITORY
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> startup.cpp:431
> +
> +void KSMServer::secondPhaseLoaded()
> +{
maybe secondKDEDPhaseLoaded
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISI
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It's an overly slow call and it gets in the way on a process that needs
to be responsive
TEST PLAN
Still boots
mart added a comment.
ah, you are right, yes, it should do checkcologgroupchanged instead
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8917
To: apol, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in colorscope.cpp:193
> this is when the item changes window and we're not sure we are still in the
> same color set, so i think is ok to keep this signal
yeah, my point was we may /also/ need the colorsChanged signal (via
chec
mart accepted this revision.
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in colorscope.cpp:193
> check here.
this is when the item changes window and we're not sure we are still in the
same color set, so i think is ok to keep this signal
REPOSITORY
R242 Plasma Framewor
drosca accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R97 Bluedevil
REVISION DETAIL
https://phabricator.kde.org/D9079
To: marten, #plasma, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
davidedmundson added a comment.
description needs updating with the new benefits (saving lookups every time)
INLINE COMMENTS
> colorscope.cpp:193
> if (value.window) {
> emit colorGroupChanged();
> }
check here.
REPOSITORY
R242 Plasma Framework (Library)
RE
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.
I will push it for you when it's done (you need a developer account to push).
But actually I thought about it some more and I realized I need to ask you
for some changes in the pa
rjvbb added a comment.
If you read
https://bugreports.qt.io/browse/QTBUG-63792?focusedCommentId=381570 the
take-home message seems to be that the platform theme plugin (and KDE in
general) shouldn't be messing with setStyleName() at all UNLESS asking for a
font with properties that cannot b
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:4779f9564a4a: Suppress unnecessary scroll indicators if
the flickable is a ListView with… (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricat
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9089
To: hein, #plasma, mart, garg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed
hein added a reviewer: garg.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9089
To: hein, #plasma, mart, garg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
hein created this revision.
hein added reviewers: Plasma, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
ListView.atYEnd is notoriously buggy and sometimes will cause indicators
to blink in and out of exi
rdieter added a comment.
If you're going to do this, may as well undo all of
https://phabricator.kde.org/D3616 , and remove the reveal password button from
the lockscreen too ?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7629
To: siteshwarv, #plasma_wo
cryptodude added a comment.
> Why don't you set up the preferred size for the dialogue, and allow the
label to be multi-line?
My laptop is 260 DPI, all the places where preferred size is used are really
not usable for this display. I'm thinking the same goes for people with a
non-standa
ivan added subscribers: jensreuterberg, colomar.
ivan added a comment.
Why don't you set up the preferred size for the dialogue, and allow the label
to be multi-line?
For some reason, this looks really strange to me. Maybe we could ask @colomar
and @jensreuterberg for advice?
REPOSITOR
This revision was automatically updated to reflect the committed changes.
Closed by commit R845:fef23f48913f: Better UI for the "Create a new
vault" button (authored by ivan).
REPOSITORY
R845 Plasma Vault
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9045?vs=23161&id=23219
REVISION
lopatin added a comment.
Where I need to push this? I think that I don't have permissions for this.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8816
To: lopatin, #plasma, hein
Cc: hein, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jens
broulik updated this revision to Diff 23213.
broulik added a comment.
- Take into account that below we're adding 16 additional items from rawData
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9086?vs=23212&id=23213
REVISION DETAIL
https://phabric
broulik edited the test plan for this revision.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D9086
To: broulik, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik created this revision.
broulik added reviewers: Plasma, graesslin.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We know how many items we're going to add to the vector.
REPOSITORY
R278 K
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Can you push this or do you need someone to do it for you?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8816
To: lopatin, #plasma, hein
Cc: hein, mart, plasm
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6effcdf11d1a: [Task Manager] Support places categories
(authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9065?vs=23165&id=23203
REVISION
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9065
To: broulik, #plasma, hein, #vdg, renatoo
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, seb
marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The "--kio", "--ubi" and "--files"options (or their short equivalents) have
no description text set. This doe
apol updated this revision to Diff 23202.
apol added a comment.
Move to tracking parents instead of doing a look-up on every color get
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8917?vs=22664&id=23202
BRANCH
master
REVISION DETAIL
37 matches
Mail list logo
