xuetianweng added a comment.
In https://phabricator.kde.org/D8798#175698, @subdiff wrote:
> Sorry for the long delay on a review.
>
> Can you give a short overview on how the switching works between Xlib and
libinput backend on X? So what's the runtime detection if libinput is
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ec352304d357: Add xf86-input-libinput support for X11
mouse backend. (authored by xuetianweng).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8798?vs=22774=23472#toc
REPOSITORY
R119 Plasma
xuetianweng added a comment.
In https://phabricator.kde.org/D8798#175698, @subdiff wrote:
> Sorry for the long delay on a review.
>
> Can you give a short overview on how the switching works between Xlib and
libinput backend on X? So what's the runtime detection if libinput is
davidedmundson reopened this revision.
davidedmundson added a comment.
Was pushed in a branch, not master. Reopening on phab
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9124
To: mart, #plasma
Cc: davidedmundson, ngraham, apol, plasma-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:84104aa463b1: port to Package::fileUrl (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9169?vs=23430=23464
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d0cbef14cbdd: make packageurlinterceptor as noop as
possible (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
anthonyfieroni updated this revision to Diff 23462.
anthonyfieroni added a comment.
Ability to detect delete on close.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9130?vs=23459=23462
REVISION DETAIL
https://phabricator.kde.org/D9130
anthonyfieroni updated this revision to Diff 23461.
anthonyfieroni added a comment.
Ability to detect delete on close.
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9131?vs=23457=23461
REVISION DETAIL
https://phabricator.kde.org/D9131
AFFECTED
anthonyfieroni updated this revision to Diff 23459.
anthonyfieroni added a comment.
Oh i revert patch, WidgetExplorer is not widget, what DownloadDialog expects
as parent.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9130?vs=23420=23459
anthonyfieroni updated this revision to Diff 23457.
anthonyfieroni added a comment.
Oh i revert patch, DownloadDialog expect Widget as its parent.
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9131?vs=23413=23457
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:fe54adf50ae2: port to Package::fileUrl (authored by mart).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9180?vs=23445=23454
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:aa53860409ac: use the new Package::fileUrl to load from
resources (authored by mart).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9176?vs=23438=23452
hein planned changes to this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4746
To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f75816a33a32: Initialize scale factor to the last scale
factor set on any instance (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9119
To: hein, #plasma, davidedmundson, broulik, mart
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff,
ngraham added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
I didn't; I just subscribed myself by clicking on the "Subscribe" button. No
idea why that would remove Plasma...
REPOSITORY
R108 KWin
BRANCH
fix-quick-tiling-maximize
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:8a2796d280dd: Fix regression from KWin 5.9 regarding
quick tiling (authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
CHANGES SINCE
ngraham added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
And now posting that comment appears to have done the same thing. Bizarre.
REPOSITORY
R108 KWin
BRANCH
fix-quick-tiling-maximize
REVISION DETAIL
https://phabricator.kde.org/D9178
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:da91a5224e48: Add a signal notifying a change in the
names of running activities. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
@ngraham may I ask why you removed Plasma?
REPOSITORY
R108 KWin
BRANCH
fix-quick-tiling-maximize
REVISION DETAIL
https://phabricator.kde.org/D9178
To: graesslin, #kwin, #plasma,
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:08eec037ce07: Refresh when the names of the running
activities change. (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8524
To: hein, #plasma, davidedmundson
Cc: davidedmundson, anthonyfieroni, ivan, plasma-devel, ZrenBot,
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e19529cdeca0: Dont read a config file and then
never use it. (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9177?vs=23439=23446
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9177
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
mvourlakos added a comment.
In https://phabricator.kde.org/D9126#175594, @broulik wrote:
> (I'd be fine with this one liner going in but I'm wondering why it would be
needed in the first place)
are we ok for landing this?
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
BRANCH
fix-quick-tiling-maximize
REVISION DETAIL
https://phabricator.kde.org/D9178
To: graesslin, #kwin, #plasma, davidedmundson
Cc: ngraham, plasma-devel, kwin, bwowk, ZrenBot, progwolff,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
phab/packegeFileUrl
REVISION DETAIL
https://phabricator.kde.org/D9176
To: mart, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
BRANCH
fix-quick-tiling-maximize
REVISION DETAIL
https://phabricator.kde.org/D9178
To: graesslin, #kwin,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R133 KScreenLocker
BRANCH
phab/packegeFileUrl
REVISION DETAIL
https://phabricator.kde.org/D9180
To: mart, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
mart added a reviewer: Plasma.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9176
To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
makes things work when packages are in resources
TEST PLAN
kscreenlocker works again
REPOSITORY
R133
This revision was automatically updated to reflect the committed changes.
Closed by commit R100:b38adfbbb991: Move KGammas KCMInit work to phase 1
of login. (authored by hein).
REPOSITORY
R100 KGamma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9179?vs=23442=23444
REVISION DETAIL
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R100 KGamma
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9179
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
hein created this revision.
hein added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Phase 0 is already after the splash screen is up, so the visual
change will occur during startup either way. It doesn't make
sense to wait around for it
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The regression got introduced with
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:a8be959b8f62: Implement geometry update blocking in
ShellClient (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
CHANGES SINCE LAST
hein created this revision.
hein added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9177
AFFECTED FILES
kcms/access/kcmaccess.cpp
To: hein, #plasma,
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QUrl::fromLocalFile can't be used when packages are qrc
TEST PLAN
plasashell loads correctly with packages from qrc
REPOSITORY
R120 Plasma
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
I like your test plan :D
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/packegeFileUrl
REVISION DETAIL
https://phabricator.kde.org/D9169
To: mart, #plasma,
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Plasmashell literally never checks the X screen, but we expose it in
this scripting system.
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We don't remotely support multihead in plasmashell.
Nor do we support two plasmashells
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
makes things work when packages are in resources
Depends from:
hein added a comment.
Comment added:
https://commits.kde.org/knotifications/9472dc7b9c63d10e5b707d1e3e3c3a24111fbe9d
INLINE COMMENTS
> davidedmundson wrote in knotificationmanager.cpp:136
> QLatin1String * 5
- 6 :P
> davidedmundson wrote in knotificationmanager.cpp:156
> No reason we
subdiff added a comment.
Sorry for the long delay on a review.
Can you give a short overview on how the switching works between Xlib and
libinput backend on X? So what's the runtime detection if libinput is available
or not? Somebody above said mouse kcm is not available without
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:1e048a10f861: Lazy-instanciate and lazy-load
KNotification plugins. (authored by hein).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9165?vs=23426=23427
hein added a comment.
Fixed in
https://commits.kde.org/plasma-desktop/9dfc225ece2758e1b93a4c818e5559ede12a5d72
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot,
hein added a comment.
Ooops, fixing.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol,
davidedmundson accepted this revision.
davidedmundson added inline comments.
INLINE COMMENTS
> knotificationmanager.cpp:160
> +[, ](const KPluginMetaData ) {
> +if (pluginFound) {
> +return false;
please add a comment explaining this.
REPOSITORY
broulik added inline comments.
INLINE COMMENTS
> main.qml:282
>
> -property int oldX: x
> -property int oldY: y
> +readonly property int oldX: x
> +readonly property int oldY: y
This property is being assigned to, it cannot be `readonly`.
>
hein updated this revision to Diff 23426.
hein added a comment.
Add and utilize a X-KDE-KNotification-OptionName field in
KNotificationPlugin to try and avoid more instanciations.
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9165?vs=23417=23426
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
One minor comment, then good to go.
INLINE COMMENTS
> knotificationmanager.cpp:136
> +addPlugin(plugin);
> +} else if (action == QStringLiteral("Taskbar")) {
>
ngraham edited the summary of this revision.
REPOSITORY
R99 KDE Gtk Configuration Tool
REVISION DETAIL
https://phabricator.kde.org/D9163
To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
anthonyfieroni updated this revision to Diff 23420.
anthonyfieroni added a comment.
Take ownership of DownloadDialog. Remove slot that not present.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9130?vs=23336=23420
REVISION DETAIL
hein added a subscriber: Frameworks.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D9165
To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
hein created this revision.
hein added reviewers: Plasma, Frameworks, davidedmundson.
Restricted Application added projects: Plasma, Frameworks.
REVISION SUMMARY
KNotificationManager always instanciates all of its built-in plugins
as well as any externally supplied icons as soon as the first
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.
not really an expert here in the geometry stuff, but it looks in line with
the X code.
REPOSITORY
R108
davidedmundson added inline comments.
INLINE COMMENTS
> applet.cpp:98
> : QObject(0),
> - d(new AppletPrivate(KPluginMetaData(), args.count() > 1 ?
> args[1].toInt() : 0, this))
> + d(new AppletPrivate(KPluginMetaData(), args.count() > 2 ?
> args[2].toInt() : 0, this))
> {
jgrulich edited the summary of this revision.
REPOSITORY
R99 KDE Gtk Configuration Tool
REVISION DETAIL
https://phabricator.kde.org/D9163
To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
jgrulich created this revision.
jgrulich added a reviewer: apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Currently all gtk3 configuration is stored to a config file in ini format,
while
this configuration is
mvourlakos added a comment.
without that line there is the following problem:
if in the combobox list there are also LTR items then when these items are
selected they are aligned to the left and
when the RTL items are selected they are aligned to the right.
By adding that line the
anthonyfieroni updated this revision to Diff 23413.
anthonyfieroni added a comment.
Take ownership of DownloadDialog.
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9131?vs=23339=23413
REVISION DETAIL
https://phabricator.kde.org/D9131
AFFECTED
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Personally I'd have just set a parent when creating the new
KNS3::DownloadDialog.
If someone ever did change this code so it deletes on close, the old code
would have
broulik added a comment.
I don't understand. Isn't this the default and doesn't it automatically
mirror it (`effectiveHorizontalAlignment`)? (I'd be fine with this one liner
going in but I'm wondering why it would be needed in the first place)
REPOSITORY
R242 Plasma Framework (Library)
anthonyfieroni added a comment.
It's called only from here ->
https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/comic/package/contents/ui/configGeneral.qml$91
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D9131
To: anthonyfieroni,
broulik added inline comments.
INLINE COMMENTS
> mart wrote in qmlobject.h:72
> what about a different ctor which does that, but without exposing that enum?
What signature should I use for the constructor?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9141
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:49884b79f95a: [lookandfeel] Only constant globals in
shader code for GL ES compatibility (authored by subdiff).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
66 matches
Mail list logo
