D8756: Forbid more syscalls which could modify the filesystem

bshah added a comment. Hello, It seems this commit doesn't seem to build on arm64 properly: https://build.neon.kde.org/job/xenial_unstable_plasma_kscreenlocker_bin_arm64/1/console I don't exactly understand what's going on. REPOSITORY R133 KScreenLocker REVISION DETAIL

D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3ad4798ca683: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4362 To: broulik, #plasma, davidedmundson Cc: mart, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,

D9216: export org.kde.appmenuview

broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. > Which means unless a user edited this, it's not in their config unless they explicitly added it. If that is so, then I'm all for it \o/ REPOSITORY R108 KWin REVISION DETAIL

D9216: export org.kde.appmenuview

davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. > (I made it the default). You half made it the default It's the default in kwin, it's not in the KCM default. Which means unless a user edited this, it's not in their config

D9216: export org.kde.appmenuview

broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. I'm not saying the current way it's to be configured is good, it's not, it's terrible. I really like the applet approach indeed. Mostly I'm concerned about what'll happen to existing setups when this

D9216: export org.kde.appmenuview

davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. > Imho the button should be there by default and shown if global menu is enabled in settings With that approach: - users have an icon in the previews they can't see on their titlebar,

D9216: export org.kde.appmenuview

broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. Not sure. Imho the button should be there by default and shown if global menu is enabled in settings. I wouldn't want people manually having to fiddle that title bar menu button in there in order for

D9216: export org.kde.appmenuview

mart planned changes to this revision. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. WIP REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9216 To: mart, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D9216: export org.kde.appmenuview

mart created this revision. mart added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY drop the global settings and export the service wich will activate the appmenu kded TEST PLAN adding

D9215: Make Appmenu work based on the presence of a visual representation

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY drop the internal settings InApp,Menu, Decoration but instead export the menu based on the presence of a dbus

Re: Stopping X11 maintenance after Plasma 5.12

Am 2017-12-05 18:07, schrieb Eike Hein: On 12/06/2017 01:31 AM, Martin Flöser wrote: Hi all, this is just an early heads-up that I decided to personally stop any work related to X11 after Plasma 5.12. That is I will not add any new X11 specific code to e.g. KWin and I will not fix any bugs

D9201: Slightly reduce vertical gutter width.

Zren added a comment. Before patch: - `GridView.cellHeight` was `icon.height + text.height + 6 * smallSpacing` - `Loader {id: frameLoader }` was `icon.height + text.height + 5 * smallSpacing`. It also has a `y offset` giving it a `1 * smallSpacing` top margin. After patch: -

D9209: Don't set a window icon in Plasma::Dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R242:78f83f5c7744: Dont set a window icon in Plasma::Dialog (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9209?vs=23520=23523

D9209: Don't set a window icon in Plasma::Dialog

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9209 To: hein, #plasma, #frameworks, davidedmundson, graesslin Cc: broulik, plasma-devel, ZrenBot,

D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine

broulik added a comment. Ping. (Stupid Phab doesn't move this thing to the top in search result because it'd old) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4362 To: broulik, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks,

D9209: Don't set a window icon in Plasma::Dialog

broulik added a comment. +1 I still get an icon for plasma popups in tabbox and present windows REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9209 To: hein, #plasma, #frameworks, davidedmundson, graesslin Cc: broulik, plasma-devel, ZrenBot,

D9126: [RTL] - align properly the selected text for RTL

This revision was automatically updated to reflect the committed changes. Closed by commit R242:71f8f16fea15: [RTL] - align properly the selected text for RTL (authored by mvourlakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: Stopping X11 maintenance after Plasma 5.12

On 12/06/2017 01:31 AM, Martin Flöser wrote: > Hi all, > > this is just an early heads-up that I decided to personally stop any > work related to X11 after Plasma 5.12. That is I will not add any new > X11 specific code to e.g. KWin and I will not fix any bugs related to > X11. I'll do that for

D9209: Don't set a window icon in Plasma::Dialog

hein created this revision. hein added reviewers: Plasma, Frameworks, davidedmundson, graesslin. Restricted Application added projects: Plasma, Frameworks. REVISION SUMMARY Setting a window icon is costly enough to be worth avoiding when it's not actually needed. This is a resurrection

D8738: Add DBus interface to OrientationSensor and a persistent configuration

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH orientation-sensor-dbus REVISION DETAIL https://phabricator.kde.org/D8738 To: graesslin, #kwin, #plasma,

D8787: Fix PWD dialog

abetts added a comment. In https://phabricator.kde.org/D8787#176346, @ivan wrote: > Since VDG has not responded. Can you remove the padding and make the name bold? What was the question exactly? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787

D8787: Fix PWD dialog

ivan added a comment. Since VDG has not responded. Can you remove the padding and make the name bold? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787 To: cryptodude, #plasma, ivan Cc: colomar, jensreuterberg, ngraham, cfeck, plasma-devel, ZrenBot,

D8738: Add DBus interface to OrientationSensor and a persistent configuration

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8738 To: graesslin, #kwin, #plasma, sebas, davidedmundson Cc: anthonyfieroni, plasma-devel, kwin, ZrenBot, progwolff,

D8731: [x11] Add support for automatic screen rotation through XRandR

graesslin abandoned this revision. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Discarding. There seems to not be any interest in this on X11. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8731 To: graesslin, #kwin,

Stopping X11 maintenance after Plasma 5.12

Hi all, this is just an early heads-up that I decided to personally stop any work related to X11 after Plasma 5.12. That is I will not add any new X11 specific code to e.g. KWin and I will not fix any bugs related to X11. I'll do that for 5.12, but not for 5.13. KWin itself is something I

D9207: Don't load KDE platform module in kglobalaccel5

graesslin added a comment. I'm against a risky change here. Especially as this becomes irrelevant with Wayland. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart Cc: graesslin, plasma-devel, #frameworks, ZrenBot,

D9207: Don't load KDE platform module in kglobalaccel5

hein created this revision. hein added reviewers: Plasma, davidedmundson, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I'm not as sure on this one as I was with https://phabricator.kde.org/D9194 and the

D9200: Move touchpad kcm_init phase

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D9200 To: davidedmundson, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D9199: Add missing lower and upper bounds to the rows spinbox.

This revision was automatically updated to reflect the committed changes. Closed by commit R108:06a9a2a468df: Add missing lower and upper bounds to the rows spinbox. (authored by hein). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin CHANGES SINCE LAST

D9193: Don't load KDE platform module in kactivitymanagerd

This revision was automatically updated to reflect the committed changes. Closed by commit R161:f28f917b88d0: Dont load KDE platform module in kactivitymanagerd (authored by hein). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE

D9201: Slightly reduce vertical gutter width.

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. REVISION SUMMARY Allows more rows to fit on screen. Results in less goofy-looking vertical gutters with the default of two text rows (as most labels only have one, it's a lot of dead

D9150: Remove unused module requirement

This revision was automatically updated to reflect the committed changes. Closed by commit R119:744c4e3f18a2: Remove unused module requirement (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9150?vs=23377=23498#toc REPOSITORY R119 Plasma Desktop CHANGES

D9200: Move touchpad kcm_init phase

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Touchpad's kcminit only sets some x atoms on an alrady running X. There's an argument

D9199: Add missing lower and upper bounds to the rows spinbox.

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9199 To: hein, #plasma, graesslin, davidedmundson

D9199: Add missing lower and upper bounds to the rows spinbox.

hein created this revision. hein added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin. REVISION SUMMARY 0 rows makes no sense. Setting than 20 rows make no sense when the number of desktops is limited to

D9193: Don't load KDE platform module in kactivitymanagerd

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R161 KActivity Manager Service BRANCH master REVISION DETAIL https://phabricator.kde.org/D9193 To: hein, #plasma, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9194: Don't load KDE platform module in xembedsniproxy

hein updated this revision to Diff 23493. hein added a comment. Remove David's line. That one can't work because the app's already been instantiated then. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9194?vs=23484=23493 BRANCH master

D9194: Don't load KDE platform module in xembedsniproxy

This revision was automatically updated to reflect the committed changes. Closed by commit R120:23c30cfba92d: Dont load KDE platform module in xembedsniproxy (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9194?vs=23493=23494

D9196: Don't set a window icon for plasmashell

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7672be093de2: Dont set a window icon for plasmashell (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9196?vs=23486=23495 REVISION

D9194: Don't load KDE platform module in xembedsniproxy

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. please remove the useless line. Ideally without running git blame first. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D9196: Don't set a window icon for plasmashell

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D9196 To: hein, #plasma, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9194: Don't load KDE platform module in xembedsniproxy

broulik added inline comments. INLINE COMMENTS > main.cpp:59 > > app.setDesktopSettingsAware(false); > app.setQuitOnLastWindowClosed(false); It was clearly meant to be :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9194 To: hein, #plasma,

D9195: fix wallpaper config and logout screen

broulik added a comment. Can we please not mingle three separate things into one commit REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9195 To: mart, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9124: make packageurlinterceptor as noop as possible

mart updated this revision to Diff 23490. mart added a comment. - use kpackage_install_bundled_package REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23463=23490 BRANCH phab/packegeFileUrl REVISION DETAIL

D9197: experimental support for rcc files loading in kpackage

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY support for the contents/ directory of kpackage to be compressed in an rcc file, new cmake

D9195: fix wallpaper config and logout screen

mart updated this revision to Diff 23487. mart added a comment. - drop unused themes folder REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9195?vs=23485=23487 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9195 AFFECTED FILES

D9195: fix wallpaper config and logout screen

mart edited the summary of this revision. mart edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9195 To: mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9196: Don't set a window icon for plasmashell

hein created this revision. hein added reviewers: Plasma, davidedmundson, mart. Restricted Application added a project: Plasma. REVISION SUMMARY Setting a window icon is surprisingly costly and a decent chunk of startup time. The shell doesn't need one. The only place I could find where

D9195: fix wallpaper config and logout screen

mart added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9195 To: mart, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9195: fix wallpaper config and logout screen

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY in the wallpaper config dialog there was custom code duplicating listing of kpackage, just wrong (if the same wallpaper was installed in more

D9194: Don't load KDE platform module in xembedsniproxy

hein created this revision. hein added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. REVISION SUMMARY xembedsniproxy doesn't do anything that requires it to be aware of KDE GUI settings (colors, style, standard keys, etc). This makes it start a fair

D9193: Don't load KDE platform module in kactivitymanagerd

hein created this revision. hein added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. REVISION SUMMARY kactivitymanagerd doesn't do anything that requires it to be aware of KDE GUI settings (colors, style, standard keys, etc). This makes it start a

Fwd: KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 156 - Still Failing!

Hi Plasma Folks, Please see the below. Kirigami as a Framework is required to be able to be compiled using Qt 5.7 If you could please rectify this that would be great. Cheers, Ben -- Forwarded message -- From: CI System Date: Tue, Dec 5, 2017 at 10:35 PM