D9627: Reduce menu shadows to 25% of the window shadow size

ngraham added a comment. I'm working on the combobox patch, but in my KDE Neon machine, I'm having trouble getting my changes applied when I open the Breeze settings in the Window Decoration KCM. I'm building to /usr and can verify that

D9625: Require Qt 5.9

volkov closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma, graesslin Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9516: [libinput] Add support for switch devices and events

ngraham added a comment. Restricted Application edited projects, added KWin; removed Plasma. Building libinput from source isn't too hard, and maybe then you can test on your hardware? REPOSITORY R108 KWin

D6004: Add method to unlock greeter via consolekit.

tcberner added a comment. Sure. I kind of forgot about it. Sorry. You can find a more current version at https://github.com/freebsd/freebsd-ports-kde/tree/kde5.9-import/security/plasma5-kscreenlocker/files Note, the only needed thing is basically that ck skript. The rest is just

D6004: Add method to unlock greeter via consolekit.

PureTryOut added a comment. Could this be updated? Over at Alpine Linux and postmarketOS we'd love to use this patch as we don't have systemd (but do have consolekit2), but currently it fails to apply. Of course merging it upstream would be the best! REPOSITORY R133 KScreenLocker

Plasma 5.12 LTS delayed

To allow for code which needed Frameworks 5.42 we have delayed Plasma 5.12 LTS release. Beta is now on Monday 15 January. Final tars are made on Thu 2 Feb for a release on Tue 6th Feb. Releases then continue using a fibbonacchi squence of weeks intervals, 1, 1, 2, 3, 5 etc Plasma 5.13 and

D9516: [libinput] Add support for switch devices and events

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9516 To: graesslin, #kwin, #plasma Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9647: Ignore outputOnly QWindows for pointer and touch events

This revision was automatically updated to reflect the committed changes. Closed by commit R108:6ab625ed9770: Ignore outputOnly QWindows for pointer and touch events (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE

D9638: [effects] add 'Slide Desktops' effect

ngraham added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#185720, @graesslin wrote: > Just putting it as an idea: maybe we should just drop the "old" slide desktop effect and replace it with this one? +1

D9647: Ignore outputOnly QWindows for pointer and touch events

broulik accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH internal-window-pointer-ignore-output-only REVISION DETAIL https://phabricator.kde.org/D9647 To: graesslin,

D9647: Ignore outputOnly QWindows for pointer and touch events

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY The idea is to be output

D9618: Don't send keyboard events to QWindows which have outputOnly property set

This revision was automatically updated to reflect the committed changes. Closed by commit R108:f5f1f6ceb49d: Dont send keyboard events to QWindows which have outputOnly property set (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108

D9638: [effects] add 'Slide Desktops' effect

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Just putting it as an idea: maybe we should just drop the "old" slide desktop effect and replace it with this one? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To:

D9638: [effects] add 'Slide Desktops' effect

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Overall code looks good for me and the video looks really promising. I fear it's too late for 5.12, which is a pity. INLINE COMMENTS > slidedesktops.cpp:144 > +QRegion clipRegion =

D9627: Reduce menu shadows to 25% of the window shadow size

ngraham added a comment. Excellent ideas, everyone. I'll see if I can work up something with a combobox. Also with that approach, I can fine-tune the menu shadows for each option to make sure they look good. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL

D9625: Require Qt 5.9

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma, graesslin Cc: graesslin, plasma-devel, ZrenBot, progwolff,

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. > This is good to know. It doesn't look bad right now. Maybe the speed can also clue in the user of what's happening behind. That should be an easier method. So, what do you propose to do?

D9638: [effects] add 'Slide Desktops' effect

abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#185606, @zzag wrote: > In https://phabricator.kde.org/D9638#185547, @abetts wrote: > > > What I would maybe want to add would be some sort of effect,

D9627: Reduce menu shadows to 25% of the window shadow size

rkflx added a comment. @hpereiradacosta +1 Essentially this: https://phabricator.kde.org/D9549#184975 (but a "No" option could be added). REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts

D9627: Reduce menu shadows to 25% of the window shadow size

hpereiradacosta added a comment. In https://phabricator.kde.org/D9627#185615, @ngraham wrote: > Those are valid concerns, and I will think on them! I always admire your thoroughness, @rkflx. > > That said, for upgrades, users who did not manually change the shadow size should get

D9627: Reduce menu shadows to 25% of the window shadow size

ngraham added a comment. Those are valid concerns, and I will think on them! I always admire your thoroughness, @rkflx. That said, for upgrades, users who did not manually change the shadow size should get the new setting since they will not have a config file written out to override

D9627: Reduce menu shadows to 25% of the window shadow size

ngraham retitled this revision from "Reduce menu shadows to half the size of the window shadows" to "Reduce menu shadows to 25% of the window shadow size". REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta,

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

Zren added inline comments. INLINE COMMENTS > broulik wrote in SizeHandle.qml:123 > I don't know exactly how `MouseEventListener` behaves but in `MouseArea` you > get a ton of `onWheel` events for touchpads (which scroll pixel-precisely), > potentially causing you to making your panel enormous

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#185547, @abetts wrote: > What I would maybe want to add would be some sort of effect, darkening, or slight zooming in/out when moving a window from one desktop

D9627: Reduce menu shadows to half the size of the window shadows

rkflx added a comment. Thanks Nate, your blog readership seems to like it too (congratulations on the blog, BTW ;) What about the inevitable "But can I change it back?". You claim we allow this, but if you actually try it, it does not work, i.e. the menu shadow is now almost completely gone

D9643: Support submenus in context menu for systray icon

davidedmundson added a comment. Please fill in the "testing done" field. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D9643: Support submenus in context menu for systray icon

davidedmundson added a comment. > Why don't rely on QDBusTrayIcon? It's internal to Qt. We could fork it like we did with the application menu, but then that's no easier than maintaining our current code. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D9637: Add jump list action for "Updates"

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I like this, seems very intuitive, in a corner, less thinking in selecting the item. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9637 To:

D9627: Reduce menu shadows to half the size of the window shadows

abetts accepted this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9637: Add jump list action for "Updates"

ngraham added a comment. Ooh I love this. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9637 To: broulik, #plasma, apol, #vdg Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to half the size of the window shadows

ngraham edited reviewers, added: abetts; removed: apol. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9201: Slightly reduce vertical gutter width.

Zren added a comment. I don't think I can attach a new diff to your differential, so here's a link to it: https://phabricator.kde.org/differential/diff/24677/?revisionID=9201 Here's an example without the outlines. 1080p with 32px panel on bottom and IconSize=3 (1 smaller than

D9627: Reduce menu shadows to half the size of the window shadows

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ship it. Thanks ! REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, apol, hpereiradacosta Cc:

D9643: Support submenus in context menu for systray icon

volkov added a comment. BTW, why do we need to support KDEPlatformSystemTrayIcon? Why don't rely on QDBusTrayIcon? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin Cc: plasma-devel, ZrenBot,

D9643: Support submenus in context menu for systray icon

volkov added reviewers: Plasma, graesslin. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9641: [Digital Clock] Add tooltip for agenda items with too long description

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9641 To: broulik, #plasma, #vdg, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9638: [effects] add 'Slide Desktops' effect

abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. This is great work. I like the results. I like the gap as well. It makes for a good idea of separation. What I would maybe want to add would be some sort of effect, darkening, or slight zooming in/out

D9627: Reduce menu shadows to half the size of the window shadows

ngraham marked an inline comment as done. ngraham added a comment. Thanks for the advice, Hugo. Menu shadows now match the screenshot in the prior patch that people liked and that https://phabricator.kde.org/tag/vdg/ approved. REPOSITORY R31 Breeze REVISION DETAIL

D9627: Reduce menu shadows to half the size of the window shadows

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, apol, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9641: [Digital Clock] Add tooltip for agenda items with too long description

broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9641 To: broulik, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to half the size of the window shadows

ngraham updated this revision to Diff 24674. ngraham added a comment. - Change scale factor in both places - Use a variable to score the scale factor - Default to 25% for the scale, to match the prior patch's screenshot (which people really liked, and VGD agreed to) REPOSITORY R31

D9638: [effects] add 'Slide Desktops' effect

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg,

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. I've made this effect because I am very disappointed with the Slide effect. Let me list some of the biggest problems with slide effect: - It's not intuitive - It has poor(like my English)

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Motivation behind this effect and demos will be soon. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: plasma-devel, kwin, iodelay, bwowk,

D9638: [effects] add 'Slide Desktops' effect

zzag created this revision. zzag added reviewers: VDG, KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY Slide Desktops animates switching

D9627: Reduce menu shadows to half the size of the window shadows

hpereiradacosta added a comment. Hi thanks for the patch ! ... see inline comment. Also note that to more or less match the different scales shown in your original screenshot, you would need a 0.25% scale (or even 0.20%) rather than 0.5% But I am also fine with the current

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.9/20/ Project: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 03 Jan 2018 11:07:57 + Build duration: 21 min and counting JUnit Tests

D9625: Require Qt 5.9

volkov retitled this revision from "Require Qt 5.7" to "Require Qt 5.9". volkov edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma Cc: graesslin, plasma-devel, ZrenBot,

D9625: Require Qt 5.7

volkov updated this revision to Diff 24659. volkov added a comment. move to master Require Qt 5.7 -> Require Qt 5.9 REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9625?vs=24637=24659 BRANCH master REVISION DETAIL

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.9/16/ Project: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 03 Jan 2018 11:07:57 + Build duration: 13 min and counting JUnit Tests

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

broulik updated this revision to Diff 24657. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9631?vs=24649=24657 REVISION DETAIL https://phabricator.kde.org/D9631 AFFECTED FILES libdbusmenuqt/dbusmenuimporter.cpp To: broulik, #plasma,

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.9 - Build # 77 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/77/ Project: Plasma kwayland kf5-qt5 SUSEQt5.9 Date of build: Wed, 03 Jan 2018 11:07:57 + Build duration: 8 min 42 sec and counting JUnit Tests Name:

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Plasma kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 03 Jan 2018 11:07:57 + Build duration: 8 min 43 sec and counting JUnit Tests

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9631 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 - Build # 19 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.9/19/ Project: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 03 Jan 2018 10:44:37 + Build duration: 3 min 9 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.9 - Build # 76 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/76/ Project: Plasma kwayland kf5-qt5 SUSEQt5.9 Date of build: Wed, 03 Jan 2018 10:44:37 + Build duration: 56 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.9/15/ Project: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 03 Jan 2018 10:44:37 + Build duration: 31 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Plasma kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 03 Jan 2018 10:44:37 + Build duration: 22 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.9/18/ Project: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 03 Jan 2018 10:39:47 + Build duration: 3 min 5 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.9/14/ Project: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 03 Jan 2018 10:39:47 + Build duration: 29 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.9 - Build # 75 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/75/ Project: Plasma kwayland kf5-qt5 SUSEQt5.9 Date of build: Wed, 03 Jan 2018 10:39:48 + Build duration: 51 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.9 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Plasma kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 03 Jan 2018 10:39:47 + Build duration: 47 sec and counting CONSOLE OUTPUT

D9599: Create interface for passing server decoration palettes

This revision was automatically updated to reflect the committed changes. Closed by commit R127:dec26d932914: Create interface for passing server decoration palettes (authored by davidedmundson). Restricted Application edited projects, added Plasma on Wayland; removed Plasma. CHANGED PRIOR TO

D9633: Add a private libPlasmaWeatherSolar for the ion data engines

kossebau added a comment. Better ideas very welcome, this is just a desperate first shot at the challenge. (Yes, right in time before feature freeze, boh me. One could also claim though it is rather a late Plasma5 porting regression fix ;) ) REPOSITORY R120 Plasma Workspace REVISION

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

davidedmundson added inline comments. INLINE COMMENTS > dbusmenuimporter.cpp:436 > auto menu = action->menu(); > connect(menu, ::aboutToShow, this, [menu, this]() { > +updateMenu(menu); This needs to be a unique connection see

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9631 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9618: Don't send keyboard events to QWindows which have outputOnly property set

broulik accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH internal-window-ignore-keyboard-output-only REVISION DETAIL https://phabricator.kde.org/D9618 To: graesslin,