D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

fvogt closed this revision. fvogt added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fixed up the trailing whitespace in line 165 and landed: https://commits.kde.org/kwin/eb69e87288d37fdb13eca32ca807ed8279f912af REPOSITORY R108 KWin REVISION DETAIL

KDE CI: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kinfocenter%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 07:54:12 + Build duration: 44 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kinfocenter%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 07:51:42 + Build duration: 1 min 20 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kinfocenter%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 07:21:35 + Build duration: 2 min 32 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kinfocenter%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 07:18:42 + Build duration: 2 min 43 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kdeplasma-addons%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 06:49:37 + Build duration: 2 min 42 sec and counting CONSOLE

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9873 To: fvogt, #plasma, graesslin Cc: kwin,

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 104 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/104/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 02:40:39 + Build duration: 2 min 7 sec and counting CONSOLE OUTPUT

D9868: Rename Discover's "Home" page to "Featured"

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f9515410f251: Rename Discovers Home page to Featured (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9868?vs=25349=25362

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 103 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/103/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 02:18:39 + Build duration: 2 min 17 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 102 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/102/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 02:06:54 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 101 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/101/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 01:57:24 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 100 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/100/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 01:42:45 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 99 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/99/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 01:41:24 + Build duration: 1 min 10 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 98 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/98/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 15 Jan 2018 01:25:39 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT

D9868: Rename Discover's "Home" page to "Featured"

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH arcpatch-D9868 REVISION DETAIL https://phabricator.kde.org/D9868 To: ngraham, apol, #discover_software_store Cc: ankits, plasma-devel, ZrenBot, progwolff,

Re: KDE and Google Summer of Code 2018

I'm very discouraged to see so little movement on this. After skipping GCi this past fall, are we now also considering skipping GSoC? Or downsizing the number of students we are mentoring? Without Ideas we will not get students. More important, we must complete the Org application soon, and the

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#191008, @zzag wrote: > In https://phabricator.kde.org/D9848#190964, @luebking wrote: > > > I'm not actually smiling ... > > > > Anyway, instead of

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190964, @luebking wrote: > I'm not actually smiling ... > > Anyway, instead of using three vectors it's strongly suggest to use one vector (or rather array)

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

luebking added a comment. Restricted Application edited projects, added Plasma; removed KWin. I'm not actually smiling ... Anyway, instead of using three vectors it's strongly suggest to use one vector (or rather array) of a struct. a) you can access the inner values by names b) it's

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190676, @romangg wrote: > In https://phabricator.kde.org/D9848#190644, @anemeth wrote: > > > .arcconfig is not needed here > > > Your current patch

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

fvogt updated this revision to Diff 25351. fvogt added a comment. Restricted Application edited projects, added KWin; removed Plasma. Move the added functions from the class into the xkb.cpp's static scope. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

fvogt added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9873#190789, @graesslin wrote: > I wasn't aware of this secure_getenv functionality. Me neither... > Is that also in place after the process has

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. > (Or how can I see the previous patch in this messy review tool Under "Revision Contents" is a "History" tab. > which draws an entire core when typing...) :D REPOSITORY R108 KWin

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

luebking added a comment. Restricted Application edited projects, added KWin; removed Plasma. Why was that a problem? (Or how can I see the previous patch in this messy review tool which draws an entire core when typing...) REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 6 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik,

KDE CI: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kdeplasma-addons%20kf5-qt5%20FreeBSDQt5.9/12/ Project: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 14 Jan 2018 20:30:48 + Build duration: 2 min 16 sec and counting CONSOLE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25350. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Reverted the change of putting the blur strength configuration into a vector, because it resulted in some complications. Doing it with the huge switch

D9868: Rename Discover's "Home" page to "Featured"

ngraham updated this revision to Diff 25349. ngraham added a comment. "Featured Apps" -> "Featured" REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9868?vs=25293=25349 BRANCH arcpatch-D9868 REVISION DETAIL

D9872: [weather] Show optionally temperature next to icon in compact mode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:ad04c42b28d1: [weather] Show optionally temperature next to icon in compact mode (authored by kossebau). REPOSITORY

D9868: Rename Discover's "Home" page to "Featured"

ngraham retitled this revision from "Rename Discover's "Home" page to "Featured apps"" to "Rename Discover's "Home" page to "Featured"". ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9868 To: ngraham,

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 97 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/97/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 14 Jan 2018 20:25:33 + Build duration: 3 min 16 sec and counting CONSOLE OUTPUT

D9850: Remove redundant changeLog field

This revision was automatically updated to reflect the committed changes. Closed by commit R134:fad964d9a0b9: Remove redundant changeLog field (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9850?vs=25292=25347 REVISION

D9868: Rename Discover's "Home" page to "Featured apps"

apol added a comment. Okay, makes sense. Can you leave it at just "Featured"? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9868 To: ngraham, apol, #discover_software_store Cc: ankits, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9879: [effects/blur] Disable texture cache on Wayland

luebking added a comment. Restricted Application edited projects, added KWin; removed Plasma. On a general note, UI-wise: if there's no way to ever enable an item it should not be shown anyway. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9879 To: graesslin, #kwin,

D9879: [effects/blur] Disable texture cache on Wayland

graesslin updated this revision to Diff 25345. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Hide option instead of disable it REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9879?vs=25343=25345 BRANCH

D9874: Fix executable name in README

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9874 To: pali, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9850: Remove redundant changeLog field

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. On ArchLinux the changelog field is empty/unused. REPOSITORY R134 Discover Software Store BRANCH arcpatch-D9850 REVISION DETAIL https://phabricator.kde.org/D9850 To: ngraham, apol,

D9879: [effects/blur] Disable texture cache on Wayland

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9879#190916, @graesslin wrote: > Also disable the cache blur checkbox on Wayland ah no, that's a stupid idea. The load call enables it again. I'll hide

D9879: [effects/blur] Disable texture cache on Wayland

graesslin updated this revision to Diff 25343. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Also disable the cache blur checkbox on Wayland REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9879?vs=25342=25343

D9868: Rename Discover's "Home" page to "Featured apps"

ngraham added a comment. Sure, we could do Applications instead of Apps. The problem with "Home" as well as "Discover" is that is conveys no information about what its content is. Users want to know: "What am I seeing here?" They're seeing a list of featured/curated apps, but they don't

D9868: Rename Discover's "Home" page to "Featured apps"

apol added a comment. Why "Apps"? How about we change it to "Discover" instead of "Home"? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9868 To: ngraham, apol, #discover_software_store Cc: ankits, plasma-devel, ZrenBot, progwolff, lesliezhai,

D9879: [effects/blur] Disable texture cache on Wayland

broulik added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > blur_config.cpp:42 > +if (KWindowSystem::isPlatformWayland()) { > +ui.kcfg_CacheTexture->setEnabled(false); > +} Shouldn't it hide or at least disable the check

D9872: [weather] Show optionally temperature next to icon in compact mode

kossebau added a comment. Given the feature freeze tomorrow, this being a non-critical feature at the outer spheres of plasma, the feature itself making sense surely, and being the de-facto maintainer of the weather applet code, I decided to just push this now. I have had run most of the

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anthonyfieroni added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > blur.cpp:94 > delete shader; > -delete target; > +shader = NULL; > + m_simpleTarget should be deleted too > blur.cpp:96-104 > +for (int i = 0; i <

D9879: [effects/blur] Disable texture cache on Wayland

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190882, @broulik wrote: > > There are some rendering artifacts, when intermediate rendering results shall be saved. > > That feature has shown to be

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. > There are some rendering artifacts, when intermediate rendering results shall be saved. That feature has shown to be flaky numerous times and is, I think, still broken on Wayland

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 60 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/60/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 14 Jan 2018 18:22:48 + Build duration: 2 min 41 sec and counting CONSOLE

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

broulik created this revision. broulik added reviewers: Plasma, hein, graesslin, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Notifications do not show up on top of full

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added a comment. Restricted Application edited projects, added Plasma; removed KWin. It works on my main PC. There are some rendering artifacts, when intermediate rendering results shall be saved. To reproduce: put a window with different color to background halfway under the sound

D9792: even slimmer scrollbars

hpereiradacosta added inline comments. INLINE COMMENTS > breezestyle.cpp:5016 > +// in case this QStyle is used by QQuickControls QStyle wrapper > +else if( option->styleObject ) widgetMouseOver = > option->styleObject->property("hover").toBool(); > + Ok. Just checked: this

Re: Review Request 121010: Keep track of notifications that were covered by a fullscreen window

> On Nov. 6, 2014, 12:12 nachm., Martin Flöser wrote: > > applets/notifications/plugin/notificationshelper.cpp > > Lines 169-173 (patched) > > > > > > note: this code causes roundtrips to the X server. At the

D9803: Apply some C++11 niceties, styling consistency

Kanedias closed this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9872: [weather] Show optionally temperature next to icon in compact mode

kossebau updated this revision to Diff 25326. kossebau added a comment. Align label text size twisting more with the one of fuzzyclock REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9872?vs=25307=25326 BRANCH

D9803: Apply some C++11 niceties, styling consistency

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH c++11 REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9792: even slimmer scrollbars

colomar added a comment. Dunno why I only noticed it now, but of course then this is not the right place to fix it. Sorry for the noise. REPOSITORY R31 Breeze BRANCH arcpatch-D9792 REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta,

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. I wasn't aware of this secure_getenv functionality. Is that also in place after the process has completely dropped all privs? INLINE COMMENTS > xkb.h:121-127 > +static bool

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190775, @romangg wrote: > I'm trying to test this. In Konsole it does not seem to blur anything at all. Read something about setting xprop dbus signal to

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added a comment. Restricted Application edited projects, added Plasma; removed KWin. I'm trying to test this. In Konsole it does not seem to blur anything at all. Read something about setting xprop dbus signal to Konsole. Then it was blurred but a change of blur strength in the

D9876: Add support for apply initial shortcut window rule

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > blur.cpp:35 > > +#define BORDER_SIZE 5 > + `static const` and in the KWin namespace please. Also camel case then. > blur.cpp:139 > + * > + * The texture blur amount is

D9275: fix RTL appearance for ComboBox

safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > +LayoutMirroring.enabled: true > +LayoutMirroring.childrenInherit: true So it is true even for LTR locales? REPOSITORY R242 Plasma Framework (Library)

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190606, @mvourlakos wrote: > To test it in Latte I added in the head of /shell/package/contents/configuration/AppearanceConfig.qml > > import org.kde.plasma.components 3.0 as PlasmaComponents3 > > > and I set

D9875: Extend parsing ssh prompt

pali created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. pali requested review of this revision. REVISION SUMMARY - Add support for yes/no questions from ssh-agent and openssh client - Add support for more openssh

D9874: Fix executable name in README

pali created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. pali requested review of this revision. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9874 AFFECTED FILES README To:

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

fvogt created this revision. fvogt added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin. fvogt requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY

D9872: [weather] Show optionally temperature next to icon in compact mode

kossebau added a comment. Looks like this when enabled on the panels (tooltip shown for one on right panel): F5648962: Screenshot_20180114_124441.png Would really, really like to get this in for 5.12 :) All the layout logic might be a little

D9872: [weather] Show optionally temperature next to icon in compact mode

kossebau created this revision. kossebau added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Adds the logic for showing an alternative component

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190644, @anemeth wrote: > .arcconfig is not needed here Your current patch would delete the .arcconfig file from the KWin repo when being pushed. Do

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 2 inline comments as done. anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > romangg wrote in blur.h:29 > Put this into the cpp. Why? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25305. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Moved pointer initialization to the header file. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25300=25305

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. > .arcconfig is not needed here and I re-added the whitespace to match the old version. git-checkout `.arcconfig` from parent commit. REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > blurshader.cpp:58 > +GLShader *m_shaderUpsample = nullptr; > +GLShader *m_shaderCopysample = nullptr; > + No, it should be in the header file. E.g. ... private:

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 8 inline comments as done. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190515, @romangg wrote: > In https://phabricator.kde.org/D9848#190128, @anemeth wrote: > > > Removed .arcconfig

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 54 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/54/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 14 Jan 2018 10:20:27 + Build duration: 3 min 7 sec and counting CONSOLE OUTPUT

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

This revision was automatically updated to reflect the committed changes. Closed by commit R108:85ef2831dbc1: Do not call into NETWinInfo in AbstractClient::setSkipPager (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25300. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Changed all references of NULL to nullptr REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25290=25300 BRANCH

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

This revision was automatically updated to reflect the committed changes. Closed by commit R108:42b099355c80: Add support for initial apply rules for skip (taskbar|pager|switcher) (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin

D9792: even slimmer scrollbars

hpereiradacosta added a comment. In https://phabricator.kde.org/D9792#190540, @ngraham wrote: > In https://phabricator.kde.org/D9792#190538, @colomar wrote: > > > Looks great! > > My only concern would be that in the mouseover state the contrast between the grip and groove is

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Also, I would consider using smart pointers(e.g. `QScopedPointer`). INLINE COMMENTS > blur.cpp:92 > +delete m_simpleTarget; > +m_simpleTarget = NULL; > + Please use `nullptr`. >

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. In https://phabricator.kde.org/D9275#190594, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote: > > > with your example me I cant reproduce it either... > > I can only reproduce it with Latte Settings window, all other

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote: > with your example me I cant reproduce it either... > I can only reproduce it with Latte Settings window, all other components are aligned correctly except the PlasmaComponent3.Combobox list

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

graesslin added a dependent revision: D9870: Add support for apply initial keep above/below window rules. REPOSITORY R108 KWin BRANCH shell-client-skip-rules REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma, hein Cc: plasma-devel, kwin, ZrenBot, progwolff,

D9870: Add support for apply initial keep above/below window rules

graesslin added a dependency: D9866: Add support for initial apply rules for skip (taskbar|pager|switcher). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9870 To: graesslin, #kwin, #plasma Cc:

D9870: Add support for apply initial keep above/below window rules

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 68 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/68/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 14 Jan 2018 08:25:25 + Build duration: 11 min and counting JUnit Tests

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. In https://phabricator.kde.org/D9275#190547, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote: > > > how did you test it? > > > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"... > > If