D9998: Actually quit threads nicely

fvogt added inline comments. INLINE COMMENTS > ivan wrote in ResourceScoreMaintainer.cpp:62 > If that is enough, then why not just `wait()`? Simple: `wait()` waits for an infinite amount of time if `run()` never returns. If that happens (`run()` is stuck), we prefer a crash over silently

D9998: Actually quit threads nicely

This revision was automatically updated to reflect the committed changes. Closed by commit R161:ed092b96f7af: Actually quit threads nicely (authored by fvogt). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9998?vs=25709=25737 REVISION

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/31/ Project: Plasma libksysguard kf5-qt5 SUSEQt5.9 Date of build: Mon, 22 Jan 2018 07:06:59 + Build duration: 5 min 5 sec and counting CONSOLE OUTPUT

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 22 Jan 2018 07:06:59 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT

Re: Fwd: KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 11 - Still Failing!

On Sonntag, 21. Jänner 2018 22:40:31 CET Ben Cooksley wrote: > On Mon, Jan 22, 2018 at 10:15 AM, Martin Koller wrote: > > Hi, > > Hi Martin, > > > > > On Sonntag, 21. Jänner 2018 20:43:42 CET Ben Cooksley wrote: > >> Hi Martin, > >> > >> Looks like your latest commit to

Re: KDE and Google Summer of Code 2018

On Sun, Jan 21, 2018 at 7:25 PM, Albert Astals Cid wrote: > El divendres, 19 de gener de 2018, a les 10:42:44 CET, Marco Martin va > escriure: > > On Mon, Jan 15, 2018 at 8:15 PM, Nate Graham > wrote: > > > I've submitted an idea for System Settings:

KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20SUSEQt5.9/12/ Project: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 Date of build: Sun, 21 Jan 2018 23:10:07 + Build duration: 5 min 52 sec and counting JUnit Tests Name:

D9998: Actually quit threads nicely

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Otherwise +1 REPOSITORY R161 KActivity Manager Service BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D9998 To: fvogt, #plasma, ivan, anthonyfieroni Cc: lbeltrame,

KDE CI: Plasma ksshaskpass kf5-qt5 FreeBSDQt5.9 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Plasma ksshaskpass kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 21 Jan 2018 23:10:07 + Build duration: 1 min 11 sec and counting

D9998: Actually quit threads nicely

ivan added inline comments. INLINE COMMENTS > lbeltrame wrote in ResourceScoreMaintainer.cpp:62 > Same as above. If that is enough, then why not just `wait()`? REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D9998 To: fvogt, #plasma, ivan,

Re: Fwd: KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 11 - Still Failing!

On Mon, Jan 22, 2018 at 10:15 AM, Martin Koller wrote: > Hi, Hi Martin, > > On Sonntag, 21. Jänner 2018 20:43:42 CET Ben Cooksley wrote: >> Hi Martin, >> >> Looks like your latest commit to ksshaskpass doesn't build. >> Could you please take a look? > > I don't understand this. >

Re: Fwd: KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 11 - Still Failing!

Hi, On Sonntag, 21. Jänner 2018 20:43:42 CET Ben Cooksley wrote: > Hi Martin, > > Looks like your latest commit to ksshaskpass doesn't build. > Could you please take a look? I don't understand this. Why does my new line fail QRegularExpression re3a("^(Password|Username) for

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 21 Jan 2018 20:09:01 + Build duration: 10 min and counting JUnit Tests

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 21 Jan 2018 19:49:31 + Build duration: 8 min 34 sec and counting CONSOLE OUTPUT

Fwd: KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 11 - Still Failing!

Hi Martin, Looks like your latest commit to ksshaskpass doesn't build. Could you please take a look? Cheers, Ben -- Forwarded message -- From: CI System Date: Mon, Jan 22, 2018 at 8:40 AM Subject: KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 11 -

KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20SUSEQt5.9/11/ Project: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 Date of build: Sun, 21 Jan 2018 19:38:58 + Build duration: 1 min 5 sec and counting CONSOLE OUTPUT

Re: KDE and Google Summer of Code 2018

El divendres, 19 de gener de 2018, a les 10:42:44 CET, Marco Martin va escriure: > On Mon, Jan 15, 2018 at 8:15 PM, Nate Graham wrote: > > I've submitted an idea for System Settings: Improve handling for touchpads > > and mice with Libinput > > Speaking of systemsettings,

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 65 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/65/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 21 Jan 2018 18:09:13 + Build duration: 23 min and counting JUnit Tests Name: (root)

D9930: Require libinput version 1.9

tcberner added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9930#194036, @graesslin wrote: > In https://phabricator.kde.org/D9930#193993, @tcberner wrote: > > > Hi there > > > > This breaks the CI on FreeBSD, where

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 64 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/64/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 21 Jan 2018 18:04:37 + Build duration: 3 min 38 sec and counting CONSOLE OUTPUT

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

Hi, > I think you've only half analysed this. If nothing is really listening on > DBus it will fall back to legacy X which will work on XFCE. Where did I miss this in the code? The createPlatformSystemTrayIcon() functions in qtbase/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fredrik wrote in blur.cpp:255 > Does calling effects->addRepaintFull() also work? It does. Changed to that. REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25720. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Implemented the changes suggested by @fredrik REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25643=25720 BRANCH

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 3 inline comments as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added a comment. Restricted Application edited projects, added KWin; removed Plasma. I haven't looked at everything in detail, but in general I think this looks ready to land. Just a couple of nitpicks, and a question below. INLINE COMMENTS > anemeth wrote in blur.cpp:145 > Ok

D9930: Require libinput version 1.9

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9930#193993, @tcberner wrote: > Hi there > > This breaks the CI on FreeBSD, where we only have libinput 1.6 > > 10:17:48 -- Could NOT find Libinput:

D10002: Improve header and screenshots

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10002 To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10002: Improve header and screenshots

apol accepted this revision. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10002 To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9892: cmake: Use the official CMake variable for building as a static plugin.

croick added inline comments. INLINE COMMENTS > CMakeLists.txt:69 > +if (PLASMA_ENABLED) > +install(DIRECTORY styles/Plasma DESTINATION > ${KDE_INSTALL_QMLDIR}/org/kde/kirigami.2/styles) > +endif() When trying to install it using kdesrc-build, it complains about not finding

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190176, @graesslin wrote: > I would like to see this reviewed by @fredrik, @mart , @davidedmundson and in general the https://phabricator.kde.org/tag/vdg/

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

>Following the initialisation I now see that the Qt5 systray set-up fails because there's nothing listening on the DBus I think you've only half analysed this. If nothing is really listening on DBus it will fall back to legacy X which will work on XFCE. You'll get into this situation if you have

D9930: Require libinput version 1.9

tcberner added a comment. Restricted Application edited projects, added KWin; removed Plasma. Hi there This breaks the CI on FreeBSD, where we only have libinput 1.6 10:17:48 -- Could NOT find Libinput: Found unsuitable version "1.6.0", but required is at least "1.9" (found

D9998: Actually quit threads nicely

fvogt updated this revision to Diff 25709. fvogt added a comment. Add comments to explain the magic values REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9998?vs=25694=25709 BRANCH Plasma/5.12 REVISION DETAIL

D9998: Actually quit threads nicely

lbeltrame added inline comments. INLINE COMMENTS > fvogt wrote in Resources.cpp:60 > It's the `// initial delay before processing the events` plus some time for > it to process the last request. I can add a comment if you want to. A comment would do (so that it is less "magic"). REPOSITORY

D9998: Actually quit threads nicely

fvogt added inline comments. INLINE COMMENTS > lbeltrame wrote in Resources.cpp:60 > What's the reason for 1500 here? It's the `// initial delay before processing the events` plus some time for it to process the last request. I can add a comment if you want to. REPOSITORY R161 KActivity

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 63 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/63/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 21 Jan 2018 10:16:13 + Build duration: 6 min 43 sec and counting CONSOLE OUTPUT

D9930: Require libinput version 1.9

This revision was automatically updated to reflect the committed changes. Closed by commit R108:4cc1d7a24546: Require libinput version 1.9 (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9980: Do not reset the size of window once we move it to an edge

graesslin added a comment. I took care of the auto test with https://commits.kde.org/kwin/0d2a34172357c016f74f5374e6db1785e7739f11 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9980 To: jgrulich, graesslin Cc: ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk,

DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

Hi, I'm running a simple XFCE environment on a Unix rig (not Linux) and thought some dependency was missing because the xfce4-panel notification area remained empty - until I noticed that it works just fine when GTk2 applications try to use it. Following the initialisation I now see that the

KDE CI: Plasma ksshaskpass kf5-qt5 FreeBSDQt5.9 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Plasma ksshaskpass kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 21 Jan 2018 09:27:08 + Build duration: 1 min 23 sec and counting CONSOLE OUTPUT

KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20SUSEQt5.9/10/ Project: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 Date of build: Sun, 21 Jan 2018 09:27:08 + Build duration: 1 min 18 sec and counting CONSOLE OUTPUT

D9998: Actually quit threads nicely

lbeltrame added inline comments. INLINE COMMENTS > Resources.cpp:60 > +requestInterruption(); > +wait(1500); > } What's the reason for 1500 here? > ResourceScoreMaintainer.cpp:62 > +requestInterruption(); > +wait(1500); > } Same as above. REPOSITORY R161 KActivity Manager

D9072: make ksshaskpass work with git-lfs

This revision was automatically updated to reflect the committed changes. Closed by commit R105:37aa02a33a86: make it work with with git-lfs (authored by mkoller). REPOSITORY R105 KDE SSH Password Dialog CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9072?vs=23181=25706 REVISION