D10038: Use QTemporaryDir::filePath() instead of path concatenation

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10038 To: volkov, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

Re: Powerdevil bug help needed

On Wed, Feb 7, 2018 at 10:47 PM, Ongun Kanat wrote: > Hello devs, > > I'm trying to contribute by fixing a small bug. I'm proficient with > C++ and pretty much used to debug C++ programs with Qt Creator. I've > managed to build full plasma desktop into a directory in my

Powerdevil bug help needed

Hello devs, I'm trying to contribute by fixing a small bug. I'm proficient with C++ and pretty much used to debug C++ programs with Qt Creator. I've managed to build full plasma desktop into a directory in my home using kdesrc-build. and set environment correctly Now I can launch latest git

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham added a comment. Is this committable? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

Default SDDM and KScreenLocker backgrounds

Howdy Plasma folks! VDG has managed to achieve a consensus regarding a desired change in the default SDDM and KScreenLocker backgrounds. The current default is a flat blue color; we would like to change them both to use the current default Plasma background. We believe this addresses all

D10362: Swap reveal password button logic

elvisangelaccio added a comment. Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). Would it be possible to implement this feature like in the Windows 10 lock screen? (i.e. don't toggle the state; reveal the password

D10296: Make it possible to compile 5.12 branch with a kdecoration from master

This revision was automatically updated to reflect the committed changes. Closed by commit R108:8245a74b31dc: Make it possible to compile 5.12 branch with a kdecoration from master (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10142 To: graesslin, #frameworks, #kwin, #plasma Cc: plasma-devel, schernikov, michaelh, ZrenBot,

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d38825d934e4: [server] Dont crash when a subsurface gets commited whose parent surface got… (authored by graesslin). Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham added a comment. No worries, it sent me down the right path, at least! REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10237 To: apol, ngraham, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham added a reviewer: Discover Software Store. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10237 To: apol, ngraham, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10038: Use QTemporaryDir::filePath() instead of path concatenation

volkov added a comment. ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10038 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. In https://phabricator.kde.org/D10300#202468, @lbeltrame wrote: > Ping? Why this has not been committed even if in "accepted" state? Because I wasn't at my system yet.

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

lbeltrame added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Ping? Why this has not been committed even if in "accepted" state? REPOSITORY R127 KWayland BRANCH subsurface-parent-destroyed REVISION DETAIL https://phabricator.kde.org/D10300

D10357: Show high-resolution and vector logos properly in HighDPI mode

cfeck added a comment. Suggesting Qt:AA_EnableHighDpiScaling was my fault; I really should have checked our applications to suggest the correct attribute. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc:

D10362: Swap reveal password button logic

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me, consistency is good. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: broulik, #plasma, #vdg, ngraham Cc:

Plasma 5.8.9

Plasma 5.8.9 LTS is now released with some important bugfixes https://www.kde.org/announcements/plasma-5.8.9.php

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

ngraham added a comment. This came up again recently as a user pain point: https://www.reddit.com/r/kde/comments/7vnxhc/plasma_512_is_out_and_it_is_faster_stabler_and/dttyqwi/?utm_content=permalink_medium=front_source=reddit_name=kde REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10362: Swap reveal password button logic

starbuck added a comment. Dolphin screenshot where "eye crossed out=files hidden": https://user-images.githubusercontent.com/840070/34343479-cdc01690-e984-11e7-8728-2dac1e258c18.png Would further be also likely more consistent with other toggles in the future, like imagined on mobile

D10362: Swap reveal password button logic

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: broulik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10362: Swap reveal password button logic

broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: broulik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10362: Swap reveal password button logic

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY Indicate state, not the action it will

D10357: Show high-resolution and vector logos properly in HighDPI mode

This revision was automatically updated to reflect the committed changes. Closed by commit R102:82e64226c2e6: Show high-resolution and vector logos properly in HighDPI mode (authored by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham edited the summary of this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham edited the test plan for this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10357: Show high-resolution and vector logos properly in HighDPI mode

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff,

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham updated this revision to Diff 26699. ngraham added a comment. Simplify the code and address review comments REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10357?vs=26685=26699 BRANCH master REVISION DETAIL

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham marked 4 inline comments as done. ngraham added inline comments. INLINE COMMENTS > broulik wrote in Module.cpp:145 > Did you check how it behaves with a distro-provided pixmap? I fear it would > become tiny. I don't think we have any kind of `@2x` support for that Yes, it still works

Re: Start kwin_wayland through ssh

Yes, query on the terminal session the XDG_SESSION_ID variable and set on the remote ssh session the variable to this value. Then issue on the remote ssh session: export $(dbus-launch) && startplasmacompositor On Sun, Feb 4, 2018 at 5:40 PM, Kamil Piwowarski <9luty1...@gmail.com> wrote: > Is

Re: Start kwin_wayland through ssh

​Yes-ish. Log in to a real TTY locally export the XDG_SESSION_ID from that session into your ssh session

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 36 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/36/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Feb 2018 11:56:59 + Build duration: 3 min 22 sec and counting

Start kwin_wayland through ssh

Is there any way to run kwin_wayland on selected tty from remote ssh session?

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 35 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/35/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Feb 2018 11:52:44 + Build duration: 4 min 10 sec and counting

D10357: Show high-resolution and vector logos properly in HighDPI mode

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.cpp:40 > also it would need to be called before the QApplication constructor Never did that, app.setAttribute(Qt::AA_UseHighDpiPixmaps, true); works just fine and the docs also don't mention it REPOSITORY R102

D10359: [Mouse KCM] Check libinput Atom availability before using them

This revision was automatically updated to reflect the committed changes. Closed by commit R119:483565374f79: [Mouse KCM] Check libinput Atom availability before using them (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D10359: [Mouse KCM] Check libinput Atom availability before using them

romangg added a comment. In https://phabricator.kde.org/D10359#202364, @davidedmundson wrote: > If we're on wayland, why are we even loading x11mousebackend at all? > Can it not be guarded there? Martin implemented some hack in KWin for the short term to make cursor speed

D10359: [Mouse KCM] Check libinput Atom availability before using them

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. If we're on wayland, why are we even loading x11mousebackend at all? Can it not be guarded there? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10357: Show high-resolution and vector logos properly in HighDPI mode

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in Module.cpp:145 > Did you check how it behaves with a distro-provided pixmap? I fear it would > become tiny. I don't think we have any kind of `@2x` support for that once you have UseHighDpiPixmaps you won't need this

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

broulik added a comment. > every time I changed konsole tabs, saved a file in kate, the appDataFromUrl (missed the cache) was called. Whenever `NET::WMVisibleName ` changes, both caches are evicted. It might be worth checking what's more expensive to create, the `KWindowInfo` or

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate updated this revision to Diff 26692. jtamate edited the test plan for this revision. jtamate added a comment. What I've noticed is that with the first version of the patch, every time I changed konsole tabs, saved a file in kate, the appDataFromUrl (missed the cache) was called.

Re: 5.12 release: congratulations and post-mortem

Plasma 5.13 kickoff meeting being scheduled if anyone wants to come along https://doodle.com/poll/8wwrt59dt8prz6pf Jonathan On 6 February 2018 at 15:54, Nate Graham wrote: > Congrats on a fantastic release of Plasma 5.12 everybody! People are really > gonna love it. > >

D10359: [Mouse KCM] Check libinput Atom availability before using them

broulik created this revision. broulik added reviewers: Plasma, romangg, xuetianweng. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise the KCM aborts on XWayland.

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

broulik added a comment. The progress display is completely independent of libtaskmanager. Can you disable it (Uncheck "Show application badges and progress" in task manager settings) and see if that changes anything? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10357: Show high-resolution and vector logos properly in HighDPI mode

broulik added inline comments. INLINE COMMENTS > Module.cpp:145 > } else { > logo = QPixmap(logoPath); > } Did you check how it behaves with a distro-provided pixmap? I fear it would become tiny. I don't think we have any kind of `@2x` support for that > main.cpp:2 > > +