D10627: Reduce plasmashell frozen time to almost nothing

2018-02-18 Thread Jaime Torres Amate
jtamate retitled this revision from "Reduce plasma lock up time to almost nothing" to "Reduce plasmashell frozen time to almost nothing". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R120 Plasma Workspace BRANCH polling (branched

D10642: [kcmkwin/rules] Disable detect button on Wayland

2018-02-18 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Tooltip is not possible, we are in string freeze. I can of course hide the button, but then users might be wondering where it has gone. Given that I doubt it makes much difference. REPOSITORY

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Scott Harvey
sharvey added a comment. In D10618#209247 , @ngraham wrote: > Thanks! I'll let @davidedmundson push this if he's satisfied with the changes. Sounds fair to me. Thanks for the guidance. Now back to trying to fix my video drivers...

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Nathaniel Graham
ngraham added a comment. Thanks! I'll let @davidedmundson push this if he's satisfied with the changes. REPOSITORY R114 Plasma Addons BRANCH mediaframefix (branched from master) REVISION DETAIL https://phabricator.kde.org/D10618 To: sharvey, #plasma, mart, davidedmundson Cc: ngraham,

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Scott Harvey
sharvey added a comment. Arabic translations REMOVED. Now I understand. I thought I had typo'ed and accidentally changed them originally. I'm trying, I'm trying! REPOSITORY R114 Plasma Addons BRANCH mediaframefix (branched from master) REVISION DETAIL

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Scott Harvey
sharvey updated this revision to Diff 27508. sharvey added a comment. - Removed new Arabic translations from metadata.desktop REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10618?vs=27507=27508 BRANCH mediaframefix (branched from master) REVISION

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Nathaniel Graham
ngraham added a comment. No worries! There's always a bit of a learning curve here. You might check out https://community.kde.org/Infrastructure/Phabricator, which outlines some sane workflows for Phabricator. The new Arabic translations in `applets/mediaframe/package/metadata.desktop`

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Scott Harvey
sharvey added a comment. My apologies. I thought his changes were already made. I'm new to this whole process. I don't know how the Text item changed; I didn't do any work on that file. And now the change doesn't show up in the resubmitted diff. It is currently a Label and works just fine.

D8168: kcm_input: Refactor the code and add support for libinput under X11

2018-02-18 Thread Nathaniel Graham
Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8168 To: xuetianweng, davidedmundson, mart Cc: romangg, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Scott Harvey
sharvey updated this revision to Diff 27507. sharvey added a comment. - Change "Text" item to preferred "Label" item REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10618?vs=27433=27507 BRANCH mediaframefix (branched from master) REVISION DETAIL

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Nathaniel Graham
ngraham added a comment. Thanks! Also please address @davidedmundson's requests and revert the changes from Label to Text and the new Arabic translations (translation is done via another process). REPOSITORY R114 Plasma Addons BRANCH mediaframefix (branched from master) REVISION

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Scott Harvey
sharvey added a comment. My email is bund...@gmail.com My KDE Identity username is sharvey Although if you see me on IRC, I am bundito Thanks! REPOSITORY R114 Plasma Addons BRANCH mediaframefix (branched from master) REVISION DETAIL

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Nathaniel Graham
ngraham added a comment. We'll need an email address for you first. What's a good one? REPOSITORY R114 Plasma Addons BRANCH mediaframefix (branched from master) REVISION DETAIL https://phabricator.kde.org/D10618 To: sharvey, #plasma, mart, davidedmundson Cc: ngraham, plasma-devel,

D10618: Fix ComboBox & mode description for image fill mode

2018-02-18 Thread Scott Harvey
sharvey added a comment. Can someone (David?) land this for me? I don't have the superpowers to do it myself. Thanks! REPOSITORY R114 Plasma Addons BRANCH mediaframefix (branched from master) REVISION DETAIL https://phabricator.kde.org/D10618 To: sharvey, #plasma, mart,

D10620: Improve sidebar header visibility

2018-02-18 Thread Nathaniel Graham
ngraham added a comment. Oh shoot, I hadn't noticed that. :( REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10642: [kcmkwin/rules] Disable detect button on Wayland

2018-02-18 Thread Nathaniel Graham
ngraham added a comment. Restricted Application edited projects, added KWin; removed Plasma. Maybe we should just remove it instead of disabling it? Otherwise people will wonder why it's disabled and sitting there, taunting them. Alternatively, an informative tooltip explaining the issue

D10607: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2

2018-02-18 Thread Friedrich W . H . Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:f7fd71258f15: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2 (authored by kossebau).

D10607: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2

2018-02-18 Thread Friedrich W . H . Kossebau
kossebau added a comment. Taking the comments on D10450 about this patch as implicit +1 and going to push now, so there is 2 more days of build testing before the next release. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10633: Use 22px battery and keyboard icon in lock screen and sddm

2018-02-18 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Analysis seems fine. Solution can be better. Lets try to avoid any hardcoded values. You can get icon sizes from the Units too. INLINE COMMENTS >

[ksysguard] [Bug 390671] Add "Kill X Server" including Keyboard shortcut to Tools menu

2018-02-18 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=390671 --- Comment #4 from Martin Flöser --- (In reply to Gregor Mi from comment #3) > > > and used to be hit accidentally all the time. > The solution to this would be to disable the shortcut, wouldn't it? But it > is enabled by default

D10642: [kcmkwin/rules] Disable detect button on Wayland

2018-02-18 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10627: Reduce plasma lock up time to almost nothing

2018-02-18 Thread Kai Uwe Broulik
broulik added a comment. It's lookup, not lockup REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 To: jtamate, #frameworks, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai,

D10629: Avoid a double emitResult()

2018-02-18 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. A quick search through plasma codebase reveals that `setResult` followed by `emitResult` is done quite often. Care to fix these, too? :) REPOSITORY R120 Plasma Workspace BRANCH

[ksysguard] [Bug 390671] Add "Kill X Server" including Keyboard shortcut to Tools menu

2018-02-18 Thread Gregor Mi
https://bugs.kde.org/show_bug.cgi?id=390671 --- Comment #3 from Gregor Mi --- > As for system monitor if you can read system monitor and > open a tools menu, your X is working fine. True. On the other hand, I recently was in a situation where only Ctrl+Esc -> System

[ksysguard] [Bug 390671] Add "Kill X Server" including Keyboard shortcut to Tools menu

2018-02-18 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=390671 --- Comment #2 from Martin Flöser --- I'm also against this. The feature was rightfully removed from most distributions and is only implemented in KWin/Wayland on special request by sebas. -- You are receiving this mail because:

D10623: INFORMATIONAL: Make plasma-workspace compile

2018-02-18 Thread Michael Heidelbach
michaelh abandoned this revision. michaelh added a comment. @apol: It compiles now. But something is strange. This is what I did for D10624 : `$ kdesrc-build plasma-workspace' did not compile `$ zypper si -d plasma-workspace` did not compile error

[ksysguard] [Bug 390671] Add "Kill X Server" including Keyboard shortcut to Tools menu

2018-02-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=390671 David Edmundson changed: What|Removed |Added CC|

D10622: Add multimedia sub-categories

2018-02-18 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10622 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10611: Put all systemwide add-ons in Plasma Addons category

2018-02-18 Thread Aleix Pol Gonzalez
apol added a comment. :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10611 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10623: INFORMATIONAL: Make plasma-workspace compile

2018-02-18 Thread Aleix Pol Gonzalez
apol added a comment. Are you sure you are up to date? 235fa3ea97d7226a6e5c8859fe7e1cd5c3cf8b0c should fix it. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10623 To: michaelh,

D10611: Put all systemwide add-ons in Plasma Addons category

2018-02-18 Thread Nathaniel Graham
ngraham added a comment. You said ship-it in the Telegram channel! :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10611 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10622: Add multimedia sub-categories

2018-02-18 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH more-multimedia-categories (branched from master) REVISION DETAIL https://phabricator.kde.org/D10622 To: ngraham, #discover_software_store, apol Cc: plasma-devel,

D10611: Put all systemwide add-ons in Plasma Addons category

2018-02-18 Thread Aleix Pol Gonzalez
apol added a comment. ? xD what happened here? +1 anyway REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10611 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10633: Use 22px battery and keyboard icon in lock screen and sddm

2018-02-18 Thread Yunhe Guo
guoyunhe edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10633 To: guoyunhe, #plasma_workspaces Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10633: Use 22px battery and keyboard icon in lock screen and sddm

2018-02-18 Thread Yunhe Guo
guoyunhe added a reviewer: Plasma: Workspaces. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10633 To: guoyunhe, #plasma_workspaces Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10633: Use 22px battery and keyboard icon in lock screen and sddm

2018-02-18 Thread Yunhe Guo
guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY ToolButton and Battery components are using 16px icons but here is no 16px icons in Breeze theme

Plasma mobile multirom zip

2018-02-18 Thread Yasir AL-Gizouli
Where can I find this build http://dev.plasma-mobile.org/phone/maui-lge-hammerhead-0.2.1.zip

[ksysguard] [Bug 390671] New: Add "Kill X Server" including Keyboard shortcut to Tools menu

2018-02-18 Thread Gregor Mi
https://bugs.kde.org/show_bug.cgi?id=390671 Bug ID: 390671 Summary: Add "Kill X Server" including Keyboard shortcut to Tools menu Product: ksysguard Version: 5.12.1 Platform: Other OS: Linux

D10629: Avoid a double emitResult()

2018-02-18 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY ServiceJob::setResult already does a emitResult.

D10628: Optional barcodes in libprison

2018-02-18 Thread Sune Vuorela
svuorela edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10628 To: svuorela, graesslin, vkrause Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10628: Optional barcodes in libprison

2018-02-18 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: graesslin, vkrause. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. svuorela requested review of this revision. REVISION SUMMARY createBarcode can sometimes return nullpointers. In

D10627: Reduce plasma lock up time to almost nothing

2018-02-18 Thread Jaime Torres Amate
jtamate added a comment. May I do the other 2 commits without another revision? REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 To: jtamate, #frameworks, #plasma, davidedmundson Cc: davidedmundson,

D10613: Make it possible for actions to show submenus

2018-02-18 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 27454. apol added a comment. Usability REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10613?vs=27419=27454 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10613 AFFECTED FILES

D10627: Reduce plasma lock up time to almost nothing

2018-02-18 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. This code already has a platform check before adding the native event filter. IMHO we could just make this an assert. But I like your approach too. REPOSITORY

D10627: Reduce plasma lock up time to almost nothing

2018-02-18 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY CCBUG: 358231 CCBUG: 342056 Even the icon with the

D10624: baloosearchrunner: Add 3 search types

2018-02-18 Thread Michael Heidelbach
This revision was automatically updated to reflect the committed changes. Closed by commit R120:de16179f0ded: baloosearchrunner: Add 3 search types (authored by michaelh). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10624?vs=27446=27447 REVISION

D10624: baloosearchrunner: Add 3 search types

2018-02-18 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH baloosearchrunner (branched from master) REVISION DETAIL https://phabricator.kde.org/D10624 To: michaelh, #plasma_workspaces, davidedmundson Cc: plasma-devel,

D10624: baloosearchrunner: Add 3 search types

2018-02-18 Thread Michael Heidelbach
michaelh created this revision. michaelh added a reviewer: Plasma: Workspaces. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. michaelh requested review of this revision. REVISION SUMMARY baloo can also handle the following types -

D10623: INFORMATIONAL: Make plasma-workspace compile

2018-02-18 Thread Michael Heidelbach
michaelh edited the summary of this revision. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10623 To: michaelh, #plasma, #plasma_workspaces Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10623: INFORMATIONAL: Make plasma-workspace compile

2018-02-18 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Plasma, Plasma: Workspaces. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. michaelh requested review of this revision. REVISION SUMMARY This diff is purely informational.

D10620: Improve sidebar header visibility

2018-02-18 Thread Henrik Fehlauer
rkflx added a comment. Note that for the light theme this changes the background colour from `#FCFCFC` to `#FF`. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai,