D11166: Simplify display when there's only a single input device and a single output device

ngraham updated this revision to Diff 29133. ngraham added a comment. Fix typo causing behavior issue REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11166?vs=29055=29133 BRANCH simplify-single-device-ui (branched from master)

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

ngraham added a comment. Ping! Is this landable? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9878 To: broulik, #plasma, hein, graesslin, #vdg, fabianr Cc: ngraham, fabianr, abetts, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11197: Allow OverlaySheet clients to omit the built-in close button

ngraham added a comment. "Close button + cancel" is inherently redundant; a historical relic of the fact that dialog boxes have traditionally been separate windows, and windows have titlebars with fixed button arrangements (that said, in macOS, dialog boxes now have no window decorations).

D11197: Allow OverlaySheet clients to omit the built-in close button

apol added a comment. I'd say it's okay to have the close button and a cancel, every dialog does. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11197 To: ngraham, mart, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein

D11194: Load correct wallpaper plugin configuration in the dialog

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I think there's a bug report about this somewhere if you want to find it. REPOSITORY R119 Plasma Desktop BRANCH fix_wallpaper_configuration_dialog REVISION DETAIL

D11195: Use separate config group for each wallpaper plugin

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. One could argue keeping the colour persist across wallpapers is a feature, what problems does it cause? INLINE COMMENTS > containmentconfigview.cpp:180 >

D11197: Allow OverlaySheet clients to omit the built-in close button

ngraham updated this revision to Diff 29130. ngraham added a comment. Fix whitespace REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11197?vs=29125=29130 BRANCH overlay-sheet-without-close-button (branched from master) REVISION DETAIL

D11199: Don't show the built-in close button on ProceedDialogs

ngraham created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Don't show the Kirigami OverlaySheet's built-in close button, since we draw our own Depends

D11175: [WIP][kstyle] refine shadows

zzag updated this revision to Diff 29128. zzag added a comment. - move libbreezecommon to another patch REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11175?vs=29122=29128 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11175 AFFECTED

D11069: [WIP][kdecoration] refine shadows

zzag updated this revision to Diff 29127. zzag added a comment. - move libbreezecommon to another patch REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=29121=29127 REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES

D11198: [WIP][libbreezecommon] add box shadow helper

zzag created this revision. zzag added reviewers: Breeze, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY TODO: write motivation behind this helper. REPOSITORY R31 Breeze

D11197: Allow OverlaySheets to omit built-in close buttons

ngraham created this revision. ngraham added reviewers: mart, Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Most of the time we want an OverlayDialog to draw a

D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a comment. In D10807#222173 , @rkflx wrote: > Did you already look at which approach Tracker uses regarding filesystems? Are they just indexing everything? Nope, good you reminded me. Made a note for myself T8066

T8066: Fix BUG:390830

michaelh added a comment. How does tracker handle file systems? TASK DETAIL https://phabricator.kde.org/T8066 To: michaelh Cc: nicolasfella, ivan, plasma-devel, alexeymin, michaelh, ashaposhnikov, spoorun

D11069: [WIP][kdecoration] refine shadows

zzag added a comment. - split this patch(deco shadow patch and libbreezecommon patch) - fix params issues REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot,

D11175: [WIP][kstyle] refine shadows

zzag planned changes to this revision. zzag added a comment. - fix params issues REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11175: [WIP][kstyle] refine shadows

zzag updated this revision to Diff 29122. zzag added a comment. - fix KDE4 build - move cmake changes to this patch REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11175?vs=29073=29122 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11175

D11069: [WIP][kdecoration] refine shadows

zzag updated this revision to Diff 29121. zzag added a comment. - fix KDE4 build REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=29072=29121 REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES CMakeLists.txt

D11175: [WIP][kstyle] refine shadows

zzag added a comment. > But then, this code is compiled in a separate library ? > How is it linked against the kstyle code ? Doesn't that require changes to CMakeLists ? I'm confused. Yes, it is compiled as a separate shared library. Yes, it requires changes to CMakeLists.txt. (e.g.

D11189: Force a content size into the background style item

apol added inline comments. INLINE COMMENTS > ngraham wrote in PrivateActionToolButton.qml:70 > Magic number? Should that be `Kirigami.units.LargeSize` (18) or > `Kirigami.units.MediumSize * 2` (16)? It's just copying the logic that is used above. REPOSITORY R169 Kirigami REVISION DETAIL

D11195: Use separate config group for each wallpaper plugin

aleksejshilin created this revision. aleksejshilin added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Wallpaper plugins were storing their

D11194: Load correct wallpaper plugin configuration in the dialog

aleksejshilin created this revision. aleksejshilin added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Wallpaper plugin was previously set for

D11175: [WIP][kstyle] refine shadows

hpereiradacosta added a comment. In D11175#222124 , @zzag wrote: > In D11175#222001 , @hpereiradacosta wrote: > > > I am confused. Where is the shadow rending code ? > > >

D11175: [WIP][kstyle] refine shadows

hpereiradacosta added inline comments. INLINE COMMENTS > zzag wrote in breezeshadowhelper.cpp:145 > No, I just prefer this method of initialization of structs. IMHO, it's more > readable. > > I'll see what I can do. > > PS. I'd say it looks like js. yeah well, but unless you sign up as the

D10807: fileindexerconfig: Exclude Vaults by default

rkflx added a comment. Did you already look at which approach Tracker uses regarding filesystems? Are they just indexing everything? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: rkflx, alexeymin,

D11189: Force a content size into the background style item

ngraham added inline comments. INLINE COMMENTS > PrivateActionToolButton.qml:70 > id: layout > +onImplicitWidthChanged: control.background.contentWidth = > implicitWidth + 16 > anchors.centerIn: parent Magic number? Should that be

D11190: Make sure we are taking into account hte size of the element when styling

apol created this revision. apol added reviewers: Frameworks, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY See https://phabricator.kde.org/D11189 REPOSITORY R858 Qt

D11189: Force a content size into the background style item

apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise the background will still be rendered without taking into account the sizes we offer

D11175: [WIP][kstyle] refine shadows

zzag added a comment. In D11175#222001 , @hpereiradacosta wrote: > I am confused. Where is the shadow rending code ? `BoxShadowHelper::boxShadow()` does pretty much all rendering. > How is it shared between style and deco ?

D10807: fileindexerconfig: Exclude Vaults by default

michaelh abandoned this revision. michaelh added a comment. Too naive approach REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, michaelh,

D11175: [WIP][kstyle] refine shadows

hpereiradacosta added inline comments. INLINE COMMENTS > breezeshadowhelper.cpp:145 > } > +}; > ok. I know this whole chunc of code is to make it look like css, but this is ugly sorry. The fact that you need to repeat all the member names for each new set of parameters is not

D11175: [WIP][kstyle] refine shadows

hpereiradacosta added a comment. I am confused. Where is the shadow rending code ? How is it shared between style and deco ? In general, the sharing should be a separate patch, that could be applied even with the current shadows, before modifying how shadows are drawn ... That would

D11182: org.freedesktop.PowerManagement.Inhibit should only prevent suspend

broulik created this revision. broulik added reviewers: Plasma, oliverhenshaw. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY For preventing screen standby or screen locking the

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 165 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/165/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 09 Mar 2018 14:38:48 + Build duration: 21 min and counting JUnit Tests

D11180: Reverse tooltip colors for Breeze colorscheme

rwurth created this revision. rwurth added a reviewer: Breeze. rwurth added a project: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. rwurth requested review of this revision. REVISION SUMMARY Hello this patch reverses the

D10461: GMenu-DBusMenu-Proxy

broulik closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10461 To: broulik, #plasma, mart, davidedmundson Cc: davidedmundson, mart, rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11175: [WIP][kstyle] refine shadows

zzag added a comment. Yet, I would like to have single shadow size for kstyle shadows. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11175: [WIP][kstyle] refine shadows

zzag added a comment. In D11175#221928 , @ngraham wrote: > What shadow size is being used in the screenshot? Large. Well, currently, shadow params are shared among all sizes. You can help by providing CSS shadows. :) IMHO, Large

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 164 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/164/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 09 Mar 2018 14:29:23 + Build duration: 5 min 42 sec and counting

D11174: fix detecting changes in sub-pixel and hinting settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ac5c39292836: fix detecting changes in sub-pixel and hinting settings (authored by progwolff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11175: [WIP][kstyle] refine shadows

ngraham added a comment. What shadow size is being used in the screenshot? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

[Powerdevil] [Bug 365100] Power button ignored

https://bugs.kde.org/show_bug.cgi?id=365100 Peter Kreussel changed: What|Removed |Added CC|

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. It will soon be this patch 2nd birthday. Can we speed up things a bit? I've seen this is scheduled for Plasma 5.13, would be good if we have time to test it. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin,

D1230: GBM remote access support for KWin

Kanedias added a comment. Please re-review this and D1231 as I'm starting to work on KRfb support for this and it will be the 3rd patch depending on this. Or suggest reviewers with more spare time so they can look this through. REPOSITORY R108 KWin

D11168: [AppMenu Applet] Support actions without menu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:640042ce0771: [AppMenu Applet] Support actions without menu (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11168?vs=29059=29081

D11069: [WIP][kdecoration] refine shadows

zzag added a comment. TODOs(kdecoration and kstyle): - revise params - document how to fill params @hpereiradacosta: could you please give it first round review code? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg,

D11175: [WIP][kstyle] refine shadows

zzag created this revision. zzag added reviewers: Breeze, VDG, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY TODO Depends on D11069

D11069: [WIP] refine decoration shadows

zzag updated this revision to Diff 29072. zzag added a comment. fix previous update REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=29071=29072 REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES CMakeLists.txt

D11069: [WIP] refine decoration shadows

zzag updated this revision to Diff 29071. zzag added a comment. move box shadow helper out to a separate library REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28893=29071 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069

D11174: fix detecting changes in sub-pixel and hinting settings

progwolff created this revision. progwolff added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY Since #R119, on changes to the sub-pixel and hinting

D11069: [WIP] refine decoration shadows

fabianr added a comment. In D11069#221381 , @zzag wrote: > So, I'd spent last two hours trying to find good menu shadow params.. HIG guidelines don't say too much about shadows(also, navigating them is hard) so I don't know whether these

D11168: [AppMenu Applet] Support actions without menu

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Applications could place actions in the main menu bar that do not