D7537: KDE logout screen - change black icons & texts to white/greyish

Pitel added a comment. I have the same problem in 5.12.2 release. I think the root of it is assuming that foreground in `PlasmaCore.Theme.ComplementaryColorGroup` is white(ish) and background is dark (this is true only if normal color scheme uses dark text on light background, which is

D11069: [WIP][kdecoration] refine shadows

ngraham added a comment. Looks pretty nice to me! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

[Powerdevil] [Bug 365100] Power button ignored

https://bugs.kde.org/show_bug.cgi?id=365100 Dr. Chapatin changed: What|Removed |Added CC||bugsefor...@gmx.com ---

D11069: [WIP][kdecoration] refine shadows

zzag planned changes to this revision. zzag added a comment. change the way default params are represented(right now, it's js-ish) --- I'll take a break from working on these shadows. Current look: F5748966: desktop.png Menu shadows:

D11175: [WIP][kstyle] refine shadows

zzag planned changes to this revision. zzag added a comment. change the way default params are represented REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11175: [WIP][kstyle] refine shadows

zzag updated this revision to Diff 29198. zzag added a comment. - add shadow params REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11175?vs=29128=29198 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11175 AFFECTED FILES

D11069: [WIP][kdecoration] refine shadows

zzag updated this revision to Diff 29197. zzag added a comment. - bump strength to 85% REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=29127=29197 REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES kdecoration/CMakeLists.txt

D7537: KDE logout screen - change black icons & texts to white/greyish

mvourlakos added a comment. I dont know if I can help in this... I used the ColorOverlay approach lately with Latte in order to color properly the panel contents based on the underlying background. This approach could be also be used here I think. The luminosity of the textColor and

D11220: option to force FolderView icon-only presentation

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --when a FolderView applet is located in panel, there

D7537: KDE logout screen - change black icons & texts to white/greyish

ngraham added a comment. @pekkah? Can you add the screenshots here and address the review comments? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7537 To: pekkah, #plasma_workspaces, #plasma, #breeze, mart Cc: ngraham, mart, bshah, #breeze, pekkah,

D7537: KDE logout screen - change black icons & texts to white/greyish

ngraham added a comment. Also, is this even still relevant? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7537 To: pekkah, #plasma_workspaces, #plasma, #breeze, mart Cc: ngraham, mart, bshah, #breeze, pekkah, #plasma_workspaces, plasma-devel, #plasma,

D11218: Show all actions on the main Kirigami toolbar and use the secondary one only for status

ngraham added a comment. There is one bug: the Update button correctly becomes a Cancel button once you click it, but it's disabled: F5748798: Screenshot_20180310_142300.png I could use a hand fixing that. REPOSITORY R134 Discover Software

D11218: Show all actions on the main Kirigami toolbar and use the secondary one only for status

ngraham updated this revision to Diff 29193. ngraham added a comment. Remove another now-unnecessary thing REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11218?vs=29191=29193 BRANCH better-updates-page-toolbars (branched from master)

D11003: Fix the Add Source dialog

ngraham added a comment. In D11003#222401 , @ach wrote: > FWIW: My first imprression was that the dialog is too narrow.My 'rule' is : the most frequently entered URLs should fit into the dialog without scrolling to the left or the right.

D11219: Increase the "Add Source" dialog's width, to accommodate longer repo URLs without cutting anything off

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As @ach pointed out, even after my last

D11215: Improve Updates page toolbar entries left and right padding

ngraham added a comment. Possibly/likely superseded by D11218 . REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11215 To: ngraham, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11214: Don't let the selection text overlap the Update button

ngraham added a comment. Possibly/likely superseded by D11218 . REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11214 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10232: Include a pixel more in the dirty area

hindenburg added a comment. ping... have you had a chance to look at this again? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D10232 To: mart, #plasma, #konsole, markg Cc: qi437103, markg, hindenburg, ngraham, plasma-devel, herrold, ZrenBot, lesliezhai,

D11218: Show all actions on the main Kirigami toolbar and use the secondary one only for status

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is an alternative to D11214

D11215: Improve Updates page toolbar entries left and right padding

ngraham created this revision. ngraham added reviewers: Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Updates page has an internal toolbar

D11214: Don't let the selection text overlap the Update button

ngraham created this revision. ngraham added a reviewer: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY By removing the "n unsepected" text (which

D11205: Fix ActionButton size

ngraham added a comment. I think the real error is deriving the button size from a Spacing value and not a Size value. We should fix that, or else we'll have to do the same thing if we ever change the spacing again. REPOSITORY R169 Kirigami REVISION DETAIL

D11209: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

kossebau created this revision. kossebau added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Nested classes inherit the visibility of their outer class,

D11195: Use separate config group for each wallpaper plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bb5645d8c6e7: Use separate config group for each wallpaper plugin (authored by aleksejshilin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11194: Load correct wallpaper plugin configuration in the dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b0304a2ef312: Load correct wallpaper plugin configuration in the dialog (authored by aleksejshilin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11195: Use separate config group for each wallpaper plugin

aleksejshilin added a comment. In D11195#222490 , @davidedmundson wrote: > typically we'd do cfg = cfg.group("") which IMHO is easier to read Yeah, I like it more, too, but I saw the same styling almost everywhere in shell/ and

D11195: Use separate config group for each wallpaper plugin

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Urgh, I can't read. Sorry. typically we'd do cfg = cfg.group("") which IMHO is easier to read, but this is fine too Thanks REPOSITORY R120 Plasma Workspace

D11195: Use separate config group for each wallpaper plugin

aleksejshilin added a comment. In D11195#222450 , @davidedmundson wrote: > Fix setting cfg twice It's not setting twice, it's creating a nested config group. Or did you mean to use a separate variable each time instead of reusing

D11195: Use separate config group for each wallpaper plugin

davidedmundson added a comment. I see, thanks for the explanation. Fix setting cfg twice, and then I'll approve it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11195 To: aleksejshilin, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel,

D11195: Use separate config group for each wallpaper plugin

aleksejshilin added a comment. In D11195#222313 , @davidedmundson wrote: > One could argue keeping the colour persist across wallpapers is a feature, what problems does it cause? It's not limited to colors, that's just a testcase. And

D11205: Fix ActionButton size

icota created this revision. icota added a reviewer: Kirigami. icota added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. icota requested review of this revision. REVISION SUMMARY Its dimensions were cut in half by the change in largeSpacing introduced in

D11194: Load correct wallpaper plugin configuration in the dialog

aleksejshilin added a comment. In D11194#222319 , @davidedmundson wrote: > I think there's a bug report about this somewhere if you want to find it. I've found quite a few similar ones (like 366390, 367546, 374691, 375532 etc.) - but

D11003: Fix the Add Source dialog

ach added a comment. FWIW: My first imprression was that the dialog is too narrow.My 'rule' is : the most frequently entered URLs should fit into the dialog without scrolling to the left or the right. In this dialog the string '.flatpakrepo' seems to use already 30 % of the width.