KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 114 - Still Failing!

2018-03-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/114/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 03:44:58 + Build duration: 20 min and counting CONSOLE OUTPUT [...truncated

D11455: Update kcmstyle docbook

2018-03-19 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d2e62b9fe256: Update kcmstyle docbook (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11455?vs=29835=29961 REVISION DETAIL

D11352: [RFC] Auto ordered systray

2018-03-19 Thread Wojciech Stachurski
wsdfhjxc added a comment. Thanks for a fix. I've changed the category order to - `UnknownCategory` - `ApplicationStatus` - `Communications` - `SystemServices` - `Hardware` and updated `metadata.desktop` for some Plasma components - Networks ->

D10750: wayland: Add support for zwp_linux_dmabuf

2018-03-19 Thread Fredrik Höglund
fredrik updated this revision to Diff 29953. fredrik added a comment. Fix issues pointed out by romangg. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=29331=29953 REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED FILES

Re: no OSK in Plasma Mobile

2018-03-19 Thread Heather Ellsworth
On 03/17/2018 02:41 PM, Martin Flöser wrote: > > > Am 17. März 2018 02:01:24 MEZ schrieb Heather Ellsworth > : >> On 03/15/2018 09:10 PM, Bhushan Shah wrote: >>> Hello Heather, >>> >>> On Thu, Mar 15, 2018 at 06:57:27PM -0600, Heather Ellsworth wrote: I've been

D10750: wayland: Add support for zwp_linux_dmabuf

2018-03-19 Thread Fredrik Höglund
fredrik added a comment. In D10750#224860 , @romangg wrote: > In D10750#216337 , @fredrik wrote: > > > An issue that this patch does not fully address is switching compositing backends at runtime.

D11502: Make the item heights rounded to avoid font rendering issues

2018-03-19 Thread Ivan Čukić
This revision was automatically updated to reflect the committed changes. Closed by commit R124:4f1f9b9f7ad9: Make the item heights rounded to avoid font rendering issues (authored by ivan). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 113 - Failure!

2018-03-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/113/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 19 Mar 2018 21:12:46 + Build duration: 25 min and counting CONSOLE OUTPUT [...truncated

D11502: Make the item heights rounded to avoid font rendering issues

2018-03-19 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: mart, davidedmundson, broulik, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY Fixes small font rendering issues produced

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Martin Flöser
graesslin added a comment. In D11447#229478 , @romangg wrote: > Could we use a wrapper for QApplication being called by > > QApplication app = KWorkSpace::createPlattformAwareQApplication(argc, argv); > > > and that sets and unsets

D11410: [RFC] Add option to make applet fixed width

2018-03-19 Thread Radek Hušek
Pitel updated this revision to Diff 29940. Pitel added a comment. In D11410#229277 , @mart wrote: > it's moving on the right track.. i would like the checkbox to appear like the one in the panel spacer, in the context menu could be tricky as

D11499: Fix warnings

2018-03-19 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. should go deeper in this issue.. i already encountered it, tough it seems that ListView.view is always null until the component completes, which could potentially make it a Qt bug REPOSITORY

D11499: Fix warnings

2018-03-19 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Apparently sometimes controlRoot.ListView.view is null TEST PLAN Ran Discover, it worked REPOSITORY

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Roman Gilg
romangg added a comment. Could we use a wrapper for QApplication being called by QApplication app = KWorkSpace::createPlattformAwareQApplication(argc, argv); and that sets and unsets the env variable in the wrapper call? With above code there might be a copy involved though.

D11498: Install firefox's native messaging host to LIBDIR

2018-03-19 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, bshah, broulik, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Fabian Vogt
fvogt resigned from this revision. fvogt added a comment. This revision is now accepted and ready to land. > Please move the qunsetenv into a method in KWorkSpace at least. Hm, that's not much prettier either. I really don't know how to make this look less hacky with editing env vars.

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. In D11447#229385 , @graesslin wrote: > In D11447#229337 , @fvogt wrote: > > > In

D11289: checkable FormLayout items

2018-03-19 Thread Julian Wolff
progwolff updated this revision to Diff 29937. progwolff marked 3 inline comments as done. progwolff added a comment. - split buddyComponent and checkableBuddyComponent - toggle checkbox on shortcut activated REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D11199: Don't show the built-in close button on ProceedDialogs

2018-03-19 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:609aa67e0fc8: Dont show the built-in close button on ProceedDialogs (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. Right it's a pointer array. So `detectPlatform` would need to do some pointer and memory rearranging, what is not worth the hassle. REPOSITORY R120 Plasma Workspace BRANCH unset-qt-qpa-platform REVISION DETAIL

D11289: checkable FormLayout items

2018-03-19 Thread Julian Wolff
progwolff planned changes to this revision. progwolff added a comment. In D11289#229340 , @mart wrote: > can you provide screenshots as well t see how does it look? I added one under "test plan". INLINE COMMENTS > mart wrote in

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Martin Flöser
graesslin added a comment. In D11447#229337 , @fvogt wrote: > In D11447#229334 , @graesslin wrote: > > > In D11447#229128 , @fvogt wrote: > > > > > If

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Roman Gilg
romangg added a comment. `KWorkSpace::detectPlatform(argc, argv);` is already testing the arguments if `--platform` flag is set and in this case would do nothing. Therefore I think it's safe to set the flag instead of the env variable as proposed by @fvogt. REPOSITORY R120 Plasma

D11197: Allow OverlaySheet clients to omit the built-in close button

2018-03-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11197 To: ngraham, mart, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein

D11289: checkable FormLayout items

2018-03-19 Thread Marco Martin
mart added a comment. can you provide screenshots as well t see how does it look? INLINE COMMENTS > FormLayout.qml:185 > id: buddyComponent > -Kirigami.Heading { > +CheckBox { > id: labelItem what i'm concerned is that this makes every field a checkbox,

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Fabian Vogt
fvogt added a comment. In D11447#229334 , @graesslin wrote: > In D11447#229128 , @fvogt wrote: > > > If `KWorkSpace::detectPlatform(argc, argv);` were changed to edit `argc` and `argv` to pass

kdesrc-build stable branch

2018-03-19 Thread Stéphane Ancelot
Hi, I am compiling with kdesrc-build , however, I am on branch-group kf5-qt5 and I think it is the development branch. I want to be on a "latest stable" branch , what can I provide to branch-group in order to avoid inconsistant builds ? Regards, S.Ancelot

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Martin Flöser
graesslin added a comment. In D11447#229128 , @fvogt wrote: > If `KWorkSpace::detectPlatform(argc, argv);` were changed to edit `argc` and `argv` to pass `-platform foo` instead of setting `QT_QPA_PLATFORM`, the `qunsetenv` calls would become

D11375: Don't block evaluating DBus scripts if widgets are locked.

2018-03-19 Thread Marco Martin
mart added a comment. In D11375#227088 , @broulik wrote: > Please change the check to be > > if (immutability() == Plasma::Types::SystemImmutable) { > ... > return; > } > > > we don't want to introduce a way to

D11410: [RFC] Add option to make applet fixed width

2018-03-19 Thread Marco Martin
mart added a comment. it's moving on the right track.. i would like the checkbox to appear like the one in the panel spacer, in the context menu could be tricky as would need to inject into the applet's contextualactons, so let's forget about it for now. one thing that could be done is

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-19 Thread Marco Martin
mart added a comment. In D11469#229219 , @ngraham wrote: > I volunteer to do the UI part. Hopefully @mart or @hein can help me with my first FormLayout KCM, then maybe I can do more in the future... sure REPOSITORY R119 Plasma Desktop

D11478: Use dbus-run-session instead of dbus-launch --exit-with-session

2018-03-19 Thread Nathaniel Graham
ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=372789? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11478 To: fvogt, #plasma, davidedmundson Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-19 Thread Nathaniel Graham
ngraham added subscribers: mart, hein. ngraham added a comment. I volunteer to do the UI part. Hopefully @mart or @hein can help me with my first FormLayout KCM, then maybe I can do more in the future... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11469

D11482: Export Translations to right filename

2018-03-19 Thread Leszek Lesner
leszeklesner created this revision. leszeklesner added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. leszeklesner requested review of this revision. REVISION SUMMARY It exports its qml translations to

D11393: Neon/Kubuntu dependency installation batch script

2018-03-19 Thread Scott Harvey
sharvey added a comment. Ah, I see. I put this together after following the README directions for installing the plasmoid interface. I wasn't aware you had scripts in the Mycroft Core repository - I just followed along as I was told. You can disregard this, then. I'll look into

D11316: Components for Cards

2018-03-19 Thread Marco Martin
mart updated this revision to Diff 29904. mart added a comment. - use kirigami namespace REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29626=29904 BRANCH mart/Card REVISION DETAIL https://phabricator.kde.org/D11316 AFFECTED FILES

D11316: Components for Cards

2018-03-19 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R169:def2e9760909: Components for Cards (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11316?vs=29904=29905#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D11316: Components for Cards

2018-03-19 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. +1 Probably worth porting some real world code before commiting the new API. Please commit with split the header changes, and Units change they seem very stand-alone.

D11393: Neon/Kubuntu dependency installation batch script

2018-03-19 Thread Aditya Mehra
Aiix added a comment. Hi Sharvey, I am not sure if this install script belongs within the plasmoid repository itself additionally also there are already installation scripts for Debian/Kubuntu/Neon or any debian/buntu based distribution already available under the Mycroft AI Git-hub

D11413: Fix build with Qt 5.11 (missing headers)

2018-03-19 Thread Andreas Sturmlechner
asturmlechner abandoned this revision. asturmlechner added a comment. Obsolete by f83d0336a875f04361acb714c2eab490335d8d88 REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D11413 To:

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Fabian Vogt
fvogt added a comment. If `KWorkSpace::detectPlatform(argc, argv);` were changed to edit `argc` and `argv` to pass `-platform foo` instead of setting `QT_QPA_PLATFORM`, the `qunsetenv` calls would become unnecessary. REPOSITORY R120 Plasma Workspace BRANCH unset-qt-qpa-platform

D11471: [Touchpad KCM] Sync values to UI on Defaults in Wayland session

2018-03-19 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R119:bac840058119: [Touchpad KCM] Sync values to UI on Defaults in Wayland session (authored by romangg). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11478: Use dbus-run-session instead of dbus-launch --exit-with-session

2018-03-19 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R120:19bee4105feb: Use dbus-run-session instead of dbus-launch --exit-with-session (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11478: Use dbus-run-session instead of dbus-launch --exit-with-session

2018-03-19 Thread Fabian Vogt
fvogt added a comment. https://bugzilla.opensuse.org/show_bug.cgi?id=1085772#c10 for more context. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11478 To: fvogt, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11478: Use dbus-run-session instead of dbus-launch --exit-with-session

2018-03-19 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY dbus-launch --exit-with-session behaves badly if there's no X server running. This resulted in it breaking when being launched

D10686: [DesktopNotifier] Notify change for any link to trash:/

2018-03-19 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ee48796ec556: [DesktopNotifier] Notify change for any link to trash:/ (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10686?vs=27619=29891#toc REPOSITORY R120 Plasma

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-19 Thread Roman Gilg
romangg added a comment. Thanks for your feedback guys. I maybe should have noted that I see the UI more as a placeholder right now and didn't bother about the design. This patch is only about the technical bits. Making the UI beautiful should then go in a separate one ASAP. And I hope