D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 30979. croick added a comment. - update socket file location REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=29249=30979 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D6183: [Digital Clock] Allow copying current date and time to clipboard

bschiffner updated this revision to Diff 30975. bschiffner added a comment. It supressed the seconds to be copied into the clipboard in case of the per minute update of the display. Missing: I don't know how to make the result of the action available to the MMB (middle mouse button).

D11262: KDE logout screen background color fix

cfeck added a comment. In D11262#237017 , @Pitel wrote: > I guess I should have renamed it from `isLightColor` to something like `isNotAlmostBlack`... The point was to replace almost black colors with real black because it looks better with

D11808: [weather dataengine] Fix BBC provider to adapt to change RSS feed

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. You cannot break what no longer works :) INLINE COMMENTS > ion_bbcukmet.cpp:270 > + > +XMLMapInfo& place = m_place[QStringLiteral("bbcukmet|") > +sourceAction[2]]; > + Space

D10747: Implement zwp_linux_dmabuf_v1

romangg added a comment. Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code base or could we use the system one? It's only available on Linux? In this case could we include it as a dummy only on non-Linunx systems? This way we could use the system one on Linux.

D11410: [RFC] Add option to make applet fixed width

Pitel added inline comments. INLINE COMMENTS > mart wrote in ConfigOverlay.qml:385 > this will probably need as well > currentApplet.applet.pluginName == "org.kde.plasma.panelspacer" > > or it gets lost when the spacer is configured as not expanding and i guess > the spacer is special and we

D11817: Update kcmsmserver docbook to 5.12

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date +

D11021: [Media controller] Add simple volume control

Pitel updated this revision to Diff 30963. Pitel added a comment. Convert `changeVolume` helper into a Job... Right now it does not check wheter the DBus call is successful - I tried to wire it in but ended with segfault. I will investigate it further. Except that I hope it is ok.

D11813: Update colors docbook to 5.12

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date +

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Qt minimum version for plasma-integration is 5.9 these days, so this patch should be updated. REPOSITORY R135 Integration for Qt applications in Plasma

D11262: KDE logout screen background color fix

Pitel added a comment. In D11262#237099 , @ragreen wrote: > > I am not sure what artifacts is he referring to (but I am usually blind to this kind of issues)... > > I'm not. I did not mean that I want to ignore them, I just need them

D11262: KDE logout screen background color fix

ragreen added a comment. @ngraham You're right. Thanks for the heads-up. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot,

D11812: Update translations docbook to 5.12

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread bump date + releaseinfo kde

D11262: KDE logout screen background color fix

ngraham added a comment. @ragreen, this isn't the right place for that kind of discussion. Phabricator Differential is used for patch and code review, not commentary on larger design decisions. If you'd like to start a conversation about whether the current UX is a regression (and I would

D11262: KDE logout screen background color fix

ragreen added a comment. @Pitel I'm sorry to say this but they had nailed it in 5.8, then they ruined it in 5.12. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik,

D11262: KDE logout screen background color fix

Pitel added a comment. It also should be in `Plasma/5.12` now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai,

D11262: KDE logout screen background color fix

Pitel added a comment. @ragreen I am sorry to disappoint but this patch does not remove the (usually black) half-opaque overlay the G+ post refers to. It only changes its color to button background color in the case that button background color is too far from black to make sure the text is

D11262: KDE logout screen background color fix

ragreen added a comment. Will this also fix the aliasing in the logout screen? https://plus.google.com/communities/105101838887387505413 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: ragreen, fvogt, cfeck, fredrik,

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

ngraham added a comment. @elvisangelaccio, does this look sane? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma, elvisangelaccio Cc: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin,

D11262: KDE logout screen background color fix

ragreen added a comment. Okay, Nate. It's good to know there's hope. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai,

D11262: KDE logout screen background color fix

ngraham added a comment. Ray, this fix hasn't made it into a release yet; it was just committed this morning. So we wouldn't expect someone using 5.12.4 to benefit from the fix yet. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart,

D11262: KDE logout screen background color fix

ragreen added a comment. 5.12.4 Way too dark. A guy posted a 5.8 vs 5.12 on Neon's G+. F5778120: Screenshot_20180330_182831.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc:

D11262: KDE logout screen background color fix

ngraham added a comment. I meant, we wouldn't need to subsequently merge it into master because in this case, it's already in master. But yes, for the future, committing to the branch and merging to master is the preferred approach. You can actually use `arc` for this, for future

D11808: [weather dataengine] Fix BBC provider to adapt to change RSS feed

kossebau added a comment. The old RSS feed disappeared the last days, so this needs to go to Plasma/5.12 and also be pointed at to the distributions as hotfix, as any existing weather applets using the BBC weather service will continue to fail without this patch. Hoping for some

D11262: KDE logout screen background color fix

fvogt added a comment. In D11262#237036 , @ngraham wrote: > Since it was already committed to the `master` branch, wouldn't just need to be cherry-picked into the `Plasma/5.12` branch at this point? That's exactly what I wrote?

D11808: [weather dataengine] Fix BBC provider to adapt to change RSS feed

kossebau created this revision. kossebau added reviewers: Plasma, jriddell. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The urls of the BBC weather feeds seem to have

D11262: KDE logout screen background color fix

ngraham added a comment. Since it was already committed to the `master` branch, wouldn't just need to be cherry-picked into the `Plasma/5.12` branch at this point? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: fvogt,

D11262: KDE logout screen background color fix

fvogt added a comment. In D11262#237032 , @Pitel wrote: > It is meant as one. I am still kinda new here, so I am not exactly sure how to that (without confusing Phabricator). Cherry-pick the commit into the destination branch, merge into

D11262: KDE logout screen background color fix

Pitel added a comment. It is meant as one. I am still kinda new here, so I am not exactly sure how to that (without confusing Phabricator). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: fvogt, cfeck, fredrik, ngraham,

D11807: AbstractModel: Check if index is valid in setData

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY It would crash in MapBase::objectAt if the index is not valid

D11262: KDE logout screen background color fix

fvogt added a comment. This seems to be a bugfix - `Plasma/5.12` branch as well? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ragreen, ZrenBot,

D11262: KDE logout screen background color fix

Pitel added a comment. I guess I should have renamed it from `isLightColor` to something like `isNotAlmostBlack`... The point was to replace almost black colors with real black because it looks better with opacity. IMHO `(0,0,128)`, which is deep blue, is far enough from black to not mess

D11262: KDE logout screen background color fix

cfeck added a comment. In D11262#235414 , @Pitel wrote: > I finally got to do some testing and it is not looking good for luminance formula `0.2126*r + 0.7152*g + 0.0722*b`. > > Screenshot with background color `#5500FF` (blueish, button

Re: Changes to networkmanager-qt - breakage in plasma-workspace

krop already fixed that On Thursday, March 29, 2018 6:21:41 PM EDT Ben Cooksley wrote: > Hi Jan, > > It seems that as part of your recent changes to networkmanager-qt to > increase the dependency to 1.0.0 you've made some other changes which > mean the appropriate include paths are no longer

D11262: KDE logout screen background color fix

This revision was automatically updated to reflect the committed changes. Closed by commit R120:af2a74341d5f: KDE logout screen background color fix (authored by Pitel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11262?vs=29324=30937 REVISION

D11757: Polish sidebar header appearance

ngraham closed this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D11757 To: ngraham, mart, #plasma, #vdg Cc: davidedmundson, abetts, richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11638: modernize: delete redundant return statements

This revision was automatically updated to reflect the committed changes. Closed by commit R31:004b81c4efdd: modernize: delete redundant return statements (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11638?vs=30377=30933 REVISION DETAIL

D11636: modernize: delete redundant void args

This revision was automatically updated to reflect the committed changes. Closed by commit R31:f632fdc8c431: modernize: delete redundant void args (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11636?vs=30375=30932 REVISION DETAIL

D11635: modernize: use nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit R31:a7b40ce13d2b: modernize: use nullptr (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11635?vs=30374=30930 REVISION DETAIL

D11639: delete COPYING-ICONS

This revision was automatically updated to reflect the committed changes. Closed by commit R31:98cfe1d1f2fc: delete COPYING-ICONS (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11639?vs=30378=30929 REVISION DETAIL

D11659: Update systemsettings fonts docbook to 5.12

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e0dcb53828e5: Update systemsettings fonts docbook to 5.12 (authored by lueck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11659?vs=30435=30928#toc REPOSITORY R119 Plasma Desktop

D11660: Update systemsettings cursortheme docbook

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9496387296b2: Update systemsettings cursortheme docbook (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11660?vs=30436=30927 REVISION

D11686: Update desktop theme docbook to 5,12

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6f7e65df93eb: Update desktop theme docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11686?vs=30518=30926 REVISION DETAIL

D11687: Update autostart docbook to 5,12

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b24fcb3a63ea: Update autostart docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11687?vs=30520=30924 REVISION DETAIL

D11688: Update mouse docbook to 5,12

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e190bb9bddaf: Update mouse docbook to 5.12 (authored by lueck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11688?vs=30521=30923#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D11690: Update keys docbook to 5.12

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4edcfeb171f3: Update keys docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11690?vs=30523=30922 REVISION DETAIL

D11693: Update kcmnotify docbook to 5.12

This revision was automatically updated to reflect the committed changes. Closed by commit R119:80db7f6151f6: Update kcmnotify docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11693?vs=30535=30921 REVISION DETAIL

D11711: Update launchfeedback docbook to 5.12

This revision was automatically updated to reflect the committed changes. Closed by commit R119:71a6081d11e9: Update launchfeedback docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11711?vs=30613=30920 REVISION

D11794: Drop unused dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0a349abccb5f: Drop unused dependency (authored by asturmlechner). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11794?vs=30887=30917 REVISION DETAIL

D11262: KDE logout screen background color fix

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. let's go for it REPOSITORY R120 Plasma Workspace BRANCH logoutColorFix REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: fredrik, ngraham, abetts,

D11410: [RFC] Add option to make applet fixed width

mart added a comment. almost there :) I have a couple of points, then it can go :) INLINE COMMENTS > ConfigOverlay.qml:385 > +iconSource: "distribute-horizontal-x" > +visible: currentApplet.expandingApplet > +tooltip: i18n("Make

D11794: Drop unused dependency

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. right, we removed all kcms from that repo a while ago REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D11794 To: asturmlechner, #plasma, mart

D11722: If GL context creation fails fall back to the software renderer

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.cpp:186 > Nvidia driver upgrade is how I ended up in my situation :D > > Pernament global forcing is what I've gone for. Which is why it sort of > already covers the lock screen case. > I could make it not save and do

D11801: remove m_desktopContainments

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY with new corona containment query functions in D11361

D6313: Support Icon Scale from Icon naming specification 0.13

hein added a comment. I also prefer the "Before" images. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, davidedmundson,