KDE CI: Plasma xdg-desktop-portal-kde kf5-qt5 SUSEQt5.9 - Build # 16 - Failure!

2018-04-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20xdg-desktop-portal-kde%20kf5-qt5%20SUSEQt5.9/16/ Project: Plasma xdg-desktop-portal-kde kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Apr 2018 05:48:44 + Build duration: 3 min 38 sec and counting

KDE CI: Plasma xdg-desktop-portal-kde kf5-qt5 FreeBSDQt5.9 - Build # 5 - Failure!

2018-04-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20xdg-desktop-portal-kde%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Plasma xdg-desktop-portal-kde kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 05 Apr 2018 05:48:44 + Build duration: 1 min 13 sec and counting

D11928: fade to blue when the login box appears

2018-04-04 Thread Nathaniel Graham
ngraham added a subscriber: richardbowen. ngraham added a comment. Well, we don't actually have to fade to a color at all. If we don't do that, then my concern #2 becomes moot. In this case, all that's really needed is to further improve the text contrast against light or busy backgrounds.

D11832: Update kfontview docbook to 5.12

2018-04-04 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R119:1133795f6995: Update kfontview docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11832?vs=31024=31319 REVISION DETAIL

D11864: Update kinfocenter docbook to 5.12

2018-04-04 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R102:5d2473481412: Update kinfocenter docbook to 5.12 (authored by lueck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11864?vs=31099=31318 REVISION DETAIL

D11812: Update translations docbook to 5.12

2018-04-04 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5f8541f791b0: Update translations docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11812?vs=30954=31317 REVISION DETAIL

D11813: Update colors docbook to 5.12

2018-04-04 Thread Burkhard Lück
lueck closed this revision. lueck added a comment. https://commits.kde.org/plasma-desktop/14ba3cfe43663077edc0362d00301522451fa8bc REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11813 To: lueck, #plasma, #documentation, mart Cc: plasma-devel,

D11817: Update kcmsmserver docbook to 5.12

2018-04-04 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4c627632a92c: Update kcmsmserver docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11817?vs=30967=31316 REVISION DETAIL

D11831: Update fontinst docbook to 5.12

2018-04-04 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R119:31677cba0e71: Update fontinst docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11831?vs=31020=31314 REVISION DETAIL

Purism and Plasma meeting summary

2018-04-04 Thread Heather Ellsworth
Hi Everyone, Today we had the first bi-weekly meeting to facilitate more collaboration between Plasma and Purism developers. The attendees were: Aleix, Bhushan, Sebastien, Bob, Dorota, and myself. **Here are some of the highlights:** * Introductions and recap on what's been done so far to run

D11551: use the new install_package form

2018-04-04 Thread Martin Kostolný
martinkostolny added a comment. Last info: on my side everything seems to compile and work just fine now. Thanks for your work! :) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D11551 To: mart, #plasma Cc: martinkostolny, plasma-devel, ragreen,

D11919: support for standalone ksplash themes

2018-04-04 Thread David Edmundson
davidedmundson added a comment. What do we need the different package root for? Just for making sure it's not selected in the lnf KCM? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11919 To: mart, #plasma Cc: davidedmundson, plasma-devel, ragreen, Pitel,

D11928: fade to blue when the login box appears

2018-04-04 Thread Marco Martin
mart added a comment. In D11928#239917 , @ngraham wrote: > I think we need to keep in mind the original issues that prompted the desire for a redesign: > > 1. Poor text contrast against some backgrounds > 2. Inappropriate use of "Plasma

D11928: fade to blue when the login box appears

2018-04-04 Thread Marco Martin
mart added a comment. phabricator seems not to like youtube links, let's try again https://www.youtube.com/watch?v=m1--4czRr8Q REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11928 To: mart, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, ragreen,

D11919: support for standalone ksplash themes

2018-04-04 Thread Marco Martin
mart added a comment. In D11919#239861 , @davidedmundson wrote: > > the idea is the store wants to move all packages that have a splash and nothing else as a separate splashscreen category and not having them listed in look and feel if

D11928: fade to blue when the login box appears

2018-04-04 Thread Nathaniel Graham
ngraham added a comment. I think we need to keep in mind the original issues that prompted the desire for a redesign: 1. Poor text contrast against some backgrounds 2. Inappropriate use of "Plasma Blue" selection color as a background color This patch arguably makes issue #1

D3484: Center systemmonitor window properly on multi-screen setup

2018-04-04 Thread Christoph Feck
cfeck added a comment. > I thought the consensus was that the window shouldn't set it's properties (size and keepabove) and it's up to Kwin to set them It is the application that sets the window size. Since the initial size is likely wrong, applications usually remember sizes of windows

D11928: fade to blue when the login box appears

2018-04-04 Thread Marco Martin
mart created this revision. mart added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY - display the wallpaper and the clock with a shadow by default - at

D11927: [System Model] Support actions

2018-04-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Forward the action information to the model and pass all

D11876: Display star ratings

2018-04-04 Thread Andrew Crouthamel
acrouthamel added a comment. I like the bigger stars, but then again I seem to increase font size and whatnot for a lot of things. REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store, #vdg Cc: fabianr, ragreen, acrouthamel, plasma-devel, Pitel,

D11919: support for standalone ksplash themes

2018-04-04 Thread David Edmundson
davidedmundson added a comment. > the idea is the store wants to move all packages that have a splash and nothing else as a separate splashscreen category and not having them listed in look and feel if everything it does is to just change the splash screen. Store change makes sense, as

D11919: support for standalone ksplash themes

2018-04-04 Thread Marco Martin
mart added a comment. In D11919#239761 , @davidedmundson wrote: > I'm a bit confused by a few things. > > 1. We seem to have our own generic ksplash package format already. See KCMSplashScreen::load ~128 Which isn't deleted. How do your

D11923: Avoid pointless config parse in ksplash

2018-04-04 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:3b02ff3c1706: Avoid pointless config parse in ksplash (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11923?vs=31293=31298

D11876: Display star ratings

2018-04-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 31295. ngraham added a comment. Update design CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11876?vs=31137=31295 BRANCH show-star-ratings (branched from master) REVISION DETAIL https://phabricator.kde.org/D11876 AFFECTED FILES

[Powerdevil] [Bug 353032] Add ability to set screen brightness for non-laptop displays so I can adjust to the room's lighting

2018-04-04 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=353032 Dr. Chapatin changed: What|Removed |Added CC||bugsefor...@gmx.com ---

D11876: Display star ratings

2018-04-04 Thread Nathaniel Graham
ngraham added a comment. How about this, folks? F5787644: How's this.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store, #vdg Cc: fabianr, ragreen,

D11923: Avoid pointless config parse in ksplash

2018-04-04 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. The same is also done in plasmashell, krunner, etc, probably a copy-paste thing. Not sure it had a deeper meaning? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D11923: Avoid pointless config parse in ksplash

2018-04-04 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Due to the nature of cascading configs we

D11876: Display star ratings

2018-04-04 Thread Fabian Riethmayer
fabianr added a comment. +1 for no line And if there must be a line, please choose a different color. Plasma blues is supposed to be used to indicate possible interaction . REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham,

D11876: Display star ratings

2018-04-04 Thread Andrew Crouthamel
acrouthamel added a comment. Yeah I like it without since they are already on separate cards. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store, #vdg Cc: ragreen, acrouthamel, plasma-devel, Pitel,

D11919: support for standalone ksplash themes

2018-04-04 Thread David Edmundson
davidedmundson added a comment. I'm a bit confused by a few things. 1. We seem to have our own generic ksplash package format already. See KCMSplashScreen::load ~128 Which isn't deleted. How do your changes tie in with that - and with the existing themes? 2. What's the

D11876: Display star ratings

2018-04-04 Thread Ray Green
ragreen added a comment. > VDG input requested. Do folks think we should also drop the blue line? > Or perhaps gray instead of blue? No line at all +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol,

D11876: Display star ratings

2018-04-04 Thread Nathaniel Graham
ngraham added a comment. Or perhaps gray instead of blue? I think that conforms to our HIG better, which says that color should be used for action. F5787610: gray instead of blue.png REPOSITORY R134 Discover Software Store REVISION DETAIL

D11876: Display star ratings

2018-04-04 Thread Nathaniel Graham
ngraham added a reviewer: VDG. ngraham added a comment. VDG input requested. Do folks think we should also drop the blue line? Here's how the lists would look: F5787605: Without blue lines.png REPOSITORY R134 Discover Software Store REVISION DETAIL

D11662: Minor cleanup.

2018-04-04 Thread Eike Hein
hein closed this revision. hein added a comment. Committed as 2c9cb3b2b961 to master. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11662 To: hein, #kirigami, mart, davidedmundson Cc:

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2018-04-04 Thread Alex Richardson
arichardson updated this revision to Diff 31284. arichardson edited the summary of this revision. arichardson added a comment. - Removed version check since we now depend on Qt 5.9 - Updated commit message REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST

D11919: support for standalone ksplash themes

2018-04-04 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY support the new standalone splashscreens of D11918

D11918: use a separate kind of package for splash screens

2018-04-04 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY use a standalone package type for splashscreens retrocompatible with lnf

Re: Changes to networkmanager-qt - breakage in plasma-workspace

2018-04-04 Thread Christophe Giboudeaux
Hi, On vendredi 30 mars 2018 00:21:41 CEST Ben Cooksley wrote: > Hi Jan, > > It seems that as part of your recent changes to networkmanager-qt to > increase the dependency to 1.0.0 you've made some other changes which > mean the appropriate include paths are no longer being provided to >