D12050: Make automounting work even if StorageAccess is ignored

ngraham added a comment. In D12050#242890 , @bruns wrote: > Well, I really do not like what arc is doing behind my back ... It irritated me too at first, but over time I found that it's fairly logical. In general, you just need to:

D12056: Don't have a non-integral size on separators

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY They look odd when placed by a rectangle in a Layout, they will be

D12050: Make automounting work even if StorageAccess is ignored

bruns added a comment. Well, I really do not like what arc is doing behind my back ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12050 To: bruns, ngraham, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12050: Make automounting work even if StorageAccess is ignored

ngraham added a comment. Well it's too late now, but yes, that would have worked (in general, make sure to look before you land by first doing `arc land --preview `). By default, `arc` lands the diff on the parent branch, which in this case was master. Arc documentation is at

D12050: Make automounting work even if StorageAccess is ignored

bruns added a comment. damn, that did not work as expected ... landed on master should I just "arc land --onto Plasma/5.12" ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12050 To: bruns, ngraham, #plasma, broulik Cc: plasma-devel, ragreen, Pitel,

D12050: Make automounting work even if StorageAccess is ignored

ngraham added a comment. Can you make sure this ends up on the 5.12 branch too? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12050 To: bruns, ngraham, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12050: Make automounting work even if StorageAccess is ignored

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8dedbcdf4197: Make automounting work even if StorageAccess is ignored (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12050: Make automounting work even if StorageAccess is ignored

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Land on the 5.12 branch, please. REPOSITORY R119 Plasma Desktop BRANCH fix_automounting_internal REVISION DETAIL https://phabricator.kde.org/D12050 To: bruns, ngraham, #plasma,

D12055: Delete border around menubars

zzag created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL https://phabricator.kde.org/D12055 AFFECTED

D11876: Display star ratings

This revision was automatically updated to reflect the committed changes. Closed by commit R134:19dbc556dbf2: Display star ratings (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11876?vs=31697=31704 REVISION DETAIL

D11842: Remove categories from app delegates

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:0911fbcd561c: Remove categories from app delegates (authored by ngraham). REPOSITORY R134 Discover Software Store

D11876: Display star ratings

rkflx added a comment. In D11876#242783 , @ngraham wrote: > Thanks for your review, @rkflx. I've fixed the overflow issue on Installed page, and in the Compact view more generally (Installed uses the Compact view). A by-product of these fixes

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren updated this revision to Diff 31700. Zren added a comment. Remove commented code. Add " New " to button label. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12041?vs=31652=31700 REVISION DETAIL https://phabricator.kde.org/D12041 AFFECTED

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

ngraham added inline comments. INLINE COMMENTS > Zren wrote in ConfigurationContainmentAppearance.qml:159 > "Get New Wallpaper" is capitalized. Are we using lowercase so the "Wallpaper > Plugins" stands out more? > > lowercase new vs uppercase New > > F5800706: 2018-04-08___11-09-40.png

D12036: Change "different user" icon on login screen

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7d19c5059b10: Change different user icon on login screen (authored by sharvey, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D6183: [Digital Clock] Allow copying current date and time to clipboard

bschiffner added a comment. No, I don't have commit access. "Bernhard Schiffner" But why my email, Kai-Uwe did 98,7% of the work ... @Kai-Uwe: Can you do the merge (DigitalClock.qml#77) before pushing, please? REVISION DETAIL

D12036: Change "different user" icon on login screen

ngraham added a comment. Let's stay with `system-switch-user` for now and see how that goes. REPOSITORY R120 Plasma Workspace BRANCH change-user-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12036 To: sharvey, ngraham, #vdg, #plasma, davidedmundson Cc:

D11848: [Kickoff] Reduce hover delay before switching tabs

ngraham added a comment. In D11848#242794 , @abetts wrote: > I am all for reducing the time but maybe keep some lag to tackle the points already made in the ticket Yes, this patch reduces it from 250ms to 50ms. REPOSITORY R119 Plasma

D11848: [Kickoff] Reduce hover delay before switching tabs

abetts added a comment. I am all for reducing the time but maybe keep some lag to tackle the points already made in the ticket REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, davidedmundson, abetts Cc: rikmills, hein, cfeck,

D11848: [Kickoff] Reduce hover delay before switching tabs

ngraham added a comment. Friendly ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, davidedmundson, abetts Cc: rikmills, hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11876: Display star ratings

ngraham added a comment. Thanks for your review, @rkflx. I've fixed the overflow issue on Installed page, and in the Compact view more generally (Installed uses the Compact view). A by-product of these fixes is that the alignment in general is now fixed as well! BRANCH show-star-ratings

D6183: [Digital Clock] Allow copying current date and time to clipboard

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Let's go for it now! Thanks for patience and apologies it took so long :/ Do you have commit access? else I need your email address and can push it on your behalf. INLINE COMMENTS >

D12050: Make automounting work even if StorageAccess is ignored

broulik added a comment. I did the KF5 port but I don't recall doing that or why it would be there, so +1 from me if it fixes that. I don't use automounter so I don't know REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12050 To: bruns, ngraham, #plasma,

D11876: Display star ratings

ngraham updated this revision to Diff 31697. ngraham added a comment. Also fix the general case for Compact view, which also has the side effect of fixing the alignment and centering, yay! CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11876?vs=31694=31697 BRANCH

D12050: Make automounting work even if StorageAccess is ignored

bruns added a comment. In D12050#242755 , @ngraham wrote: > Did you mean BUG: 391706? No, this commit *fixes* 389479, but it is a prerequisite for fixing 391706 (which is essentially a revert, thus would regress 389479). REPOSITORY

D12050: Make automounting work even if StorageAccess is ignored

ngraham added a comment. Did you mean BUG: 391706? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12050 To: bruns, ngraham Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12050: Make automounting work even if StorageAccess is ignored

bruns created this revision. bruns added a reviewer: ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY There is no reason to make mounting dependent on the

D11876: Display star ratings

ngraham updated this revision to Diff 31694. ngraham added a comment. Fix the overflow on the Installed page by not showing the stars there (it's not relevant on that page) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11876?vs=31646=31694 BRANCH show-star-ratings (branched

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added a comment. I've tried to restore old behavior, so: - If I run KWindowConfig::restoreWindowSize from dialog's constructor, it doesn't work on multi-monitor setup very well. windowHandle()→screen() seems to be set to leftmost screen (which isn't even primary in my case;

D6183: [Digital Clock] Allow copying current date and time to clipboard

bschiffner updated this revision to Diff 31690. bschiffner added a comment. works for me now / ready to ship Thanks Kai-Uwe for your advices with the qml problems. I'am far from understanding this topic. Mostly cargo cult, but nevertheless working. CHANGES SINCE LAST UPDATE

D11876: Display star ratings

abetts added a comment. +1 REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store, #vdg Cc: abetts, rkflx, fabianr, ragreen, acrouthamel, plasma-devel, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12036: Change "different user" icon on login screen

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace BRANCH change-user-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12036 To: sharvey, ngraham, #vdg, #plasma, davidedmundson Cc: abetts, sebas, davidedmundson, #vdg, plasma-devel, ragreen, Pitel,

D11876: Display star ratings

rkflx added a comment. @ngraham Thanks for the version bump. KF 5.45 is not even released yet, but after compiling Kirigami master I was able to run Discover with your patch. FYI, after clicking on Installed there is now some vertical overflowing going on. REVISION DETAIL

D12036: Change "different user" icon on login screen

sharvey added a subscriber: sebas. sharvey added a comment. PS: Credit to @sebas for making Cuttlefish! REPOSITORY R120 Plasma Workspace BRANCH change-user-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12036 To: sharvey, ngraham, #vdg, #plasma,

D12036: Change "different user" icon on login screen

sharvey added a comment. In D12036#242299 , @ngraham wrote: > In the Login screen, it lets you **//find//** other users not listed there to log in as. With all due respect to the designers, I never made that connection. I know the

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren added inline comments. INLINE COMMENTS > ngraham wrote in ConfigurationContainmentAppearance.qml:159 > It might be a bit wordy, but to be consistent with the form used everywhere > else, this should say, "Get new Wallpaper Plugins..." "Get New Wallpaper" is capitalized. Are we using

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

ngraham added inline comments. INLINE COMMENTS > ConfigurationContainmentAppearance.qml:71 > spacing: units.largeSpacing / 2 > -anchors.right: wallpaperRow.right > +// anchors.right: wallpaperRow.right > visible: pluginComboBox.count > 1 Don't leave

D11876: Display star ratings

ngraham added a comment. In D11876#242370 , @rkflx wrote: > In D11876#241499 , @ngraham wrote: > > > Should we tweak it a bit more? > > > One more thing to look into as a follow-up (besides

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

elvisangelaccio added a comment. Go for it! REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma, elvisangelaccio Cc: fvogt, ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel,

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson added a comment. In D4193#242444 , @fvogt wrote: > What about `Plasma/5.12`? It has a minimum of Qt 5.9 as well. Good point. Any objections against me cherry-picking it to the 5.12 branch? REPOSITORY R135 Integration for Qt

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

fvogt added a comment. What about `Plasma/5.12`? It has a minimum of Qt 5.9 as well. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma, elvisangelaccio Cc: fvogt, ngraham, krzyc, anthonyfieroni,

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

This revision was automatically updated to reflect the committed changes. Closed by commit R135:bfd41a95530f: KDEPlatformFileDialog: Fix initial directory selection for remote files (authored by arichardson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D11876: Display star ratings

rkflx added a comment. In D11876#241499 , @ngraham wrote: > Should we tweak it a bit more? One more thing to look into as a follow-up (besides the font size of the title) could be the vertical alignment of the text, i.e. how the first

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren created this revision. Zren added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Patch 2/2 (other patch is D12040 for

D12040: [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren created this revision. Zren added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Patch 1/2 (other patch is for plasma-desktop) BUG: #386621 -