D8673: Sanitize signal handling in ksmserver

2018-04-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:eb6e26197984: Sanitize signal handling in ksmserver (authored by jpalecek, committed by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D8673: Sanitize signal handling in ksmserver

2018-04-13 Thread Jiří Paleček
jpalecek added a comment. In D8673#245716 , @davidedmundson wrote: > Thanks, do you have commit access? Sorry, no. BRANCH master REVISION DETAIL https://phabricator.kde.org/D8673 To: jpalecek, #plasma, davidedmundson Cc: broulik,

D12148: update the wallpaper dialog to the new design

2018-04-13 Thread Marco Martin
mart added a comment. In D12148#245289 , @broulik wrote: > Now I don't see any wallpapers in the list > > GridDelegate.qml:63: ReferenceError: view is not defined > > I did update kdeclarative and kirigami before ouch right,

D12088: port the ksplash kcm to the new design

2018-04-13 Thread Marco Martin
mart added a comment. this is an experiment (still full of binding loops) which implements the way we talked about of - frame always 100% wide - cells spacing flexible while resizing https://www.youtube.com/watch?v=bJjESzaUL48 REPOSITORY R119 Plasma Desktop BRANCH

D12176: Turn okularkirigami into an executable

2018-04-13 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R223:5f8f84d53cf8: Turn okularkirigami into an executable (authored by apol). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12176?vs=32070=32071 REVISION DETAIL

D12176: Turn okularkirigami into an executable

2018-04-13 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Kirigami, Okular, mart. Restricted Application added projects: Kirigami, Okular. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Makes for straightforward Android testing and will

D8673: Sanitize signal handling in ksmserver

2018-04-13 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks, do you have commit access? BRANCH master REVISION DETAIL https://phabricator.kde.org/D8673 To: jpalecek, #plasma, davidedmundson Cc: broulik, graesslin,

D8673: Sanitize signal handling in ksmserver

2018-04-13 Thread Jiří Paleček
jpalecek updated this revision to Diff 32067. jpalecek added a comment. I finally got round to this. So: - this revision stores the socketpair fds in KSMServer instance, so they can be closed later. - also, it uses the modern QObject::connect syntax with pmfs instead of strings

D12173: [Workspace Scripting] Turn "gridUnit" into a property getter function

2018-04-13 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids calling into `QFontMetrics` on startup for a method that

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 395 - Still unstable!

2018-04-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/395/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Fri, 13 Apr 2018 12:56:40 + Build duration: 15 min and counting JUnit Tests Name: (root)

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 224 - Still unstable!

2018-04-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/224/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 13 Apr 2018 12:56:40 + Build duration: 2 min 40 sec and counting JUnit Tests

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 223 - Still Failing!

2018-04-13 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/223/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 13 Apr 2018 12:47:05 + Build duration: 49 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 394 - Still Failing!

2018-04-13 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/394/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Fri, 13 Apr 2018 12:47:05 + Build duration: 55 sec and counting CONSOLE OUTPUT [...truncated

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-13 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12171 To: aacid, #plasma, hein Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-13 Thread Albert Astals Cid
aacid added a comment. This is how it looks now F5806642: now.png This is how it looked before F5806645: before.png Notice how quite critical information is missing from the cut text in the old

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-13 Thread Albert Astals Cid
aacid created this revision. aacid added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY On my install i have various application names that don't fit on