D9875: Extend parsing ssh prompt

2018-04-19 Thread Pali Rohár
pali updated this revision to Diff 32615. pali added a comment. Rebased on top of master, hopefully correctly. REPOSITORY R105 KDE SSH Password Dialog CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9875?vs=25313=32615 REVISION DETAIL https://phabricator.kde.org/D9875 AFFECTED

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-19 Thread Friedrich W . H . Kossebau
kossebau added a comment. @aacid Does the new context pattern "spacing to number + unit" make more sense to you (and remind you less of sad things ) )? Would then push this otherwise now, given that the new proposed context UI marker will be only really available once 4.46 is out, so

D12361: Use XCursorTheme on wayland as well

2018-04-19 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R123:4af192630606: Use XCursorTheme on wayland as well (authored by fvogt). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12361?vs=32586=32599

D12102: Port Language KCM to Qt Quick

2018-04-19 Thread Eike Hein
hein updated this revision to Diff 32597. hein added a comment. Fix logic bug in managing the sheet's Add button enabled state. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=32589=32597 BRANCH master REVISION DETAIL

D12097: Make room for footer and header.

2018-04-19 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R296:c6c41b4a97cc: Make room for footer and header. (authored by hein). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12097?vs=31836=32594 REVISION DETAIL

D12102: Port Language KCM to Qt Quick

2018-04-19 Thread Eike Hein
hein added a comment. About the overlay sheet close button missing a hover effect: @mart committed 66402004783 to kirigami.git, but it's not working for me and the icon on the button is also scaled wrong somehow

D12102: Port Language KCM to Qt Quick

2018-04-19 Thread Eike Hein
hein added a comment. @mart Remaining issues: - I need an 'animating' property on OverlaySheet similar to other components, so I can delay unsetting the source model for the list view in the sheet until after the sheet is done animating. I want to unset the model to save resources but

D12102: Port Language KCM to Qt Quick

2018-04-19 Thread Eike Hein
hein updated this revision to Diff 32589. hein added a comment. - Disable the "Add languages..." button when no languages are available and show an InlineMessage - Fix using the overlay sheet more than once to add languages within the same session (QStringList props and concat() with

D12361: Use XCursorTheme on wayland as well

2018-04-19 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY wayland-cursor uses xcursor to load cursors, so this is fine. TEST PLAN I can select cursors on wayland again. REPOSITORY

D12356: Move volume constants into functions

2018-04-19 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R994:c102a76c9538: Move volume constants into functions (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12356?vs=32583=32584

D12356: Move volume constants into functions

2018-04-19 Thread David Rosca
drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Yeah, sorry, it would actually build, but it wouldn't do what you wanted. REPOSITORY R994 Pulseaudio Qt Bindings BRANCH nopulseheader REVISION DETAIL

D12356: Move volume constants into functions

2018-04-19 Thread Nicolas Fella
nicolasfella added a comment. Weird, it did build for me so I didn't notice, sorry REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D12356 To: nicolasfella, drosca, apol Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12356: Move volume constants into functions

2018-04-19 Thread Nicolas Fella
nicolasfella updated this revision to Diff 32583. nicolasfella added a comment. - Fix names REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12356?vs=32573=32583 BRANCH nopulseheader REVISION DETAIL https://phabricator.kde.org/D12356

D12359: Also read sddm.conf.d config directories

2018-04-19 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY /etc/sddm.conf is read last, with files in /etc/sddm.conf.d/ and /usr/lib/sddm/sddm.conf.d/ taking precedence. The paths in

D12356: Move volume constants into functions

2018-04-19 Thread David Rosca
drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Yes, that's what I had in mind. But please make it build (`MinimalVolume` in header vs `minimalVolume` in source). Also I think we should use "minimum" instead of "minimal",

D12356: Move volume constants into functions

2018-04-19 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: drosca, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Get rid of pulse include in context.h TEST

D12351: introduce candidateContainments

2018-04-19 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY DesktopView contains a property candidateContainments which are all

Re: KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 60 - Failure!

2018-04-19 Thread Marco Martin
should be fixed now, the job is blue On Thu, Apr 19, 2018 at 11:09 AM, Ben Cooksley wrote: > On Thu, Apr 19, 2018 at 12:12 AM, Aleix Pol wrote: > >> Yes, we were having the same issue for android. Just landed a fix. >> > > Thanks for fixing the CMake part

Re: KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 60 - Failure!

2018-04-19 Thread Ben Cooksley
On Thu, Apr 19, 2018 at 12:12 AM, Aleix Pol wrote: > Yes, we were having the same issue for android. Just landed a fix. > Thanks for fixing the CMake part of it, but it appears that we've still got a broken header include :( Marco: please investigate this. As a Dependency

D12323: Read theme.conf of themes

2018-04-19 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R123:ebdfab7e0867: Read theme.conf of themes (authored by fvogt). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12323?vs=32499=32549 REVISION

Fwd: Your Akademy talk proposal

2018-04-19 Thread Jonathan Riddell
Rejected! - Forwarded message from akademy-t...@kde.org - Date: Thu, 19 Apr 2018 05:40:26 + From: akademy-t...@kde.org To: j...@jriddell.org Subject: Your Akademy talk proposal Reply-To: akademy-t...@kde.org Dear Jonathan. Thank you for your talk proposal we've received for this

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-19 Thread Fabian Riethmayer
fabianr added a comment. What I don't like is that the menus in the different hierarchy levels can have a different size now. To have them in an uniform size gives them a more consistent look. Change all the menus, in all hierarchy levels, to the same dynamic size? REPOSITORY R119