D12676: [Notifications] Show tooltip on action when text doesn't fit

2018-05-02 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN I fear the tooltip as a separate window might screw with the auto hide

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread Fabian Vogt
fvogt added a comment. In D12405#257444 , @davidedmundson wrote: > The good: > > In one setup I was pleasantly surpised at how well it worked. Fonts did behave as expected. > Specatcle was able to capture all screens and individual

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread David Edmundson
davidedmundson added a comment. The good: In one setup I was pleasantly surpised at how well it worked. Fonts did behave as expected. Specatcle was able to capture all screens and individual rects correctly. The less good: When I switched round the primary monitor all

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread Fabian Vogt
fvogt updated this revision to Diff 33520. fvogt added a comment. Fix build REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12405?vs=32709=33520 BRANCH perscreenxcb REVISION DETAIL https://phabricator.kde.org/D12405 AFFECTED FILES

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > outputconfig.cpp:143 > +} else { > +QPushButton scaleDialogButton = new QPushButton(i18n("Scale > Display"), this); > +connect(scaleDialogButton, ::released, [this] { QPushButton* REPOSITORY R104 KScreen REVISION

Re: Late API change to KWayland for upcoming Frameworks release

2018-05-02 Thread Martin Flöser
Am 2018-05-02 06:19, schrieb Roman Gilg: I have the following patch to KWayland adding a property for per OutputDevcie color correction via color curve adjustment: https://phabricator.kde.org/D12388 The problem is that Frameworks tag is on Saturday, but if the patch does not get in with next

D12433: Add Plasma Calendar plugin Astronomical Events

2018-05-02 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R114:0b3312f0ade3: Add Plasma Calendar plugin Astronomical Events (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12433?vs=32771=33503#toc REPOSITORY R114 Plasma Addons

KDE CI: Plasma user-manager kf5-qt5 SUSEQt5.10 - Build # 3 - Fixed!

2018-05-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20user-manager%20kf5-qt5%20SUSEQt5.10/3/ Project: Plasma user-manager kf5-qt5 SUSEQt5.10 Date of build: Wed, 02 May 2018 14:51:29 + Build duration: 1 min 33 sec and counting JUnit Tests

KDE CI: Plasma user-manager kf5-qt5 FreeBSDQt5.10 - Build # 3 - Fixed!

2018-05-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20user-manager%20kf5-qt5%20FreeBSDQt5.10/3/ Project: Plasma user-manager kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 02 May 2018 14:51:29 + Build duration: 40 sec and counting

KDE CI: Plasma user-manager kf5-qt5 SUSEQt5.10 - Build # 2 - Failure!

2018-05-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20user-manager%20kf5-qt5%20SUSEQt5.10/2/ Project: Plasma user-manager kf5-qt5 SUSEQt5.10 Date of build: Wed, 02 May 2018 14:45:44 + Build duration: 3 min 30 sec and counting CONSOLE OUTPUT

KDE CI: Plasma user-manager kf5-qt5 FreeBSDQt5.10 - Build # 2 - Failure!

2018-05-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20user-manager%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Plasma user-manager kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 02 May 2018 14:45:44 + Build duration: 3 min 14 sec and counting CONSOLE OUTPUT

D12468: Enable anti-aliasing for user avatars

2018-05-02 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R128:da05675b4292: Enable anti-aliasing for user avatars (authored by ktatunov, committed by davidedmundson). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D12469: Fix avatar picture aliasing and stretching in kickoff

2018-05-02 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:9da4da7ea7f7: Fix avatar picture aliasing and stretching in kickoff (authored by ktatunov, committed by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12468: Enable anti-aliasing for user avatars

2018-05-02 Thread Kirill Tatunov
ktatunov added a comment. Could someone commit this for me please? I don't have a developer account. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D12468 To: ktatunov, #plasma, davidedmundson Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel,

D12469: Fix avatar picture aliasing and stretching in kickoff

2018-05-02 Thread Kirill Tatunov
ktatunov added a comment. Could someone commit this for me please? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12469 To: ktatunov, #plasma, mart Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12278: WIP: [Colors KCM] Port to new design

2018-05-02 Thread Marco Martin
mart added a comment. ok, will work on the widget tinting on next weeks then :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Marco Martin
mart added a comment. In D12563#257052 , @dscheffer wrote: > In D12563#257024 , @broulik wrote: > > > Urgh. Just because you can doesn't mean you should. This will horribly break if the user is

D12663: Link against kcrash

2018-05-02 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R161:27aef2a104d7: Link against kcrash (authored by davidedmundson). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12663?vs=33492=33493 REVISION

D12610: Avoid crashing on failed flatpak_installation_list_installed_refs_for_update

2018-05-02 Thread Aleix Pol Gonzalez
apol added a comment. Ugh sorry, saw the bug report and fixed it before going through the e-mails... REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12610 To: davidedmundson, #plasma, mart Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12663: Link against kcrash

2018-05-02 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Now get drkonqi errors REPOSITORY R161 KActivity Manager Service BRANCH master

D11410: [RFC] Add option to make applet fixed width

2018-05-02 Thread Marco Martin
mart added a comment. we're here, mergein few days when 5.13 freezes and 5.14 branch opens REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11410 To: Pitel, #plasma Cc: mart, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D11558: Sync systemloadviewer showed items to ksysguard/system monitor

2018-05-02 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R114:6e753e6653ac: Sync systemloadviewer showed items to ksysguard/system monitor (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11558?vs=30143=33491#toc REPOSITORY

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-05-02 Thread Marco Martin
mart added a comment. In D12040#257172 , @Zren wrote: > In D12040#257170 , @mart wrote: > > > so, if the qpointer is used in a connect, it needs to have .data() to work on gcc 4.8. > > if

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-05-02 Thread Chris Holland
Zren added a comment. In D12040#257170 , @mart wrote: > so, if the qpointer is used in a connect, it needs to have .data() to work on gcc 4.8. > if accessed normally, it doesn't need it So I need to change

D12278: WIP: [Colors KCM] Port to new design

2018-05-02 Thread Kai Uwe Broulik
broulik added a comment. In D12278#257148 , @mart wrote: > what about having this with just color boxes on 5.13 and then figure out controls tinting in 5.14? I would prefer not to rush things and have something half-baked, I still need

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-05-02 Thread Marco Martin
mart added a comment. In D12040#253357 , @cfeck wrote: > In D12040#253335 , @Zren wrote: > > > Remove `.data()` since it seems to work without it. > > > Even with gcc 4.8 (openSUSE Leap)?

D11909: properly use kpackage_install_package

2018-05-02 Thread Marco Martin
mart added a comment. fine tis version (with kpackage_install_package and not yet the bundled version) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11909 To: zzag, #breeze Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread Fabian Vogt
fvogt added a comment. > As for this patch. It needs Qt patches, so it's definitely not 5.13, possibly not even 5.14 material. > > After 5.13.0 I'm willing to give this a fair test. > If it indeed does work great, cool. That's a misunderstanding. The code here as-is works with Qt

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread David Edmundson
davidedmundson added a comment. As for this patch. It needs Qt patches, so it's definitely not 5.13, possibly not even 5.14 material. After 5.13.0 I'm willing to give this a fair test. If it indeed does work great, cool. However, I dont' want to merge something that replaces one

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread Fabian Vogt
fvogt added a comment. > It is, for things that aren't Qt Yup. Just for Qt it's not required anymore. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: mart, hein, ngraham, graesslin, davidedmundson, plasma-devel, ragreen, Pitel,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread David Edmundson
davidedmundson added a comment. > With https://bugreports.qt.io/browse/QTBUG-67928 fixed, the Xft.dpi setting code shouldn't be needed anymore either. It is, for things that aren't Qt REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc:

D12278: WIP: [Colors KCM] Port to new design

2018-05-02 Thread Marco Martin
mart added a comment. what about having this with just color boxes on 5.13 and then figure out controls tinting in 5.14? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg Cc: mart, abetts, ngraham, davidedmundson, plasma-devel,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread Fabian Vogt
fvogt added a comment. > -1 from here as well, it won't and it can't work reliably, it would be pretty much a false promise It does though. With https://bugreports.qt.io/browse/QTBUG-67928 fixed, the Xft.dpi setting code shouldn't be needed anymore either. REPOSITORY R104

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-05-02 Thread Marco Martin
mart added a comment. -1 from here as well, it won't and it can't work reliably, it would be pretty much a false promise REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: mart, hein, ngraham, graesslin, davidedmundson, plasma-devel,

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-05-02 Thread Marco Martin
mart added a comment. anyways, that's just my personal use case (that has a lot of keep it simple) final decision is Eike's REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12462 To: Fuchs, hein Cc: mart, fabianr, plasma-devel, ragreen, Pitel, ZrenBot,

D12610: Avoid crashing on failed flatpak_installation_list_installed_refs_for_update

2018-05-02 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. Heh, aleix just pushed the same thing REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12610 To: davidedmundson, #plasma, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D12658: Migrate to ecm_qt_declare_logging_category

2018-05-02 Thread Maximiliano Curia
maximilianocuria closed this revision. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D12658 To: maximilianocuria, #plasma, ivan, lbeltrame, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

ki18n 5.45 issue for Plasma workspace 5.12.5

2018-05-02 Thread Jonathan Riddell
Plasma Workspace 5.12.5 has an issue when compiled with ki18n 5.45, cmake can get confused if your build path is long and hang until it runs out of memory. Should be fixed by Diff 12216 "Don't need to run previous iterations commands again" [Closed] https://phabricator.kde.org/D12216

Re: Late API change to KWayland for upcoming Frameworks release

2018-05-02 Thread Roman Gilg
On Wed, May 2, 2018 at 10:11 AM, Marco Martin wrote: > how necessary is it for 5.13? would it miss important functionality? It would miss the per output color correction feature, what is important to some people: https://bugs.kde.org/show_bug.cgi?id=389110

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-05-02 Thread Fabian Riethmayer
fabianr added a comment. > to me pinning should mean: > > - i say what are the most important tasks to me (regardless if it's for one activity or for all activities) > - i want them always there, no matter whether running or not > - they stay always exactly in the same place (muscle

D12658: Migrate to ecm_qt_declare_logging_category

2018-05-02 Thread Maximiliano Curia
maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, ivan, lbeltrame. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. REVISION SUMMARY During D12656

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-05-02 Thread Christian
Fuchs added a comment. In D12462#257021 , @mart wrote: > In D12462#252987 , @Fuchs wrote: > > > In D12462#252982 , @mart wrote: > > > > > I like the

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Dennis Scheffer
dscheffer added a comment. In D12563#257024 , @broulik wrote: > Urgh. Just because you can doesn't mean you should. This will horribly break if the user is running a different look and feel package (different form factor, distro branding, etc).

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Kai Uwe Broulik
broulik added a comment. > wrote a C++ plugin that loads the RunCommand.qml using KPackage and subsequently registers the file with the qml type system. Urgh. Just because you can doesn't mean you should. This will horribly break if the user is running a different look and feel package

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Dennis Scheffer
dscheffer added a comment. In D12563#257018 , @mart wrote: > what's the exact use case? what plasmoid are you writing? (btw, you can't use that qml file in a plasmoid, if you want to embed parts of krunner in a plasmoids, those are components

D12656: Use category logging

2018-05-02 Thread Maximiliano Curia
maximilianocuria closed this revision. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D12656 To: maximilianocuria, #plasma, lbeltrame, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-05-02 Thread Marco Martin
mart added a comment. In D12462#252987 , @Fuchs wrote: > In D12462#252982 , @mart wrote: > > > I like the idea a lot, > > tough i am not sure i like the implementation: right now is kindof

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Marco Martin
mart added a comment. what's the exact use case? what plasmoid are you writing? (btw, you can't use that qml file in a plasmoid, if you want to embed parts of krunner in a plasmoids, those are components coming from milou) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D12573: Style enhancement for network management applet

2018-05-02 Thread Marco Martin
mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. imo that's not a thing to be fixed at the applet level, that's how that particular plasma theme looks, you can't fix a 3rd party plasma theme by patching applets to not follow it.

D12656: WIP: Use category logging

2018-05-02 Thread Maximiliano Curia
maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, lbeltrame, ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. REVISION SUMMARY Without this

D7747: Added an extra fuzzytime setting - Hobbit Time

2018-05-02 Thread Luigi Toscano
ltoscano added a comment. In D7747#184142 , @ltoscano wrote: > Also, according those links: > > - http://askmiddlearth.tumblr.com/post/41765286488/the-seven-daily-hobbit-meals > -

Re: Late API change to KWayland for upcoming Frameworks release

2018-05-02 Thread Marco Martin
how necessary is it for 5.13? would it miss important functionality? otherwise would be better to push dai 1 of new cycle and have the plasma part at the beginning of 5.14 cycle? too late for 5 13 to depend on next framework? On Wed, May 2, 2018 at 6:19 AM, Roman Gilg wrote: >

[Powerdevil] [Bug 382105] Power devil crash dès la sortie de veille

2018-05-02 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=382105 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

2018-05-02 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=345618 Kai Uwe Broulik changed: What|Removed |Added CC|

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

2018-05-02 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=345618 Kai Uwe Broulik changed: What|Removed |Added CC||kris...@agiliadev.fr

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

2018-05-02 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=345618 Kai Uwe Broulik changed: What|Removed |Added CC||alpenadi...@gmail.com

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

2018-05-02 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=345618 Kai Uwe Broulik changed: What|Removed |Added CC|

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

2018-05-02 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=345618 Kai Uwe Broulik changed: What|Removed |Added CC||espe...@junta.no ---

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

2018-05-02 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=345618 Kai Uwe Broulik changed: What|Removed |Added CC||kde@estada.ch