Re: Closing old Plasma 4 bugs

No objections from me. It was definitely not the intention to prevent users from being able to report wishlist tickets, or to prevent DrKonqi from being able to correctly file crash bugs. Nate On Fri, 11 May 2018 14:06:46 -0700 Christoph Feck wrote > On 11.02.2018

Re: Closing old Plasma 4 bugs

On 11.02.2018 20:52, Nate Graham wrote: All right, so let's give it a shot. How about we make it so that normal users have full privilages except the following: - Can't bulk change - Can't change Importance field We now see regressions caused by this particular change: - new 'wishlist'

D12774: Fix submenus not updating when switching between categories of the same size

dfaure added a comment. Oops, thanks for the fix. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12774 To: hein, #plasma, mart Cc: dfaure, rikmills, ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12102: Port Language KCM to Qt Quick

mart added a comment. if i select more than one language, only one will be added, the others will be added as "unknown" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij,

D12827: Added process details in the process list context menu

chrisx created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. chrisx requested review of this revision. REVISION SUMMARY The process details dialog displays more information on a process such as number of page faults and

D12102: Port Language KCM to Qt Quick

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:66 > +delegate: Kirigami.BasicListItem { > +width: ListView.view.width > + sorry, counter what i told you before, setting an

D12823: Workaround for binding loop in Material Theme

Dax created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. Dax requested review of this revision. REVISION SUMMARY This patch adds a workaround for Material theme: the highlightColor property causes a binding loop thats

D12822: Added null check in OverlayDrawer

Dax created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. Dax requested review of this revision. REVISION SUMMARY This patch checks if 'header' property is valid Tested with Qt 5.10.1 on Android REPOSITORY R169

D12821: Added missing files in QMake's .pri

Dax created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. Dax requested review of this revision. REVISION SUMMARY As the title says I have added some missing files, in this way an Kirigami based application compiles

D12760: Improve single-instance application behavior

volkov added inline comments. INLINE COMMENTS > mart wrote in main.cpp:71 > KWindowSystem::forceActiveWindow should never be used by normal applications, > it's reserved for workspaces and won't work on Wayland. > QWidget::activateWindow should be enough, even if that's not guaranteed to >

D12760: Improve single-instance application behavior

volkov added a comment. The documentation of KDBusService recommends to use it: https://api.kde.org/frameworks/kdbusaddons/html/classKDBusService.html#af0ad38f597aedaf22a30045d0423ed0e And many applications do it: https://lxr.kde.org/search?_filestring=&_string=forceActiveWindow

D12685: Fix calendar view: hide unused start/end time labels in day events list

mart added inline comments. INLINE COMMENTS > CalendarView.qml:193 > +readonly property bool hasEndTime: > !isNaN(modelData.endDateTime.getTime()); > +readonly property bool isAllDay: { > // Explicitly all-day event being a very

D12713: Make some strings easier to translate

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > FancyPlotter.cpp:597 > //Use a multi length string incase we do not have > enough room > -lastValue = i18n("%1 of %2"

D12760: Improve single-instance application behavior

mart added inline comments. INLINE COMMENTS > main.cpp:71 > +connect(service, ::activateRequested, this, [this]() { > +KWindowSystem::forceActiveWindow(display->winId()); > +}); KWindowSystem::forceActiveWindow should never be used by normal applications, it's reserved for

D12781: Fix filetypestest

maximilianocuria closed this revision. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D12781 To: maximilianocuria, #plasma, kossebau, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12775: Always set applet title, even when label is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R119:28dc6b88538e: Always set applet title, even when label is disabled (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12775?vs=33871=33978

D12774: Fix submenus not updating when switching between categories of the same size

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c0cd1f8d49e6: Fix submenus not updating when switching between categories of the same size (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12698: WIP: Show SNI to install browser-side extension

hein added a comment. I currently don't have the time to make the showCount stuff per-browser to handle multi-browser usage. I think it might also not be worth it. People who use multiple browsers are probably power user enough to hear about and install the extension themselves. Please

D12698: WIP: Show SNI to install browser-side extension

hein updated this revision to Diff 33976. hein added a comment. Unload also on early abort. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12698?vs=33975=33976 BRANCH arcpatch-D12698 REVISION DETAIL

D12698: WIP: Show SNI to install browser-side extension

hein added a comment. > - The SNI doesn't disappear when the browser is closed. This no longer matters in the latest revision, because the SNI will now run the launched browser with the URL as argument. If it's been closed it'll just reopen. > - When you click the SNI to open, it

D12698: WIP: Show SNI to install browser-side extension

hein updated this revision to Diff 33975. hein added a comment. Always open the extension URL in the browser that was actually launched, instead of relying on it being the same as the default browser. Don't show the SNI if we can't find the browser to launch it. REPOSITORY R856

D12819: Fix the global drawer handle "click"

lepagevalleeemmanuel created this revision. lepagevalleeemmanuel added reviewers: davidedmundson, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. lepagevalleeemmanuel requested review of this revision. REVISION SUMMARY Bug: -