D12855: Move search field to its own row so it doesn't get compressed

ngraham added inline comments. INLINE COMMENTS > WidgetExplorer.qml:157 > /* > +* This was here when I got here 5/12/18 - sharvey > PlasmaCore.Dialog { ? Not sure The extra comment adds anything. Instead we should just remove the commented-out code in a new patch IMHO. >

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Reported on reddit:

D12837: Split replaceAccount from addAccountToCache

ngraham added a comment. Bulletproof steps to reproduce for me: 1. System Settings > Account Details > User Manager > Create a new user 2. Give the new user admin rights 3. Log out 4. Log in as that the new user 5. Go to System Settings > Account Details > User Manager The

D12855: Move search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34083. sharvey added a comment. Submitted from wrong local branch REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34078=34083 BRANCH new-search-row (branched from master) REVISION DETAIL

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

miklosm created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. miklosm requested review of this revision. REVISION SUMMARY When the applet is on a vertical panel, its horizontal size is limited, and the speedLabel clashes

D12855: Move search field to its own row so it doesn't get compressed

sharvey added a comment. Before: {F5846708} -- After: F5846710: Screenshot_20180513_082104.png F5846712: Screenshot_20180513_082036.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12849: Improve layout of fonts kcm

ngraham added a comment. Alignment looks great to me! We might want to take the opportunity to also center-align the titles, which it better-looking for these centered formlayout style UIs. And maybe use a bit of extra vertical padding instead of that horizontalline separator? REPOSITORY

D12855: Move search field to its own row so it doesn't get compressed

sharvey created this revision. sharvey added reviewers: ngraham, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Move search to its own row to prevent it from

Re: Cursor sizes on wayland

Am 2018-05-09 12:08, schrieb Aleix Pol: On Tue, May 8, 2018 at 8:57 PM, Martin Flöser wrote: Am 8. Mai 2018 17:05:57 MESZ schrieb Aleix Pol : Hi, I've been looking into getting a consistent cursor look on wayland, which is specially daunting because of

D12853: Calendar widget: fix resize

miklosm created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. miklosm requested review of this revision. REVISION SUMMARY If the fullRepresentation has a minimum size, the applet cannot be shrinked back to show the

D12835: Draw borders around side panels by default

ngraham abandoned this revision. ngraham added a comment. Wow, I didn't know what a minefield I was stepping into with this topic... but I believe my suspicions are confirmed that this design choice represented a compromise that did not satisfy everyone--hence the option. I can see now that

D12852: Added the option to display date in the same line of clock

astevanato created this revision. astevanato added a reviewer: Plasma: Workspaces. astevanato added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. Restricted Application added a subscriber: plasma-devel. astevanato requested review

D12851: Change preview text background color to match with default combobox background color

progwolff created this revision. progwolff added reviewers: mart, abetts, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY The default combobox background color is

D12849: Improve layout of fonts kcm

progwolff created this revision. progwolff added reviewers: mart, abetts, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY Change the layout of the fonts kcm using

D12835: Draw borders around side panels by default

dhaumann added a comment. I as someone being around for 15 years now also immediately thought "huh? Why this forth and back and forth..."? I believe you need much more investigation here and discussion with the visual design group, maybe a blog asking about what people like more.

D12835: Draw borders around side panels by default

hpereiradacosta added a comment. Note: I am not saying that the current design is the best one. However it was designed as an improvement to the framed one. Reverting to the framed version is basically discarding this work. I would rather see some work done on improving upon what has been

D12835: Draw borders around side panels by default

hpereiradacosta added a comment. Note that there is no bug report, to my knowledge, complaining about this. (neither usability wise nor design wise). REPOSITORY R31 Breeze BRANCH borders-around-settings-window-side-panels (branched from master) REVISION DETAIL

D12835: Draw borders around side panels by default

hpereiradacosta added a comment. Maybe it is just me who has been around for too long ... REPOSITORY R31 Breeze BRANCH borders-around-settings-window-side-panels (branched from master) REVISION DETAIL https://phabricator.kde.org/D12835 To: ngraham, andreaska Cc: hpereiradacosta,

D12835: Draw borders around side panels by default

hpereiradacosta added a comment. This is really interesting how things go back and forth if you wait long enough ... Removing this frame (by default) was a _big_ thing at the time breeze was designed, and there was countless discussion on how to do it. Wait five years, and the same

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 34053. hein added a comment. Don't mutate source model while building list of langs to add to selection. This will likely fix Marco's problem. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12822: Added null check in OverlayDrawer

Dax added a comment. Yes it's the same one! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12822 To: Dax Cc: apol, plasma-devel, davidedmundson, mart, hein

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 34051. hein added a comment. Remove width from delegate in sheet again. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=33818=34051 BRANCH arcpatch-D12102_1 REVISION DETAIL

D12774: Fix submenus not updating when switching between categories of the same size

hein added a comment. No worries, also my fault for not spotting it in review. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12774 To: hein, #plasma, mart Cc: dfaure, rikmills, ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12835: Draw borders around side panels by default

rkflx added a comment. If you revert a design decision, your summary should include a reference to the arguments of the original decision, a justification for changing it back again based on those, and you should try to get consent from the original authors and designers. In general