Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

Hi all, If someone could please check if this is correct, and whether Plasma Vault is intended to be built outside of Linux systems? Regards, Ben On Sat, May 19, 2018 at 9:30 AM, CI System wrote: > *BUILD FAILURE* > Build URL https://build.kde.org/job/Plasma%20plasma-vault%

D12974: Workspace KCM Code Improvement

ngraham added a comment. While we're doing some formatting and style cleanup work, how about renaming some variables? For example `m_ostateToolTip` and `m_ostateVisualFeedback` aren't very descriptive IMHO. Maybe instead, they could be `m_currentToolTipState` and

D12973: Workspace KCM Redesign Using Kirigami

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nicely done! Code and visual changes look good to me. Tested it out and everything still works. Just two little comment formatting nitpicks, then this is good to go from my perspective!

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in actionlist.cpp:156 > I assume you have a second patch in p-f for this? > > (which means this is Plasma 5.14 material) This patch worked just for me all by itself, so I wasn't aware this required a plasma-framework change

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

davidedmundson added inline comments. INLINE COMMENTS > actionlist.cpp:156 > actionList << Kicker::createActionItem(i18n("Pin to Task Manager"), > "addToTaskManager"); > +} else if (ContainmentInterface::mayAddLauncher(appletInterface, > ContainmentInterface::Panel)) { > +

D12973: Workspace KCM Redesign and Formatting Improvement

furkantokac updated this revision to Diff 34459. furkantokac added a comment. Workspace KCM is redesigned by using Kirigami. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12973?vs=34454=34459 BRANCH kcmworkspace-Redesign REVISION DETAIL

D12974: Workspace KCM Code Improvement

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REVISION SUMMARY Code formatting is improved. "save" function is improved by preventing unnecessary file

D12973: Workspace KCM Redesign and Formatting Improvement

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH kcmWorkspaceFormatting REVISION DETAIL

KDE CI: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 - Build # 15 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20SUSEQt5.10/15/ Project: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 21:29:52 + Build duration: 19 min and counting JUnit

KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/ Project: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 21:29:55 + Build duration: 1 min 4 sec and counting

plasma-desktop 5.13 beta update

I've updated the tar for plasma-desktop to include fixes from the Plasma/5.12 branch plasma-desktop;Plasma/5.13;9403d033927990dd71319583dd9c196f7da36c24;plasma-desktop-5.12.90.1.tar.xz;d7bf37b745ef47efa2bd19338d45a12d385fdf35d1c4d17f235241475 59ddae5

KDE CI: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20SUSEQt5.10/14/ Project: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 20:39:54 + Build duration: 5 min 27 sec and counting

KDE CI: Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-integration%20stable-kf5-qt5%20FreeBSDQt5.10/2/ Project: Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 17:15:17 + Build duration: 30 min and counting

KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/3/ Project: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 17:15:17 + Build duration: 28 min and counting

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham created this revision. ngraham added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Users get confused by the difference between "Pin to Task

D12960: Drag handle to reorder items in a ListView

alex-l added a comment. Cursors and hover: F5856535: immagine.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol,

D12960: Drag handle to reorder items in a ListView

mart added a comment. In D12960#264749 , @ngraham wrote: > IMHO the up-and-down arrows do a much better job of communicating "drag me!" than a 9 dot grid does. good point, so so far my favourite are the options by alex REPOSITORY R169

D12960: Drag handle to reorder items in a ListView

ngraham added a comment. IMHO the up-and-down arrows do a much better job of communicating "drag me!" than a 9 dot grid does. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: alex-l, abetts, rkflx, ngraham, zzag,

D12960: Drag handle to reorder items in a ListView

mart added a comment. In D12960#264737 , @alex-l wrote: > In D12960#264732 , @alex-l wrote: > > > F5856484: immagine.png > > > I think the mouse cursor

D12936: Rewrite workspace KCM in QtQuick

furkantokac added inline comments. INLINE COMMENTS > zzag wrote in workspaceoptions.cpp:110 > Coding style nitpick: No whitespace after `(` and before `)`. Also, I > believe, there should be a whitespace between control statement keyword and > opening parentheses. Done. Thanks. I avoid small

D12960: Drag handle to reorder items in a ListView

alex-l added a comment. In D12960#264732 , @alex-l wrote: > F5856484: immagine.png I think the mouse cursor should be: - drag-open-hand for first one - clickable-finger (like for links) for

KDE CI: Plasma powerdevil kf5-qt5 SUSEQt5.10 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/5/ Project: Plasma powerdevil kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 14:49:49 + Build duration: 42 min and counting JUnit Tests Name: (root)

D12960: Drag handle to reorder items in a ListView

abetts added a comment. In D12960#264734 , @ngraham wrote: > Regardless of what icon we choose, for a drag handle, I think it has to be a very light gray. We previously had a 4x3 dot grid, but because it was black, it looked very heavy and when

D12960: Drag handle to reorder items in a ListView

ngraham added a comment. In D12960#264732 , @alex-l wrote: > F5856484: immagine.png I really like the vertical drag icon here! Not so sure about the horizontal swipe icon though. REPOSITORY R169

D12960: Drag handle to reorder items in a ListView

ngraham added a comment. Regardless of what icon we choose, for a drag handle, I think it has to be a very light gray. We previously had a 4x3 dot grid, but because it was black, it looked very heavy and when a bunch of them were all lined up vertically, the net effect was sort of weird.

D12960: Drag handle to reorder items in a ListView

alex-l added a comment. F5856484: immagine.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, mart, hein

KDE CI: Plasma plasma-integration kf5-qt5 SUSEQt5.10 - Build # 4 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20SUSEQt5.10/4/ Project: Plasma plasma-integration kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 14:47:54 + Build duration: 33 min and counting JUnit Tests

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/7/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 14:48:19 + Build duration: 23 min and counting CONSOLE OUTPUT

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.10 - Build # 5 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/5/ Project: Plasma kde-cli-tools kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 14:44:21 + Build duration: 3 min 2 sec and counting JUnit Tests

D12960: Drag handle to reorder items in a ListView

abetts added a comment. In D12960#264657 , @rkflx wrote: > F5855884: drag-handles.png I think with this image we are trying to convey too much. Users in general, will understand that if you have a

Plasma 5.13 beta

Plasma 5.13 Beta brings many new features to this lightweight but full featured desktop. https://www.kde.org/announcements/plasma-5.12.90.php Plasma Browser Integration, System Settings Redesigns, New Look Login/Lock Screens, Redesigned Media Player Widget, oh so much more...

Plasma 5.13 errata

Please review this page (copied from 5.12) for noteable problems in Plasma 5.13 https://community.kde.org/Plasma/5.13_Errata Jonathan

KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.10 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/18/ Project: Plasma systemsettings kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 13:06:52 + Build duration: 29 min and counting JUnit Tests

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 13:05:08 + Build duration: 29 min and counting CONSOLE OUTPUT

KDE CI: Plasma powerdevil kf5-qt5 SUSEQt5.10 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/4/ Project: Plasma powerdevil kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 13:06:43 + Build duration: 20 min and counting CONSOLE OUTPUT

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/4/ Project: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 13:01:36 + Build duration: 5 min 6 sec and counting CONSOLE

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.10 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/4/ Project: Plasma kde-cli-tools kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 13:01:36 + Build duration: 1 min 56 sec and counting CONSOLE OUTPUT

D12960: Drag handle to reorder items in a ListView

rkflx added a comment. F5855884: drag-handles.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

ngraham added a comment. How about the version like that, but with fewer dots? I thought those looked really, really good. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: ngraham, zzag, plasma-devel, apol, davidedmundson,

Plasma Vaults by Default

It's been suggested that we don't have Plasma Vaults visible by default in the systray as it adds extra clutter. Should we set them to be hidden by default? Jonathan

D12960: Drag handle to reorder items in a ListView

mart added a comment. Possible handles (to resume that old discussion) F5855838: Spectacle.q10653.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: zzag, plasma-devel, apol,

D12960: Drag handle to reorder items in a ListView

mart updated this revision to Diff 34430. mart added a comment. all files REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12960?vs=34426=34430 BRANCH mart/dragHandle REVISION DETAIL https://phabricator.kde.org/D12960 AFFECTED FILES

D12962: prototype of a drag handle

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY fix DelegateRecycler for elements that may change index when moved seamless drag finish up

D12960: Drag handle to reorder items in a ListView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:5ba11c3b9efe: proper version (authored by mart). CHANGED PRIOR TO COMMIT

D12960: Drag handle to reorder items in a ListView

mart updated this revision to Diff 34425. mart added a comment. - proper version REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12960?vs=34423=34425 BRANCH mart/dragHandle REVISION DETAIL https://phabricator.kde.org/D12960 AFFECTED FILES

D12960: Drag handle to reorder items in a ListView

zzag added inline comments. INLINE COMMENTS > kirigamiplugin.cpp:172 > +//2.5 > +qmlRegisterType(componentUrl(QStringLiteral("ListItemDragHandle.qml")), > uri, 2, 4, "ListItemDragHandle"); > + Is the minor version correct? REPOSITORY R169 Kirigami REVISION DETAIL

D12960: Drag handle to reorder items in a ListView

mart added a comment. in action https://youtu.be/vQUnOpwV9xU note that the red square icon is a placeholder, new breeze icons are needed for that REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: plasma-devel, apol,

D12960: Drag handle to reorder items in a ListView

mart created this revision. mart added reviewers: Kirigami, VDG, hein. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY A component to be inserted in list items of any kind, when

D12958: Fix AppsModel not refreshing on syccoa changes.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7e514201e2f1: Fix AppsModel not refreshing on syccoa changes. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12958?vs=34420=34421

D12958: Fix AppsModel not refreshing on syccoa changes.

sitter accepted this revision. sitter added a comment.    REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D12958 To: hein, broulik, sitter, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12958: Fix AppsModel not refreshing on syccoa changes.

broulik accepted this revision. broulik added a comment. Aua :( REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D12958 To: hein, broulik, sitter, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12958: Fix AppsModel not refreshing on syccoa changes.

hein created this revision. hein added reviewers: broulik, sitter. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Fixes regression introduced by a0ca2d1bc204 .

KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.10 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/17/ Project: Plasma systemsettings kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 09:44:34 + Build duration: 24 min and counting CONSOLE OUTPUT

KDE CI: Plasma powerdevil kf5-qt5 SUSEQt5.10 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/3/ Project: Plasma powerdevil kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 09:44:22 + Build duration: 23 min and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 09:43:17 + Build duration: 16 min and counting CONSOLE OUTPUT

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/3/ Project: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 09:39:51 + Build duration: 1 min 53 sec and counting CONSOLE

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.10 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/3/ Project: Plasma kde-cli-tools kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 09:39:51 + Build duration: 1 min 25 sec and counting CONSOLE OUTPUT

D12957: Show focus rect when CheckBox or RadioButton are focused

broulik created this revision. broulik added reviewers: Plasma, VDG, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This was missing from the QQC1 desktop style. TEST

D12956: Fix Workspace KCM translation domain name

This revision was automatically updated to reflect the committed changes. Closed by commit R119:00ec9a991525: Fix Workspace KCM translation domain name (authored by romangg). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12956?vs=34415=34416 REVISION

D12936: Rewrite workspace KCM in QtQuick

romangg added inline comments. INLINE COMMENTS > ltoscano wrote in Messages.sh:2 > Because they did not ask :) > But in most cases the renamed KCMs kept the old name, and that's fine too. Jeez, I won't say who these people were (Night Color KCM...). Ok, I created a patch in D12956

D12956: Fix Workspace KCM translation domain name

romangg created this revision. romangg added reviewers: Plasma, ltoscano, yurchor. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY TRANSLATION_DOMAIN and value in Messages.sh

D12936: Rewrite workspace KCM in QtQuick

ltoscano added inline comments. INLINE COMMENTS > romangg wrote in Messages.sh:2 > Ok, I will upload a diff shortly in order to change it here and in the > TANSLATION_DOMAIN to `kcm5_workspace`. I was just a bit unsure about the `5` > in the name, because other QML rewrites of KCMs I saw

D12936: Rewrite workspace KCM in QtQuick

romangg added inline comments. INLINE COMMENTS > ltoscano wrote in Messages.sh:2 > Either the old name, or kcm5_, and it should be the same as > TRANSLATION_DOMAIN. Ok, I will upload a diff shortly in order to change it here and in the TANSLATION_DOMAIN to `kcm5_workspace`. I was just a bit

D12936: Rewrite workspace KCM in QtQuick

ltoscano added inline comments. INLINE COMMENTS > romangg wrote in Messages.sh:2 > Change this line as follows? > > $XGETTEXT `find . -name "*.cpp" -o -name "*.qml"` -o > $podir/kcm_workspace.pot Either the old name, or kcm5_, and it should be the same as TRANSLATION_DOMAIN. REPOSITORY

D12936: Rewrite workspace KCM in QtQuick

romangg added inline comments. INLINE COMMENTS > Messages.sh:2 > #! /usr/bin/env bash > -$EXTRACTRC *.ui >> rc.cpp > -$XGETTEXT *.cpp -o $podir/kcmworkspaceoptions.pot > +$XGETTEXT `find . -name "*.cpp" -o -name "*.qml"` -o > $podir/kcm_workspaceoptions.pot Change this line as follows?

D12936: Rewrite workspace KCM in QtQuick

ltoscano added inline comments. INLINE COMMENTS > romangg wrote in workspaceoptions.cpp:34 > So do we need to change this here, in the CMake file, or can the translation > catalog be renamed (or a new one created) with the name `kcm_workspace` to > make the naming consistent? > > Before in

D12936: Rewrite workspace KCM in QtQuick

romangg added inline comments. INLINE COMMENTS > ltoscano wrote in workspaceoptions.cpp:34 > Iirc that's unrelated. The catalog name is not set by this call. So do we need to change this here, in the CMake file, or can the translation catalog be renamed (or a new one created) with the name

D12936: Rewrite workspace KCM in QtQuick

ltoscano added inline comments. INLINE COMMENTS > yurchor wrote in workspaceoptions.cpp:34 > This might not work with translations as the translation catalog is named > "kcm_workspaceoptions". Iirc that's unrelated. The catalog name is not set by this call. REPOSITORY R119 Plasma Desktop