D13101: Fix adding langs more than once within the same session.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:150f8877ee42: Fix adding langs more than once within the same session. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13101?vs=34837&id=3

D13101: Fix adding langs more than once within the same session.

hein added a comment. There's no more risk than before. Both versions of the code add two lists together, the other one just ran into Qt Quick type bullshit where one list got serialized to a string. In terms of what the risk of dupes is: There's one base model with a data role for "is

D13101: Fix adding langs more than once within the same session.

davidedmundson added inline comments. INLINE COMMENTS > main.qml:108 > > addLanguagesSheet.selectedLanguages.sort().forEach(function(index) { > > langs.push(availableLanguagesModel.get(index).LanguageCode); > }); Is there now a

D13101: Fix adding langs more than once within the same session.

hein created this revision. hein added a reviewer: davidedmundson. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY BUG:394455 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.13 REVISION DETAIL https://phabricator.kde.org/D13101 AF

D13100: do not use buffered file IO

dakon created this revision. dakon added a reviewer: aacid. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dakon requested review of this revision. REVISION SUMMARY This is not necessary here. Additionally we can use O_CLOEXEC to make sur

D11262: KDE logout screen background color fix

raddison added a comment. It looks like that in Kubuntu 18.04 ... F5866833: current.png Seems okay to me. It's not dark, it's fairly transparent and it doesn't have any artifacts. Can anyone confirm it with a screenshot? REPOSITORY R120 Plasma W

Dependency on Solid/PowerManagement from KDELibs4Support

Checking what blocks porting away -workspace and -desktop from KDELibs4Support, I see Solid/PowerManagement. I have not checked what exactly is needed from this module, but could we release this module separately if there is no plan to integrate it back to Solid? -- Christoph Feck

D13095: Scren brightness follow a quatratic progression

thsurrel updated this revision to Diff 34825. thsurrel added a reviewer: Plasma. thsurrel added a comment. Added context REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13095?vs=34812&id=34825 REVISION DETAIL https://phabricator.kde.org/D13095 AFFECTE

D13095: Scren brightness follow a quatratic progression

romangg added a comment. Pls add context and reviewer Plasma. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13071: [Klipper] Port away from KLineEdit

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf5e72907510: Port away from KLineEdit (authored by cfeck). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13071?vs=34734&id=34823 REVISION DETAIL https

D13070: [libtaskmanager] Add missing QUrlQuery includes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ed274a056de9: Add missing QUrlQuery includes (authored by cfeck). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13070?vs=34732&id=34822 REVISION DETAIL

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added inline comments. INLINE COMMENTS > kiconloader.h:277 > + * @p canReturnNull. > + * @since 5.48 > + */ Next release is 5.47, but I am fine with waiting for additional feedback if this is controversial. REPOSITORY R302 KIconThemes REVISION DETAIL https://phab

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added inline comments. INLINE COMMENTS > kiconloader.h:527 > * @see resetPalette > - * @since 5.39 > + * @since 5.38 > */ Is this missing a rebase or intended? See https://cgit.kde.org/kiconthemes.git/commit/?id=b506a48214a08f56d79e7847a22b0417028a46ff REPOSITORY R3

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

On 24.05.2018 12:05, Ben Cooksley wrote: Based on the lack of response I will be deeming Plasma Vault unmaintained Why do sysadmins enforce a strict policy to have a clean CI instead of "just" offering the service? We don't declare products unmaintained because they have bugs in bugzilla eith

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

Ivan, please respond. Ben, Vault is maintained, so it's unfortunate that you haven't gotten a response yet. Nate On 05/24/2018 04:05 AM, Ben Cooksley wrote: On Wed, May 23, 2018 at 9:08 PM, Ben Cooksley > wrote: On Sat, May 19, 2018 at 4:15 PM, Ben Cooksley m

D13030: Display brightness OSD even when min and max is reached

This revision was automatically updated to reflect the committed changes. Closed by commit R122:4b8ae4d708a6: Display brightness OSD even when min and max is reached (authored by thsurrel, committed by ngraham). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D13030: Display brightness OSD even when min and max is reached

romangg accepted this revision. romangg added a comment. Works for me (can't test minimum case since screen is dark then) and good usability improvement. Please in next patches import the context of the diff to Phab (either use arc or `git diff -U9 ...`. REPOSITORY R122 Powerdevil

D13095: Scren brightness follow a quatratic progression

thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Modern hardware allow to adjust the screen brightness very precisely, with more than hundreds or

D13063: distro release upgrade checker for ubuntu distros

jriddell abandoned this revision. jriddell added a comment. Moved to own app https://cgit.kde.org/scratch/jriddell/distro-release-notifier.git/ REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13063 To: jriddell, apol, rikmills Cc: plasma-devel, ragr

D13073: Weigh matching services by relating data used in query to their menuids

This revision was automatically updated to reflect the committed changes. Closed by commit R120:664b90afcfd8: Weigh matching services by relating data used in query to their menuids (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13

D13073: Weigh matching services by relating data used in query to their menuids

hein updated this revision to Diff 34804. hein added a comment. Don't both mutate _and_ return. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13073?vs=34742&id=34804 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13073 AFFE

D13059: Only enable on XCB

This revision was automatically updated to reflect the committed changes. Closed by commit R100:8d88ca5a07fc: Only enable on XCB (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13059?vs=34704&id=34800#toc REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE

D13062: Don't manipulate foreign windows

This revision was automatically updated to reflect the committed changes. Closed by commit R135:6288079d936b: Don't manipulate foreign windows (authored by broulik). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13062?vs=3471

D13031: [ProcessModel] Center more column headings

This revision was automatically updated to reflect the committed changes. Closed by commit R111:7a580e83e1b2: [ProcessModel] Center more column headings (authored by broulik). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13031?vs=34626&id=34796 RE

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

In data giovedì 24 maggio 2018 12:05:08 CEST, Ben Cooksley ha scritto: > Based on the lack of response I will be deeming Plasma Vault unmaintained > and will be moving it there in 24 hours time. Please contact Ivan first. He may have missed this message in the ML. -- Luca Beltrame - KDE Forums

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

On Wed, May 23, 2018 at 9:08 PM, Ben Cooksley wrote: > On Sat, May 19, 2018 at 4:15 PM, Ben Cooksley wrote: > >> Hi all, >> >> If someone could please check if this is correct, and whether Plasma >> Vault is intended to be built outside of Linux systems? >> > > *Ping* > Based on the lack of res

D13085: [RadioButton] Rename "control" to "controlRoot"

This revision was automatically updated to reflect the committed changes. Closed by commit R858:9e864e8059c1: [RadioButton] Rename "control" to "controlRoot" (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13085

D13086: Don't set explicit spacing on RadioButton/CheckBox

This revision was automatically updated to reflect the committed changes. Closed by commit R858:05d7f273eb94: Don't set explicit spacing on RadioButton/CheckBox (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13

D13087: [FocusRect] Use manual placement instead of anchors

This revision was automatically updated to reflect the committed changes. Closed by commit R858:ec06b3bc2f98: [FocusRect] Use manual placement instead of anchors (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13087?vs=34787&id=34791#toc REPOSITORY R858 Qt Quick C

D13087: [FocusRect] Use manual placement instead of anchors

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I thought I was smart by using `anchors` that get auto-mirror

D13086: Don't set explicit spacing on RadioButton/CheckBox

broulik created this revision. broulik added reviewers: Plasma, VDG, mart, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The appropriate spacing is already determined by

D13085: [RadioButton] Rename "control" to "controlRoot"

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This makes it consistent with `CheckBox` and also fixes the f

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 34781. broulik added a comment. … REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=34780&id=34781 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES src/kiconengine.cpp src/kiconengine.h

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 34780. broulik added a comment. - Remove accidental cruft REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=34779&id=34780 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES src/kiconengine.

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 34779. broulik added a comment. - Rename to `loadIcon` with `scale` to `loadScaledIcon` to avoid ambiguous overload REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=31197&id=34779 REVISION DETAIL https://p

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. One last word about the necessity of this arrow. To me the arrow is mandatory as soon as it refers to an action that is different than the one of the icon. (either long press, or extra menu beside the icon main action). Still to me, opening a menu when pressi

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. In D13064#267463 , @ngraham wrote: > Got the chance to test this out. Functionally, it works great, and resolves the issue! > > Visually, I can understand you guys's hesitation about bringing the arrows back

D13068: Filter out incognito tabs and media controls on Firefox

This revision was automatically updated to reflect the committed changes. Closed by commit R856:8ddc5bc6f920: Filter out incognito tabs and media controls on Firefox (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13068

[kio-extras] [Bug 369520] FISH: directories are mistaken for files and vice-versa

https://bugs.kde.org/show_bug.cgi?id=369520 --- Comment #3 from sebaro --- Yes, in "Details" view I can also expend the directory content. I have this issue in any server I tried, VPS/DigitalOcean or dedicated/OVH, many versions of Ubuntu and CentOS. Didn't try LAN. -- You are receiving this m

D13042: Do not show activity switcher during fast switches

thsurrel updated this revision to Diff 34774. thsurrel added a comment. Update the timing to match what is used in KWin and Alt-Tab REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13042?vs=34655&id=34774 REVISION DETAIL https://phabricator.kde.org/