D11848: [Kickoff] Reduce hover delay before switching tabs

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, davidedmundson, abetts, hein Cc: rikmills, hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. Oh. I see. The Phab emails say "now ready to land", so I did what the machine told me to. But I clearly see your point. Hopefully he will be okay with it. If not, I'm more than willing to roll it back and make any further changes. REPOSITORY R119 Plasma Deskto

D13122: Add second line of text for KickerDash item descriptions

ngraham added a comment. Hmm, I might have waited for @hein's review too... One thing I'm myself just now coming to understand is that it's often a good idea to wait for more than just one reviewer to offer their view. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.k

D13122: Add second line of text for KickerDash item descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cd7252e9fa07: Add second line of text for KickerDash item descriptions (authored by sharvey). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13122?vs=34895&i

D13122: Add second line of text for KickerDash item descriptions

sharvey updated this revision to Diff 34895. sharvey added a comment. - - Remove trailing whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13122?vs=34885&id=34895 BRANCH two-row-dash (branched from master) REVISION DETAIL https://phabr

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. I forgot it was a bug. I thought it was an assignment. :-) REPOSITORY R119 Plasma Desktop BRANCH two-row-dash (branched from master) REVISION DETAIL https://phabricator.kde.org/D13122 To: sharvey, ngraham, hein, plasma-devel Cc: ragreen, Pitel, ZrenBot, leslie

Re: Closing old Plasma 4 bugs

Kubuntu 18.04 has now now been out for a month, so if there are no further objections, I'll begin preparations for this Plasma 4 mass bug close. Nate On 02/14/2018 10:16 AM, Christoph Feck wrote: On 10.02.2018 21:24, Nate Graham wrote: Hello folks, We have more than 2,500 Plasma 4 bugzill

D13122: Add second line of text for KickerDash item descriptions

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, this is exactly how I'd have done it, too. Since this fixes https://bugs.kde.org/show_bug.cgi?id=362986, let's add `BUG: 362986` at the bottom of the Summary (if you do it with t

KDE CI: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 - Build # 25 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20SUSEQt5.10/25/ Project: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 Date of build: Sat, 26 May 2018 02:10:34 + Build duration: 42 min and counting JUnit T

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.10 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.10/20/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 26 May 2018 02:10:34 + Build duration: 7 min 25 sec and counting

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 50 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/50/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Sat, 26 May 2018 02:10:09 + Build duration: 6 min 56 sec and counting JUnit Tests

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 - Build # 43 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.10/43/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 26 May 2018 02:10:09 + Build duration: 3 min 55 sec and counting JUnit Tes

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.10 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.10/19/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 26 May 2018 02:02:04 + Build duration: 5 min 21 sec and counting

KDE CI: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20SUSEQt5.10/24/ Project: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 Date of build: Sat, 26 May 2018 02:02:04 + Build duration: 4 min 1 sec and counting CON

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 49 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/49/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Sat, 26 May 2018 01:43:49 + Build duration: 21 min and counting CONSOLE OUTPUT [

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 - Build # 42 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.10/42/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 26 May 2018 01:43:49 + Build duration: 6 min 46 sec and counting CONSOLE OU

D13123: Make .deb and .rpm mime type handling optional at build time

apol added a comment. Good idea! How about looking for the `rpm` and `dpkg` executables? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13123 To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abet

D13119: Abort transaction on PK dependency resolution error

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks better, thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13119 To: arojas, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. Great, looking much better than before. As far as I can see the inline comments are done. In D10297#229850 , @rkflx wrote: > - The text should use title case: "Kill a Window" Not done. > - The shortcut doe

D13123: Make .deb and .rpm mime type handling optional at build time

arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY Having discover handle .deb packages is useless in non-Debian based dis

D13119: Abort transaction on PK dependency resolution error

arojas updated this revision to Diff 34886. arojas added a comment. Remove wrong check for !m_proceedFunctions.isEmpty() REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13119?vs=34881&id=34886 REVISION DETAIL https://phabricator.kde.org/D1

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. F5868921: Screenshot_20180525_164110.png Unfortunate line breaks in long file names. See line 98. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13122 To: sharvey, ngraham, hein, plasma-devel

D13122: Add second line of text for KickerDash item descriptions

sharvey added inline comments. INLINE COMMENTS > ItemGridDelegate.qml:98 > elide: Text.ElideRight > -wrapMode: Text.NoWrap > +wrapMode: Text.Wrap > Note: will wrap at an arbitrary point if there's no natural break. Happens with long filenames under "Recent Documents"

D13122: Add second line of text for KickerDash item descriptions

sharvey created this revision. sharvey added reviewers: ngraham, hein, plasma-devel. Restricted Application added a project: Plasma. sharvey requested review of this revision. REVISION SUMMARY Adds a second line of text under icon/doc icons for more clarity. Will stop at two lines; if text con

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

https://bugs.kde.org/show_bug.cgi?id=362830 --- Comment #7 from Thomas Surrel --- Proposed patch: https://phabricator.kde.org/D13095 If you can, try it out and tell me what you think. -- You are receiving this mail because: You are the assignee for the bug.

D13111: Activate next task in group on shortcut

mvourlakos added a comment. @lholecek do you have commit access? or I should commit it for you ? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D13111 To: lholecek, mvourlakos Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abe

D13119: Abort transaction on PK dependency resolution error

arojas updated this revision to Diff 34881. arojas added a comment. Check for ExitStatus in cleanup() and move setStatus there REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13119?vs=34873&id=34881 REVISION DETAIL https://phabricator.kde.

KDE CI: Plasma kwallet-pam kf5-qt5 SUSEQt5.10 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwallet-pam%20kf5-qt5%20SUSEQt5.10/14/ Project: Plasma kwallet-pam kf5-qt5 SUSEQt5.10 Date of build: Fri, 25 May 2018 19:10:38 + Build duration: 52 sec and counting Cobertura Report

KDE CI: Plasma kwallet-pam kf5-qt5 FreeBSDQt5.10 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwallet-pam%20kf5-qt5%20FreeBSDQt5.10/14/ Project: Plasma kwallet-pam kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 25 May 2018 19:10:38 + Build duration: 36 sec and counting

D13022: add workspaceoptions docbook

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6229570c3da2: add workspaceoptions docbook (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13022?vs=34592&id=34878 REVISION DETAIL htt

D13119: Abort transaction on PK dependency resolution error

apol added a comment. Looks like it's missing checking the `exit` argument in ::cleanup() for `ExitFailed` no? Can you check if in this case we're getting the an ExitFailed? If so the setStatus should go there. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.

D11848: [Kickoff] Reduce hover delay before switching tabs

ngraham added a comment. Thanks, Eike! @davidedmundson, are you okay with this now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, davidedmundson, abetts, hein Cc: rikmills, hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesli

D11848: [Kickoff] Reduce hover delay before switching tabs

ngraham added a comment. Friendly ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, davidedmundson, abetts Cc: rikmills, hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

KDE CI: Plasma kwallet-pam kf5-qt5 SUSEQt5.10 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwallet-pam%20kf5-qt5%20SUSEQt5.10/13/ Project: Plasma kwallet-pam kf5-qt5 SUSEQt5.10 Date of build: Fri, 25 May 2018 18:18:48 + Build duration: 54 sec and counting CONSOLE OUTPUT [...tru

KDE CI: Plasma kwallet-pam kf5-qt5 FreeBSDQt5.10 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwallet-pam%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Plasma kwallet-pam kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 25 May 2018 18:18:48 + Build duration: 40 sec and counting CONSOLE OUTPUT [

D12937: Drop privileges when reading the salt file

dakon requested changes to this revision. dakon added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pam_kwallet.c:705 > +{ > +int readSaltPipe[2] = { -1, -1}; > +if (pipe(readSaltPipe) < 0) { no init necessary, either pipe overwrites it or it returns e

D13119: Abort transaction on PK dependency resolution error

arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY If PackageKit throws a dependency resolution error, abort the transacti

Advance Monday Meeting Notes

Hi all, probably can't make it to next Monday's meeting, here's my notes: * Fixes for plasma-browser-integration (excludes incognito tabs now on Firefox and fixed options page there) * Various fixes for QQC2 desktop style (focus indicator on CheckBox/ RadioButton, more consistent spacing, right-

D13112: Port Plasma Desktop Scripting to QJSEngine

mart updated this revision to Diff 34864. mart added a comment. proper diff REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13112?vs=34863&id=34864 BRANCH mart/QJSEngineScripting REVISION DETAIL https://phabricator.kde.org/D13112 AFFECTED FIL

D13112: first round of porting to QJSEngine

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY nothing builds yet, unfortunately it needs a complete port in order to even build port of scripteng

D13111: Activate next task in group on shortcut

lholecek created this revision. lholecek added a reviewer: mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. lholecek requested review of this revision. REVISION SUMMARY Clicking a task group shows a tooltip with list of tasks. T

D13006: Move the inline installer progress cancel button to the left side

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13006 To: ngraham, apol, #discover_software_store Cc: andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13108: [Global Menu Applet] Open menu on press

This revision was automatically updated to reflect the committed changes. Closed by commit R120:26045ba5358e: [Global Menu Applet] Open menu on press (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13108?vs=34855&id=34856 REVISI

D13108: [Global Menu Applet] Open menu on press

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:143 > +anchors.fill: parent > +onPressed: parent.clicked() > +} That's a very smart sol

D13108: [Global Menu Applet] Open menu on press

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Adds a `MouseArea` so it opens on press like `QMenu

Re: Dependency on Solid/PowerManagement from KDELibs4Support

I don't think it's worth integrating back into anywhere in frameworks given it's based around a deprecated FDO spec, I can see us replacing it sometime soon. Putting a stripped version in libplasmaworkspace does seem sensible. David

D13107: Add Settings class to API documentation

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Putting anything above the class declaratio

D13106: Add RTL support to some QtQuick ported KCMs

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It is delierately not added to translations a

D13103: [Look and Feel KCM] Make GHNS dialog modal

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ea5199a75187: [Look and Feel KCM] Make GHNS dialog modal (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13103?vs=34845&id=34848 REVIS

D10855: Emit clicked when double click expires

broulik added a comment. Ping. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10855 To: broulik, #plasma, graesslin, #vdg Cc: mart, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13103: [Look and Feel KCM] Make GHNS dialog modal

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it consistent with the other KCMs. TEST PLAN Code Co