D13433: Introduce ActionToolbar

2018-06-08 Thread Aleix Pol Gonzalez
apol added a comment. +1 makes a lot of sense. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13433 To: mart, #kirigami, hein Cc: apol, davidedmundson, plasma-devel, mart, hein

Re: Closing old Plasma 4 bugs

2018-06-08 Thread Ben Cooksley
On Sat, Jun 9, 2018 at 9:06 AM, Scott Harvey wrote: > Did anyone check how much space has been freed up in the Bugzilla database? The closure of bugs doesn't archive them from the database. Once entered into the system they're in there permanently. Cheers, Ben > On Jun 8, 2018, 3:39 PM -0500,

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-06-08 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:740289bd824d: Systemmonitor: use different label format when the applet is on a vertical panel (authored by miklosm, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-06-08 Thread Nathaniel Graham
ngraham added a comment. Thanks! For your next patch, consider using `arc` instead of the web UI, which makes reviewing and landing a lot easier for us. :-) See https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist REVISION DETAIL https://phabricator.kde.org/D12857 To:

Re: Closing old Plasma 4 bugs

2018-06-08 Thread Christoph Feck
On 08.06.2018 23:06, Scott Harvey wrote: Did anyone check how much space has been freed up in the Bugzilla database? None, because the bugs are still there; they just changed the status. On the other hand, we have some 2600+ less open tickets.

Re: Closing old Plasma 4 bugs

2018-06-08 Thread Scott Harvey
Did anyone check how much space has been freed up in the Bugzilla database? On Jun 8, 2018, 3:39 PM -0500, Nate Graham , wrote: > This work is done; all the bugs and feature requests in the plasma4 > product have been closed. Hope all of your inboxes survived the onslaught! > > Nate > > > > On

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-06-08 Thread Miklós Máté
miklosm added a comment. BTW the updateInterval, which caused the conflict, is not as useful as it sounds, because the data source sends new data at a fixed 1Hz frequency. REVISION DETAIL https://phabricator.kde.org/D12857 To: miklosm, #plasma, mart Cc: ngraham, mart, plasma-devel,

Re: Closing old Plasma 4 bugs

2018-06-08 Thread Nate Graham
This work is done; all the bugs and feature requests in the plasma4 product have been closed. Hope all of your inboxes survived the onslaught! Nate On 02/21/2018 07:21 AM, Nate Graham wrote: I have also cleaned up the bug triaging page:

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

2018-06-08 Thread Miklós Máté
miklosm updated this revision to Diff 35855. miklosm added a comment. Rebased on current master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12857?vs=34080=35855 REVISION DETAIL https://phabricator.kde.org/D12857 AFFECTED FILES

D13435: Remove verbose debugging statement

2018-06-08 Thread Andreas Hartmetz
ahartmetz accepted this revision. ahartmetz added a comment. There are many more plain qDebug()s in this module, but this one seems to produce the most noise... REPOSITORY R101 KHotKeys BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13435 To: fvogt, #plasma,

D13435: Remove verbose debugging statement

2018-06-08 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R101:c5743089667d: Remove verbose debugging statement (authored by fvogt). REPOSITORY R101 KHotKeys CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13435?vs=35849=35850 REVISION DETAIL

D13435: Remove verbose debugging statement

2018-06-08 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY This ends up in the system log otherwise. Reintroduction with categorized logging might be useful. TEST PLAN No message in

D13433: Introduce ActionToolbar

2018-06-08 Thread David Edmundson
davidedmundson added a comment. Did you fix your binding loop? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13433 To: mart, #kirigami, hein Cc: davidedmundson, plasma-devel, apol, mart, hein

D13433: Introduce ActionToolbar

2018-06-08 Thread Marco Martin
mart added a comment. F5898818: Spectacle.W14814.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13433 To: mart, #kirigami, hein Cc: plasma-devel, apol, davidedmundson, mart, hein

D13433: first prototype of ActionToolbar and port usage

2018-06-08 Thread Marco Martin
mart updated this revision to Diff 35847. mart added a comment. - document flat REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13433?vs=35846=35847 BRANCH mart/actiontoolbar REVISION DETAIL https://phabricator.kde.org/D13433 AFFECTED FILES

D13433: first prototype of ActionToolbar and port usage

2018-06-08 Thread Marco Martin
mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY remove the dead code add ActionToolBar in the qrc REPOSITORY R169 Kirigami BRANCH

D13390: Fonts KCM: Fix text readability regression

2018-06-08 Thread Andres Betts
abetts added a comment. Maybe this is for another ticket, but... can we make the field where the font is named the actual field where you select the fonts from? F5898561: InkedSpectacle.S22260_LI.jpg I mean, why have so many controls when the

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:033ad5ca60b3: Port Plasma Desktop Scripting to QJSEngine (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13112?vs=35838=35839 REVISION

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread Marco Martin
mart updated this revision to Diff 35838. mart added a comment. - newError function to create JS errors REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13112?vs=34864=35838 BRANCH mart/QJSEngineScripting REVISION DETAIL

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread David Edmundson
davidedmundson added a comment. Oh sorry, I meant to find one. Yep that's the script I meant. Awesome. Ship it! REPOSITORY R120 Plasma Workspace BRANCH mart/QJSEngineScripting REVISION DETAIL https://phabricator.kde.org/D13112 To: mart, #plasma, davidedmundson Cc:

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread Marco Martin
mart added a comment. https://github.com/pashazz/ksetwallpaper/blob/master/ksetwallpaper.py works perfectly REPOSITORY R120 Plasma Workspace BRANCH mart/QJSEngineScripting REVISION DETAIL https://phabricator.kde.org/D13112 To: mart, #plasma, davidedmundson Cc: davidedmundson,

D13357: Use logging categories in a few dataengines

2018-06-08 Thread Rik Mills
rikmills added a comment. @davidedmundson Seems so. Thank you. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13357 To: davidedmundson, #plasma, mart Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13372: Mouse KCM Redesign Using Kirigami

2018-06-08 Thread Safa Alfulaij
safaalfulaij added a comment. Small question, why we're not using QQC2-based controls? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13372 To: furkantokac, ngraham, romangg, mart Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13390: Fonts KCM: Fix text readability regression

2018-06-08 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R119:540edfdd2a88: Fonts KCM: Fix text readability regression (authored by rkflx). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13390?vs=35808=35826 REVISION

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.10 - Build # 45 - Still unstable!

2018-06-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/45/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Jun 2018 11:40:23 + Build duration: 12 min and counting JUnit Tests

D13357: Use logging categories in a few dataengines

2018-06-08 Thread David Edmundson
davidedmundson added a comment. Thanks. Hopefully fixed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13357 To: davidedmundson, #plasma, mart Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread Marco Martin
mart added a comment. In D13112#275382 , @davidedmundson wrote: > + > Thanks for tackling a very boring and difficult task. > > There are two things I'd like to see also tested: > > - the DBus wallpaper changing script that I know

D13390: Fonts KCM: Fix text readability regression

2018-06-08 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. awesome, thanks :) REPOSITORY R119 Plasma Desktop BRANCH fonts-kcm-readability (branched from Plasma/5.13) REVISION DETAIL https://phabricator.kde.org/D13390 To: rkflx, mart Cc: mart,