D13694: Fix wrong availability of profiles and ports.

akrutzler updated this revision to Diff 36728. akrutzler added a comment. Implement `setInfo` function for each, the `Port` and `Profile` class. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13694?vs=36717&id=36728 BRANCH fix_wrong_av

D13694: Fix wrong availability of profiles and ports.

akrutzler added a comment. My patched version of the plugin for the KCM wasn't loaded correctly, that's why I saw the same results. I'm still struggling developing KDE libs/plugins but it's getting better :) I solved the problem by implementing the `setInfo` function for each, the `Port

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

hein created this revision. hein added a reviewer: mart. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Missing: - The KWayland API has no way to add/remove desktops yet - The KWayland API has no way to move windows yet Depend

D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 36726. hein added a comment. Remove accidental CMakeLists.txt change. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13746?vs=36725&id=36726 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13746 AF

D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 36725. hein retitled this revision from "Adjust to libtaskmanager API changes for Wayland virtual desktop support" to "Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support". hein added a comment. Unambigous revision title. R

D13746: Adjust to libtaskmanager API changes for Wayland virtual desktop support

hein created this revision. hein added a reviewer: mart. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Missing: - The Move to -> New Desktop action is not supported by the protocol yet and currently hidden on Wayland. Depends

D13745: Implement support for virtual desktops on Wayland

hein created this revision. hein added a reviewer: mart. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Includes, among other things: - A refactoring towards supporting more than one desktop per window, for an eventual virtual deskt

D13694: Fix wrong availability of profiles and ports.

nicolasfella added a comment. It may work on your system because Profile reports 2 when available, but the libpulse docs say that anything non-zero should be interpreted as available (for Profile, not Port!) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.

D13694: Fix wrong availability of profiles and ports.

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. Sorry, but this does not solve the issue. Now it only shows the profiles that are not available. I'll try to make clear why: profile->available is either 0 (not avail

D13694: Fix wrong availability of profiles and ports.

akrutzler updated this revision to Diff 36717. akrutzler added a comment. Accept profiles which are not unavailable. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13694?vs=36558&id=36717 BRANCH fix_wrong_availability REVISION DETAIL

D13694: Fix wrong availability of profiles and ports.

akrutzler added a comment. In D13694#282499 , @nicolasfella wrote: > This breaks the profile selection Combobox in the KCM. I'm sorry to hear that, on my system I get the same results as in the released kcm. In D13694#282499

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 107 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/107/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Jun 2018 20:13:57 + Build duration: 7 min 18 sec and counting JUnit Tests

D13672: Mouse KCM Pointer Speed Slider Improvement

This revision was automatically updated to reflect the committed changes. Closed by commit R119:13b35bd8025a: Mouse KCM Pointer Speed Slider Improvement (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13672?vs=36495&id=36714 R

D13672: Mouse KCM Pointer Speed Slider Improvement

ngraham added inline comments. INLINE COMMENTS > romangg wrote in main.qml:199 > The 0.1 was wrong before. Should be now some value in the range, probably `1`. IMHO it should be the exact middle value (0 in terms of the libinput value, or position 6 on the slider). Material for another patch,

D13672: Mouse KCM Pointer Speed Slider Improvement

romangg accepted this revision. romangg added inline comments. INLINE COMMENTS > main.qml:199 > if (!enabled) { > -value = 0.1 > +value = 0.2 > return The 0.1 was wrong before. Should be now some value in the range, pr

D13679: Fix recent toolbar layout regression

ngraham abandoned this revision. ngraham added a comment. Aleix implemented a better version of this with https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13679 To:

D13742: Make sure d is deleted

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Found the issue using ASAN TEST PLAN Been running the patch few days

D13225: Move methods to private class

This revision was automatically updated to reflect the committed changes. Closed by commit R994:38c0b2d24bd5: Move methods to private class (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13225?vs=35223&id=36698 REVIS

D13663: Refactor the Global ToolBar concept

This revision was automatically updated to reflect the committed changes. Closed by commit R169:26b8bdea24c3: Refactor the Global ToolBar concept (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13663?vs=36686&id=36696 REVISION DETAIL htt

D13663: Refactor the Global ToolBar concept

mart updated this revision to Diff 36686. mart added a comment. - fix handle y REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13663?vs=36685&id=36686 BRANCH arcpatch-D13663 REVISION DETAIL https://phabricator.kde.org/D13663 AFFECTED FILES examples

D13663: Refactor the Global ToolBar concept

mart updated this revision to Diff 36685. mart added a comment. - use a binding REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13663?vs=36670&id=36685 BRANCH arcpatch-D13663 REVISION DETAIL https://phabricator.kde.org/D13663 AFFECTED FILES example

Plasma 5.13.2

Plasma 5.13.2 is now released https://www.kde.org/announcements/plasma-5.13.2.php

D13663: Refactor the Global ToolBar concept

ngraham added a comment. Yep, no regressions with an unpatched Discover (though obviously the bug is not fixed). REPOSITORY R169 Kirigami BRANCH arcpatch-D13663 REVISION DETAIL https://phabricator.kde.org/D13663 To: mart, #kirigami, ngraham Cc: apol, IlyaBizyaev, ngraham, davidedmund

D13663: Refactor the Global ToolBar concept

mart added a comment. In D13663#283188 , @ngraham wrote: > Thanks! I tried to break this in a bunch of ways but couldn't. Discover now feels a bit snappier, too. > > Looks good from a visual and behavioral perspective now. No comment on the

D13663: Refactor the Global ToolBar concept

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! I tried to break this in a bunch of ways but couldn't. Discover now feels a bit snappier, too. Looks good from a visual and behavioral perspective now. No comment on the code

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/10/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Jun 2018 11:25:55 + Build duration: 21 min and counting CONSOLE OU

KDE CI: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/20/ Project: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Jun 2018 11:19:14 + Build duration: 23 min and counting CONSOLE

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/16/ Project: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Jun 2018 11:19:11 + Build duration: 21 min and counting CONSOLE OUTPUT

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/8/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 26 Jun 2018 11:17:49 + Build duration: 12 min and counting CONSO

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/9/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Jun 2018 11:14:04 + Build duration: 11 min and counting CONSOLE OUT

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/7/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 26 Jun 2018 11:14:04 + Build duration: 3 min 42 sec and counting

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. I have two things I observed when implementing same in WebRTC to have this working in Firefox and Chrome: 1. Please use "Fru" for max_framerate and "Rru" for size, as it allows some negotiation when matching streams, I used the same in xdg-desktop-portal-kde no

D13481: Recommend window border size "None"

hein added a comment. This one is definitely tricky. I don't think it's insurmountable to track whether there's movement or not prior to a release, and if not, raise the lower window and synthesise press+release events to send to it. But it would't completely eliminate the dead zone problem,

D13694: Fix wrong availability of profiles and ports.

nicolasfella added a comment. In D13694#283089 , @drosca wrote: > In D13694#282499 , @nicolasfella wrote: > > > This breaks the profile selection Combobox in the KCM. > > > How does this break

D13663: Refactor the Global ToolBar concept

mart added a comment. In D13663#282780 , @mart wrote: > right, of course for the first item the layout spacing isn't applied, will fix spacing of the first button should be fixed REPOSITORY R169 Kirigami REVISION DETAIL https://phab

D13568: SinkModel: Ignore virtual sinks for preferredSink

This revision was automatically updated to reflect the committed changes. Closed by commit R115:974bd408f719: SinkModel: Ignore virtual sinks for preferredSink (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13568?vs=362

D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available

davidedmundson added a comment. Do you have commit access? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12708 To: tundracomp, mart Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, ngraham, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13694: Fix wrong availability of profiles and ports.

drosca added a comment. In D13694#282499 , @nicolasfella wrote: > This breaks the profile selection Combobox in the KCM. How does this break that combobox? The current code is obviously wrong. REPOSITORY R115 Plasma Audio Volume Applet

D13591: Set complete vectors instead of creting them at runtime

tcanabrava added a comment. ping? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13591 To: tcanabrava, #breeze Cc: ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13663: Refactor the Global ToolBar concept

mart updated this revision to Diff 36670. mart added a comment. - fix spacing when there is no handle REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13663?vs=36635&id=36670 BRANCH arcpatch-D13663 REVISION DETAIL https://phabricator.kde.org/D13663 AF