[Powerdevil] [Bug 361708] System stuck in ac-plugged in mode ignoring Power management rules

2018-07-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=361708 --- Comment #5 from battagli...@gmail.com --- Finally, I note the problem may result from a discrepancy between upower and acpi. Note the following terminal results. Both of these are in the state where the AC is not plugged in, but the tray icon still

[Powerdevil] [Bug 361708] System stuck in ac-plugged in mode ignoring Power management rules

2018-07-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=361708 --- Comment #4 from battagli...@gmail.com --- Created attachment 113772 --> https://bugs.kde.org/attachment.cgi?id=113772=edit All charging One more - now things are plugged in. Note that the tray icon is "charging", and now the battery icon in the

[Powerdevil] [Bug 361708] System stuck in ac-plugged in mode ignoring Power management rules

2018-07-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=361708 --- Comment #3 from battagli...@gmail.com --- Created attachment 113771 --> https://bugs.kde.org/attachment.cgi?id=113771=edit Battery inconsistency Note the tray icon still has the battery in AC mode, even though it is listed as "Discharging" in the

[Powerdevil] [Bug 361708] System stuck in ac-plugged in mode ignoring Power management rules

2018-07-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=361708 battagli...@gmail.com changed: What|Removed |Added CC||battagli...@gmail.com --- Comment #2

D13870: Correct Folder View sizing and representation switch behavior

2018-07-04 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4ad27c62b5e7: Correct Folder View sizing and representation switch behavior (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Discussion for Virtual Desktops and Activities future

2018-07-04 Thread Michail Vourlakos
2018-07-04 22:01 GMT+03:00 David Edmundson : > > ​Are you (Michail and Ivan) at Akademy? > > unfortunately not David, family matters prevent me from attending

Re: Discussion for Virtual Desktops and Activities future

2018-07-04 Thread Nate Graham
I used to be of the opinion that having both Activities and Virtual Desktops was "too confusing" to users. I've changed my opinion recently, because I finally came to understand how they're designed to be used for very different things: Virtual Desktops are for window organization within the

Re: Discussion for Virtual Desktops and Activities future

2018-07-04 Thread David Edmundson
​Are you (Michail and Ivan) at Akademy? David

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread René J . V . Bertin
rjvbb added a comment. A couple of snapshot (with my current KMessageWidget facelift; styles and themes switched "on-the-fly"): Oxygen with the Oxygen theme: F6014853: image.png Breeze with Breeze-Dark: F6014872: image.png

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread René J . V . Bertin
rjvbb updated this revision to Diff 37155. rjvbb added a comment. Updated as (hopefully) requested. I've left the property change event filter, for builds against older than 5.48.0 (or whatever version D13884 will appear in). There is one

D13745: Implement support for virtual desktops on Wayland

2018-07-04 Thread Marco Martin
mart added a comment. In D13745#286500 , @mvourlakos wrote: > In D13745#286491 , @hein wrote: > > > Michail: Please follow this review, as these API changes might impact Latte Dock, too. :) > >

Re: Discussion for Virtual Desktops and Activities future

2018-07-04 Thread Michail Vourlakos
2018-07-03 22:19 GMT+03:00 Eike Hein : > > This is the relevant thread :-) > > There are some technical decisions and commit reviews referencing MERGE and this is why I proposed this thread. Proposed technical decisions: 1. Virtual Desktops Ids from integers will be QVariants possibly strings I

D13853: Fix setting primary connector if primary output changed

2018-07-04 Thread Robert Hoffmann
hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. Addition to last comment: In the other case, booting with HDMI-2 and hotplugging HDMI-3 the problem with primary switching doesn't exist. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D13853: Fix setting primary connector if primary output changed

2018-07-04 Thread Robert Hoffmann
hoffmannrobert marked an inline comment as done. hoffmannrobert added inline comments. INLINE COMMENTS > davidedmundson wrote in screenpool.cpp:108 > Either this is a valid case to be in, and this assert doesn't make sense. > > Or we should never be in this case, and the patch doesn't make

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread Kai Uwe Broulik
broulik added a comment. D13884 fixes that. It doesn't set a custom palette but a custom style sheet on the `QFrame` (where you apparently can't style the hyperlink color for labels inside :/) REPOSITORY R113 Oxygen Theme REVISION DETAIL

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In D13881#286869 , @broulik wrote: > > 1/ As far as I know, the widget style has no way to style these widgets. Correct ? > > Yes. I would have preferred if Breeze applied the new flat style to the widget

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread Kai Uwe Broulik
broulik added a comment. > 1/ As far as I know, the widget style has no way to style these widgets. Correct ? Yes. I would have preferred if Breeze applied the new flat style to the widget instead of changing the look in the class itself. > As such I wonder if oxygen-demo is the

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > rjvbb wrote in oxygenframedemowidget.cpp:90 > That's to catch the event sent to the qApp instance when the theme is changed > (to be exact: after KColorSchemeManager sets or changes the > `KDE_COLOR_SCHEME_PATH` property. > > Without this, the

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. 1/ As far as I know, the widget style has no way to style these widgets. Correct ? As such I wonder if oxygen-demo is the right place for showing this. Might better have a showcase in kwidgetsaddon. (but in fact we also discussed that ultimately

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread René J . V . Bertin
rjvbb added inline comments. INLINE COMMENTS > broulik wrote in oxygenframedemowidget.cpp:90 > What do you need this for? That's to catch the event sent to the qApp instance when the theme is changed (to be exact: after KColorSchemeManager sets or changes the `KDE_COLOR_SCHEME_PATH` property.

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread Kai Uwe Broulik
broulik added a comment. +1 INLINE COMMENTS > oxygenframedemowidget.cpp:90 > +{ > +if (event->type() == QEvent::DynamicPropertyChange && obj == qApp) { > +QDynamicPropertyChangeEvent *e = > dynamic_cast(event); What do you need this for? REPOSITORY R113 Oxygen

D13883: Don't keep transfer div in DOM

2018-07-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This confuses websites. Instead keep a

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

2018-07-04 Thread Tagore Chandan Reddy
tagorechandanreddy updated this revision to Diff 37141. tagorechandanreddy edited the test plan for this revision. tagorechandanreddy added a comment. Made RegExp changes to simplify. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D13878: Also intercept creation of video elements

2018-07-04 Thread Kai Uwe Broulik
broulik updated this revision to Diff 37139. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. This revision is now accepted and ready to land. - Remove child right after adding it, fixes YouTube and other video player

Re: Discussion for Virtual Desktops and Activities future

2018-07-04 Thread Ivan Čukić
> I think this is a fair recap so far: The recap sounds great. > When Martin and I started talking about the > Wayland protocol, we > were keen to do work that would reusable > for either use case. This I especially like this part. As I said, merging the implementation (at least to some

D13881: oxygen-demo : add KMessage preview

2018-07-04 Thread René J . V . Bertin
rjvbb created this revision. rjvbb added a reviewer: hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. rjvbb requested review of this revision. REVISION SUMMARY A recent change to the `KMessageWidget` look has caught my

D13878: Also intercept creation of video elements

2018-07-04 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. it seems the `video` tags accumulate in the DOM, sometimes it creates a new player when playing a new song. Also it seems to break YouTube first opening. .. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D13879: Monitor document title

2018-07-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a website updates its page title

D13878: Also intercept creation of video elements

2018-07-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Spotify web player uses a `video` tag

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2018-07-04 Thread Peter
https://bugs.kde.org/show_bug.cgi?id=348529 Peter changed: What|Removed |Added CC||pe...@ceiley.net --- Comment #16 from Peter --- Is

D12517: Wayland: when blocking remember latest config change instead of crashing

2018-07-04 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R110:af609c37ddfd: Wayland: when blocking remember latest config change instead of crashing (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12517?vs=33067=37132#toc

D12517: Wayland: when blocking remember latest config change instead of crashing

2018-07-04 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > apol wrote in waylandtestserver.cpp:155 > maybe it's a bit easier to understand if you add an else instead of a return? The coding style recommendation in general is to return as early as possible instead of using else. > apol wrote in