D14011: Use PlasmaComponents for Label

bosimonsen added a comment. In D14011#289661 , @broulik wrote: > You can mix the two, just import it with a namespace > > import QtQuick.Controls 2.0 as QQC2 > > > and then `QQC2.Label`. I think it's still fine for 5.12 even this way.

D14017: Splitting Touchpad KCM, Stage 3

furkantokac created this revision. furkantokac added a project: Plasma. furkantokac requested review of this revision. REVISION SUMMARY kcm_touchpad (Wayland) and kcm_touchpadx (X11) are available by this commit. kcm_touchpad is dummy for now. Tested, it is working. REPOSITORY R119 Plasma

D14016: Splitting Touchpad KCM, Stage 2

furkantokac created this revision. furkantokac added a project: Plasma. furkantokac requested review of this revision. REVISION SUMMARY Minimum changes are done since there will be another commit for kcm_touchpadx cleaning. The kcm_touchpad is changed as kcm_touchpadx and it is moved to new

D13997: Splitting Touchpad KCM

furkantokac updated this revision to Diff 37484. furkantokac added a comment. Phase 1 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13997?vs=37464=37484 REVISION DETAIL https://phabricator.kde.org/D13997 AFFECTED FILES

D13776: Move remaining salt file operations into unprivileged processes

aacid added a comment. In D13776#289490 , @fvogt wrote: > > Are you saying that there are files that root can't read but the user can? > > Exactly. This is really interesting and shows how little i know about stuff, can you point me

D14011: Use PlasmaComponents for Label

broulik added a comment. You can mix the two, just import it with a namespace import QtQuick.Controls 2.0 as QQC2 and then `QQC2.Label`. I think it's still fine for 5.12 even this way. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14011 To:

D14011: Use PlasmaComponents for Label

bosimonsen added a comment. In D14011#289654 , @broulik wrote: > -1 > > Don't use Plasma components in "widget" Ui. Use `QtQuick.Controls 2` instead ScrollView is not available in QtQuick.Controls 2.0 appears to be at a later

D14011: Use PlasmaComponents for Label

broulik added a comment. -1 Don't use Plasma components in "widget" Ui. Use `QtQuick.Controls 2` instead REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14011 To: bosimonsen Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14011: Use PlasmaComponents for Label

bosimonsen updated this revision to Diff 37481. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14011?vs=37477=37481 REVISION DETAIL https://phabricator.kde.org/D14011 AFFECTED FILES Modules/energy/package/contents/ui/main.qml

D14011: Use PlasmaComponents for Label

bosimonsen created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bosimonsen requested review of this revision. REVISION SUMMARY The Label in QtQuick.Controls is only using renderType Text.QtRendering for mobile devices.

D13997: Splitting Touchpad KCM

furkantokac added a comment. In D13997#289384 , @romangg wrote: > If we go with this split the stages should be: > > 1. Append an x to the name of the old Touchpad KCM, make the KCM show only on X and add the new Wayland KCM without the X

D13997: Splitting Touchpad KCM

furkantokac updated this revision to Diff 37464. furkantokac edited the test plan for this revision. furkantokac added a comment. Stage 3 kcm_touchpad (Wayland) and kcm_touchpadx (X11) are available by this commit. Tested and working fine. To test it, you should manually remove the old

D14007: doc: Delete info about removed checkbox "Place in system tray"

aspotashev updated this revision to Diff 37462. aspotashev added a comment. update commit msg REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14007?vs=37461=37462 BRANCH doc-cleanup-ksystraycmd REVISION DETAIL https://phabricator.kde.org/D14007

D14007: doc: Delete info about removed checkbox "Place in system tray"

aspotashev created this revision. aspotashev added reviewers: lueck, broulik. Restricted Application added projects: Plasma, Documentation. Restricted Application added subscribers: kde-doc-english, plasma-devel. aspotashev requested review of this revision. REVISION SUMMARY Screenshots also

D13776: Move remaining salt file operations into unprivileged processes

fvogt added a comment. > Are you saying that there are files that root can't read but the user can? Exactly. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D13776 To: fvogt, #plasma, aacid Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13686: Updated RunCommand.qml to scroll with Ctrl + home row (j, k)

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a58e48707601: Updated RunCommand.qml to scroll with Ctrl + home row (j, k) (authored by michaeleden). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d8b6f90e2ddb: [Icons KCM] Load preview pixmaps for animation on-demand and cache them (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D13988: Use subseq matching for service runner

ngraham added a comment. `plasma-workspace` does compile without D13670 and KRunner //seems// to work, but it gives me a whole lotta console spew: kf5.kservice.services: Parsing "exist Exec and ( (exist Keywords and 'scover' ~subin Keywords) or

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

broulik added a comment. Why, or who, is setting this environment variable? Plasma-integration sets `QQuickStyle` depending on whether there is a `QApplication` or not, so this makes no sense. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D13920: [Font Management KCM] Only show on xcb platform

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a446bf0fb1d4: [Font Management KCM] Only show on xcb platform (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13920?vs=37236=37447

D13919: [Fonts KCM] Generate font rendering previews only on X

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:3fd0bf5cef8a: [Fonts KCM] Generate font rendering previews only on X (authored by broulik). REPOSITORY R119 Plasma

D13997: Splitting Touchpad KCM

romangg added a comment. If we go with this split the stages should be: 1. Append an x to the name of the old Touchpad KCM, make the KCM show only on X and add the new Wayland KCM without the X code as kcm_touchpad. 2. Remove all Wayland related code from the old KCM. 3. Rewrite the

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb updated this revision to Diff 37439. rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb added a comment. Getting the user's desktop style was easier than I thought. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14000?vs=37437=37439

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb created this revision. rjvbb added a reviewer: Framework: Syntax Highlighting. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. rjvbb requested review of this revision. REVISION SUMMARY See https://bugs.kde.org/show_bug.cgi?id=396287

D13997: Splitting Touchpad KCM

furkantokac updated this revision to Diff 37438. furkantokac added a comment. Stage 2 : Minimum changes are done since there will be another commit for kcm_touchpadx cleaning. The kcm_touchpad is changed as kcm_touchpadx and it is moved to new folder "touchpadx". Since "touchpad" folder is

D13999: [Kicker System Entry] Remove KDisplayManager global static

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It is only used in one place and cached, so no need for a

D13998: [Logout Greeter] Remove KDM cruft

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `KDisplayManager::bootOptions` only worked with

D13903: doc: Fix actions description: the buttons are on the bottom

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3a5ee447dc7e: doc: Fix actions description: the buttons are on the bottom (authored by aspotashev). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D13997: Splitting Touchpad KCM

furkantokac added a comment. Since you can review the old diff, I'm moving to stage 2. If you have problem with the Stage 1's diff, please tell me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13997 To: furkantokac, romangg, ngraham, #plasma Cc:

D13997: Splitting Touchpad KCM

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13997