Re: Discussion for Virtual Desktops and Activities future

On Thursday, July 12, 2018 4:36:02 PM CDT Michail Vourlakos wrote: > 2018-07-12 17:43 GMT+03:00 Marco Martin : > As a plasma user I am a [Multiple Activities and 1 VD] user so I am get used > in that workflow and I wouldnt like to miss it :) > > > I have in my mind without any > study but only

Re: Discussion for Virtual Desktops and Activities future

On 07/12/2018 03:36 PM, Michail Vourlakos wrote: As a plasma user I am a [Multiple Activities and 1 VD] user so I am get used in that workflow and I wouldnt like to miss it :) It seems to me that if we merge the features of both, it should be possible to not lose anything for people who use

Re: Discussion for Virtual Desktops and Activities future

2018-07-12 17:43 GMT+03:00 Marco Martin : > On Wed, Jul 4, 2018 at 9:28 PM Michail Vourlakos > wrote: > > > > unfortunately not David, family matters prevent me from attending > > That's too bad, I'm still looking forward to some day, somehow making > an in person meeting with you and other

D13874: textplugin: Fix missing QTextStream include

alistairf added a comment. Hey, sorry this slipped through. I don't have push access. Who can commit this? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D13874 To: alistairf, kossebau Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14081: Fix types, improve readability

broulik added a comment. I dont really have a strong opinion on this one INLINE COMMENTS > xcbeventlistener.cpp:151 > { > -xcb_randr_screen_change_notify_event_t *e2 = > -(xcb_randr_screen_change_notify_event_t *) e; > +auto e2 = reinterpret_cast(e); > I prefer to keep

D14081: Fix types, improve readability

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY These changes don't matter in the big picture but hopefully

D13931: [KCM] Add speaker placement test

nicolasfella added inline comments. INLINE COMMENTS > drosca wrote in Advanced.qml:132 > Make it into one property, without `index` and `role`, either with pasting > the code inline or moving it to separate function. Also it probably should be > `readonly` property. I couldn't make it

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37660. nicolasfella added a comment. - Fix context ref'ing in sink REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13931?vs=37659=37660 BRANCH speakertest REVISION DETAIL

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37659. nicolasfella added a comment. - Variable initialization and pointer style - Wait for sound being played before unref'ing context - Merge properties - Remove log - Fix unused parameter warning REPOSITORY R115 Plasma Audio Volume

Re: Discussion for Virtual Desktops and Activities future

> And there would be quite a nice opportunity for a nice pr campaign. IF (and that is a big "if") we can create a new feature (just don't call it "Virtual Activated Desktops" :D) that will merge activities and VDs in a sane way, which would not be overly limiting, I would be more than happy. It

D14056: Remove FileItemActionPlugin in favor of Purpose plugin

nicolasfella added a comment. Sending via Bluetooth will be available in Dolphin via the Share menu. (See D13124 ) REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D14056 To: nicolasfella, broulik, drosca Cc: plasma-devel,

Re: Discussion for Virtual Desktops and Activities future

> Personally i always used virtual desktops exactly for that, as "activities", > even before activities were a thing, "i need a new physical space to stuff > new windows" is not an use case that ever occurred to me in any way > noted that there are people which see virtual desktops like that..

Re: Discussion for Virtual Desktops and Activities future

On Wed, Jul 4, 2018 at 9:28 PM Michail Vourlakos wrote: > > unfortunately not David, family matters prevent me from attending That's too bad, I'm still looking forward to some day, somehow making an in person meeting with you and other lattedock people happen.. In the meantime, can you provide

D14056: Remove FileItemActionPlugin in favor of Purpose plugin

drosca added a comment. Is it still available in Dolphin? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D14056 To: nicolasfella, broulik, drosca Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Discussion for Virtual Desktops and Activities future

On Wed, Jul 4, 2018 at 9:12 PM Nate Graham wrote: > very different things: Virtual Desktops are for window organization > within the current set of tasks, and Activities are for higher-level > task and context switching. which is.. a pretty blurry concept, it asks the question "which of the two

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. In D14064#291125 , @broulik wrote: > I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I

D13931: [KCM] Add speaker placement test

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Looks much better now. INLINE COMMENTS > canberracontext.h:44 > private: > -ca_context *m_context = nullptr; > +ca_context *m_canberra; > +int m_references;

Re: Discussion for Virtual Desktops and Activities future

On Tue, Jul 3, 2018 at 8:03 PM Ivan Čukić wrote: > Just read the phab discussion. If I misunderstood the situation, please > correct me. > > Wondering where the original discussion happened where 'we' decided to > merge two orthogonal concepts into one. Can you point me to the relevant > thread

Re: Discussion for Virtual Desktops and Activities future

On Tue, Jul 3, 2018 at 5:36 PM Michail Vourlakos wrote: > Example: I am working on my current actitivity and I am writing a note in a > plasma widget. I am creating a new Activity, should that Activity look the > same as the previous one and if I change the note in the first should it look >

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37656. nicolasfella added a comment. - refcount CanberraContext REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13931?vs=37602=37656 BRANCH speakertest REVISION DETAIL

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

broulik added a comment. I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I don't understand why it has this code in the first place. REPOSITORY R112 Milou

D14063: KRunner Dictionary can't find anything

ngraham added a comment. Thanks for the patch! It will be nice to get the Dictionary runner working again. Please change `https://bugs.kde.org/show_bug.cgi?id=390776` to `BUG: 390776`. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords REPOSITORY R114

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

ngraham added a comment. Thanks for the patch! It will be nice to get the Dictionary runner working again. Please change `https://bugs.kde.org/show_bug.cgi?id=390776` to `CCBUG: 390776`. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords REPOSITORY R112

D14077: [Folder View] Don't spawn multiple stat jobs for the same folder

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e03217edfc1a: [Folder View] Dont spawn multiple stat jobs for the same folder (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14079: [Folder View] Create rename editor on demand

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6f6a002a48e9: [Folder View] Create rename editor on demand (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14079?vs=37646=37651

D14076: Use QStringLiteral when a conversion to QString will happen

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ccbee3e89925: Use QStringLiteral when a conversion to QString will happen (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D14074: Use context argument in lambda connect

gladhorn added inline comments. INLINE COMMENTS > broulik wrote in daemon.cpp:94 > You could also connect it to the method directly > > connect(action, ::triggered, this, ::displayButton); Of course, that was pretty blind of me. REPOSITORY R104 KScreen REVISION DETAIL

D14075: In function returning void, use plain return

This revision was automatically updated to reflect the committed changes. Closed by commit R104:f62f316ab207: In function returning void, use plain return (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14075?vs=37637=37649 REVISION

D14074: Use context argument in lambda connect

broulik added inline comments. INLINE COMMENTS > daemon.cpp:94 > KGlobalAccel::self()->setGlobalShortcut(action, switchDisplayShortcuts); > -connect(action, ::triggered, [&](bool) { displayButton(); }); > +connect(action, ::triggered, this, [&](bool) { displayButton(); > }); >

D14074: Use context argument in lambda connect

This revision was automatically updated to reflect the committed changes. Closed by commit R104:439feca241e8: Use context argument in lambda connect (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14074?vs=37636=37648 REVISION DETAIL

D14073: Improve wording in comment

This revision was automatically updated to reflect the committed changes. Closed by commit R104:94d19d7e335f: Improve wording in comment (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14073?vs=37635=37647 REVISION DETAIL

D14079: [Folder View] Create rename editor on demand

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Creating a `TextArea` is surprisingly costly. TEST PLAN -

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

davidedmundson added a comment. Sorry for the delay Update: Spoke to kpackage maintainer. I'll add an anonymous DBus signal in kpackagetool and a PackageWatcher to monitor that. Then when I get that hooked up, the blocking problem will be solved. REPOSITORY R119 Plasma Desktop

D14078: Simplify string comparison

This revision was automatically updated to reflect the committed changes. Closed by commit R110:9694b4a511e4: Simplify string comparison (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14078?vs=37643=37645 REVISION DETAIL

D14077: [Folder View] Don't spawn multiple stat jobs for the same folder

broulik updated this revision to Diff 37644. broulik added a comment. - Add job error check REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14077?vs=37641=37644 REVISION DETAIL https://phabricator.kde.org/D14077 AFFECTED FILES

D14078: Simplify string comparison

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library BRANCH stringcomp REVISION DETAIL

D14077: [Folder View] Don't spawn multiple stat jobs for the same folder

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Check for one already running before spawning a new one.

D14076: Use QStringLiteral when a conversion to QString will happen

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY In this case we would allocate to create a QString instance

D14075: In function returning void, use plain return

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH x REVISION DETAIL

D14074: Use context argument in lambda connect

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH x REVISION DETAIL https://phabricator.kde.org/D14074 AFFECTED FILES

D14073: Improve wording in comment

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14073

D14059: Attempt at making less refreshes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:f9b17f265915: Attempt at making less refreshes (authored by apol). REPOSITORY R134 Discover Software Store CHANGES

D14065: Be strict about implicit string casts

This revision was automatically updated to reflect the committed changes. Closed by commit R104:e9cca953e8bc: Be strict about implicit string casts (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14065?vs=37619=37630#toc REPOSITORY R104 KScreen CHANGES SINCE

D14060: Clean up string casts

This revision was automatically updated to reflect the committed changes. Closed by commit R110:973bef8349d2: Clean up string casts (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14060?vs=37616=37628#toc REPOSITORY R110 KScreen Library CHANGES SINCE LAST

D14060: Clean up string casts

davidedmundson accepted this revision. davidedmundson added a comment. > I think micro-optimizing the tests further is simply not worth anyone's time Me too. Previous +2 applies REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D14060

D14068: add -P switch to one-shot redshift call

grmat added a comment. I was hoping the bug would get linked in automatically... anyways, here it is, with additional information: https://bugs.kde.org/show_bug.cgi?id=395641 REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D14068 To: grmat Cc:

D14068: add -P switch to one-shot redshift call

grmat created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. grmat requested review of this revision. REVISION SUMMARY This trivial patch adds the missing parameter to get the familiar behaviour working for redshift

D14060: Clean up string casts

gladhorn added a comment. I think micro-optimizing the tests further is simply not worth anyone's time. I'd propose taking this in (and if you spot more things, do them on top of this change). REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL

D14063: KRunner Dictionary can't find anything

mart added a comment. needs a more complete comment in the summary on what this change does REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14063 To: McPain, broulik Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D14065: Be strict about implicit string casts

zzag added inline comments. INLINE COMMENTS > CMakeLists.txt:11-16 > + -DQT_USE_QSTRINGBUILDER > + -DQT_NO_CAST_TO_ASCII > + -DQT_NO_CAST_FROM_ASCII > + -DQT_STRICT_ITERATORS > + -DQT_NO_URL_CAST_FROM_STRING > + -DQT_NO_CAST_FROM_BYTEARRAY Use 4 spaces to indent. REPOSITORY R104

D14048: Fix fake parser copy and paste error

This revision was automatically updated to reflect the committed changes. Closed by commit R110:967f21ac54f2: Fix fake parser copy and paste error (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14048?vs=37565=37620 REVISION

D14065: Be strict about implicit string casts

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Use QT_NO_CAST_FROM_ASCII and friends. There are a bunch of places where QString should really

D14064: Dictionary haven't enough time to complete query before resetting by milou

McPain created this revision. McPain added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=390776 REPOSITORY R112

D14063: KRunner Dictionary can't find anything

McPain created this revision. McPain added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=390776 REPOSITORY R114

D14060: Clean up string casts

zzag added inline comments. INLINE COMMENTS > anthonyfieroni wrote in parser.cpp:145 > It should be QLatin1String on contains? http://doc.qt.io/qt-5/qbytearray.html#contains-1 REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D14060 To:

D14060: Clean up string casts

anthonyfieroni added inline comments. INLINE COMMENTS > parser.cpp:145 > +const QByteArray type = > map[QStringLiteral("type")].toByteArray().toUpper(); > if (type.contains("LVDS") || type.contains("EDP") || > type.contains("IDP") || type.contains("7")) { >

D14060: Clean up string casts

gladhorn added inline comments. INLINE COMMENTS > davidedmundson wrote in waylandtestserver.cpp:39 > shouldn't that be a QStringLiteral? Concatenation is still faster with latin1string. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D14060

D14060: Clean up string casts

gladhorn updated this revision to Diff 37616. gladhorn marked 2 inline comments as done. gladhorn added a comment. Fixed some of Kai's comments, some minor things are still to do. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14060?vs=37599=37616

D14060: Clean up string casts

gladhorn marked 3 inline comments as done. gladhorn added inline comments. INLINE COMMENTS > broulik wrote in testkwaylandbackend.cpp:88 > Why `true`? Indeed, that makes no sense. > broulik wrote in testlog.cpp:52 > I thought when concatenating the advantage of `QStringLiteral` don't cut it >