KDE CI: Plasma plasma-browser-integration kf5-qt5 FreeBSDQt5.10 - Build # 147 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-browser-integration%20kf5-qt5%20FreeBSDQt5.10/147/ Project: Plasma plasma-browser-integration kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 28 Jul 2018 01:50:06 + Build duration: 55 sec and

D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available

tundracomp added a comment. Thanks for accepting this! Please also add it to the code repository! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12708 To: tundracomp, mart Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14368: Let edidDecodeFraction return float

This revision was automatically updated to reflect the committed changes. Closed by commit R110:15aa08f36561: Let edidDecodeFraction return float (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14368?vs=38593=38623 REVISION

D10344: Create panel on current screen

mvourlakos added a comment. In D10344#299287 , @hoffmannrobert wrote: > Thank you. If these non-consecutive screen numbers are legitimate, then getting the QScreen via QGuiApplication::screens().at(screenNum) is wrong. I found a solution using

D14389: Invert shade button by same logic as keep-above button

andykluger updated this revision to Diff 38618. andykluger added a comment. Invert shade button colors when in checked state; Vertically flip keep-above button in checked state REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14389?vs=38617=38618 BRANCH

D14389: Invert shade button by same logic as keep-above button

andykluger updated this revision to Diff 38617. andykluger added a comment. Flip keep-above icon when in checked state, for consistency with shade button CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14389?vs=38466=38617 BRANCH feature/shade-louder REVISION DETAIL

D14389: Invert shade button by same logic as keep-above button

andykluger added a comment. F6154423: Screenshot_20180727_115020.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14389 To: andykluger, #breeze, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14389: Invert shade button by same logic as keep-above button

andykluger added a comment. I see how the shade button flips while the keep-above doesn't, but I don't see the difference between toggling the shade state and shade/unshade, or toggling the keep-above state and keep-above/don't-keep-above. But I can't argue against consistency here.

D10344: Create panel on current screen

hoffmannrobert updated this revision to Diff 38614. hoffmannrobert added a comment. Fix crash if screen numbers are not consecutive. Add ShellCorona::screenForId(int screenNum) for easy access to a panel's QScreen replacing wrong access via QGuiApplication::screens().at(screenNum).

D14387: Optimise setting up the palette

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c56e3e06729a: Optimise setting up the palette (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14387?vs=38603=38611 REVISION DETAIL

D14353: Improve alignment of types

zzag added a comment. In D14353#299286 , @gladhorn wrote: > OK, this should be the default for everyone. To have structures packed tight. Then the compiler can decide on alignment/padding (potentially depending on optimization space vs

D10344: Create panel on current screen

hoffmannrobert added a comment. Thank you. If these non-consecutive screen numbers are legitimate, then getting the QScreen via QGuiApplication::screens().at(screenNum) is wrong. I found a solution using ShellCorona::m_desktopViewforId. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D14353: Improve alignment of types

gladhorn added a comment. In D14353#299282 , @zzag wrote: > I suggest to describe in the summary why data members are ordered from largest to smallest. OK, this should be the default for everyone. To have structures packed tight. Then

D14405: Use short pnp id as fallback when the DB file is not found

gladhorn added a comment. I think the qml code should not do logic fiddling with the EDID :) but needs investigation. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14405 To: gladhorn, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel,

D14353: Improve alignment of types

zzag added a comment. I suggest to describe in the summary why data members are ordered from largest to smallest. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14353 To: gladhorn, #plasma, romangg Cc: zzag, romangg, plasma-devel, ragreen, Pitel, ZrenBot,

D14418: Add test for edid parsing and fix reading gamma

This revision was automatically updated to reflect the committed changes. Closed by commit R110:b80bbeb2e419: Add test for edid parsing and fix reading gamma (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38594=38604

D14387: Optimise setting up the palette

apol updated this revision to Diff 38603. apol added a comment. remove debug info REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14387?vs=38464=38603 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14387 AFFECTED FILES

D14428: Define ownership of edid in output and do not leak it

gladhorn updated this revision to Diff 38600. gladhorn added a comment. Messed up merge :( REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14428?vs=38599=38600 REVISION DETAIL https://phabricator.kde.org/D14428 AFFECTED FILES src/output.cpp

D14428: Define ownership of edid in output and do not leak it

gladhorn updated this revision to Diff 38599. gladhorn added a comment. Add note about the edid pointer becoming invalid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14428?vs=38598=38599 REVISION DETAIL https://phabricator.kde.org/D14428

D14428: Define ownership of edid in output and do not leak it

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Valgrind showed that in some cases we were leaking the edid in

D14418: Add test for edid parsing and fix reading gamma

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. > The old code's output was "2.0" instead of "2.2": integer division first, then cast. Yes, I know. But my train of thoughts was that the original value was multiplied by 100 when

D14050: Fwupd Backend For Review and Improvement

apol added inline comments. INLINE COMMENTS > abhijeet2096 wrote in FwupdBackend.h:48 > I need it for g_ptr_array_index, g_cancellable_new and similar functions No, definitely not, this is part of glib, not gio. REPOSITORY R134 Discover Software Store REVISION DETAIL

D14353: Improve alignment of types

gladhorn updated this revision to Diff 38596. gladhorn added a comment. initializer order fixed REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14353?vs=38595=38596 BRANCH arcpatch-D14353 REVISION DETAIL https://phabricator.kde.org/D14353

D14353: Improve alignment of types

gladhorn updated this revision to Diff 38595. gladhorn added a comment. Move two more members to the right spot REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14353?vs=38379=38595 BRANCH arcpatch-D14353 REVISION DETAIL

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38594. gladhorn added a comment. arc messup, it squashed another patch into this one REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38592=38594 REVISION DETAIL https://phabricator.kde.org/D14418

D14368: Let edidDecodeFraction return float

gladhorn updated this revision to Diff 38593. gladhorn edited the summary of this revision. gladhorn added a comment. arc mangled two patches again :( REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14368?vs=38421=38593 BRANCH arcpatch-D14368

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38592. gladhorn edited the summary of this revision. gladhorn added a subscriber: romangg. gladhorn added a comment. Updated commit message and rebased. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38590. gladhorn added a comment. Sort edids in test rows. I still think this is completely pointless and a waste of time. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38588=38590 BRANCH

D14405: Use short pnp id as fallback when the DB file is not found

gladhorn added a comment. Good catch, I'll have to look into it, right now I get an empty string for both. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14405 To: gladhorn, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38588. gladhorn added a comment. Removed xfail, it was fixed by the string parsing fix REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38565=38588 BRANCH arcpatch-D14418_1 REVISION DETAIL

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When no label is displayed, there's no point in creating a

D14361: Remove unused function

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ed42cf46ae2c: Remove unused function (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14361?vs=38404=38586 REVISION DETAIL

D14350: Make sure for loop does not detach

This revision was automatically updated to reflect the committed changes. Closed by commit R110:7cbccda5a273: Make sure for loop does not detach (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14350?vs=38426=38584 REVISION

D14359: Create m_saveTimer lazily

This revision was automatically updated to reflect the committed changes. Closed by commit R104:f4b0d85fe061: Create m_saveTimer lazily (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14359?vs=38517=38585 REVISION DETAIL

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

This revision was automatically updated to reflect the committed changes. Closed by commit R110:106251461674: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn updated this revision to Diff 38582. gladhorn added a comment. Moved Q_REQUIRED_RESULT to the front REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14369?vs=38422=38582 BRANCH arcpatch-D14369 REVISION DETAIL

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn added a comment. It's been there for ages, it's mentioned in the changelog at least... but actually it seems more common to put the attribute before the function, I'll update with that. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14369 To:

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn added a comment. I'll check, if it's not public API, I'll make it. Thanks for the pointer. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14369 To: gladhorn, #plasma, davidedmundson Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14410: EDID parsing: strings are up to 13 bytes

gladhorn added a comment. Yes, my laptop screen uses all 13 bytes, that's how I noticed (the model had one character cut off and I happened to debug and see that it was there, so I did the math :)). REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14410 To:

D14410: EDID parsing: strings are up to 13 bytes

This revision was automatically updated to reflect the committed changes. Closed by commit R110:c66291ec8307: EDID parsing: strings are up to 13 bytes (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14410?vs=38532=38580

D14418: Add test for edid parsing and fix reading gamma

gladhorn added a comment. In D14418#299028 , @romangg wrote: > I'm not sure if you could really say that the current code is with a bug, since `data[GCM_EDID_OFFSET_GAMMA]` should be dividable by 100. I.e. the result is again an integer and

D10344: Create panel on current screen

mvourlakos added a comment. In D10344#299042 , @hoffmannrobert wrote: > In D10344#297751 , @hoffmannrobert wrote: > > > > > > Still looking where these screen numbers come from...

D14364: Test configId in TestSerializer

romangg added inline comments. INLINE COMMENTS > gladhorn wrote in serializertest.cpp:163 > I was hoping the comment above is enough, repeated explanations are not that > sensible either in my opinion. I need the constant configId to compare > against it later, the point is to confirm that the

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

broulik added a comment. `Q_REQUIRED_RESULT` isn't documented as public API, is it? REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14369 To: gladhorn, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D14405: Use short pnp id as fallback when the DB file is not found

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Where vendor is used in the output display we do: text: ... } else if (root.output.edid && root.output.edid.vendor) { return

D14410: EDID parsing: strings are up to 13 bytes

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. According to Wikipedia [1] we have 57-71, 72-89, 90-107, 108-125 (18 each, of which 5 are "the header", so this makes 13) [1]

D14361: Remove unused function

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Can this cause trouble with ABI since this class is exported? But it's probably just exported as an entry point for KDED and not for use as a library ABI changing is

D10344: Create panel on current screen

hoffmannrobert added a comment. In D10344#297751 , @hoffmannrobert wrote: > In Wayland there seems to be a problem with QScreen: creating a panel on the second screen crashes plasmashell in QScreen::size(), called by PanelView::panelConfig()

D14364: Test configId in TestSerializer

gladhorn added inline comments. INLINE COMMENTS > romangg wrote in serializertest.cpp:163 > Below we do some tests in regards to the current config id value. These tests > are unrelated to any changes of the config id value over time. Therefore it > should not reference the magic config id

D14418: Add test for edid parsing and fix reading gamma

romangg added a comment. I'm not sure if you could really say that the current code is with a bug, since `data[GCM_EDID_OFFSET_GAMMA]` should be dividable by 100. I.e. the result is again an integer and nothing gets truncated. But we can still go with the updated code, which looks nicer.

D14364: Test configId in TestSerializer

romangg added inline comments. INLINE COMMENTS > serializertest.cpp:163 > +auto configId = QLatin1String("8684e883209d7644eb76feea2081c431"); > +QCOMPARE(Serializer::configId(config), configId); > + Below we do some tests in regards to the current config id value. These tests are

D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

This revision was automatically updated to reflect the committed changes. Closed by commit R110:2b5a4727ee34: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled (authored by kossebau). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D14422: Add edid converter

zzag added inline comments. INLINE COMMENTS > edid_converter.cpp:27 > + > +class EdidHelper { > +public: Why do you need EdidHelper class? Would be better to have just functions. > edid_converter.cpp:98 > +return helper.parseFile(parser.value(binFileOption), >

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38565. gladhorn added a comment. Added one more edid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38564=38565 BRANCH arcpatch-D14418 REVISION DETAIL https://phabricator.kde.org/D14418

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38564. gladhorn added a comment. Removed some extra parenthesis REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38553=38564 BRANCH arcpatch-D14418 REVISION DETAIL

D14371: Simplify Edid::Private::parse gamma

gladhorn abandoned this revision. gladhorn added a comment. D14418 is nicer REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14371 To: gladhorn Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14423: Mingw compile fix

habacker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. habacker requested review of this revision. REVISION SUMMARY - fix finding of bfd, intl, iberty and z library - fix drkonqi compile issue (missing functions

D14422: Add edid converter

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Make it convenient to work with various EDID formats by

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 - Build # 142 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.10/142/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 27 Jul 2018 06:50:55 + Build duration: 8 min 13 sec and counting JUnit

D13776: Move remaining salt file operations into unprivileged processes

This revision was automatically updated to reflect the committed changes. Closed by commit R107:c78e8ade9e2b: Move remaining salt file operations into unprivileged processes (authored by fvogt). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 153 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/153/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Fri, 27 Jul 2018 06:50:55 + Build duration: 5 min 47 sec and counting JUnit Tests

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38553. gladhorn added a comment. Remove extra newline REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38550=38553 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418 AFFECTED

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38550. gladhorn added a comment. Minor cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38549=38550 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418 AFFECTED FILES

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38549. gladhorn added a comment. Simplify gamma parsing code REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38548=38549 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418

D14418: Add test for edid parsing and fix reading gamma

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The bug in reading the gamma value was there from the start (2012), dividing the number by 100