KDE CI: Plasma plasma-browser-integration kf5-qt5 FreeBSDQt5.10 - Build # 148 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-browser-integration%20kf5-qt5%20FreeBSDQt5.10/148/ Project: Plasma plasma-browser-integration kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 29 Jul 2018 01:42:01 + Build duration: 1 min 23 sec and

D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available

ngraham added a comment. I can commit this for you if you can provide your real name and a preferred email address. Thanks! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12708 To: tundracomp, mart Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,

D14437: Fix QFileDialog not remembering the last visited directory.

dfaure updated this revision to Diff 38682. dfaure added a comment. Add unittest (which fails without this fix) REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14437?vs=38648=38682 BRANCH directoryEntered REVISION

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

dfaure updated this revision to Diff 38681. dfaure added a comment. Add a workaround for the current Qt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14440?vs=38653=38681 BRANCH Plasma/5.13 REVISION DETAIL https://phabricator.kde.org/D14440 AFFECTED FILES

D14444: Use nullptr/override

al1xz updated this revision to Diff 38674. al1xz added a comment. Update REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=38665=38674 BRANCH arcpatch-D1 REVISION DETAIL https://phabricator.kde.org/D1 AFFECTED FILES

D14444: Use nullptr/override

zzag added inline comments. INLINE COMMENTS > ListViewSettings.cpp:47 >delete m_settingsWidget; > + m_settingsWidget = nullptr; > } This class is about to go away so this assignment is redundant. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D1 To: al1xz

D14444: Use nullptr/override

al1xz created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. al1xz requested review of this revision. REPOSITORY R106 KSysguard BRANCH new (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 updated this revision to Diff 38655. abhijeet2096 added a comment. - Removed The FindGIO.cmake - Added GObject Dependency - Removed Not Used Gcancellable Object REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

arichardson added a comment. Does this mean for Qt < 5.12 (or .13?) pressing open in kwrite will select the cwd again? I now have almost all my source directories NFS mounted rather than having to use sftp so it is no longer such a big issue for me. However, I do wonder if it makes

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

dfaure created this revision. dfaure added reviewers: arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik. dfaure requested review of this revision. REVISION SUMMARY This was fixed initially in commit 7bbbd93

D14437: Fix QFileDialog not remembering the last visited directory.

dfaure created this revision. dfaure added reviewers: anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson. Restricted Application added a project: Plasma. dfaure requested review of this revision. REVISION SUMMARY This regression (compared to kdelibs4's direct KFileDialog

D14436: SwitchDesktop mousewheel options with config dialog added

totto added inline comments. INLINE COMMENTS > desktop.cpp:36 > +constexpr const char *cfgKeyProperty = "cfgKey"; > +bool readKwinrcRollOverDesktops() { > +auto cfg = KSharedConfig::openConfig("kwinrc"); The rollover option is from another kde component (kwin), is there a way to get

D14436: SwitchDesktop mousewheel options with config dialog added

totto created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. totto requested review of this revision. REVISION SUMMARY By default the mouse wheel action of switchdesktop always wraps around/rolls over when switching

D14428: Define ownership of edid in output and do not leak it

gladhorn added a comment. The alternative would be to deprecate this and add a new function. I think this is nonetheless sensible. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14428 To: gladhorn, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot,