D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

2018-08-21 Thread Michael Pyne
mpyne created this revision. mpyne added reviewers: Frameworks, Plasma, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mpyne requested review of this revision. REVISION SUMMARY I recently rebuilt my Qt, KF5, and Plasma 5 environments from scratch. I noticed

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-21 Thread Stefan Brüns
bruns updated this revision to Diff 40160. bruns edited the test plan for this revision. bruns added a comment. Remove from patch stack, apply first REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14807?vs=39637=40160 REVISION DETAIL

D14923: Supress paste in screen locker

2018-08-21 Thread Martin Flöser
graesslin added a comment. In D14923#311845 , @davidedmundson wrote: > > . As a matter of fact the default options of Klipper are also fine. Only if the not default prevent empty clipboard option is used this breaks. > > Code says

D14855: Add applet with screen layouts and presentation mode

2018-08-21 Thread Anthony Fieroni
anthonyfieroni added a comment. @broulik, i'm pretty sure that it has a review that enable accessing OSD by mouse, can you investigate and ship it. I'm not against this but accessing OSD by mouse is pretty good feature after all. REPOSITORY R104 KScreen REVISION DETAIL

D14855: Add applet with screen layouts and presentation mode

2018-08-21 Thread Kai Uwe Broulik
broulik added a comment. Then please make a final layout image that I can change my work to, preferably not being *completely* different from what I have now … also, the headings are smaller than e.g. System Tray's "Status and Notifications" heading REPOSITORY R104 KScreen REVISION

D14976: customIconColoring Theme api

2018-08-21 Thread Marco Martin
mart created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY get rid of hascustomiconcoloring REPOSITORY R169 Kirigami BRANCH mart/customIconColoring REVISION DETAIL

Re: Upcoming reorganisation of the CI system

2018-08-21 Thread Ben Cooksley
On Wed, Aug 22, 2018 at 2:36 AM Morten Volden wrote: > > Hi Ben Hi Morten, > > I don't know if this is on you radar or not, but here goes. > > I have noticed that quite a few of the KDevelop unittests are failing on the > Windows CI. > > Running the tests locally they work fine. > > If I look

D14933: Implemented Version checker for fwupd in FindLIBFWUPD.cmake

2018-08-21 Thread Abhijeet sharma
This revision was automatically updated to reflect the committed changes. Closed by commit R134:10b790f43052: Implemented Version checker for fwupd in FindLIBFWUPD.cmake (authored by abhijeet2096). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

Re: Upcoming reorganisation of the CI system

2018-08-21 Thread Ben Cooksley
Hi all, Final call for objections or queries for this change - i'll be looking to roll this out this weekend. Note: Plasma and KDevelop, i'm not subscribed to your lists so please ensure i'm in CC for any responses. Cheers, Ben

D14855: Add applet with screen layouts and presentation mode

2018-08-21 Thread Nathaniel Graham
ngraham added a comment. Maybe, but right now it's being oppressed to death by huge headers! :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel,

D14949: Add option for whether to show the volume change OSD

2018-08-21 Thread Nathaniel Graham
ngraham added a comment. I think the current UI is just fine as the default; no need to change it. Simply making it smaller wouldn't really help the submitter's use case very much anyway since it would still show up and cover up //something//. However I'd be open to making the default

D14949: Add option for whether to show the volume change OSD

2018-08-21 Thread Roman Gilg
romangg added a comment. Could we have a small bar at the top edge of the screen in case of fullscreen app and otherwise the current one? REVISION DETAIL https://phabricator.kde.org/D14949 To: anonym, #vdg Cc: romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14949: Add option for whether to show the volume change OSD

2018-08-21 Thread Kai Uwe Broulik
broulik added a comment. > this begs more the question whether the osd layer should stay on top of fullscreen windows It used to not do that but people also complained (me included, I want it ontop of my video). Maybe we need a new, more compact design (like the bar we had in 4.x), or

D14970: [MPris Dataengine] Avoid blocking calls in media shortcuts handling

2018-08-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY All the information we need (player capabilities and playback status) is already

D14949: Add option for whether to show the volume change OSD

2018-08-21 Thread Marco Martin
mart added a comment. this begs more the question whether the osd layer should stay on top of fullscreen windows, rater than adding yet another configuration option REVISION DETAIL https://phabricator.kde.org/D14949 To: anonym, #vdg Cc: mart, broulik, plasma-devel, ragreen, Pitel,

D14855: Add applet with screen layouts and presentation mode

2018-08-21 Thread Kai Uwe Broulik
broulik added a comment. The presentation mode doesn't really relate to the layouts that's why I put the headings in there. Just placing a checkbox there will make it drown underneath the layout buttons REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: