D15110: Fix scrollbars in LibreOffice

This revision was automatically updated to reflect the committed changes. Closed by commit R98:43f2cb7c2334: Fix scrollbars in LibreOffice (authored by gepardo, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15110?vs=40529=40679#toc REPOSITORY R98 Breeze for Gtk

D15110: Fix scrollbars in LibreOffice

gepardo added a comment. @davidedmundson, can you please merge this revision? I don't have a developer account, so I can't do it. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D15110 To: gepardo, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D13481: Recommend window border size "None"

abetts added a comment. I think we were able to identify the issues, even the ones pointed out in the discussions earlier in this ticket. I feel that we have a path forward. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13481 To: romangg, #plasma, #vdg Cc:

D13481: Recommend window border size "None"

ngraham added a comment. Yes, the plan was (is?) to make the content area touch the window edge with no separation at all, the way it does in for example apps on GNOME, ElementaryOS, Cinnamon, Windows, and macOS, not to mention our own Kirigami apps and some non-Kirigami apps like Konsole

D13481: Recommend window border size "None"

pedrogomes1698 added a comment. I'm on board with removing the borders, just wondering if things like this will be changed: Dolphin has nice spacing with borders: https://ibb.co/eur6tU With no borders it's way too close to the edge: https://ibb.co/gwXCYU REPOSITORY R31

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns added a comment. Anyone at home? Not answering a simple question is rude, at best. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma, apol, #frameworks Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

jgrulich added a comment. Can we get some opinions from KDE Neon people? I have older review to bump NM requirements to 1.4.0 here https://phabricator.kde.org/D12493. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov,

D14035: Unbreak SSH agent support for SSH VPN tunnels.

This revision was automatically updated to reflect the committed changes. Closed by commit R116:38b659465d86: Unbreak SSH agent support for SSH VPN tunnels. (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D14130: Parse protocol in port option

This revision was automatically updated to reflect the committed changes. Closed by commit R116:1feaa4ca1cdf: Parse protocol in port option (authored by martinschulze, committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D15145: Fixes minor memory leak in the KNSBackend

hallas closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D15145 To: hallas, apol Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

ngraham added a comment. In D13415#317064 , @sharvey wrote: > Thanks for the investigation. I've been hoping someone else would lend a pair of eyes to this problem for ages. > > When you change the icon in `user-manager` repeatedly, are you

D15145: Fixes minor memory leak in the KNSBackend

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Please put it in master. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D15145 To: hallas, apol Cc: apol, plasma-devel, ragreen,

D15130: make mycroftplasmoidplugin translatable

apol accepted this revision. apol added a comment. LGTM REPOSITORY R846 Mycroft Plasma integration REVISION DETAIL https://phabricator.kde.org/D15130 To: lueck, #plasma, #localization, Aiix, yurchor, apol Cc: apol, yurchor, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

abetts added a comment. Just a nitpick: Since we have a checkbox and then a label, can the label also have the word "Enable". We have transitioned into making actionable checkboxes to start their label with an active verb. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D15143: Allow creation of separator Actions

dkardarakos updated this revision to Diff 40647. dkardarakos edited the summary of this revision. dkardarakos added a comment. Function isSeparator removed REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15143?vs=40639=40647 REVISION DETAIL

D13617: Support kwin fractional scaling in wayland backend

This revision was automatically updated to reflect the committed changes. Closed by commit R110:3a0e95629912: Support kwin fractional scaling in wayland backend (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13617?vs=36349=40645#toc REPOSITORY R110

D15145: Fixes minor memory leak in the KNSBackend

hallas created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Fixes minor memory leak in the KNSBackend, the destructor of KNSBackend failed to delete the contents of the m_rootCategories

D15143: Allow creation of separator Actions

broulik added a comment. `isSeparator()` is for use in C++, that method is neither a slot nor `Q_INVOKABLE` so you cannot use it from QML anyway. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15143 To: dkardarakos, mart Cc: broulik, plasma-devel, apol,

D15143: Allow creation of separator Actions

dkardarakos added a comment. isSeparator function has been added to ensure compatibility with QAction https://doc.qt.io/qt-5/qaction.html#isSeparator. We do not need it? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15143 To: dkardarakos, mart Cc: broulik,

D14487: [Klipper] Only create KHelpMenu when used

This revision was automatically updated to reflect the committed changes. Closed by commit R120:adff6dcf7759: [Klipper] Only create KHelpMenu when used (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14487?vs=38783=40641

D15143: Allow creation of separator Actions

broulik added inline comments. INLINE COMMENTS > Action.qml:172 > + */ > +function isSeparator() { > +return separator; That function is superfluous, you have the property after all > ActionsMenu.qml:55 > if (!action.children || action.children.length === 0) {

D15143: Allow creation of separator Actions

dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY The QAction class allows an action to be considered a separator. In Kirigami Action

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov updated this revision to Diff 40632. volkov added a comment. minimize the number of setDeviceStatisticsRefreshRateMs() callings REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14835?vs=39790=40632 BRANCH master REVISION

D14581: support for multilevel kcms

mart updated this revision to Diff 40627. mart added a comment. - remove old remains of extra layouts REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14581?vs=40502=40627 BRANCH arcpatch-D14581 REVISION DETAIL

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. Thanks for the investigation. I've been hoping someone else would lend a pair of eyes to this problem for ages. When you change the icon in `user-manager` repeatedly, are you prompted for a root password **every time**? On my system (Tumbleweed), there's a

D13853: Fix setting primary connector if primary output changed

hoffmannrobert added a comment. Thanks for reviewing. Can you please land it for me, I don't have commit access. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D13853 To: hoffmannrobert, #plasma, mart, davidedmundson Cc: davidedmundson,

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn updated this revision to Diff 40619. phuongn added a comment. Correct the erroneous logic for determining the next and previous desktop index REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14989?vs=40555=40619 REVISION DETAIL

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn updated this revision to Diff 40618. phuongn added a comment. Correct the erroneous logic for determining the next and previous desktop index REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14988?vs=40549=40618 REVISION DETAIL