D14988: Implement option to toggle page navigation wraps around for pager plasmoid

ngraham added a comment. My sense is that it would be best to put this option alongside the existing one in the virtual desktops KCM. Navigation wraps around: [] When switching with keyboard shortcuts [] When switching with a scroll Or something like

D15268: [Folder View] Use KIO::PreviewJob::defaultPlugins() for default plugins

ngraham added a comment. +1 for the result! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15268 To: broulik, #plasma, #vdg, hein Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

ngraham added a comment. Does this look good now @davidedmundson? REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D15247: Show tooltips in krunner

ngraham added a comment. Thanks, the patch applies now. Can you verify that this works for you? When I apply the patch (and reboot for good measure), I still don't see tooltips for items whose names are elided in KRunner. REPOSITORY R112 Milou REVISION DETAIL

D15228: Export install location for DBUS interfaces via CMake

cgiboudeaux added a comment. In D15228#320381 , @bruns wrote: > This did not break the build, but D15229 becoming effective before this one. Without commit 36a7e03

D15228: Export install location for DBUS interfaces via CMake

bruns added a comment. This did not break the build, but D15229 becoming effective before this one. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D15228 To: bruns, #plasma, davidedmundson Cc: cgiboudeaux, broulik,

D15269: [Folder View] Add checkbox for toggling previews

ngraham added inline comments. INLINE COMMENTS > viewpropertiesmenu.cpp:97 > > +m_previews = > m_menu->addAction(QIcon::fromTheme(QStringLiteral("view-preview")), > i18n("Preview"), this, ::previewsChanged); > +m_previews->setCheckable(true); How about "Show Previews"? Should

D15269: [Folder View] Add checkbox for toggling previews

broulik created this revision. broulik added reviewers: Plasma, hein, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's all sorts of icon view options in the context menu, so add a quick toggle for

D15206: [Kickoff] Add a subtle separator line between the header and the content view

abetts added a comment. In D15206#320116 , @mmustac wrote: > Personally I like it more without the separators but except of that the top-margin of the first element seems to be only 6px while the margin to the underneath elements is about 12px.

D15268: [Folder View] Use KIO::PreviewJob::defaultPlugins() for default plugins

broulik created this revision. broulik added reviewers: Plasma, VDG, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Rather than a hardcoded list of only two thumbnailers. All of this is done under the

[ksystraycmd] [Bug 344168] there is no ksystray for plasma5

https://bugs.kde.org/show_bug.cgi?id=344168 Andrew Crouthamel changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

D15233: Add a tooltip for the appentry in the kicker

abetts added a comment. What would this look like? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15233 To: underwit, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Disabled use of AppStream for plasma-desktop on stable branches

Hi, There is an issue when using an old AppStream version (older than 0.12) with plasma-desktop. It would sometimes crash. Since it's an optional feature and not central to plasma's usability overall, we decided to just bump the version, understanding that lacking the feature is better than

D15245: Start looking for the context from the delegate itself

This revision was automatically updated to reflect the committed changes. Closed by commit R169:00e73ec1091c: Start looking for the context from the delegate itself (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15245?vs=40920=40985

D15243: Remove some double look-ups

This revision was automatically updated to reflect the committed changes. Closed by commit R169:301af35592af: Remove some double look-ups (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15243?vs=40947=40984 REVISION DETAIL

D15263: Don't use older buggier versions of AppStream Qt

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b96651acdca4: Dont use older buggier versions of AppStream Qt (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15263?vs=40971=40983

D15247: Show tooltips in krunner

McPain added a comment. In D15247#319839 , @ngraham wrote: > The patch does not apply because of an extraneous `milou` in the path for your diff: > > Consider setting up `arc`; it makes the patch submission process so much simpler and less

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. Just in case, I don't have commit access REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D15206: [Kickoff] Add a subtle separator line between the header and the content view

mmustac added a comment. Personally I like it more without the separators but except of that the top-margin of the first element seems to be only 6px while the margin to the underneath elements is about 12px. I think we should use the same margin here to have a consistent look. REPOSITORY

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 40973. McPain marked 12 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=40923=40973 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt

D15263: Don't use older buggier versions of AppStream Qt

apol created this revision. apol added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This is not a hard requirement so if a distribution is using older versions then it won't have the

Plasma 5.13.5

Plasma 5.13.5 is now released https://www.kde.org/announcements/plasma-5.13.5.php

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.11 - Build # 4 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.11/4/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 04 Sep 2018 11:24:54 + Build duration: 1 min 38 sec and counting

KDE CI: Plasma systemsettings stable-kf5-qt5 FreeBSDQt5.11 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20FreeBSDQt5.11/6/ Project: Plasma systemsettings stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 04 Sep 2018 11:24:52 + Build duration: 46 sec and counting

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.11/4/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 04 Sep 2018 11:24:58 + Build duration: 51 sec and counting

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn added a comment. In D14988#320052 , @hein wrote: > And @phuongn, I'm guessing you set all of these options to disabling wrap-around, right? I wasn't the original author of the very first wrap-around option for KWin, which only

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

hein added a comment. And @phuongn, I'm guessing you set all of these options to disabling wrap-around, right? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: hein, zzag, ngraham, abetts, davidedmundson,

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

hein added a comment. This patch is good, but I share Kai's concern that it's perhaps suboptimal we have two-three checkboxes now to control similar behavior in different places. Does the VDG have an opinion on that @ngraham? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D15170: Add icon names for root level kicker, recent docs, recent apps, power and session

hein added a comment. This is a good patch, but I think it's actually doing too much :). I'd be OK with hardcoding the icon names in the code. I don't think they need to be configurable. Could you simplify the patch? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D15206: [Kickoff] Add a subtle separator line between the header and the content view

hein added a comment. Code looks fine. I have no opinion on the design change. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15206 To: ngraham, #plasma, #vdg Cc: hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

KDE CI: Plasma systemsettings stable-kf5-qt5 FreeBSDQt5.11 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20FreeBSDQt5.11/5/ Project: Plasma systemsettings stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 04 Sep 2018 10:01:14 + Build duration: 14 min and counting

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

broulik added a comment. I'm not a huge fan of having that notification but if you can assure it doesn't spam the user by showing up repeatedly if a mount is blocked indefinitely, it's fine I guess INLINE COMMENTS > soliddeviceengine.cpp:29 > #include > #include > #include Unused >

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.11 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.11/3/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 04 Sep 2018 09:58:22 + Build duration: 5 min 48 sec and counting

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.11 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.11/3/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 04 Sep 2018 09:58:22 + Build duration: 5 min 27 sec and counting

D15261: Remove XRandrBrightness

broulik created this revision. broulik added reviewers: Plasma, bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It doesn't work on Wayland and was from what I recall only supported by the long disused

D15228: Export install location for DBUS interfaces via CMake

cgiboudeaux added a comment. In D15228#319955 , @broulik wrote: > This breaks plasma-workspace build on CI: https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.11/16/ FTR; fixed in master. REPOSITORY R133

D15247: Show tooltips in krunner

McPain updated this revision to Diff 40956. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15247?vs=40924=40956 REVISION DETAIL https://phabricator.kde.org/D15247 AFFECTED FILES lib/qml/ResultDelegate.qml To: McPain, #plasma, broulik, ngraham Cc: ngraham, plasma-devel, ragreen,

D15228: Export install location for DBUS interfaces via CMake

broulik added a comment. This breaks plasma-workspace build on CI: https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.11/16/ REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D15228 To: bruns, #plasma, davidedmundson Cc: broulik,