D10429: Disable the title bar separator by default

2018-09-12 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R31:51cedac0889b: Disable the title bar separator by default (authored by fvogt). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10429?vs=26883=41512 REVISION DETAIL

D10429: Disable the title bar separator by default

2018-09-12 Thread Nathaniel Graham
ngraham added a comment. In D10429#324936 , @romangg wrote: > It's unnecessary bling imo. And it can interfere with in-window elements (Firefox for example marks the active tab with a very similar colored line at the top). I would say let's try

D10429: Disable the title bar separator by default

2018-09-12 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. It's unnecessary bling imo. And it can interfere with in-window elements (Firefox for example marks the active tab with a very similar colored line at the top). I would say let's try it out and listen for feedback in 5.14 cycle if

D10429: Disable the title bar separator by default

2018-09-12 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think all the +1s here deserve to amount to at least one green checkbox. :) REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt,

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

2018-09-12 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e1c19ce4daf9: Plasmashell freezes when trying to get free space info from mounted remoteā€¦ (authored by McPain, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15435: Add translucent background attribute to desktop icon popup menu

2018-09-12 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc47b95094a3: Add translucent background attribute to desktop icon popup menu (authored by anemeth, committed by asturmlechner). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14362: Use unpretty channel name in speakertest

2018-09-12 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R115:7cd16db35a49: Use unpretty channel name in speakertest (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D15435: Add translucent background attribute to desktop icon popup menu

2018-09-12 Thread Alex Nemeth
anemeth added a comment. I'm having problems with my arcanist. Could someone please land this for me? REPOSITORY R119 Plasma Desktop BRANCH fix_desktop_menu_tp REVISION DETAIL https://phabricator.kde.org/D15435 To: anemeth, hein, davidedmundson, #plasma Cc: ngraham, plasma-devel,

D15462: Do ignore-filtered-siblings properly

2018-09-12 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c81205cc458e: Do ignore-filtered-siblings properly (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15462?vs=41499=41500 REVISION

D15462: Do ignore-filtered-siblings properly

2018-09-12 Thread Eike Hein
hein created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY Turns out c8358c203f11 only worked accidentally. We can't

D15440: Translated into Russian

2018-09-12 Thread Sheykhnur Latipov
sheykhnurlatipov added a comment. Well, thnx for reply, I'll do it. It's just that I do it for the first time. :) REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15440 To: sheykhnurlatipov, pino Cc: aspotashev, pino, plasma-devel, ragreen, Pitel,

D15256: [Mouse KCM] Avoid changes to touchpads in libinput backend

2018-09-12 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a4c724173b5c: [Mouse KCM] Avoid changes to touchpads in libinput backend (authored by romangg). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15256: [Mouse KCM] Avoid changes to touchpads in libinput backend

2018-09-12 Thread Nathaniel Graham
ngraham added a comment. The beta branches tomorrow. It would be nice to get this in so that people can test and offer feedback before the release. REPOSITORY R119 Plasma Desktop BRANCH fixMouseResettingTouchpad REVISION DETAIL https://phabricator.kde.org/D15256 To: romangg,

D15458: Re-filter launcher when a window changes identity

2018-09-12 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a057edc7e9fb: Re-filter launcher when a window changes identity (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15458?vs=41489=41490

D15458: Re-filter launcher when a window changes identity

2018-09-12 Thread Eike Hein
hein created this revision. hein added a reviewer: broulik. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY LibreOffice reuses the same main window for both its start center and sub-apps like Writer launched from it, changing the window metadata on

D15410: Handle clients which change window metadata during early startup

2018-09-12 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b15eaf38b6bf: Handle clients which change window metadata during early startup (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

2018-09-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:dff9d7fe09f2: [Folder View] Create KFilePlacesModel only when needed and listen for changes (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14426?vs=41331=41485#toc

D10855: Emit clicked when double click expires

2018-09-12 Thread Roman Gilg
romangg added a comment. Why is the press and hold timer still needed? It should be enough to only test on double click expiration with this patch and open the menu on release of mouse button afterwards. We should accept this behavioral change in order to reduce code complexity (people

D15430: Open Web Shorcuts KCM from Web Shortcut Runner config

2018-09-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4b4439fe2ef5: Open Web Shorcuts KCM from Web Shortcut Runner config (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15427: [Spellchecker Runner] Add button to open Spell Check KCM

2018-09-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R114:1d99daa41fd6: [Spellchecker Runner] Add button to open Spell Check KCM (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

Fwd: network connectivity with proxy

2018-09-12 Thread Harald Sitter
Shouldn't plasma-integration install a QNetworkProxyFactory implementing a factory based on KProtocolManager? It seems to me that proxy settings from the KCM should "just work" when running a Qt application under Plasma. -- Forwarded message - From: Harald Sitter Date: Wed, Sep

D15442: Improve DDCUtil handling in CMakeLists

2018-09-12 Thread Christophe Giboudeaux
cgiboudeaux added a comment. With the change, you can't tell if powerdevil must use the old or the new api. Suggestion: https://paste.kde.org/powk2bhxm config_powerdevil.h then defines HAVE_DDCUTIL and DDCUTIL_VERSION REPOSITORY R122 Powerdevil REVISION DETAIL

D15447: [libdbusmenuqt] Port to categorized logging

2018-09-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1e1ce733920d: [libdbusmenuqt] Port to categorized logging (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15447?vs=41461=41465

D15441: Initial migration to >=ddcutil-0.8.6 API (tested with ddcutil-0.9.1)

2018-09-12 Thread Bhushan Shah
bshah requested changes to this revision. bshah added a comment. This revision now requires changes to proceed. Does this mean ddcutil backend will break compilation with the ddcutil < 0.8.6 ? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D15441 To: nilathak,

D15447: [libdbusmenuqt] Port to categorized logging

2018-09-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY And make it less chatty overall, none of these are real "warnings" TEST PLAN No longer spams

D15440: Translated into Russian

2018-09-12 Thread Alexander Potashev
aspotashev added a comment. Thanks for your work, Sheykhnur, Russian translation team here :) Since you already have the translated messages, here are the easy steps left to submit them correctly: 1. Download the file plasma-browser-extension.po from

D15093: Add WireGuard capability.

2018-09-12 Thread Pino Toscano
pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. In D15093#324457 , @andersonbruce wrote: > A couple of questions on opening other review requests: > > - Should I open a bug

D15093: Add WireGuard capability.

2018-09-12 Thread Bruce Anderson
andersonbruce added a comment. In D15093#323095 , @pino wrote: > Thanks Bruce for all the updates, and patience! In return, I have more notes :) > > - I'd send the changes to the existing SimpleIpV4AddressValidator in an own review request,

D15093: Add WireGuard capability.

2018-09-12 Thread Bruce Anderson
andersonbruce updated this revision to Diff 41451. andersonbruce added a comment. - Correct capitalization - Remove HTML from tooltip strings - Update some tooltip strings for clarity REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE