D16368: Swap Trash/Delete when Shift is used while the menu is open

hein updated this revision to Diff 44091. hein added a comment. Simplify patch. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16368?vs=44063=44091 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16368 AFFECTED FILES

D14542: KCM using new virtual desktops DBus interface

hein added a comment. Ping? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson, ltoscano, zzag Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed,

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein added a comment. Ping? INLINE COMMENTS > davidedmundson wrote in desktop.cpp:59 > Use of the & is weird. I know the containers are implicitly shared, but I consider it better coding style to do the correct C++ thing out of habit rather than rely on that. REPOSITORY R120 Plasma

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

hein added a comment. In D14796#347289 , @apol wrote: > What's the status of this? The longer we wait, the harder it will be to integrate. We just branched 5.14, maybe it's time to consider doing so? It needs a lot of review, VDG

D16365: share common values for both Breeze and Breeze-dark GTK themes

ohelin added a comment. Nada from here, I'd say go ahead. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16365 To: ohelin, jackg, #breeze, #plasma Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D16365: Update diff against newest master

ngraham added reviewers: jackg, Breeze. ngraham added a comment. Thanks, it looks good to me too in my testing. Any objections to landing this? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16365 To: ohelin, jackg, #breeze Cc: ngraham, plasma-devel, ragreen,

D16330: Add a spacer item

ngraham abandoned this revision. ngraham added a comment. Don't need this, per @mart. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D16330 To: ngraham, mart, #kirigami Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

ngraham added a comment. @mart I've implemented your suggestions. To my eyes, the vertical spacing isn't enough. Compare the current version: F6344159: Using the correct objects.png ...With the previous one I had before: F6339576: Desktop icons

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

ngraham updated this revision to Diff 44089. ngraham added a comment. Implement @mart's suggestions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16241?vs=43959=44089 BRANCH icons-page-tweaks (branched from master) REVISION DETAIL

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb updated this revision to Diff 44083. rjvbb added a comment. updated for the current git/head. David: did you perhaps forget to accept the revision (aka, should I have committed this)? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14000?vs=37897=44083 REVISION DETAIL

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

apol added a comment. What's the status of this? The longer we wait, the harder it will be to integrate. We just branched 5.14, maybe it's time to consider doing so? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: apol,

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConfigIcons.qml:130 > > -// Row 1: Spacing > -Item { > -Layout.row: 1 > -Layout.column: 0 > -

D16365: Update diff against newest master

ohelin added a comment. I checked the both the diff_part files next to each other. All the other differences were quite easy to see, but this one bugs me a little: scrollbar.vertical button.down { -gtk-icon-source: -gtk-icontheme("pan-down-symbolic"); } scrollbar.vertical

D16375: fix warnings

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Don't call directly properties that may be undefined TEST PLAN Now discover still works

D16374: Don't fetch the url if it's already being fetched

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3a7782e0ba5c: Dont fetch the url if its already being fetched (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16374?vs=44075=44076 REVISION

D16374: Don't fetch the url if it's already being fetched

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It had weird behaviours and would sometimes overwrite the image when it's downloaded for real.

D16368: Swap Trash/Delete when Shift is used while the menu is open

ngraham added a comment. Thanks Eike! Any chance this can go into the 5.12 branch? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D16368 To: hein, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,

[kio-extras] [Bug 375732] Dolphin fails to sftp to Linux box when not a direct connection

https://bugs.kde.org/show_bug.cgi?id=375732 --- Comment #2 from Scott Deagan --- I have found a workaround for this: in Dolphin, use "fish://" instaead of "sftp://;. As an example, consider the following in your ~/.ssh/config: Host ExternalHost # Host A - external/Internet facing.

D16368: Swap Trash/Delete when Shift is used while the menu is open

broulik added inline comments. INLINE COMMENTS > foldermodel.cpp:1854 > menu->popup(m_menuPosition); > -connect(menu, ::aboutToHide, [menu]() { menu->deleteLater(); }); > +connect(menu, ::aboutToHide, [this, menu]() { > +menu->deleteLater(); Use four argument connect since

D16316: [Kicker] Rename id column to itemColumn

This revision was automatically updated to reflect the committed changes. Closed by commit R119:004d838c2718: [Kicker] Rename id column to itemColumn (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16316?vs=43921=44067 REVISION

D16368: Swap Trash/Delete when Shift is used while the menu is open

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > foldermodel.cpp:653 > +// Trash and Delete actions while the Shift modifier is pressed. > +// There's no point to doing so when the menu isn't

notes for Monday meeting of 22/10/2018

Eike: * [Wayland] Fixed another review-originated thingie in one of the containment action phabs, two Wayland VD Phabs of mine still waiting on re-review now * [FV] Fixed Trash/Delete not being swapped in the context menu when Shift was pressed while the menu was already open Kai Uwe: Work done:

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a2b683a10802: Implement option to toggle page navigation wraps around for pager plasmoid (authored by phuongn, committed by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D16309: Add accessibility information to desktop icons

chempfling added a comment. In D16309#347071 , @hein wrote: > I'll land it for you (it needs a manual step, which requires a dev account - which you should eventually apply for if you wind up contributing regularly!). Ok Thanks, I ll

D16368: Swap Trash/Delete when Shift is used while the menu is open

hein created this revision. hein added reviewers: ngraham, broulik. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Matching Dolphin. BUG:395155 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D16368