D16697: [Kickoff] Fix context menu not appearing on right-click

2018-11-05 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, hein, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right-clicking on list items to bring up a context menu broke with 48b32259e73f3

D16536: [fontinst KCM] Slightly modernize layout

2018-11-05 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8a74e73228ef: [fontinst KCM] Slightly modernize layout (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16536?vs=44523&id=44940 REVISIO

D16536: [fontinst KCM] Slightly modernize layout

2018-11-05 Thread Nathaniel Graham
ngraham added a comment. Ping! #VDG or #plasma ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16536 To: ngraham, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, leslie

D16622: [Plasmoid] Clean up layout

2018-11-05 Thread Nathaniel Graham
ngraham added a comment. Is this good to go now? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D16622 To: ngraham, #plasma, broulik, #vdg Cc: Codezela, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16638: Add accessibility and set focus on the actual items in the window switcher

2018-11-05 Thread Frederik Gladhorn
gladhorn closed this revision. gladhorn added a comment. This is in I'm unsure why "arc land" didn't close it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16638 To: gladhorn, davidedmundson, chempfling, kwin Cc: plasma-devel, ragreen, Pitel, ZrenBot, les

D16658: Respect the display property of buttons

2018-11-05 Thread Alexander Stippich
astippich added a comment. In D16658#354233 , @apol wrote: > I guess we can wait until we can bump to Qt 5.10 as a dependency? This looks a bit chaotic. > Also the Under/Beside setting isn't taken into account yet. Yep, f

D16659: Size according to specified icon width and height

2018-11-05 Thread Alexander Stippich
astippich updated this revision to Diff 44936. astippich added a comment. - only query pixelMetric on demand REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16659?vs=44828&id=44936 BRANCH icon_size REVISION DETAIL https://pha

D16651: Honor flat property of buttons

2018-11-05 Thread Alexander Stippich
astippich marked an inline comment as done. astippich added a comment. How can I actually run this test? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16651 To: astippich, ngraham, mart, apol, #plasma Cc: plasma-devel, ragreen, Pitel, Zre

D16651: Honor flat property of buttons

2018-11-05 Thread Alexander Stippich
astippich updated this revision to Diff 44934. astippich added a comment. - do not unnecessarily check flat property REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16651?vs=44800&id=44934 BRANCH flat REVISION DETAIL https://

D16690: [Baloo Runner] Filter duplicates and prefer specific type matches

2018-11-05 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, ngraham, sitter, michaelh. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A Presentation is also a Document so it would show up twice. This patc

D16638: Add accessibility and set focus on the actual items in the window switcher

2018-11-05 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 44926. gladhorn retitled this revision from "Set focus on the actual items in the window switcher" to "Add accessibility and set focus on the actual items in the window switcher". gladhorn added a comment. Changed it to be more pleasant by using client a

D16638: Set focus on the actual items in the window switcher

2018-11-05 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 44925. gladhorn retitled this revision from "Handle focus in the window switcher" to "Set focus on the actual items in the window switcher". gladhorn edited the summary of this revision. gladhorn edited the test plan for this revision. gladhorn edited reviewe

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R858:8fa114df0ad1: Fix issue where there's only one element on the menu (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D166

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems like this is only a problem if you have a single-item menu, and if you have that, you've done something wrong. :) Regardless, this seems to fix the issue, so +1. REPOSITORY R858

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This (random) height shows an odd padding on the menu when there's just the one element. C

Re: Downtime announcement: www.kde.org

2018-11-05 Thread Bhushan Shah
[sending again from right address since my gmail address is not subscribed to somee lists] Hello, On Mon, Nov 05, 2018 at 11:02:43PM +1300, Ben Cooksley wrote: > > In order to allow for hardware maintenance, one of our physical > > hardware hosts will need to be shutdown for a few hours on Monday

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

2018-11-05 Thread Roman Gilg
romangg abandoned this revision. romangg added a comment. Has been made unnecessary by 1e218b405bee . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7768 To: romangg, #plasma Cc: ngra

D7769: [Task Manager] Use Grid for grouped and single tooltips

2018-11-05 Thread Roman Gilg
romangg abandoned this revision. romangg added a comment. Has been made unnecessary by 1e218b405bee . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7769 To: romangg, #plasma, davided

Re: Downtime announcement: www.kde.org

2018-11-05 Thread Ben Cooksley
On Sat, Nov 3, 2018 at 7:50 AM Ben Cooksley wrote: > > Hi all, Hi all, > > In order to allow for hardware maintenance, one of our physical > hardware hosts will need to be shutdown for a few hours on Monday. > This downtime will commence around 9:30am UTC and may take several > hours. > > During

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

2018-11-05 Thread Albert Astals Cid
aacid added a comment. Ok, understood, there's a plan to maybe make it work but isn't really working. Can i commit this today so it gets in Plasma 5.14.3 and our users get to understand the UI? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1