D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham updated this revision to Diff 46099. ngraham added a comment. Make the effect a bit more subtle REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16968?vs=45707=46099 BRANCH arcpatch-D16968 REVISION DETAIL

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. That's a great point. In fact, now that I'm looking for it, I see that Windows uses a black outline on the white label text for their desktop icons. Unfortunately, the QML outline effect doesn't seem to look real good, at least not with the very small default

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When unmounting a device, the device notifier keeps the information of the device and its

D16170: [Device Notifier] Restore busy indicator

thsurrel updated this revision to Diff 46093. thsurrel added a comment. Update the storage size every 5 seconds Thank you for catching this one @mart ! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16170?vs=43513=46093 BRANCH

D15963: [KonsoleProfiles applet] Fix initial focus

This revision was automatically updated to reflect the committed changes. Closed by commit R114:d6ee79f20adb: [KonsoleProfiles applet] Fix initial focus (authored by thsurrel). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15963?vs=42917=46092

D16053: [Window List]Fix initial focus

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8ff87951cff8: [Window List]Fix initial focus (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16053?vs=43170=46091 REVISION DETAIL

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham added a comment. @mart This was all specifically requested by @davidedmundson in D16031 , unless I misunderstood the request. @davidedmundson, can you clarify whether or not that is what you wanted? REPOSITORY R120 Plasma Workspace REVISION

D16034: Improve logout screen button appearance and contrast

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in Logout.qml:162 > This was discussed endlessly in T9658 and > we couldn't find a good way to do it without the result looking really chunky > and ugly. I'm open to a batter way to do it if you

D16034: Improve logout screen button appearance and contrast

ngraham added inline comments. INLINE COMMENTS > mart wrote in Logout.qml:162 > I would have preferred to not have new icons with a translucent circle > behind, but rather doing such circle in QML This was discussed endlessly in T9658 and we couldn't find a

D14949: Add option for whether to show the volume change OSD

ngraham added a comment. In D14949#364818 , @mart wrote: > In D14949#312757 , @ngraham wrote: > > > I think the current UI is just fine as the default; no need to change it. Simply making it

D14514: Install the OSD icons to hicolor

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This was already done; the icons were moved to the Plasma theme. I don't think this is needed anymore. REPOSITORY R104 KScreen REVISION DETAIL

D17076: Avoid indeterminism in kcolorschemeeditor

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c9cf4883da4e: Avoid indeterminism in kcolorschemeeditors compilation (authored by ochurlaud). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15862: option to specify icons spacing for systray

emateli added a comment. FWIW I agree with @mart. Just give it a default value and leave it at that. More configuration doesn't necessarily mean better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15862 To: mvourlakos, #plasma, davidedmundson, #vdg Cc:

D14514: Install the OSD icons to hicolor

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. (they are also in the plasma theme btw) REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D14514 To: gladhorn, #plasma, mart Cc: mart, broulik,

D14949: Add option for whether to show the volume change OSD

mart added a comment. In D14949#335721 , @graesslin wrote: > It's not about that there are only complaints on Reddit. It's about the user group: do we want to deaign so that the small Reddit community is happy or do we want to design for the

D14949: Add option for whether to show the volume change OSD

mart added a comment. In D14949#312757 , @ngraham wrote: > I think the current UI is just fine as the default; no need to change it. Simply making it smaller wouldn't really help the submitter's use case very much anyway since it would still

D15233: Add a tooltip for the appentry in the kicker

mart added a comment. In D15233#328690 , @alexeymin wrote: > Why isn't repository for this review set? Which repo should it be? > > P.S. Guess it is plasma desktop > P.P.S. I edited and set a repo, but still don't see it assigned in diff

D15247: Show tooltips in krunner

mart accepted this revision. mart added a comment. In D15247#341864 , @McPain wrote: > Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386 } there was a

D15418: Dim application icon when it is not playing anything

mart added a comment. In D15418#331397 , @ngraham wrote: > Maybe something like this? > > F6283615: Screenshot_20180924_195355.png I like this way REPOSITORY R115 Plasma Audio Volume Applet

D15333: Group Widget + Color Picker = Widget Out Of Bounds

mart added inline comments. INLINE COMMENTS > McPain wrote in main.qml:111 > > Especially the spacer.width being divided by 2 in the second part of the > > statement. > > Look at all the parentheses I wrote ;) > I divide by two a *subtraction* of spacer.width from width. > > Former we

D17073: Do not crop albumArt

ndavis added a comment. In D17073#364541 , @trmdi wrote: > In D17073#364393 , @ndavis wrote: > > > That blur looks nice, but I think the background should be more opaque like the Elisa header

D15702: User can define margins for the desktop

mart added a comment. I'm against this kind of micro configurations, to me seems the problem could have 2 different "proper" solutions, either - would be needed some protocol between latte dock and plasmashell to communicate its panels geometries? - Or trying again in having

D15862: option to specify icons spacing for systray

mart added a comment. I'm really against this type of micro-options REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15862 To: mvourlakos, #plasma, davidedmundson Cc: mart, Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16034: Improve logout screen button appearance and contrast

mart added inline comments. INLINE COMMENTS > Logout.qml:162 > id: suspendButton > -iconSource: "system-suspend" > +iconSource: "system-suspend-translucent" > text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", > "Suspend") I

D16170: [Device Notifier] Restore busy indicator

mart added a comment. Most of the solidevice engine should not relay on polling.. after a quick glance at its code: can you test if the free space bar is still updating correctly after copying big files from and to? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16658: Respect the display property of buttons

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Button.qml:44 > + * and controlRoot.display != AbstractButton.IconOnly == 0 */ > +Kirigami.MnemonicData.label: (controlRoot.display == undefined || >

D16658: Respect the display property of buttons

mart added a comment. In D16658#359049 , @astippich wrote: > Can I convince you to land this for Kf 5.53 with the promise to clean up once frameworks depends on Qt 5.10? it needs at least a final release of Qt 5.12: frameworks need to

D16856: [comic] Sync configuration on write

mart added a comment. disk syncs shouldn't be added that lightly, as they are quirte expensive, it should always relay on the event compression internal in Applet REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16856 To: anthonyfieroni, #plasma,

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

mart added inline comments. INLINE COMMENTS > ActionButton.qml:41 > > -PlasmaCore.IconItem { > -id: icon > -anchors { > -top: parent.top > -horizontalCenter: parent.horizontalCenter > -} > -width: iconSize > -height: iconSize

D16435: Also catch new Audio() elements

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. LGTM, but I have no idea about this part of JS. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D16435 To: broulik, davidedmundson, fvogt Cc:

D17007: Do hash and hex name based output hashes

lbeltrame requested changes to this revision. lbeltrame added a comment. This revision now requires changes to proceed. As a packager: messing up with user configuration without a clear migration path is a no-no. REPOSITORY R110 KScreen Library REVISION DETAIL

D16968: [Folder View] improve label contrast against challenging backgrounds

emateli added a comment. The classical solution to these problems is always a white text with black outline. Works well for both light and dark backgrounds. Some image from the internet: https://i.imgur.com/pQjoQ.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D16968: [Folder View] improve label contrast against challenging backgrounds

mart added a comment. tough now it looks a bit too much like a blur around the letters, rather than a shadow REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17107: global menu,rename menuHidden to visible

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5779dde86fe7: global menu,rename menuHidden to visible (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17107?vs=46032=46074

D16995: Consider identical display models in ControlConfig

mart added a comment. does this cause incompatibilities with old configs? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16995 To: romangg, #plasma Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16996: Add method to write retention to configuration control files

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > control.cpp:163 > +} > +file.write(QJsonDocument::fromVariant(m_info).toJson()); > +//qCDebug(KSCREEN_COMMON) << "Config control saved on: " << >

D17007: Do hash and hex name based output hashes

mart added a comment. could a kconfigupdate script be provided to migrate config? screwing up multiscreen config between updated is quite of an issue REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17007 To: romangg, #plasma Cc: mart, plasma-devel,

D16988: [Kickoff] Make the visible search field unfocused by default

mart added a comment. In D16988#361739 , @filipf wrote: > It also conceptually makes more sense to have the search field unfocused because searching is not necessarily the main activity done within Kickoff, so why have it in focus all the time?

D16988: [Kickoff] Make the visible search field unfocused by default

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. this breaks the workflow open menu and just start typing REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg,

D17095: Fixed comic widget crash

pavelmos added a comment. I have no commit access. REVISION DETAIL https://phabricator.kde.org/D17095 To: pavelmos, jriddell, bshah, davidedmundson, #plasma, mart Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17094: Fixed comic widget context menu crash

pavelmos added a comment. I have no commit access. REVISION DETAIL https://phabricator.kde.org/D17094 To: pavelmos, jriddell, bshah, davidedmundson, mart Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17023: [Kickoff] Change search label and username font size

mart added a comment. please add a screenshot for user visible changes REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17023 To: rooty, romangg, ngraham Cc: mart, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D17118: drop ancient commented out code

This revision was automatically updated to reflect the committed changes. Closed by commit R161:dd5cfbb6f50e: drop ancient commented out code (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17118?vs=46067=46072#toc REPOSITORY R161 KActivity Manager Service

D17105: Add a new lookandfeel runner

mart added a comment. i wonder if it could make sense putting a piece of the thumbnail image? (perhaps would be too squished to make sense) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17105 To: apol, #plasma Cc: mart, plasma-devel, ragreen, Pitel,

D17113: Allow disabling KPackage install while building Breeze

ntninja abandoned this revision. ntninja added a comment. Thanks for the feedback, I've looked some more into what the KPackage does and I agree that it doesn't make sense to disable it in general. Closing this. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D17113

D17113: Allow disabling KPackage install while building Breeze

mart added a comment. -1 for disabling random things, we would get reports of people not finding the breeze dark look and not knowing why, and if a distro would do this, would be even worse REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D17113 To: ntninja, mart,

D17112: Allow disabling the build of the file dialog component

ntninja added a comment. But what if my application runs sandboxed in the desktop and does its file selection through portals? I'd still want it to have maximum desktop integration under KDE if possible. Hence I want to include `plasma-integration` as well, or is my thinking wrong here?

D17119: actually initialize kcrash properly

This revision was automatically updated to reflect the committed changes. Closed by commit R161:699dbef8f577: actually initialize kcrash properly (authored by sitter). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17119?vs=46068=46071

D17119: actually initialize kcrash properly

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY to successfully use kcrash when linking with as-needed (which is a default flag on many linux distros) one also needs to call

D17118: drop ancient commented out code

sitter updated this revision to Diff 46067. sitter added a comment. more related stuff REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17118?vs=46066=46067 BRANCH no-comment REVISION DETAIL https://phabricator.kde.org/D17118

D17118: drop ancient commented out code

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY it's been disabled since 2013. it stands to reason that we don't need it and should we need it in the future I am sure we'll manage

D16860: touchscreen text controls

This revision was automatically updated to reflect the committed changes. Closed by commit R858:01411790d480: touchscreen text controls (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16860?vs=45408=46065

D16860: touchscreen text controls

mart added a comment. for the future, could maybe be a global eventfilter of the window which does the switch of mode when a touch event arrived or when a mouse event arrived...will have to be tought trough... REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH phab/textcontrols

D4929: DrKonqi : lldb and Mac support

rjvbb added inline comments. INLINE COMMENTS > davidedmundson wrote in backtracegenerator.cpp:140 > Yes > > Also is it worth adding a "break;" there? A break instead of or in addition to the return? I think I'd prefer the return, unless you think that maybe someday there will be some extra

D4929: DrKonqi : lldb and Mac support

davidedmundson added inline comments. INLINE COMMENTS > rjvbb wrote in backtracegenerator.cpp:140 > You mean move the check on QProcess::Running into the `if > (line.startsWith(QLatin1String("Process ")) && line.endsWith(QLatin1String(" > detached")))` ? Yes Also is it worth adding a

D17094: Fixed comic widget context menu crash

pavelmos updated this revision to Diff 46064. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17094?vs=45994=46064 REVISION DETAIL https://phabricator.kde.org/D17094 AFFECTED FILES applets/comic/comic.cpp applets/comic/comic.h To: pavelmos, jriddell, bshah, davidedmundson Cc:

D4929: DrKonqi : lldb and Mac support

rjvbb added a comment. > That'll probably be when we move to Qt6. Which is something I hope will be as far in the future as possible :) but > I doubt it really would make anyone's lives easier. Moving something outside of what I secretly call the Plasma jealousy universe