D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. Hmm... when a button has an icon the content gets aligned on the left and I can't find a way to change it... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. Oh, you mean the button content... I will try to fix that! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Matheus Marinho
matheusm added a comment. In D17323#370413 , @GB_2 wrote: > In D17323#370411 , @matheusm wrote: > > > +1, but why aren't the buttons content centered? > > > They are, do you think that because

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 updated this revision to Diff 46749. GB_2 edited the summary of this revision. GB_2 added a comment. Update panel size button icons. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46741=46749 REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17323#370411 , @matheusm wrote: > +1, but why aren't the buttons content centered? They are, do you think that because of the screenshot? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Matheus Marinho
matheusm added a comment. +1, but why aren't the buttons content centered? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17323#370402 , @ngraham wrote: > Feel free to come up with a better wording; mine is probably crap since I just randomly thought of it. :p Yeah :P REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Nathaniel Graham
ngraham added a comment. Feel free to come up with a better wording; mine is probably crap since I just randomly thought of it. :p REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: ngraham, trickyricky26, #vdg, plasma-devel,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17323#370396 , @trickyricky26 wrote: > This is awesome, thank you! > > If this is not clear enough, would it be technically possible to display a tooltip explaining you have to drag the button and make that tooltip

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Nathaniel Graham
ngraham added a comment. Nice! While we're at it, what do you think about adding a tooltip saying "Drag to the screen edge where you would like this panel to love" or something? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread TrickyRicky
trickyricky26 added a comment. This is awesome, thank you! If this is not clear enough, would it be technically possible to display a tooltip explaining you have to drag the button and make that tooltip appear when the user clicks on the button without dragging it? REPOSITORY R119

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Modifies the screen edge button and panel size button in the panel edit mode to make them easier to

D17321: Change toolbox icon from from a hamburger icon to a configure icon

2018-12-02 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'm happy now! #plasma folks, do you agree? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17321 To: GB_2,

D17321: Change toolbox icon from from a hamburger icon to a configure icon

2018-12-02 Thread Björn Feber
GB_2 updated this revision to Diff 46739. GB_2 edited the summary of this revision. GB_2 added a comment. Only change panel toolbox icon. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17321?vs=46736=46739 REVISION DETAIL

D17321: Change toolbox icon from from a hamburger icon to a configure icon

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17321#370322 , @ngraham wrote: > For the panel edit mode button, I think this is 100% appropriate since it opens a configuration UI. For the toolbox, I'm not as convinced yet, since clicking on it opens a menu with a

D17321: Change toolbox icon from from a hamburger icon to a configure icon

2018-12-02 Thread Nathaniel Graham
ngraham added a comment. For the panel edit mode button, I think this is 100% appropriate since it opens a configuration UI. For the toolbox, I'm not as convinced yet, since clicking on it opens a menu with a number of non-configuration-related menu items. It's not the biggest deal, but it

D17321: Change toolbox icon from from a hamburger icon to a configure icon

2018-12-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Changes the desktop/panel toolbox icon from a hamburger icon to a configure icon (as suggested in

D17226: Update kcmsmserver (Desktop Session) docbook to Plasma 5.14

2018-12-02 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R119:eed844a36c5c: Update kcmsmserver (Desktop Session) docbook to Plasma 5.14 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE