D16873: [comic] Request current identifier on date changed

anthonyfieroni added a comment. I will push it in few days, since no activity. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16873 To: anthonyfieroni, #plasma, davidedmundson, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.11 - Build # 34 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.11/34/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 07 Dec 2018 07:23:40 + Build duration: 3 min 7 sec and counting CONSOLE OUTPUT

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 47011. GB_2 added a comment. Increase tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47010=47011 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 47010. GB_2 added a comment. Improve code and add tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46973=47010 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17393: [Folder View] make file context menu consistent with Dolphin's

anthonyfieroni added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17393 To: ngraham, #plasma, hein Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17394: [Device Notifier] Fix transition animation

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice catch! This works and looks good to me, but let's make sure the #plasma folks agree. :) REPOSITORY R120 Plasma Workspace BRANCH

D17192: use a Kirigami Heading for perfect consistency

ngraham added a comment. I see, you're right! Finally got to test this out instead of just complaining about the pictures. :) I now have `KDeclarative`, `KCMUtils`, and `KWidgetsAddons` with the necessary changes, but when I compile System Settings with this, I see the following:

D17393: [Folder View] make file context menu consistent with Dolphin's

ngraham updated this revision to Diff 47003. ngraham added a comment. Also give the Properties action a shortcut, so now the menu is 100% identical with Dolphin's REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17393?vs=47000=47003 BRANCH

D17394: [Device Notifier] Fix transition animation

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY In the specific case of having the device notifier opened and inserting a device that

D17393: [Folder View] make file context menu consistent with Dolphin's

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 401652 FIXED-IN: 5.15.0 TEST PLAN Folder view now: Matches Dolphin: (the lack

D16212: [Device Notifier] Add a button to unmount all devices

ngraham accepted this revision. ngraham added a comment. Still looks great to me! Would be nice to get a #plasma person's comments too. REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from master) REVISION DETAIL

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel marked an inline comment as done. thsurrel added inline comments. INLINE COMMENTS > ngraham wrote in devicenotifier.qml:51 > En Anglais, les mots n'utilisent pas la lettre «u» aussi souvent qu'en > Français. :) Je ne savais pas que tu parlais français !  REPOSITORY R120 Plasma

D16212: [Device Notifier] Add a button to unmount all devices

ngraham added inline comments. INLINE COMMENTS > thsurrel wrote in devicenotifier.qml:51 > I put too much French into this one ;) En Anglais, les mots n'utilisent pas la lettre «u» aussi souvent qu'en Français. :) REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel marked 2 inline comments as done. thsurrel added inline comments. INLINE COMMENTS > ngraham wrote in devicenotifier.qml:51 > mountedRemouvables -> mountedRemovables (and change all other instances, > obviously) I put too much French into this one ;) REPOSITORY R120 Plasma Workspace

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 46999. thsurrel added a comment. Improvements as per Nate's comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=46939=46999 BRANCH arc_unmountall (branched from master) REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. We're getting there! Right now, the tooltip appears if I click-and-hold for a moment, but not when I just click. Since that's the use case we're targeting, we should probably make it appear for click-and-quickly-release as well. INLINE COMMENTS >

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

trickyricky26 added a comment. Will that tooltip be shown when just clicking on the button without dragging? It would be very helpful to trigger the tooltip when the button is pressed, but not dragged. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D16212: [Device Notifier] Add a button to unmount all devices

ngraham added inline comments. INLINE COMMENTS > FullRepresentation.qml:119 > +enabled: true > +visible: devicenotifier.mountedRemouvables.length > 0; > +anchors.right: parent.right What do you think about changing this to `> 1`? It seems kind of redundant to

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added a comment. Any news on this bug and this change yet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7260 To: i.Dark_Templar, #plasma, davidedmundson Cc: broulik, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16658: Respect the display property of buttons

astippich added a comment. ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

alexde added a comment. In D17354#372274 , @ngraham wrote: > Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ad34212a8ccd: [Digital clock plasmoid] Calendar settings page: port to QQC2 Kirigami and… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

ngraham added a comment. In D17354#372270 , @alexde wrote: > Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indented by a tab: Yes, quite a bit. This current layout

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

alexde added a comment. Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indeted by a tab: General [ ] Show week number Available plugins [ ] Plugin A [ ] Plugin B That's would I

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46973. GB_2 added a comment. Add import. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46972=46973 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. Oops, forgot the import... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46972. GB_2 added a comment. Use QQC2 tooltip. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46971=46972 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. Hmm, that tooltip doesn't match the style. Why not use the QQC2 tooltip? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 46971. GB_2 added a comment. Added the tooltip. F6459564: Panel Edit Mode Buttons (3).png It is ready now! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17375: Don't automatically refresh if the user already asked apt to do so

rikmills added a comment. Seems good to me, and a quick test on a stock Kubuntu install gets the updater registering new updates when the system does its own refresh. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17375 To: apol, #kubuntu, sitter,

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

mart accepted this revision. mart added a comment. I've just done a round of testing of the latest revision together my last kwin patch, including: - adding and/or removinf desktops - changing the number of rows - renaming some desktops - restarting kwin randomly after any of the

D17362: [RFC] [FormLayout] Top-align item labels

ngraham abandoned this revision. ngraham added a comment. Not necessary; found a way to implement this goal in D17362 without changes to Kirigami. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17362 To: ngraham, #kirigami,

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

ngraham updated this revision to Diff 46967. ngraham added a comment. Align the label to the first child properly REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17354?vs=46872=46967 BRANCH improve-calendar-settings-layout (branched from master)

D4929: DrKonqi : lldb and Mac support

davidedmundson added a comment. Yeah, it's all fine. Sorry should have replied when you asked. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces, kfunk, davidedmundson Cc: plasma-devel, #kde_applications, patrickelectric, kfunk,

D4929: DrKonqi : lldb and Mac support

rjvbb added a comment. > This revision was not accepted when it landed; it landed in state "Needs Review". Because I asked David if he'd seen the very last (=just committed) revision when he accepted this. He'd have infirmed that by now if our posts had crossed so I felt I could push

D4929: DrKonqi : lldb and Mac support

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R871:13121f4a303b: lldb and Mac support (authored by rjvbb). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 46939. thsurrel added a comment. Fix button width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=43929=46939 BRANCH arc_unmountall (branched from master) REVISION DETAIL