D17815: [Wallpaper] Allow adding multiple images at once from the file picker dialog

ngraham created this revision. ngraham added reviewers: Konsole, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 402223 FIXED-IN: 5.15.0 TEST PLAN Added multiple images from th

D17809: Check icon positions after move

davidedmundson added a comment. Looks sensible to me. Good stuff. Wait a week to allow Eike a chance to comment, otherwise consider this a ship it! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17809 To: McPain Cc: davidedmundson, plasma-devel, GB_2, ragr

D17154: Go back to SCSS

ngraham added a comment. There we go, much better! Thanks for all the work on this. Now we can move on to the next part of the review. :) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17154 To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham Cc: bcooksley, #

D17154: Go back to SCSS

gepardo updated this revision to Diff 48224. gepardo added a comment. Remove compiled themes from the sources; now the building process doesn't modify the sources at all REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17154?vs=48223&id=48224 BRANCH

D17154: Go back to SCSS

gepardo added a comment. > But files in the source repo are still overwritten during the build process if you do an in-source build. `Breeze-gtk` and `Breeze-dark-gtk` are ovewritten regardless of whether an in-source build in used or not. I'm going to fix it now by removing compiled fi

D17154: Go back to SCSS

ngraham added a comment. Thanks, I can verify that the race condition is fixed so parallel building now works! But files in the source repo are still overwritten during the build process if you do an in-source build. If this is not easily resolvable, you could just disallow in-source builds

D17154: Go back to SCSS

gepardo updated this revision to Diff 48223. gepardo added a comment. Summary of changes done: - Fix race condition during the build - Prevent the build process from writing into the source directory - Style fixes in build_theme.sh - Improve parameter parsing in build_theme.sh - Re

D17659: Set parent window for dialogs

graesslin added a comment. In D17659#379912 , @volkov wrote: > Is it possible to implement support for foreign windows in KWin QPA plugin? There is no such thing as a KWin QPA. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop

D17796: Plasma Workspace. Fixed general settings of the widgets.

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. As far as I can tell, this doesn't work: the listed widgets still have all their configuration pages' checkboxes unchecked after checking some of them, closing the window, and r

D17154: Go back to SCSS

gepardo added a comment. In D17154#382450 , @ngraham wrote: > Also, overwriting sources is a no-no. :/ > > If this is a pre-existing bug, perhaps we should fix it in another patch though. What does it mean? Should I create a new Phabr

D17154: Go back to SCSS

ngraham added a comment. Also, overwriting sources is a no-no. :/ If this is a pre-existing bug, perhaps we should fix it in another patch though. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17154 To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham Cc

D17154: Go back to SCSS

gepardo added a comment. It seems to be the issue with parallel Make. The original scripts often overwrite sources, so they can't be built in parallel. I'll try to fix it to resolve the race conditions. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17154 To

D17154: Go back to SCSS

ngraham added a comment. Hmm, now `make` fails: ~/repos/breeze-gtk$ (arcpatch-D17154) make -j2 Scanning dependencies of target gtkbreeze5.5 [ 50%] Building CXX object kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o /usr/lib/ruby/vendor_ruby/sass/util.rb:1109: warning: c

D17359: Fix use of QRegularExpressionMatch

fvogt added a comment. > Is this the issue this fix is intended for> This diff fixes the issue that no matter what failed with invoking the binary, the "wrong version" error was shown. For instance, if cryfs was not executable by the current user, it'd show that the version is too old.

D17809: Check icon positions after move

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 402574 When we're moving a bunch of icons to the area which is already busy, we didn't check whether we're moving icons to

D17359: Fix use of QRegularExpressionMatch

rikmills added a comment. I have someone on IRC asking > [12:46] Now got an issue.. Using the Plasma Vault the GUI complains about wrong versions of CryFS and alternatively wrong version of EncFS. I checked with 'apt show cryfs' and 'apt show encfs' and the installed versions are _