D17780: Add Plasma wallpapers

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R131:e1638b613172: Add Plasma wallpapers (authored by Nate Graham , committed by ngraham). REPOSITOR

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

ngraham added a comment. Hmm, this results in the menu having one colored icon and two monochrome icons. My gut feeling is that if we're going to use KMenuEdit's icon, perhaps we should mention it by name, e.g. "Edit Applications with KMenuEdit". If we don't want to do that, or we c

D17844: Show installed and available versions of updates right there on the page

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:f81ec58e96d8: Show installed and available versions of updates right there on the page (authored by ngraham). REPOSITO

D17922: Make sure update packages have been resolved

This revision was automatically updated to reflect the committed changes. Closed by commit R134:89fc0a8c6226: Make sure update packages have been resolved (authored by apol, committed by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D17975: [WIP, Notifications] Add padding to notifications

rooty marked an inline comment as done. rooty added a comment. In D17975#386685 , @ngraham wrote: > A bit more padding is good! > > 1. Making this pixel-perfect with every combination of font and font size is going to be impossible sadly. Wit

D17975: [WIP, Notifications] Add padding to notifications

ngraham added a comment. A bit more padding is good! 1. Making this pixel-perfect with every combination of font and font size is going to be impossible sadly. With that in mind, the most elegant design is one that makes this not a problem, because it doesn't have to be pixel-perfect and

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48711. rooty added a comment. Change shift in height of notification to an integer REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48709&id=48711 BRANCH notification-padding (branched from master) REV

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. In D17975#386665 , @ngraham wrote: > Can you clarify what the ultimate visual goal here? Clearly defining that might help to tighten up your code and thought process. > > Also, what remaining issues make this WIP? I fin

D17975: [WIP, Notifications] Add padding to notifications

ngraham added a comment. Can you clarify what the ultimate visual goal here? Clearly defining that might help to tighten up your code and thought process. Also, what remaining issues make this WIP? I find that the Phabricator `NOTE:` markup works well for this. See https://secure.phabri

D17975: [WIP, Notifications] Add padding to notifications

hein added inline comments. INLINE COMMENTS > NotificationItem.qml:33 > width: parent.width > -implicitHeight: Math.max(appIconItem.valid || imageItem.nativeWidth > 0 > ? units.iconSizes.large : 0, mainLayout.height) > +implicitHeight: Math.max(appIconItem.valid || imageItem.nativeW

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48709. rooty added a comment. Add margins to the right of the buttons on the right border REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48708&id=48709 BRANCH notification-padding (branched from maste

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. Okay, so I figured out how to add padding to the buttons as well, by adding a right margin to the mainLayout part (hence the deleted comment describing how I couldn't figure it out, my bad): F6525782: before-n-after.png REPOS

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. Hey so I'd also like for the Open... (image three in each set) button to shift by one units.smallSpacing to the left. The close button does, if I add "rightMargin: units.smallSpacing" into ColumnLayout / mainLayout, but the Open... button doesn't. I just don't kn

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48708. rooty added a comment. Correct spelling REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48707&id=48708 BRANCH notification-padding (branched from master) REVISION DETAIL https://phabricator.k

D17975: [WIP, Notifications] Add padding to notifications

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch aims to add padding to the notification widget and fully remedy the issues that arise once it is applied. TEST PLAN [Comi

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Failing!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown": Remo

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 04 Jan 2019 21:45:51 + Build duration: 59 min and counting CONSOLE OUTPUT [...truncate

D17834: Allow the use of One-Time Password

enriquem updated this revision to Diff 48701. enriquem added a comment. I implemented all of your comments except one. I created a new VPN setting wit nm-connection-editor, and it sets it to 0, that is, to NetworkManager::Setting::None. Thus, I believe that part is correct. REPOSITORY R116

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f29c04572c06: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This adds an icon to the "Edit Applications..." menu entry to make it look better. F6525011: Edit Ap

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

kvanton added a comment. In D17960#386323 , @davidedmundson wrote: > Seems sensible. I don't maintain the stuff in playground, but no-one really does. > > If there's no comment in a week, ship it! > > Do you have commit access? S

D17961: Fix static Kirigami (about page etc)

This revision was automatically updated to reflect the committed changes. Closed by commit R169:99e9679b44af: Fix static Kirigami (about page etc) (authored by leinir). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17961?vs=48668&id=48670 REVISION DETAIL

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

davidedmundson added a comment. Seems sensible. I don't maintain the stuff in playground, but no-one really does. If there's no comment in a week, ship it! Do you have commit access? REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D17960

D17961: Fix static Kirigami (about page etc)

leinir created this revision. leinir added reviewers: Kirigami, apol, mart. leinir added a project: Kirigami. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Without this patch, if you tried to use the AboutPage component in a static Kirigami

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”.This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature.This is important, for exam

kvanton created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kvanton requested review of this revision. REVISION SUMMARY Manual adjust Brightness and/or Temperature using custom mode options (redshift -m METHOD...) REPOSITORY R885 Redshift Control f

D17934: [Kickoff] Increase Kickoff information label readability

This revision was automatically updated to reflect the committed changes. Closed by commit R119:510c88f65b76: [Kickoff] Increase Kickoff information label readability (authored by Krešimir Čohar , committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE