D18341: Support icons from local files in buttons

broulik added a comment. `/foo/bar` is not a local URL? `file:///foo/bar` would be. I think you now broke the `QString` case? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18341 To: nicolasfella, #plasma, mart Cc: broulik, plasma-devel,

D17784: Don't ignore default virtual devices

filipf added a comment. For context, I filed the bug report (https://bugs.kde.org/show_bug.cgi?id=395466) and then David fixed it in D13568 . Since I don't think PulseEffects becomes the default device, this should be fine. REVISION DETAIL

D18343: [Imagepackage] Port wallpaper plugins to QQC2

ngraham added a comment. Good call David! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18343 To: ngraham, #plasma Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D18343: [Imagepackage] Port wallpaper plugins to QQC2

ngraham updated this revision to Diff 49779. ngraham marked an inline comment as done. ngraham added a comment. Keep the QQC1 version of the ComboBox until we've fixed tps://bugs.kde.org/show_bug.cgi?id=403153 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18347: [wallpapers/image] Don't use PlasmaCore in desktop themed UI

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Runs as before REPOSITORY R120 Plasma Workspace BRANCH master REVISION

D17784: Don't ignore default virtual devices

ngraham added a comment. Don't worry, reviewers automatically get notified. :) REVISION DETAIL https://phabricator.kde.org/D17784 To: sharhalakis, broulik, drosca Cc: ngraham, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D17784: Don't ignore default virtual devices

sharhalakis added a comment. Fixed. I'm not sure if I need to press a button or something to request another review though. REVISION DETAIL https://phabricator.kde.org/D17784 To: sharhalakis, broulik, drosca Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.11 - Build # 54 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.11/54/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Fri, 18 Jan 2019 00:14:02 + Build duration: 57 sec and counting CONSOLE OUTPUT Started by an

D18343: [Imagepackage] Port wallpaper plugins to QQC2

davidedmundson added a comment. If you want to push everything except the combobox go for it. QQC allows us to mix, we should make use of that to do regression-free ports. INLINE COMMENTS > config.qml:90 > } > -QtControls.ComboBox { > +ComboBox { > id:

D17784: Don't ignore default virtual devices

sharhalakis updated this revision to Diff 49776. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17784?vs=48152=49776 REVISION DETAIL https://phabricator.kde.org/D17784 AFFECTED FILES src/pulseaudio.cpp To: sharhalakis, broulik, drosca Cc: cfeck, plasma-devel, jraleigh, GB_2,

D18343: [Imagepackage] Port wallpaper plugins to QQC2

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 400549 FIXED-IN: 5.15.0 TEST PLAN On the lock screen KCM at 1.2x scale, before:

D17784: Don't ignore default virtual devices

cfeck added inline comments. INLINE COMMENTS > pulseaudio.cpp:300 > it.next(); > -if (it.value()->isVirtualDevice() || it.value()->state() != > state) { > +if ((it.value()->isVirtualDevice()&& !it.value()->isDefault()) > +||

D13418: Add build dependencies to INSTALL file

This revision was automatically updated to reflect the committed changes. Closed by commit R884:509a0ca40c36: Add build dependencies to INSTALL file (authored by majohnson, committed by aacid). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE

D18341: Support icons from local files in buttons

nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Trying to assign an icon from a file to a button like in import

D18340: [Date & Time KCM] Fix clock display with fractional scale factor

This revision was automatically updated to reflect the committed changes. Closed by commit R119:985acbb74657: [Date Time KCM] Fix clock display with fractional scale factor (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18340: [Date & Time KCM] Fix clock display with fractional scale factor

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 396936 FIXED-IN: 5.12.8 TEST PLAN 1.2 scale factor, before: 1.2 scale factor:

D17751: Add shadow to Hour's hand

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Land on master only please, as this requires a change in Frameworks 5.55. REPOSITORY R120 Plasma Workspace BRANCH hand REVISION DETAIL https://phabricator.kde.org/D17751 To:

D18314: Cosmetic fixes for build_theme.sh

ngraham added a comment. lol too fast for me REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18314 To: gepardo, davidedmundson Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D18314: Cosmetic fixes for build_theme.sh

ngraham added a comment. @davidedmundson should we land this to the 5.15 branch, or just master? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18314 To: gepardo, davidedmundson Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18314: Cosmetic fixes for build_theme.sh

This revision was automatically updated to reflect the committed changes. Closed by commit R98:6a6a432546bb: Cosmetic fixes for build_theme.sh (authored by gepardo, committed by davidedmundson). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D18321: support for the concept of expandible items

alex-l added a comment. Very cool! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18321 To: mart, #kirigami Cc: alex-l, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18320: Search-enable the application page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for the copious code comments. Definitely makes things easier to understand in the future. REPOSITORY R134 Discover Software Store REVISION DETAIL

KDE CI: Plasma » breeze-gtk » stable-kf5-qt5 FreeBSDQt5.12 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.12/4/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 17 Jan 2019 16:40:07 + Build duration: 1 min 23 sec and counting

D17751: Add shadow to Hour's hand

shubham updated this revision to Diff 49728. shubham added a comment. Updating D17751 : Add shadow to Hour's hand Use harcoded pixel values REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17751?vs=49656=49728

freedesktop.notifications daemon - crossplatform alternatives?

Hi, Sorry for a somewhat off-topic question. As far as I can tell the KF5/Plasma5 freedesktop notifications implementation is really not easily isolated even if it probably would be cross-platform. (I can run the systray widget in plasma-windowed, but that isn't really satisfactory.) Why the

D18318: Prettify and search enable the error page

ngraham added a comment. When submitting a patch that involves UI changes, it's always appreciated to include a screenshot. Bonus points for both before-and-after screenshots. :) https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots REPOSITORY R134 Discover

KDE CI: Plasma » breeze-gtk » stable-kf5-qt5 FreeBSDQt5.12 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.12/3/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 17 Jan 2019 14:51:10 + Build duration: 3 min 48 sec and counting CONSOLE OUTPUT

D18314: Cosmetic fixes for build_theme.sh

gepardo added a comment. @davidedmundson, can you please merge it into master? I don't have a developer account, so I can't do this by myself. REPOSITORY R98 Breeze for Gtk BRANCH build-script-minor-fixes (branched from master) REVISION DETAIL https://phabricator.kde.org/D18314 To:

D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail

davidedmundson added a comment. Setting sourceSize +++ Only thing: 211: void QQuickImageBase::load() { 258:d->pix.load(qmlEngine(this), loadUrl, d->sourcesize * d->devicePixelRatio, options, d->providerOptions); If you need to change this here we're working around

D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids loading huge screenshots just to show them in a tiny thumbnail. It's using

D18321: support for the concept of expandible items

mart added a comment. the Global Drawer Mode section is expanded F6553308: Screenshot_20190117_150513.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18321 To: mart, #kirigami Cc: plasma-devel, dkardarakos, apol,

D18321: support for the concept of expandible items

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY if an Action has the property expandible, its subactions are shown under it in globalDrawer and

D18320: Search-enable the application page

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Usually the

D18318: Prettify and search enable the error page

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY The prettification

D18189: Fix ComboBox

broulik added inline comments. INLINE COMMENTS > apol wrote in ComboBox.qml:207 > delegateModel property doesn't exist in QQC2.ComboBox. I was never getting a > popup. > > http://doc.qt.io/qt-5/qml-qtquick-controls-combobox-members.html > > Also we didn't use to specify a delegate to the

D18189: Fix ComboBox

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. This breaks mouse wheel interaction REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: broulik,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49717. croick added a comment. - swap variable declaration REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49710=49717 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

Plasma 5.15 beta

Plasma 5.15 beta is now released https://www.kde.org/announcements/plasma-5.14.90.php

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi added a comment. In D11235#395021 , @croick wrote: > What do you mean? The (internal) debugger is a child of the debuggee. yes, that's why you need setPtracer() - if crashtest was *under* gdb, that would be unnecessary. ;) (i'm

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/26/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 12:48:03 + Build duration: 26 min and counting BUILD ARTIFACTS

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 17 Jan 2019 12:44:39 + Build duration: 9 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 19 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/19/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 12:44:39 + Build duration: 5 min 49 sec and counting CONSOLE OUTPUT [...truncated

D18310: Require breeze >= 5.14.90

davidedmundson added a comment. Oh, I'm really sorry! I hadn't seen this. Yeah, I was waiting for the .90 too. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18310 To: heikobecker, #plasma Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18310: Require breeze >= 5.14.90

heikobecker abandoned this revision. heikobecker added a comment. Superseded by 843bc1cc087451d6debd86fb9f21004c4ad1fbc7 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18310 To:

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added a comment. > you got the parent-child ordering wrong in the commit message. ^^ What do you mean? The (internal) debugger is a child of the debuggee. $ pstree -pn $(pidof crashtest) crashtest(17220)─┬─{crashtest}(17221) ├─{crashtest}(17222)

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49710. croick added a comment. - swap lines, declare array for response message where needed REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49705=49710 BRANCH ptracer REVISION DETAIL

D16212: [Device Notifier] Add a button to unmount all devices

This revision was automatically updated to reflect the committed changes. Closed by commit R120:81db74434cd5: [Device Notifier] Add a button to unmount all devices (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi added a comment. you got the parent-child ordering wrong in the commit message. ^^ INLINE COMMENTS > ptracer.cpp:61 > +char msg[msize], rmsg[msize]; > +int bytes = 0, r; > +sprintf(msg, "%lld", debuggerpid); this looks stupid, i'd swap the order. REPOSITORY

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49705. croick edited the summary of this revision. croick added a comment. - adjust warning and check for EINTR when polling REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49651=49705 BRANCH ptracer

D18300: [Mouse KCM] Port away from KDELibs4Support

volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18300 To: volkov, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 35 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/35/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 11:02:07 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/25/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 10:57:57 + Build duration: 23 min and counting CONSOLE OUTPUT [...truncated 250

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/18/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 10:54:53 + Build duration: 24 min and counting CONSOLE OUTPUT [...truncated 246

D18314: Cosmetic fixes for build_theme.sh

gepardo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gepardo requested review of this revision. REVISION SUMMARY I saw the changes introduced by https://phabricator.kde.org/D18287. It's a really good idea :) The commit contains some minor

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/16/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 10:50:02 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 34 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/34/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 10:45:12 + Build duration: 16 min and counting CONSOLE OUTPUT [...truncated 255

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/24/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 10:45:04 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated 250

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/15/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 10:20:52 + Build duration: 3 min 14 sec and counting CONSOLE OUTPUT [...truncated

D18309: don't set python exe to undefined

This revision was automatically updated to reflect the committed changes. Closed by commit R98:51e27ecf4057: dont set python exe to undefined (authored by sitter). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18309?vs=49691=49700 REVISION DETAIL

D13870: Correct Folder View sizing and representation switch behavior

kossebau added inline comments. INLINE COMMENTS > main.qml:58 > + > +return undefined; > +} This and the same below sadly results in error log output e.g. when testing applets with plasmoidviewer:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/16/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 09:52:04 + Build duration: 1 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/14/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 17 Jan 2019 09:52:05 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT [...truncated

D18244: Check for python-cairo

cgiboudeaux added a comment. In D18244#394859 , @rikmills wrote: > This breaks NeonKubuntu builds, whereas previously the builds were working as I explicitly had added python3-cairo to the build depends. It is there still, but cmake thinks not.

D18309: don't set python exe to undefined

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested with cmake 3.10.2, works. REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D18309 To: sitter, davidedmundson, fvogt Cc: fvogt,